[{"id":12605,"web_url":"https://patchwork.libcamera.org/comment/12605/","msgid":"<20200921075801.hyk3pssezir7hfod@uno.localdomain>","date":"2020-09-21T07:58:01","subject":"Re: [libcamera-devel] [PATCH] test: Include specific headers\n\tinstead of libcamera.h","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Sep 20, 2020 at 04:44:09PM +0300, Laurent Pinchart wrote:\n> Let's only pull required headers, to avoid slowing compilation down.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nI haven't checked for leftovers, but the idea is good\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n\n> ---\n>  test/camera/buffer_import.cpp | 3 +++\n>  test/camera/capture.cpp       | 4 ++++\n>  test/camera/statemachine.cpp  | 2 ++\n>  test/libtest/buffer_source.h  | 2 +-\n>  test/libtest/camera_test.h    | 5 ++++-\n>  test/mapped-buffer.cpp        | 2 ++\n>  6 files changed, 16 insertions(+), 2 deletions(-)\n>\n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index d57ffa75edeb..64e96264c90b 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -12,6 +12,9 @@\n>  #include <numeric>\n>  #include <vector>\n>\n> +#include <libcamera/event_dispatcher.h>\n> +#include <libcamera/timer.h>\n> +\n>  #include \"libcamera/internal/device_enumerator.h\"\n>  #include \"libcamera/internal/media_device.h\"\n>  #include \"libcamera/internal/v4l2_videodevice.h\"\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index eb67bf2da71f..51bbd25809ee 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -7,6 +7,10 @@\n>\n>  #include <iostream>\n>\n> +#include <libcamera/event_dispatcher.h>\n> +#include <libcamera/framebuffer_allocator.h>\n> +#include <libcamera/timer.h>\n> +\n>  #include \"camera_test.h\"\n>  #include \"test.h\"\n>\n> diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> index 0bda6fe4b0b2..28faeb913f2e 100644\n> --- a/test/camera/statemachine.cpp\n> +++ b/test/camera/statemachine.cpp\n> @@ -7,6 +7,8 @@\n>\n>  #include <iostream>\n>\n> +#include <libcamera/framebuffer_allocator.h>\n> +\n>  #include \"camera_test.h\"\n>  #include \"test.h\"\n>\n> diff --git a/test/libtest/buffer_source.h b/test/libtest/buffer_source.h\n> index 95a82a8229fa..14b4770e8d8a 100644\n> --- a/test/libtest/buffer_source.h\n> +++ b/test/libtest/buffer_source.h\n> @@ -7,7 +7,7 @@\n>  #ifndef __LIBCAMERA_BUFFER_SOURCE_TEST_H__\n>  #define __LIBCAMERA_BUFFER_SOURCE_TEST_H__\n>\n> -#include <libcamera/libcamera.h>\n> +#include <libcamera/stream.h>\n>\n>  #include \"libcamera/internal/media_device.h\"\n>  #include \"libcamera/internal/v4l2_videodevice.h\"\n> diff --git a/test/libtest/camera_test.h b/test/libtest/camera_test.h\n> index 0b6bad05e37c..7939798f886e 100644\n> --- a/test/libtest/camera_test.h\n> +++ b/test/libtest/camera_test.h\n> @@ -7,7 +7,10 @@\n>  #ifndef __LIBCAMERA_CAMERA_TEST_H__\n>  #define __LIBCAMERA_CAMERA_TEST_H__\n>\n> -#include <libcamera/libcamera.h>\n> +#include <memory>\n> +\n> +#include <libcamera/camera.h>\n> +#include <libcamera/camera_manager.h>\n>\n>  using namespace libcamera;\n>\n> diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp\n> index 39d624cde6d5..027923375ed9 100644\n> --- a/test/mapped-buffer.cpp\n> +++ b/test/mapped-buffer.cpp\n> @@ -7,6 +7,8 @@\n>\n>  #include <iostream>\n>\n> +#include <libcamera/framebuffer_allocator.h>\n> +\n>  #include \"libcamera/internal/buffer.h\"\n>\n>  #include \"camera_test.h\"\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C71E3C3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Sep 2020 07:54:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59F1162FBF;\n\tMon, 21 Sep 2020 09:54:10 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFBEC60367\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Sep 2020 09:54:09 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 263EB1BF213;\n\tMon, 21 Sep 2020 07:54:08 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 21 Sep 2020 09:58:01 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20200921075801.hyk3pssezir7hfod@uno.localdomain>","References":"<20200920134409.24688-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200920134409.24688-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: Include specific headers\n\tinstead of libcamera.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":12608,"web_url":"https://patchwork.libcamera.org/comment/12608/","msgid":"<20200921083655.GG2692107@oden.dyn.berto.se>","date":"2020-09-21T08:36:55","subject":"Re: [libcamera-devel] [PATCH] test: Include specific headers\n\tinstead of libcamera.h","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-09-20 16:44:09 +0300, Laurent Pinchart wrote:\n> Let's only pull required headers, to avoid slowing compilation down.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  test/camera/buffer_import.cpp | 3 +++\n>  test/camera/capture.cpp       | 4 ++++\n>  test/camera/statemachine.cpp  | 2 ++\n>  test/libtest/buffer_source.h  | 2 +-\n>  test/libtest/camera_test.h    | 5 ++++-\n>  test/mapped-buffer.cpp        | 2 ++\n>  6 files changed, 16 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index d57ffa75edeb..64e96264c90b 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -12,6 +12,9 @@\n>  #include <numeric>\n>  #include <vector>\n>  \n> +#include <libcamera/event_dispatcher.h>\n> +#include <libcamera/timer.h>\n> +\n>  #include \"libcamera/internal/device_enumerator.h\"\n>  #include \"libcamera/internal/media_device.h\"\n>  #include \"libcamera/internal/v4l2_videodevice.h\"\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index eb67bf2da71f..51bbd25809ee 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -7,6 +7,10 @@\n>  \n>  #include <iostream>\n>  \n> +#include <libcamera/event_dispatcher.h>\n> +#include <libcamera/framebuffer_allocator.h>\n> +#include <libcamera/timer.h>\n> +\n>  #include \"camera_test.h\"\n>  #include \"test.h\"\n>  \n> diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> index 0bda6fe4b0b2..28faeb913f2e 100644\n> --- a/test/camera/statemachine.cpp\n> +++ b/test/camera/statemachine.cpp\n> @@ -7,6 +7,8 @@\n>  \n>  #include <iostream>\n>  \n> +#include <libcamera/framebuffer_allocator.h>\n> +\n>  #include \"camera_test.h\"\n>  #include \"test.h\"\n>  \n> diff --git a/test/libtest/buffer_source.h b/test/libtest/buffer_source.h\n> index 95a82a8229fa..14b4770e8d8a 100644\n> --- a/test/libtest/buffer_source.h\n> +++ b/test/libtest/buffer_source.h\n> @@ -7,7 +7,7 @@\n>  #ifndef __LIBCAMERA_BUFFER_SOURCE_TEST_H__\n>  #define __LIBCAMERA_BUFFER_SOURCE_TEST_H__\n>  \n> -#include <libcamera/libcamera.h>\n> +#include <libcamera/stream.h>\n>  \n>  #include \"libcamera/internal/media_device.h\"\n>  #include \"libcamera/internal/v4l2_videodevice.h\"\n> diff --git a/test/libtest/camera_test.h b/test/libtest/camera_test.h\n> index 0b6bad05e37c..7939798f886e 100644\n> --- a/test/libtest/camera_test.h\n> +++ b/test/libtest/camera_test.h\n> @@ -7,7 +7,10 @@\n>  #ifndef __LIBCAMERA_CAMERA_TEST_H__\n>  #define __LIBCAMERA_CAMERA_TEST_H__\n>  \n> -#include <libcamera/libcamera.h>\n> +#include <memory>\n> +\n> +#include <libcamera/camera.h>\n> +#include <libcamera/camera_manager.h>\n>  \n>  using namespace libcamera;\n>  \n> diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp\n> index 39d624cde6d5..027923375ed9 100644\n> --- a/test/mapped-buffer.cpp\n> +++ b/test/mapped-buffer.cpp\n> @@ -7,6 +7,8 @@\n>  \n>  #include <iostream>\n>  \n> +#include <libcamera/framebuffer_allocator.h>\n> +\n>  #include \"libcamera/internal/buffer.h\"\n>  \n>  #include \"camera_test.h\"\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAAC6C3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Sep 2020 08:36:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7F2B62FBF;\n\tMon, 21 Sep 2020 10:36:58 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1850760367\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Sep 2020 10:36:57 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id n25so10370483ljj.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Sep 2020 01:36:57 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t82sm2401477lfo.173.2020.09.21.01.36.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Sep 2020 01:36:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"CrhImaDh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=fvw2Xhhpz92gtUvLWl2Ph4Bb0WfvKM+YN03458HO004=;\n\tb=CrhImaDheN3UkPwsl/WH/L+NsXjaHPAZBvUHiOgXeX3eBxJ9off3G916km7oz93Asx\n\tutbI7xznlh3IrTKNlJOuh+DZQqhINXssgY5Xrg2HCkiLT9hmHMc63JttUUypUrjgpyiB\n\tYXTLQytYST4OWpPhlztYNCeDiF7ImcCNxSJg+QOu8iTraMwOZRBljqodhws9agpnXQBv\n\ttlLnns89Ncqk/PiQPezoKjmu+H9+in/Fwdq+ZSILA3m96eMgE12JSRksmv3mVdgD3ANq\n\tZK5z7UafJv1ZWBWh+rymzM3ZwgVFuKIUs8DRSTlYiXkpFmSCAHgb2b33Xht3hb2TAWA6\n\tHyxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=fvw2Xhhpz92gtUvLWl2Ph4Bb0WfvKM+YN03458HO004=;\n\tb=Ueu74sLqnmpuF6S8RaZ2mC+C6Vh7FIt7Z8sdzMtCX5SnxbKnBcNFIA6ELttjJ61yMm\n\tcZCrOwgEAHGKLUVwQmeDR8mHRrWr8M1nolYOnHfRS+8OLbfLsJ2o/nzfSpgdZ0GxaI6Z\n\tFAHkJ8VOdj54cMLcdiHip6/JZZYvZZXFoJAJZTIigi5vv/8kBPk9rwlJO6JC4dYPORb4\n\thWzr8FKlROS9ltcJ+DcgMbf409icUb0ancyb9wErERWr6TQ4Wohryil3+FfGPq4XyCYu\n\tU9iZmcTuZed1w8C1PmyluIXFNvPw9/g2Wq+bJVQdTPE6W8cPnMFu+2AxNGNJj1ZXm1SA\n\teLrg==","X-Gm-Message-State":"AOAM532bu0LYb7niGT58o0jXFj8rtFnguhM0KgTi2OJNkJ4nbtghjHvG\n\tRU07uLrIPiQimlfpkpfJYX9DhFxZPI8ADg==","X-Google-Smtp-Source":"ABdhPJzp8fIzwWwGoqK4qZrHKvYDJduYdZCRd/7rC9mhtKFWubylSVMooVbLMKsEqkZCP4GGpE2sPg==","X-Received":"by 2002:a2e:a41b:: with SMTP id\n\tp27mr16594381ljn.75.1600677416535; \n\tMon, 21 Sep 2020 01:36:56 -0700 (PDT)","Date":"Mon, 21 Sep 2020 10:36:55 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20200921083655.GG2692107@oden.dyn.berto.se>","References":"<20200920134409.24688-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200920134409.24688-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: Include specific headers\n\tinstead of libcamera.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":12619,"web_url":"https://patchwork.libcamera.org/comment/12619/","msgid":"<20200921105203.GA8290@pendragon.ideasonboard.com>","date":"2020-09-21T10:52:03","subject":"Re: [libcamera-devel] [PATCH] test: Include specific headers\n\tinstead of libcamera.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Sep 21, 2020 at 09:58:01AM +0200, Jacopo Mondi wrote:\n> On Sun, Sep 20, 2020 at 04:44:09PM +0300, Laurent Pinchart wrote:\n> > Let's only pull required headers, to avoid slowing compilation down.\n> >\n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> I haven't checked for leftovers, but the idea is good\n\nThanks. There's one leftover in the cam application, I may look at it at\nsome point.\n\n> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n> \n> > ---\n> >  test/camera/buffer_import.cpp | 3 +++\n> >  test/camera/capture.cpp       | 4 ++++\n> >  test/camera/statemachine.cpp  | 2 ++\n> >  test/libtest/buffer_source.h  | 2 +-\n> >  test/libtest/camera_test.h    | 5 ++++-\n> >  test/mapped-buffer.cpp        | 2 ++\n> >  6 files changed, 16 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> > index d57ffa75edeb..64e96264c90b 100644\n> > --- a/test/camera/buffer_import.cpp\n> > +++ b/test/camera/buffer_import.cpp\n> > @@ -12,6 +12,9 @@\n> >  #include <numeric>\n> >  #include <vector>\n> >\n> > +#include <libcamera/event_dispatcher.h>\n> > +#include <libcamera/timer.h>\n> > +\n> >  #include \"libcamera/internal/device_enumerator.h\"\n> >  #include \"libcamera/internal/media_device.h\"\n> >  #include \"libcamera/internal/v4l2_videodevice.h\"\n> > diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> > index eb67bf2da71f..51bbd25809ee 100644\n> > --- a/test/camera/capture.cpp\n> > +++ b/test/camera/capture.cpp\n> > @@ -7,6 +7,10 @@\n> >\n> >  #include <iostream>\n> >\n> > +#include <libcamera/event_dispatcher.h>\n> > +#include <libcamera/framebuffer_allocator.h>\n> > +#include <libcamera/timer.h>\n> > +\n> >  #include \"camera_test.h\"\n> >  #include \"test.h\"\n> >\n> > diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> > index 0bda6fe4b0b2..28faeb913f2e 100644\n> > --- a/test/camera/statemachine.cpp\n> > +++ b/test/camera/statemachine.cpp\n> > @@ -7,6 +7,8 @@\n> >\n> >  #include <iostream>\n> >\n> > +#include <libcamera/framebuffer_allocator.h>\n> > +\n> >  #include \"camera_test.h\"\n> >  #include \"test.h\"\n> >\n> > diff --git a/test/libtest/buffer_source.h b/test/libtest/buffer_source.h\n> > index 95a82a8229fa..14b4770e8d8a 100644\n> > --- a/test/libtest/buffer_source.h\n> > +++ b/test/libtest/buffer_source.h\n> > @@ -7,7 +7,7 @@\n> >  #ifndef __LIBCAMERA_BUFFER_SOURCE_TEST_H__\n> >  #define __LIBCAMERA_BUFFER_SOURCE_TEST_H__\n> >\n> > -#include <libcamera/libcamera.h>\n> > +#include <libcamera/stream.h>\n> >\n> >  #include \"libcamera/internal/media_device.h\"\n> >  #include \"libcamera/internal/v4l2_videodevice.h\"\n> > diff --git a/test/libtest/camera_test.h b/test/libtest/camera_test.h\n> > index 0b6bad05e37c..7939798f886e 100644\n> > --- a/test/libtest/camera_test.h\n> > +++ b/test/libtest/camera_test.h\n> > @@ -7,7 +7,10 @@\n> >  #ifndef __LIBCAMERA_CAMERA_TEST_H__\n> >  #define __LIBCAMERA_CAMERA_TEST_H__\n> >\n> > -#include <libcamera/libcamera.h>\n> > +#include <memory>\n> > +\n> > +#include <libcamera/camera.h>\n> > +#include <libcamera/camera_manager.h>\n> >\n> >  using namespace libcamera;\n> >\n> > diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp\n> > index 39d624cde6d5..027923375ed9 100644\n> > --- a/test/mapped-buffer.cpp\n> > +++ b/test/mapped-buffer.cpp\n> > @@ -7,6 +7,8 @@\n> >\n> >  #include <iostream>\n> >\n> > +#include <libcamera/framebuffer_allocator.h>\n> > +\n> >  #include \"libcamera/internal/buffer.h\"\n> >\n> >  #include \"camera_test.h\"","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FBA3BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Sep 2020 10:52:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93A2062FBF;\n\tMon, 21 Sep 2020 12:52:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CA1D60366\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Sep 2020 12:52:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A09EF27B;\n\tMon, 21 Sep 2020 12:52:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s5KpqV6M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600685558;\n\tbh=MxGRWbmQkV+PK8LV+DIFJ3PYl3cTOxzv6DwBcqJXmCw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=s5KpqV6Mn0/6jOUL2K+IoWeBEVL48o/u+wjBMpWaaHT+yJA/XREa+xs01GPBhGUjU\n\t1cAs7PbernwVyhlC+TRXXiS62gVLSj8ch+Qu2TyB83TPj/QSdoAW4tF1dxlnZ8PVIf\n\t4SK0eghxhNVLeVTYjtlmbw2ZvYeZmBRZ2QSvWRLY=","Date":"Mon, 21 Sep 2020 13:52:03 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<20200921105203.GA8290@pendragon.ideasonboard.com>","References":"<20200920134409.24688-1-laurent.pinchart@ideasonboard.com>\n\t<20200921075801.hyk3pssezir7hfod@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200921075801.hyk3pssezir7hfod@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH] test: Include specific headers\n\tinstead of libcamera.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]