[{"id":12606,"web_url":"https://patchwork.libcamera.org/comment/12606/","msgid":"<20200921083436.GE2692107@oden.dyn.berto.se>","date":"2020-09-21T08:34:36","subject":"Re: [libcamera-devel] [PATCH] libcamera: Don't unnecessarily\n\tinclude event_notifier.h","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-09-20 16:43:56 +0300, Laurent Pinchart wrote:\n> The ipc_unixsocket.h and process.h internal headers don't need to\n> include event_notifier.h, the former because a forward declaration\n> suffices, and the latter because it doesn't use event notifiers. Remove\n> the unnecessary include, and include signal.h instead which is required\n> and was included indirectly through event_notifier.h.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/ipc_unixsocket.h | 4 +++-\n> include/libcamera/internal/process.h | 2 +-\n> src/libcamera/ipc_unixsocket.cpp | 2 ++\n> 3 files changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipc_unixsocket.h b/include/libcamera/internal/ipc_unixsocket.h\n> index 9dcaaa26956d..e871b65036bd 100644\n> --- a/include/libcamera/internal/ipc_unixsocket.h\n> +++ b/include/libcamera/internal/ipc_unixsocket.h\n> @@ -12,10 +12,12 @@\n> #include \n> #include \n> \n> -#include \n> +#include \n> \n> namespace libcamera {\n> \n> +class EventNotifier;\n> +\n> class IPCUnixSocket\n> {\n> public:\n> diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\n> index 36595106f3b9..2688557cb8e2 100644\n> --- a/include/libcamera/internal/process.h\n> +++ b/include/libcamera/internal/process.h\n> @@ -10,7 +10,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \n> \n> namespace libcamera {\n> \n> diff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp\n> index 701b2c518217..5c8cce16200e 100644\n> --- a/src/libcamera/ipc_unixsocket.cpp\n> +++ b/src/libcamera/ipc_unixsocket.cpp\n> @@ -12,6 +12,8 @@\n> #include \n> #include \n> \n> +#include \n> +\n> #include \"libcamera/internal/log.h\"\n> \n> /**\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A617BF01C\n\tfor ;\n\tMon, 21 Sep 2020 08:34:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C7F662FBF;\n\tMon, 21 Sep 2020 10:34:40 +0200 (CEST)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7C5060367\n\tfor ;\n\tMon, 21 Sep 2020 10:34:38 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id y17so13054354lfa.8\n\tfor ;\n\tMon, 21 Sep 2020 01:34:38 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ta11sm2370139lfk.262.2020.09.21.01.34.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Sep 2020 01:34:37 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"CsHFGTNu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Bc+9SWLhiXpxQwByjSt0W+o7LBn+RRH0O/OwsuDQTZE=;\n\tb=CsHFGTNuFsnqKf2awc4XVCooovRYaPh97RszDnJxSlVFasDandpNAoYP24SLUVt2BG\n\t7Ypy1RTmuefCW2g0BOmrBMQBKMPq/3XOjUo3FDrNTQ5mdnXbUgXVWnmDDgbOKBBINMFe\n\tTSoITRx0rz7gGquHsUgd7vQLPDLpYWXRy5Dl6hGR+VnR6LY32ErDVbRP14v46OlDDM6q\n\txSaxr/SFZWPeTppe2PZQQBIN3bUnH5ySgqivCvBAl6VqFudlTPI3kjvPmpNnVVyrgvHL\n\tAk8mmtRRuPd4/RxCFPSI0HcVWb7Zsm9uPOJDfutD2lZeovTAMvrg3DONWfRU9Ciw7wfg\n\ti+sA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Bc+9SWLhiXpxQwByjSt0W+o7LBn+RRH0O/OwsuDQTZE=;\n\tb=O5bd9aQNgfPklQuqu+kpAoe2KFJSgWcPtM3AM33X07IGi7tCQ22MmU29mlWfkgT/n4\n\tzYn82QHpizoTVTKQPBWBW/QaHuz+jcWOeLSzavlylUDi28o5h16ypn4q4yxctzUAgxzN\n\teTQ4s7xyie3c9MLASKt5C+iyS0Ym/r/QuHHIoa9eFgY9sAE7lMzpQ2yNUVTGwgvE7jSd\n\tmielHR9VEbvrXC1q6Y2mTZ2KJEXp9FLaKt1toqEEzsMZdu3Z1bVmXOPbNR563axkdLyo\n\tL1K9r5ywP6q3OemxEkj4E+u69LV/TpEorQPBIrGdnUT40rmLdi/kkLQyubVYKAPkNafk\n\tS57g==","X-Gm-Message-State":"AOAM533poUV19hVlbGXaWaL3i5IaonZDzBBW/G52ZQM1IA1kN6NS6Fla\n\t7hHT7MdLRO6NrYU8rfEkeef9NQ==","X-Google-Smtp-Source":"ABdhPJy7sQcSnssXo+oEpvJvMaodNEllPKoOmz8EuAj9KDHy2KeDphsH2H3JD4pEke/9hTXTJ5YMBg==","X-Received":"by 2002:a05:6512:344d:: with SMTP id\n\tj13mr14668406lfr.206.1600677278064; \n\tMon, 21 Sep 2020 01:34:38 -0700 (PDT)","Date":"Mon, 21 Sep 2020 10:34:36 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200921083436.GE2692107@oden.dyn.berto.se>","References":"<20200920134356.24605-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200920134356.24605-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Don't unnecessarily\n\tinclude event_notifier.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12617,"web_url":"https://patchwork.libcamera.org/comment/12617/","msgid":"","date":"2020-09-21T09:59:26","subject":"Re: [libcamera-devel] [PATCH] libcamera: Don't unnecessarily\n\tinclude event_notifier.h","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 20/09/2020 14:43, Laurent Pinchart wrote:\n> The ipc_unixsocket.h and process.h internal headers don't need to\n> include event_notifier.h, the former because a forward declaration\n> suffices, and the latter because it doesn't use event notifiers. Remove\n> the unnecessary include, and include signal.h instead which is required\n> and was included indirectly through event_notifier.h.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/ipc_unixsocket.h | 4 +++-\n> include/libcamera/internal/process.h | 2 +-\n> src/libcamera/ipc_unixsocket.cpp | 2 ++\n> 3 files changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipc_unixsocket.h b/include/libcamera/internal/ipc_unixsocket.h\n> index 9dcaaa26956d..e871b65036bd 100644\n> --- a/include/libcamera/internal/ipc_unixsocket.h\n> +++ b/include/libcamera/internal/ipc_unixsocket.h\n> @@ -12,10 +12,12 @@\n> #include \n> #include \n> \n> -#include \n> +#include \n> \n> namespace libcamera {\n> \n> +class EventNotifier;\n> +\n> class IPCUnixSocket\n> {\n> public:\n> diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\n> index 36595106f3b9..2688557cb8e2 100644\n> --- a/include/libcamera/internal/process.h\n> +++ b/include/libcamera/internal/process.h\n> @@ -10,7 +10,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \n> \n> namespace libcamera {\n> \n> diff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp\n> index 701b2c518217..5c8cce16200e 100644\n> --- a/src/libcamera/ipc_unixsocket.cpp\n> +++ b/src/libcamera/ipc_unixsocket.cpp\n> @@ -12,6 +12,8 @@\n> #include \n> #include \n> \n> +#include \n> +\n> #include \"libcamera/internal/log.h\"\n> \n> /**\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F362FBF01C\n\tfor ;\n\tMon, 21 Sep 2020 09:59:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C257662FD1;\n\tMon, 21 Sep 2020 11:59:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C96D560367\n\tfor ;\n\tMon, 21 Sep 2020 11:59:34 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DA3927B;\n\tMon, 21 Sep 2020 11:59:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sIx5+rWm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600682370;\n\tbh=3p/75FEdbopiizILNoTV05jgOP3+PehRUIrPM2oDvWU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=sIx5+rWmLVPSHzJlWmBeOroG+jxmVm3Eq7ZcLDdUMdgvFjWjzLJf0jv0SLrOllH7i\n\tjxstpeC7Ct8xgq5mkLBcvF4vbOZvPIHgf5+fKFz7MZ+HNejTZdoRJgpWmubzIEApTy\n\tzcpZ9Rke1XGj9tGxDcxksgycKZ/Ar0wTFs7MI7fs=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200920134356.24605-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 21 Sep 2020 10:59:26 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200920134356.24605-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Don't unnecessarily\n\tinclude event_notifier.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]