{"id":9670,"url":"https://patchwork.libcamera.org/api/patches/9670/?format=json","web_url":"https://patchwork.libcamera.org/patch/9670/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200918152019.784315-4-tomi.valkeinen@iki.fi>","date":"2020-09-18T15:20:18","name":"[libcamera-devel,RFC,3/4] hack: Camera public destructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2c111c8731765232148a5f60e14db73554c560f6","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/people/70/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9670/mbox/","series":[{"id":1297,"url":"https://patchwork.libcamera.org/api/series/1297/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1297","date":"2020-09-18T15:20:15","name":"prototype python bindings","version":1,"mbox":"https://patchwork.libcamera.org/series/1297/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9670/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9670/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4DB3BF01C\n\tfor ;\n\tFri, 18 Sep 2020 15:21:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D20262FD2;\n\tFri, 18 Sep 2020 17:21:02 +0200 (CEST)","from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com\n\t[IPv6:2a00:1450:4864:20::12f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FD8562FCA\n\tfor ;\n\tFri, 18 Sep 2020 17:21:00 +0200 (CEST)","by mail-lf1-x12f.google.com with SMTP id y17so6538404lfa.8\n\tfor ;\n\tFri, 18 Sep 2020 08:21:00 -0700 (PDT)","from deskari.ti.com (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\ti63sm666472lji.66.2020.09.18.08.20.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Sep 2020 08:20:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jO9PqtG0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+KkrZj+Dl4+mETvjskRQsD4wDGRHpd+x6BOuY6WTd6Q=;\n\tb=jO9PqtG04aDr5MMCQJEDuG7nSPtehBmATbUpbmcXwNI9nklGnzOxEqGgF0vbu5B9bJ\n\tYEkRIN4FE51ez41nq+AsxqiOD8j8O3vA+LAxtSstOOzNxuOBJu4PrSxiR3lfWPX/eIng\n\to3GTAkd5km9yJSwnCgbhAbY2Tkae5kJpFDreoYUWT5qAnwTIxZIcUAMEHVGTAEFLwbPH\n\tsX2dF5fKei8NcZ8ozIwVPGO2jpVPiH+cvJ5UWDtM2Nats9MlPQwOn9FpUziNrnB7tZf+\n\t03xcxUtoO9xRJKA6Kr/duqB1BeDZYD6zJd86Ic8dJqjmFquaQXf1As4dSlVRIFH9xscp\n\tdsTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=+KkrZj+Dl4+mETvjskRQsD4wDGRHpd+x6BOuY6WTd6Q=;\n\tb=OZNFhj5MQyGpvJIRE3iXpCBpky8CjA6GnSYN1d50x+i/uYcr2WLjwDzapbuxI3s6nJ\n\tlTQcj/10GwUdoYWm4CSjjk3Tn2bx99gOA7w4dPw1BmrgbM9LexvWllAQHV66RKOSBR5U\n\tfC3MM5k0VZHZNIKmSTynUgPbifPy5JuwS9oO+eMjf2WVrmoyd0f2C81Bey4GOkh55OYg\n\tzhKphlibLp4Z6UyR/j8u2TzXuimaCCF5YNqgr308PhQ2daLl0Ju5ETC73wtd+gPwBSJg\n\tzNW//bB8rKeqPwCuHd9eh52blhpsFXPNajJ4Pjv0Q8YcdD+UpKueyxRRWqpk6ybhf9Yi\n\twXgg==","X-Gm-Message-State":"AOAM532hHFFHC8LbWP4uDLZdYt28zsXYYCtKHAQ7j8Zx1Q6+ia+OCi2c\n\tQMEkzyupv5RQZoK/GLGjFv/gHdbCwjThGQ==","X-Google-Smtp-Source":"ABdhPJwvzJqZuqodZZkddQ10cU6QHb8Gkgg+yDDfROqwHgDUKIIdnEDrazxz1ZdN0nnBOvpDzEf9qQ==","X-Received":"by 2002:a19:7912:: with SMTP id\n\tu18mr11964535lfc.298.1600442459393; \n\tFri, 18 Sep 2020 08:20:59 -0700 (PDT)","From":"Tomi Valkeinen ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Sep 2020 18:20:18 +0300","Message-Id":"<20200918152019.784315-4-tomi.valkeinen@iki.fi>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200918152019.784315-1-tomi.valkeinen@iki.fi>","References":"<20200918152019.784315-1-tomi.valkeinen@iki.fi>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC 3/4] hack: Camera public destructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Not clear why we need this with pybind11...\n\nSigned-off-by: Tomi Valkeinen \n---\n include/libcamera/camera.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 272c12c..d50b7ca 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -99,10 +99,10 @@ public:\n \tint start();\n \tint stop();\n \n+\t~Camera();\n private:\n \tCamera(PipelineHandler *pipe, const std::string &id,\n \t const std::set &streams);\n-\t~Camera();\n \n \tclass Private;\n \tstd::unique_ptr p_;\n","prefixes":["libcamera-devel","RFC","3/4"]}