{"id":9660,"url":"https://patchwork.libcamera.org/api/patches/9660/?format=json","web_url":"https://patchwork.libcamera.org/patch/9660/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200918135041.91492-3-jacopo@jmondi.org>","date":"2020-09-18T13:50:35","name":"[libcamera-devel,v2,2/8] android: camera_device: Add frame allocator","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"091036bd9b8f74a943ce5bb1df442cee837dd66d","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9660/mbox/","series":[{"id":1296,"url":"https://patchwork.libcamera.org/api/series/1296/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1296","date":"2020-09-18T13:50:33","name":"android: camera_device: Add support for internal buffers","version":2,"mbox":"https://patchwork.libcamera.org/series/1296/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9660/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9660/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 436A9BF01C\n\tfor ;\n\tFri, 18 Sep 2020 13:47:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 212A162FCD;\n\tFri, 18 Sep 2020 15:47:20 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E3C262FAD\n\tfor ;\n\tFri, 18 Sep 2020 15:47:18 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4A65040008;\n\tFri, 18 Sep 2020 13:47:17 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Sep 2020 15:50:35 +0200","Message-Id":"<20200918135041.91492-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200918135041.91492-1-jacopo@jmondi.org>","References":"<20200918135041.91492-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 2/8] android: camera_device: Add frame\n\tallocator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add to the CameraDevice class a FrameBufferAllocator class member.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Hirokazu Honda \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 5 +++--\n src/android/camera_device.h | 2 ++\n 2 files changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex e4ffbc02c2da..98b8159ebd8c 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -14,6 +14,7 @@\n \n #include \n #include \n+#include \n #include \n \n #include \"libcamera/internal/formats.h\"\n@@ -211,8 +212,8 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n */\n \n CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr &camera)\n-\t: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n-\t facing_(CAMERA_FACING_FRONT), orientation_(0)\n+\t: id_(id), running_(false), camera_(camera), allocator_(camera),\n+\t staticMetadata_(nullptr), facing_(CAMERA_FACING_FRONT), orientation_(0)\n {\n \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n \ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 9a9406cc257c..84f636f7a93c 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -16,6 +16,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -206,6 +207,7 @@ private:\n \tbool running_;\n \tstd::shared_ptr camera_;\n \tstd::unique_ptr config_;\n+\tlibcamera::FrameBufferAllocator allocator_;\n \n \tCameraMetadata *staticMetadata_;\n \tstd::map requestTemplates_;\n","prefixes":["libcamera-devel","v2","2/8"]}