[{"id":12548,"web_url":"https://patchwork.libcamera.org/comment/12548/","msgid":"<20200916150013.GE1850958@oden.dyn.berto.se>","date":"2020-09-16T15:00:13","subject":"Re: [libcamera-devel] [PATCH 1/7] qcam: Remove unneeded './' file\n\tprefix in *.qrc","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-09-16 17:52:48 +0300, Laurent Pinchart wrote:\n> There's no need to prefix files in the local directory with './'. Drop\n> it.\n> \n> While at it, add indentation to make the *.qrc files more readable.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  src/qcam/assets/feathericons/feathericons.qrc | 12 ++++++------\n>  src/qcam/assets/shader/shaders.qrc            |  8 ++++----\n>  2 files changed, 10 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/qcam/assets/feathericons/feathericons.qrc b/src/qcam/assets/feathericons/feathericons.qrc\n> index 656f2b463511..c5302040ea44 100644\n> --- a/src/qcam/assets/feathericons/feathericons.qrc\n> +++ b/src/qcam/assets/feathericons/feathericons.qrc\n> @@ -1,11 +1,11 @@\n>  <!-- SPDX-License-Identifier: GPL-2.0-or-later -->\n>  <!DOCTYPE RCC><RCC version=\"1.0\">\n>  <qresource>\n> -<file>./aperture.svg</file>\n> -<file>./camera-off.svg</file>\n> -<file>./play-circle.svg</file>\n> -<file>./save.svg</file>\n> -<file>./stop-circle.svg</file>\n> -<file>./x-circle.svg</file>\n> +\t<file>aperture.svg</file>\n> +\t<file>camera-off.svg</file>\n> +\t<file>play-circle.svg</file>\n> +\t<file>save.svg</file>\n> +\t<file>stop-circle.svg</file>\n> +\t<file>x-circle.svg</file>\n>  </qresource>\n>  </RCC>\n> diff --git a/src/qcam/assets/shader/shaders.qrc b/src/qcam/assets/shader/shaders.qrc\n> index 33eab2780d5e..9ae35c9f70d6 100644\n> --- a/src/qcam/assets/shader/shaders.qrc\n> +++ b/src/qcam/assets/shader/shaders.qrc\n> @@ -1,9 +1,9 @@\n>  <!-- SPDX-License-Identifier: LGPL-2.1-or-later -->\n>  <!DOCTYPE RCC><RCC version=\"1.0\">\n>  <qresource>\n> -<file>./NV_vertex_shader.glsl</file>\n> -<file>./NV_2_planes_UV_f.glsl</file>\n> -<file>./NV_2_planes_VU_f.glsl</file>\n> -<file>./NV_3_planes_f.glsl</file>\n> +\t<file>NV_vertex_shader.glsl</file>\n> +\t<file>NV_2_planes_UV_f.glsl</file>\n> +\t<file>NV_2_planes_VU_f.glsl</file>\n> +\t<file>NV_3_planes_f.glsl</file>\n>  </qresource>\n>  </RCC>\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8537AC3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Sep 2020 15:00:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DBDE60533;\n\tWed, 16 Sep 2020 17:00:17 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B93A460533\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Sep 2020 17:00:14 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id b19so6169625lji.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Sep 2020 08:00:14 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tl15sm5052550lfk.71.2020.09.16.08.00.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 16 Sep 2020 08:00:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"usdgcacv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=bkI3/i62DxDtyUkkFVqHSA8WBzrmD/cDScos56TKGYY=;\n\tb=usdgcacv8YbdHxyIALkVzR4sGSexaRyasjZ4LkEdAkz/SyjDlZusRnzDpPBdJw87hc\n\t2A2L+wJ5Gu1La/2EMzYbEX4n8RdG5IZ8lK++nTfl445c5mcFDIDmll6h6ZRVrcqZrLhz\n\tPoXNvlIPqADS/jn2WvR0Je5DRfr4qWkyc3r+Z9YQMgF/h9p7xaIwFx3RK+y8QVxbectW\n\ttJQifLPmAHwPkfPs1BvYQy+EIds1Ts/9a91SP0qYy1Dqq777CzjPRZqkQvh/GRXMGEh0\n\tDWIAGkSBHDK7BQxmuOQoCYiaiMSyaKUyRP0XAj7wi6FB2v1H9iMc/p0cxB2Wvt8BqtTe\n\tyavQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=bkI3/i62DxDtyUkkFVqHSA8WBzrmD/cDScos56TKGYY=;\n\tb=NK9z+4tkGucQhBCrcmUPXXksZPRTz7v8qDezYtzCysju1MPNR9G1dx1wszQZ/ejMdS\n\t9ZRc+0o8uvn1iSgtio4NUVtbwr8gnOOmDMpnOWkLa9Dgm8qO0pFdslKKaOz//GwJmlUD\n\tiqd4P6UgzO6pAVi52/Cen70as2onmR/vRrT0Yk7bGGrm9yLjNWE71GeFel3iJmGZTjOC\n\tcXv+jJgxak98XDwHVWcYgWgozRpYl35R0LuQhJLj9nJRgHXiynq0xxZJFlGTMd1+SsFN\n\tyE8jlSay981f4jNHucK6bhDm91893B8grt4eXHrNpxZUNOhzqIpjfSXpMVfy7i4sevQk\n\tXthQ==","X-Gm-Message-State":"AOAM530aYJo/vhpJxOu/5mRHNG9Mr9vqt4e2IWRKbG1AZ5n4LAX7LH1u\n\tV01F4hQwkj5yilMNKZ0rQEYGFP4IqxIBrw==","X-Google-Smtp-Source":"ABdhPJwZbHPAdNX1kSmqSMesvEm7wjwO/T9OJybx8DsdTDTrn2p0BJQNBybBUfy8OY+orYM2p7k/bA==","X-Received":"by 2002:a2e:3c11:: with SMTP id\n\tj17mr9240371lja.357.1600268414103; \n\tWed, 16 Sep 2020 08:00:14 -0700 (PDT)","Date":"Wed, 16 Sep 2020 17:00:13 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20200916150013.GE1850958@oden.dyn.berto.se>","References":"<20200916145254.1644-1-laurent.pinchart@ideasonboard.com>\n\t<20200916145254.1644-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200916145254.1644-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/7] qcam: Remove unneeded './' file\n\tprefix in *.qrc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]