[{"id":12543,"web_url":"https://patchwork.libcamera.org/comment/12543/","msgid":"<962f3b44-abe1-3c4a-700f-ddcf421c3687@ideasonboard.com>","date":"2020-09-16T13:09:53","subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 16/09/2020 14:06, Laurent Pinchart wrote:\n> Allow disabling compilation of the Android HAL adaptation layer\n> automatically when a dependency is missing by turning the android option\n> into a feature. The default value is set to 'disabled' to match the\n> current behaviour.\n> \n\nThanks, this was something that was on my radar too.\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  meson_options.txt         |  4 ++--\n>  src/android/meson.build   | 19 ++++++++++++++-----\n>  src/libcamera/meson.build |  2 +-\n>  src/meson.build           |  4 +---\n>  4 files changed, 18 insertions(+), 11 deletions(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index e9e815fde366..d2e07ef1450f 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -1,8 +1,8 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n>  option('android',\n> -        type : 'boolean',\n> -        value : false,\n> +        type : 'feature',\n> +        value : 'disabled',\n>          description : 'Compile libcamera with Android Camera3 HAL interface')\n>  \n>  option('documentation',\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index ecb92f6e9b3a..0293c2036561 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -1,5 +1,19 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> +android_deps = [\n> +    dependency('libexif', required : get_option('android')),\n> +    dependency('libjpeg', required : get_option('android')),\n> +]\n> +\n> +android_enabled = true\n> +\n> +foreach dep : android_deps\n> +    if not dep.found()\n> +        android_enabled = false\n> +        subdir_done()\n> +    endif\n> +endforeach\n> +\n>  android_hal_sources = files([\n>      'camera3_hal.cpp',\n>      'camera_hal_manager.cpp',\n> @@ -14,11 +28,6 @@ android_camera_metadata_sources = files([\n>      'metadata/camera_metadata.c',\n>  ])\n>  \n> -android_deps = [\n> -    dependency('libexif'),\n> -    dependency('libjpeg'),\n> -]\n> -\n>  android_camera_metadata = static_library('camera_metadata',\n>                                           android_camera_metadata_sources,\n>                                           include_directories : android_includes)\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index af2f3d950be6..0e6ecf5060a4 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -121,7 +121,7 @@ libcamera_deps = [\n>  \n>  libcamera_link_with = []\n>  \n> -if get_option('android')\n> +if android_enabled\n>      libcamera_sources += android_hal_sources\n>      includes += android_includes\n>      libcamera_link_with += android_camera_metadata\n> diff --git a/src/meson.build b/src/meson.build\n> index d69b4c1ea978..0c5b64d68c15 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -1,8 +1,6 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> -if get_option('android')\n> -    subdir('android')\n> -endif\n> +subdir('android')\n>  \n>  openssl = find_program('openssl', required : true)\n>  if openssl.found()\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FF7BBF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Sep 2020 13:09:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC12562E75;\n\tWed, 16 Sep 2020 15:09:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C72960533\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Sep 2020 15:09:56 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A451B57F;\n\tWed, 16 Sep 2020 15:09:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c/PLMeDZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600261796;\n\tbh=dpbtERSYYlReafI6yTlB0Oca5seXAFJxYphdZoNkKiY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=c/PLMeDZMB34lXjI3gdCPsBadE3M6jr+kyWMD8GUTqNS+bRpHDF8PePhlZCybV0ds\n\t63GrLGKt8DyJl8Yy3ubO02c2JnCu9RfTnnntUvJ4PPAT3b3+FnxOZsIi2QMB+SYvvH\n\toERmkS8DsScukPSeIfLF/4h5lY0Bj0aGfniBOqmQ=","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200916130612.27694-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<962f3b44-abe1-3c4a-700f-ddcf421c3687@ideasonboard.com>","Date":"Wed, 16 Sep 2020 14:09:53 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200916130612.27694-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":12544,"web_url":"https://patchwork.libcamera.org/comment/12544/","msgid":"<20200916131103.GF3853@pendragon.ideasonboard.com>","date":"2020-09-16T13:11:03","subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 16, 2020 at 02:09:53PM +0100, Kieran Bingham wrote:\n> Hi Laurent,\n> \n> On 16/09/2020 14:06, Laurent Pinchart wrote:\n> > Allow disabling compilation of the Android HAL adaptation layer\n> > automatically when a dependency is missing by turning the android option\n> > into a feature. The default value is set to 'disabled' to match the\n> > current behaviour.\n> \n> Thanks, this was something that was on my radar too.\n\nIt was that, or updating my build scripts to selectively enable/disable\nthe Android HAL based on the target. I think this is better :-)\n\n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > ---\n> >  meson_options.txt         |  4 ++--\n> >  src/android/meson.build   | 19 ++++++++++++++-----\n> >  src/libcamera/meson.build |  2 +-\n> >  src/meson.build           |  4 +---\n> >  4 files changed, 18 insertions(+), 11 deletions(-)\n> > \n> > diff --git a/meson_options.txt b/meson_options.txt\n> > index e9e815fde366..d2e07ef1450f 100644\n> > --- a/meson_options.txt\n> > +++ b/meson_options.txt\n> > @@ -1,8 +1,8 @@\n> >  # SPDX-License-Identifier: CC0-1.0\n> >  \n> >  option('android',\n> > -        type : 'boolean',\n> > -        value : false,\n> > +        type : 'feature',\n> > +        value : 'disabled',\n> >          description : 'Compile libcamera with Android Camera3 HAL interface')\n> >  \n> >  option('documentation',\n> > diff --git a/src/android/meson.build b/src/android/meson.build\n> > index ecb92f6e9b3a..0293c2036561 100644\n> > --- a/src/android/meson.build\n> > +++ b/src/android/meson.build\n> > @@ -1,5 +1,19 @@\n> >  # SPDX-License-Identifier: CC0-1.0\n> >  \n> > +android_deps = [\n> > +    dependency('libexif', required : get_option('android')),\n> > +    dependency('libjpeg', required : get_option('android')),\n> > +]\n> > +\n> > +android_enabled = true\n> > +\n> > +foreach dep : android_deps\n> > +    if not dep.found()\n> > +        android_enabled = false\n> > +        subdir_done()\n> > +    endif\n> > +endforeach\n> > +\n> >  android_hal_sources = files([\n> >      'camera3_hal.cpp',\n> >      'camera_hal_manager.cpp',\n> > @@ -14,11 +28,6 @@ android_camera_metadata_sources = files([\n> >      'metadata/camera_metadata.c',\n> >  ])\n> >  \n> > -android_deps = [\n> > -    dependency('libexif'),\n> > -    dependency('libjpeg'),\n> > -]\n> > -\n> >  android_camera_metadata = static_library('camera_metadata',\n> >                                           android_camera_metadata_sources,\n> >                                           include_directories : android_includes)\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index af2f3d950be6..0e6ecf5060a4 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -121,7 +121,7 @@ libcamera_deps = [\n> >  \n> >  libcamera_link_with = []\n> >  \n> > -if get_option('android')\n> > +if android_enabled\n> >      libcamera_sources += android_hal_sources\n> >      includes += android_includes\n> >      libcamera_link_with += android_camera_metadata\n> > diff --git a/src/meson.build b/src/meson.build\n> > index d69b4c1ea978..0c5b64d68c15 100644\n> > --- a/src/meson.build\n> > +++ b/src/meson.build\n> > @@ -1,8 +1,6 @@\n> >  # SPDX-License-Identifier: CC0-1.0\n> >  \n> > -if get_option('android')\n> > -    subdir('android')\n> > -endif\n> > +subdir('android')\n> >  \n> >  openssl = find_program('openssl', required : true)\n> >  if openssl.found()\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 957AABF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Sep 2020 13:11:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CC1A62EBD;\n\tWed, 16 Sep 2020 15:11:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E278460533\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Sep 2020 15:11:33 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D82C057F;\n\tWed, 16 Sep 2020 15:11:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q1oeQZt6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600261893;\n\tbh=IGL8LY5iAYLbeLI3N1NWWVGYXcir7/6tzjWVEtx02M4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q1oeQZt6J5V2Aq4LlZ3JtZwf49y3J0iw0v1nboCMOAmQBvxdfQ0x0U9lptnnQnSol\n\tUuBgTK7eNT3ZxmduHQCoWhI/yGwQ0qPdqCL+vkZ1xbTC0USyKX697VOZWPSaCTatvX\n\tRbB9j28GEEL5Ee4VC751SmzmWI3Phg+KEgRnHNP8=","Date":"Wed, 16 Sep 2020 16:11:03 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20200916131103.GF3853@pendragon.ideasonboard.com>","References":"<20200916130612.27694-1-laurent.pinchart@ideasonboard.com>\n\t<962f3b44-abe1-3c4a-700f-ddcf421c3687@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<962f3b44-abe1-3c4a-700f-ddcf421c3687@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":12545,"web_url":"https://patchwork.libcamera.org/comment/12545/","msgid":"<3c2be684-7146-35d3-5c82-ed9cc37b5f8c@ideasonboard.com>","date":"2020-09-16T13:13:46","subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 16/09/2020 14:11, Laurent Pinchart wrote:\n> On Wed, Sep 16, 2020 at 02:09:53PM +0100, Kieran Bingham wrote:\n>> Hi Laurent,\n>>\n>> On 16/09/2020 14:06, Laurent Pinchart wrote:\n>>> Allow disabling compilation of the Android HAL adaptation layer\n>>> automatically when a dependency is missing by turning the android option\n>>> into a feature. The default value is set to 'disabled' to match the\n>>> current behaviour.\n>>\n>> Thanks, this was something that was on my radar too.\n> \n> It was that, or updating my build scripts to selectively enable/disable\n> the Android HAL based on the target. I think this is better :-)\n\nWell ...\nYou could have installed libjpeg and libexif on the target hehe ;-)\n\nNow we just need to do the same with the RPi IPA and that boost dependency!\n\n--\nKieran\n\n\n>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>>\n>> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>>\n>>> ---\n>>>  meson_options.txt         |  4 ++--\n>>>  src/android/meson.build   | 19 ++++++++++++++-----\n>>>  src/libcamera/meson.build |  2 +-\n>>>  src/meson.build           |  4 +---\n>>>  4 files changed, 18 insertions(+), 11 deletions(-)\n>>>\n>>> diff --git a/meson_options.txt b/meson_options.txt\n>>> index e9e815fde366..d2e07ef1450f 100644\n>>> --- a/meson_options.txt\n>>> +++ b/meson_options.txt\n>>> @@ -1,8 +1,8 @@\n>>>  # SPDX-License-Identifier: CC0-1.0\n>>>  \n>>>  option('android',\n>>> -        type : 'boolean',\n>>> -        value : false,\n>>> +        type : 'feature',\n>>> +        value : 'disabled',\n>>>          description : 'Compile libcamera with Android Camera3 HAL interface')\n>>>  \n>>>  option('documentation',\n>>> diff --git a/src/android/meson.build b/src/android/meson.build\n>>> index ecb92f6e9b3a..0293c2036561 100644\n>>> --- a/src/android/meson.build\n>>> +++ b/src/android/meson.build\n>>> @@ -1,5 +1,19 @@\n>>>  # SPDX-License-Identifier: CC0-1.0\n>>>  \n>>> +android_deps = [\n>>> +    dependency('libexif', required : get_option('android')),\n>>> +    dependency('libjpeg', required : get_option('android')),\n>>> +]\n>>> +\n>>> +android_enabled = true\n>>> +\n>>> +foreach dep : android_deps\n>>> +    if not dep.found()\n>>> +        android_enabled = false\n>>> +        subdir_done()\n>>> +    endif\n>>> +endforeach\n>>> +\n>>>  android_hal_sources = files([\n>>>      'camera3_hal.cpp',\n>>>      'camera_hal_manager.cpp',\n>>> @@ -14,11 +28,6 @@ android_camera_metadata_sources = files([\n>>>      'metadata/camera_metadata.c',\n>>>  ])\n>>>  \n>>> -android_deps = [\n>>> -    dependency('libexif'),\n>>> -    dependency('libjpeg'),\n>>> -]\n>>> -\n>>>  android_camera_metadata = static_library('camera_metadata',\n>>>                                           android_camera_metadata_sources,\n>>>                                           include_directories : android_includes)\n>>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n>>> index af2f3d950be6..0e6ecf5060a4 100644\n>>> --- a/src/libcamera/meson.build\n>>> +++ b/src/libcamera/meson.build\n>>> @@ -121,7 +121,7 @@ libcamera_deps = [\n>>>  \n>>>  libcamera_link_with = []\n>>>  \n>>> -if get_option('android')\n>>> +if android_enabled\n>>>      libcamera_sources += android_hal_sources\n>>>      includes += android_includes\n>>>      libcamera_link_with += android_camera_metadata\n>>> diff --git a/src/meson.build b/src/meson.build\n>>> index d69b4c1ea978..0c5b64d68c15 100644\n>>> --- a/src/meson.build\n>>> +++ b/src/meson.build\n>>> @@ -1,8 +1,6 @@\n>>>  # SPDX-License-Identifier: CC0-1.0\n>>>  \n>>> -if get_option('android')\n>>> -    subdir('android')\n>>> -endif\n>>> +subdir('android')\n>>>  \n>>>  openssl = find_program('openssl', required : true)\n>>>  if openssl.found()\n>>>\n>>\n>> -- \n>> Regards\n>> --\n>> Kieran\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7C15BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Sep 2020 13:13:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42A9962E75;\n\tWed, 16 Sep 2020 15:13:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2941F60533\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Sep 2020 15:13:50 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3587E57F;\n\tWed, 16 Sep 2020 15:13:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lj9ryN3Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600262028;\n\tbh=xiXm3H6LR8Sy/4xEyWBxsrn6U2VsLpmrJhEjLOj0o04=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=lj9ryN3QNMrBPelP9opWIHBTOV9oeLSTNpB66D09WcePZPMWtMi+Ed1VLAD9epkJD\n\tML9Q3nhKTIUaMPnrZWofR5fM3epKceMm1CB/7xBkedVIvvUraclKCYIkrC4gJVHGAA\n\tMi3Wn4L5pOCx29cCszNofct/WJ/W/iIHH9PcEYHE=","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20200916130612.27694-1-laurent.pinchart@ideasonboard.com>\n\t<962f3b44-abe1-3c4a-700f-ddcf421c3687@ideasonboard.com>\n\t<20200916131103.GF3853@pendragon.ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3c2be684-7146-35d3-5c82-ed9cc37b5f8c@ideasonboard.com>","Date":"Wed, 16 Sep 2020 14:13:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200916131103.GF3853@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":12546,"web_url":"https://patchwork.libcamera.org/comment/12546/","msgid":"<20200916131411.GG3853@pendragon.ideasonboard.com>","date":"2020-09-16T13:14:11","subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 16, 2020 at 02:13:46PM +0100, Kieran Bingham wrote:\n> On 16/09/2020 14:11, Laurent Pinchart wrote:\n> > On Wed, Sep 16, 2020 at 02:09:53PM +0100, Kieran Bingham wrote:\n> >> Hi Laurent,\n> >>\n> >> On 16/09/2020 14:06, Laurent Pinchart wrote:\n> >>> Allow disabling compilation of the Android HAL adaptation layer\n> >>> automatically when a dependency is missing by turning the android option\n> >>> into a feature. The default value is set to 'disabled' to match the\n> >>> current behaviour.\n> >>\n> >> Thanks, this was something that was on my radar too.\n> > \n> > It was that, or updating my build scripts to selectively enable/disable\n> > the Android HAL based on the target. I think this is better :-)\n> \n> Well ...\n> You could have installed libjpeg and libexif on the target hehe ;-)\n> \n> Now we just need to do the same with the RPi IPA and that boost dependency!\n\nThat's something I'd like to see being done, it may require some manual\nlogic though.\n\n> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> >>\n> >> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> >>\n> >>> ---\n> >>>  meson_options.txt         |  4 ++--\n> >>>  src/android/meson.build   | 19 ++++++++++++++-----\n> >>>  src/libcamera/meson.build |  2 +-\n> >>>  src/meson.build           |  4 +---\n> >>>  4 files changed, 18 insertions(+), 11 deletions(-)\n> >>>\n> >>> diff --git a/meson_options.txt b/meson_options.txt\n> >>> index e9e815fde366..d2e07ef1450f 100644\n> >>> --- a/meson_options.txt\n> >>> +++ b/meson_options.txt\n> >>> @@ -1,8 +1,8 @@\n> >>>  # SPDX-License-Identifier: CC0-1.0\n> >>>  \n> >>>  option('android',\n> >>> -        type : 'boolean',\n> >>> -        value : false,\n> >>> +        type : 'feature',\n> >>> +        value : 'disabled',\n> >>>          description : 'Compile libcamera with Android Camera3 HAL interface')\n> >>>  \n> >>>  option('documentation',\n> >>> diff --git a/src/android/meson.build b/src/android/meson.build\n> >>> index ecb92f6e9b3a..0293c2036561 100644\n> >>> --- a/src/android/meson.build\n> >>> +++ b/src/android/meson.build\n> >>> @@ -1,5 +1,19 @@\n> >>>  # SPDX-License-Identifier: CC0-1.0\n> >>>  \n> >>> +android_deps = [\n> >>> +    dependency('libexif', required : get_option('android')),\n> >>> +    dependency('libjpeg', required : get_option('android')),\n> >>> +]\n> >>> +\n> >>> +android_enabled = true\n> >>> +\n> >>> +foreach dep : android_deps\n> >>> +    if not dep.found()\n> >>> +        android_enabled = false\n> >>> +        subdir_done()\n> >>> +    endif\n> >>> +endforeach\n> >>> +\n> >>>  android_hal_sources = files([\n> >>>      'camera3_hal.cpp',\n> >>>      'camera_hal_manager.cpp',\n> >>> @@ -14,11 +28,6 @@ android_camera_metadata_sources = files([\n> >>>      'metadata/camera_metadata.c',\n> >>>  ])\n> >>>  \n> >>> -android_deps = [\n> >>> -    dependency('libexif'),\n> >>> -    dependency('libjpeg'),\n> >>> -]\n> >>> -\n> >>>  android_camera_metadata = static_library('camera_metadata',\n> >>>                                           android_camera_metadata_sources,\n> >>>                                           include_directories : android_includes)\n> >>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> >>> index af2f3d950be6..0e6ecf5060a4 100644\n> >>> --- a/src/libcamera/meson.build\n> >>> +++ b/src/libcamera/meson.build\n> >>> @@ -121,7 +121,7 @@ libcamera_deps = [\n> >>>  \n> >>>  libcamera_link_with = []\n> >>>  \n> >>> -if get_option('android')\n> >>> +if android_enabled\n> >>>      libcamera_sources += android_hal_sources\n> >>>      includes += android_includes\n> >>>      libcamera_link_with += android_camera_metadata\n> >>> diff --git a/src/meson.build b/src/meson.build\n> >>> index d69b4c1ea978..0c5b64d68c15 100644\n> >>> --- a/src/meson.build\n> >>> +++ b/src/meson.build\n> >>> @@ -1,8 +1,6 @@\n> >>>  # SPDX-License-Identifier: CC0-1.0\n> >>>  \n> >>> -if get_option('android')\n> >>> -    subdir('android')\n> >>> -endif\n> >>> +subdir('android')\n> >>>  \n> >>>  openssl = find_program('openssl', required : true)\n> >>>  if openssl.found()","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6F6FC3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Sep 2020 13:14:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A356862E9F;\n\tWed, 16 Sep 2020 15:14:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C10F860533\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Sep 2020 15:14:43 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC52357F;\n\tWed, 16 Sep 2020 15:14:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"glVsGRBy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600262081;\n\tbh=I61oK7dhmH5t3TMU2Hrtw28OGrcsTUyd9V8eYNiOVM8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=glVsGRByx4PABF3sr44sNO4pf5c83dw3VcB4D7WYos4U/sEEdbvBOrzDNHS/QE5W8\n\tmwAPsrzArkSQ9FtiVOZMipn4mePnR5HcQm+Mvbu/eV7c+6gAcAndQOwm8a0IKu8gCs\n\taqxrEE2cN5hCYc4In4IlXgOg8WU+JbnzaygPjdvg=","Date":"Wed, 16 Sep 2020 16:14:11 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20200916131411.GG3853@pendragon.ideasonboard.com>","References":"<20200916130612.27694-1-laurent.pinchart@ideasonboard.com>\n\t<962f3b44-abe1-3c4a-700f-ddcf421c3687@ideasonboard.com>\n\t<20200916131103.GF3853@pendragon.ideasonboard.com>\n\t<3c2be684-7146-35d3-5c82-ed9cc37b5f8c@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<3c2be684-7146-35d3-5c82-ed9cc37b5f8c@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":12547,"web_url":"https://patchwork.libcamera.org/comment/12547/","msgid":"<20200916145747.GD1850958@oden.dyn.berto.se>","date":"2020-09-16T14:57:47","subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-09-16 16:06:12 +0300, Laurent Pinchart wrote:\n> Allow disabling compilation of the Android HAL adaptation layer\n> automatically when a dependency is missing by turning the android option\n> into a feature. The default value is set to 'disabled' to match the\n> current behaviour.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  meson_options.txt         |  4 ++--\n>  src/android/meson.build   | 19 ++++++++++++++-----\n>  src/libcamera/meson.build |  2 +-\n>  src/meson.build           |  4 +---\n>  4 files changed, 18 insertions(+), 11 deletions(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index e9e815fde366..d2e07ef1450f 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -1,8 +1,8 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n>  option('android',\n> -        type : 'boolean',\n> -        value : false,\n> +        type : 'feature',\n> +        value : 'disabled',\n>          description : 'Compile libcamera with Android Camera3 HAL interface')\n>  \n>  option('documentation',\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index ecb92f6e9b3a..0293c2036561 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -1,5 +1,19 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> +android_deps = [\n> +    dependency('libexif', required : get_option('android')),\n> +    dependency('libjpeg', required : get_option('android')),\n> +]\n> +\n> +android_enabled = true\n> +\n> +foreach dep : android_deps\n> +    if not dep.found()\n> +        android_enabled = false\n> +        subdir_done()\n> +    endif\n> +endforeach\n> +\n>  android_hal_sources = files([\n>      'camera3_hal.cpp',\n>      'camera_hal_manager.cpp',\n> @@ -14,11 +28,6 @@ android_camera_metadata_sources = files([\n>      'metadata/camera_metadata.c',\n>  ])\n>  \n> -android_deps = [\n> -    dependency('libexif'),\n> -    dependency('libjpeg'),\n> -]\n> -\n>  android_camera_metadata = static_library('camera_metadata',\n>                                           android_camera_metadata_sources,\n>                                           include_directories : android_includes)\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index af2f3d950be6..0e6ecf5060a4 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -121,7 +121,7 @@ libcamera_deps = [\n>  \n>  libcamera_link_with = []\n>  \n> -if get_option('android')\n> +if android_enabled\n>      libcamera_sources += android_hal_sources\n>      includes += android_includes\n>      libcamera_link_with += android_camera_metadata\n> diff --git a/src/meson.build b/src/meson.build\n> index d69b4c1ea978..0c5b64d68c15 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -1,8 +1,6 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> -if get_option('android')\n> -    subdir('android')\n> -endif\n> +subdir('android')\n>  \n>  openssl = find_program('openssl', required : true)\n>  if openssl.found()\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9618BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Sep 2020 14:57:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 577C362E75;\n\tWed, 16 Sep 2020 16:57:51 +0200 (CEST)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E5CD60380\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Sep 2020 16:57:50 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id z19so7349597lfr.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Sep 2020 07:57:50 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tj127sm5023747lfd.6.2020.09.16.07.57.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 16 Sep 2020 07:57:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"vrfa7tvs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=/XlYvZIQYJkQUBKLvF/ARoIvnb1uUVihs2RFZduF1bQ=;\n\tb=vrfa7tvsLgOe4SDbnNc3kGejIVytG4fOoYvdTwTMpGswhXmkbQpkIGAM2DcI7rV9rw\n\t2ye1L/TLyRXKkgRFTipJnk3nlfVK22otExGqiwkL7CoyDB1lZ60ODm2qULStFc479KAT\n\tnJtPC5rv9hx8tTFweoO5MO5DuY+aiEevi990GqXgT0yGFFVLA22Rasm54GBaBbdFES+y\n\tfzkxyFQwc/G6RZEIor3m7hKjF48VNGPF3u8++AqPRxqgLYQzI9Ng42rXAA6/TUGbY9r5\n\tfluVfeYXD41KrpYLCi5md5mZ+s5gFsixTNAhWRn3dl7Vypc1tHjQlWYwdxEYiQTvGCYc\n\tgBGg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=/XlYvZIQYJkQUBKLvF/ARoIvnb1uUVihs2RFZduF1bQ=;\n\tb=bPMR8MByFpJC+PYmR4EeBmpiEQ0nnKNidm/zoMutkQoFdI3jHS0mg15u3cp4HpDa+k\n\tT5rf7C4rGh7C/Vr2zdCA50GQvFBt1q2+gfzw/bIHZII500QQwAl+XVxW/SRfDwZp2xbN\n\t97PIaWq8/cde7zvZ+Zxp352iMaG2Gsa0FFOCV+7O2IVBcfcZLovk1hiFq5J+E+y8myuF\n\tM1P5Cp7DGxYkMg5i3ravIRS5gb54MWJwaO4+jcpITJabh1VESS8HKCtAVLPA8hRdjKfZ\n\tSkjLrlG2zV2riIpkdSYrk2jJJ/4WhtLlMvmxa0Lw6WJahr6cesiIMFWFDQCzNX+er2ja\n\ta4bA==","X-Gm-Message-State":"AOAM530++w0P0DzpfDhUxa9Dw8USNYq+DJWrnnJpplzYNPVIfPDxYM9Q\n\tHWrP/63aI5Gyi/HBy5E+dEm4GA==","X-Google-Smtp-Source":"ABdhPJxP79vwj2mwXLqv4xXfRxMs5s45TrVG55obCIQww5bdYvri2TDdxiFhk62+dvmTW/+wFXaGJQ==","X-Received":"by 2002:a19:d13:: with SMTP id 19mr8525278lfn.402.1600268269146; \n\tWed, 16 Sep 2020 07:57:49 -0700 (PDT)","Date":"Wed, 16 Sep 2020 16:57:47 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20200916145747.GD1850958@oden.dyn.berto.se>","References":"<20200916130612.27694-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200916130612.27694-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Turn the android option\n\tinto a feature","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]