{"id":963,"url":"https://patchwork.libcamera.org/api/patches/963/?format=json","web_url":"https://patchwork.libcamera.org/patch/963/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190409192548.20325-9-jacopo@jmondi.org>","date":"2019-04-09T19:25:44","name":"[libcamera-devel,v4,08/12] libcamera: camera: Refuse empty requests","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1b2a6ae7b4251a7a143a51e7d05e12acb56a372a","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/963/mbox/","series":[{"id":247,"url":"https://patchwork.libcamera.org/api/series/247/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=247","date":"2019-04-09T19:25:36","name":"libcamera: ipu3: Multiple streams support","version":4,"mbox":"https://patchwork.libcamera.org/series/247/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/963/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/963/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50FE660DBD\n\tfor ;\n\tTue, 9 Apr 2019 21:25:10 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id D6FF4200008;\n\tTue, 9 Apr 2019 19:25:09 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 9 Apr 2019 21:25:44 +0200","Message-Id":"<20190409192548.20325-9-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190409192548.20325-1-jacopo@jmondi.org>","References":"<20190409192548.20325-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 08/12] libcamera: camera: Refuse empty\n\trequests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 09 Apr 2019 19:25:12 -0000"},"content":"Requests that do not contain any Stream should not be forwarded to\nthe pipeline handlers. Return -EINVAL if the request does not contain\nany Stream to capture from.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/camera.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex cb392ca3b7e7..bd73ff69c3da 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -728,6 +728,7 @@ Request *Camera::createRequest()\n * \\return 0 on success or a negative error code otherwise\n * \\retval -ENODEV The camera has been disconnected from the system\n * \\retval -EACCES The camera is not running so requests can't be queued\n+ * \\retval -EINVAL The request does not contain any stream to capture from\n */\n int Camera::queueRequest(Request *request)\n {\n@@ -743,6 +744,9 @@ int Camera::queueRequest(Request *request)\n \t\treturn ret;\n \t}\n \n+\tif (request->empty())\n+\t\treturn -EINVAL;\n+\n \treturn pipe_->queueRequest(this, request);\n }\n \n","prefixes":["libcamera-devel","v4","08/12"]}