[{"id":12586,"web_url":"https://patchwork.libcamera.org/comment/12586/","msgid":"<20200919114947.GS1850958@oden.dyn.berto.se>","date":"2020-09-19T11:49:47","subject":"Re: [libcamera-devel] [PATCH 16/23] libcamera: IPAManager: add\n\tisolation flag to proxy creation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2020-09-15 23:20:31 +0900, Paul Elder wrote:\n> When the IPA proxy is created, it needs to know whether to isolate or\n> not. Feed the flag at creation of the IPA proxy.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/ipa_manager.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 2d0ea242..26458153 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -291,7 +291,8 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> \t\treturn nullptr;\n> \t}\n> \n> -\tstd::unique_ptr proxy = pf->create(m);\n> +\tstd::unique_ptr proxy =\n> +\t\tpf->create(m, !self_->isSignatureValid(m));\n> \tif (!proxy->isValid()) {\n> \t\tLOG(IPAManager, Error) << \"Failed to load proxy\";\n> \t\treturn nullptr;\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1BF5C3B5B\n\tfor ;\n\tSat, 19 Sep 2020 11:49:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9068162FBC;\n\tSat, 19 Sep 2020 13:49:49 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B20060367\n\tfor ;\n\tSat, 19 Sep 2020 13:49:48 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id n25so7207081ljj.4\n\tfor ;\n\tSat, 19 Sep 2020 04:49:48 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tl16sm1245635lje.90.2020.09.19.04.49.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 19 Sep 2020 04:49:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"jOM/FmfP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=FjvSQDl+rcX+2uIYKuRKIu5Aqt9oh1cV3Oo6N7JmJls=;\n\tb=jOM/FmfPTyRTO5WNdlQcGVbObUJpRi01EqCbw8cvc340J7DT4QEPd/4RLMNaH79Qet\n\ttBYbjad0kIekpFJwNKnlRgNtxcxSHk8GlChho1y/InMU69DvCzABtBm+VP7B+5bLzNot\n\tDYe6CtqeCCO8Qym/x32b16kx0pjZ45JUio601ZVdH612KBo+eFOwWfa68wuQcp907hA1\n\t4bxDTrIHXnBptB/u1Aq8wUd4VrVOS+mXklFLazgJ4IvcAUSx50umUSXGGPzNQbkY8RIz\n\tQ7xzzxv1804UUe5uAyFkR85Yh8Q41mzaohldwauioFmSlMk0vXa4G0k/Xfgl3CDlAbl8\n\tfbsg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=FjvSQDl+rcX+2uIYKuRKIu5Aqt9oh1cV3Oo6N7JmJls=;\n\tb=kq5L85EoOGOk4z11ezKxQrY+xr2xJwkyCE1AWkbyZN4PCg/WAqARFOKibdzVOGJhGl\n\tnv3t0JZrdfQsPcTUH49wMfoDSSCQ/SYSqHIywx2nhusCWqx1ClYh4zT1Eo5bvEauHvnV\n\tR9glsD81Lx18AEm4dVS3C8/yt/Xkf1VG2uY69g8icxE2E22N2+UTs91jCW5ELpB2T95Z\n\tZA167UIOQv4BRn9zuznZHzK6YqL2uRmXGqf219LBYaXyxcJ2BeTpCpnebw1GEXBQcHJW\n\tR890muH/ADrxgsVjEFdkCDmn4wQhhKnGvN1A4KNIupY8TeicWaNBRqjYdVhjAQ31Wh/w\n\tjl2w==","X-Gm-Message-State":"AOAM531UeaAppEwz3JhO6CSZ/g92hNzKd4LN9b6ci9Segd5BjkvnH4Eq\n\t54PDDyoUBk7WmEagWDgJaXVgrQ==","X-Google-Smtp-Source":"ABdhPJzC/Acm3FpX/hSOSApklH0NhizPlQq1aBW4u/nGphAYiOqDMFifqa6XKZrI7aRixkJ/Mq3P3A==","X-Received":"by 2002:a2e:7604:: with SMTP id\n\tr4mr12684486ljc.161.1600516187885; \n\tSat, 19 Sep 2020 04:49:47 -0700 (PDT)","Date":"Sat, 19 Sep 2020 13:49:47 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"<20200919114947.GS1850958@oden.dyn.berto.se>","References":"<20200915142038.28757-1-paul.elder@ideasonboard.com>\n\t<20200915142038.28757-17-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200915142038.28757-17-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 16/23] libcamera: IPAManager: add\n\tisolation flag to proxy creation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]