{"id":9625,"url":"https://patchwork.libcamera.org/api/patches/9625/?format=json","web_url":"https://patchwork.libcamera.org/patch/9625/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200915142038.28757-16-paul.elder@ideasonboard.com>","date":"2020-09-15T14:20:30","name":"[libcamera-devel,15/23] libcamera: IPAManager: Fetch IPAProxy corresponding to pipeline","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1fd9b3792b7a4a298c413075a32da0bd34e4f93e","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9625/mbox/","series":[{"id":1291,"url":"https://patchwork.libcamera.org/api/series/1291/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1291","date":"2020-09-15T14:20:16","name":"IPA isolation implementation","version":1,"mbox":"https://patchwork.libcamera.org/series/1291/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9625/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9625/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E7D1BF01C\n\tfor ;\n\tTue, 15 Sep 2020 14:21:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A24862E3C;\n\tTue, 15 Sep 2020 16:21:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB5EB62E17\n\tfor ;\n\tTue, 15 Sep 2020 16:21:27 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5B3314DF;\n\tTue, 15 Sep 2020 16:21:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZnVms5a3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600179687;\n\tbh=mENnW9UmAMtZuYE04IPh/wzybnVDFzxLOipDE9iDS6o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZnVms5a3yhzPXdjGBIhijX08tVogNTYsa9KSLeGXmXjv/uHKcpMW1L9liFXb5lZLP\n\thPL6fFBehiMkVSaE+/ciuwr9cqCCow/JQgS4c/m9B81BNxFvGuhaFFUlfXOxDVxiLO\n\tdH4S92wPf1hdp4nOEf7ALrcr7Veo9Tg1g9muSGVA=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 15 Sep 2020 23:20:30 +0900","Message-Id":"<20200915142038.28757-16-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200915142038.28757-1-paul.elder@ideasonboard.com>","References":"<20200915142038.28757-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 15/23] libcamera: IPAManager: Fetch\n\tIPAProxy corresponding to pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that each pipeline handler has its own IPAProxy implementation, make\nthe IPAManager fetch the IPAProxy based on the pipeline handler name.\nAlso, since the IPAProxy is used regardless of isolation or no\nisolation, remove the isolation check from the proxy selection.\n\nSigned-off-by: Paul Elder \n---\n src/libcamera/ipa_manager.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex 046fd5c6..2d0ea242 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -275,8 +275,8 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n \t *\n \t * \\todo Implement a better proxy selection\n \t */\n-\tconst char *proxyName = self_->isSignatureValid(m)\n-\t\t\t ? \"IPAProxyThread\" : \"IPAProxyLinux\";\n+\tstd::string pipeName(pipe->name());\n+\tconst char *proxyName = pipeName.replace(0, 15, \"IPAProxy\").c_str();\n \tIPAProxyFactory *pf = nullptr;\n \n \tfor (IPAProxyFactory *factory : IPAProxyFactory::factories()) {\n","prefixes":["libcamera-devel","15/23"]}