[{"id":12583,"web_url":"https://patchwork.libcamera.org/comment/12583/","msgid":"<20200919114135.GP1850958@oden.dyn.berto.se>","date":"2020-09-19T11:41:35","subject":"Re: [libcamera-devel] [PATCH 12/23] libcamera: PipelineHandler:\n\tRemove IPA from base class","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your patch.\n\nOn 2020-09-15 23:20:27 +0900, Paul Elder wrote:\n> Since pipline handlers now have their own IPA interface types, it can no\n> longer be defined in the base class, and each pipline handler\n> implementation must declare it and its type themselves. Remove it from\n> the base class.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/pipeline_handler.h | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index a4e1b529..2018bef0 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -47,7 +47,6 @@ public:\n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> \tControlList properties_;\n> -\tstd::unique_ptr ipa_;\n> \n> private:\n> \tCameraData(const CameraData &) = delete;\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC82FBF01C\n\tfor ;\n\tSat, 19 Sep 2020 11:41:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9A0B62FAD;\n\tSat, 19 Sep 2020 13:41:38 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E188B60367\n\tfor ;\n\tSat, 19 Sep 2020 13:41:36 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id w3so7190677ljo.5\n\tfor ;\n\tSat, 19 Sep 2020 04:41:36 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tj7sm1252269lfb.41.2020.09.19.04.41.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 19 Sep 2020 04:41:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"l/cjayWQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=S40LjxtOki5gccWbTkUiFEhd3TxCtlDSWHuqz7o8VLA=;\n\tb=l/cjayWQ7Nu0nzMWLAOA6w2Umlx+so2c3bfW8BxfRxOEDq+EQ1haKGsnujo8KS1mID\n\tKzk8ZtzwHJnwJadLXiwEFeMBIwJ9Uxsr8lrGqrc0/KFpbtNrq2/Ve5GinP+5fBjWDN5L\n\t1R7s3xGhfB0c6uEegFNGHO2vy1ZCd8Q2ceUXsiLngEXLQiee3p4r0J/pqde8HOChh9/Z\n\tlEnxZ8epSQ9DtDSqC/ejxL8khQx4Onzzf5df9+ATjPDlOT8hqFxISHCVjDDl6HOPPm/4\n\tCndbTcKDkRfSfQs4l5Z92ztXwSpULJV4qBqJ8891j9BXc02qki/OOEcC1FURnT0mZcQs\n\tDZVA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=S40LjxtOki5gccWbTkUiFEhd3TxCtlDSWHuqz7o8VLA=;\n\tb=M0a969jshq5bw3wBZaue0l2wnmRyH4FvGtbL0i9ZWd0X9SUGtXVR/wZOmw6vHqmh8e\n\tFSehB9E8DIEpexlErBno6Y3vIbsNhDIY7ZPcMorZnPCrK67h5xSztA0tS08/Acz+hqh9\n\tYSPRLcqD6ZX4aeZi38N0jbZKP8j3cvCTqC7HcN2/AJ2H8gE6OO8Pv49HFTDBU5lx9zrf\n\tWpEyHBF8c2RxdDAQz41/IX1hwXv6bMsUanEaZn8N57Fg+lEnKDkO7SG3gplU73jZdDse\n\tRWvqkd+nZoBov8L8p+ttfwM82nvu0ImAifb0AvurlV9nEdHY/KCE74h3A1OQkRYdfgmO\n\tHkLg==","X-Gm-Message-State":"AOAM5312zqciaO4bi0BUaroTcPLkUaU62X00Ndl3JcVqKpRbtSvNaRIq\n\tqOHh6w/c6x4gteuom9PPBf95dg==","X-Google-Smtp-Source":"ABdhPJxbIpW5REOmFRJiqS8hlp6gWVA9BuJZHoPtsDbQ494Mg1v7FsYzWmYorF6M8I/UPqRpuTmTcg==","X-Received":"by 2002:a05:651c:1053:: with SMTP id\n\tx19mr6441789ljm.32.1600515696383; \n\tSat, 19 Sep 2020 04:41:36 -0700 (PDT)","Date":"Sat, 19 Sep 2020 13:41:35 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"<20200919114135.GP1850958@oden.dyn.berto.se>","References":"<20200915142038.28757-1-paul.elder@ideasonboard.com>\n\t<20200915142038.28757-13-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200915142038.28757-13-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 12/23] libcamera: PipelineHandler:\n\tRemove IPA from base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]