[{"id":12582,"web_url":"https://patchwork.libcamera.org/comment/12582/","msgid":"<20200919114053.GO1850958@oden.dyn.berto.se>","date":"2020-09-19T11:40:53","subject":"Re: [libcamera-devel] [PATCH 11/23] libcamera: IPAProxy: Add\n\tisolate parameter to create()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your patch.\n\nOn 2020-09-15 23:20:26 +0900, Paul Elder wrote:\n> Since IPAProxy implementations now always encapsulate IPA modules, add a\n> parameter to create() to signal if the proxy should isolate the IPA or not.\n> \n> Signed-off-by: Paul Elder \n> ---\n> include/libcamera/internal/ipa_proxy.h | 22 +++++++++++-----------\n> 1 file changed, 11 insertions(+), 11 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index aec8f04f..1903150e 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -42,7 +42,7 @@ public:\n> \tIPAProxyFactory(const char *name);\n> \tvirtual ~IPAProxyFactory() {}\n> \n> -\tvirtual std::unique_ptr create(IPAModule *ipam) = 0;\n> +\tvirtual std::unique_ptr create(IPAModule *ipam, bool isolate) = 0;\n\nWith the isolate argument document in ipa_proxy.cpp,\n\nReviewed-by: Niklas Söderlund \n\n> \n> \tconst std::string &name() const { return name_; }\n> \n> @@ -53,16 +53,16 @@ private:\n> \tstd::string name_;\n> };\n> \n> -#define REGISTER_IPA_PROXY(proxy)\t\t\t\\\n> -class proxy##Factory final : public IPAProxyFactory\t\\\n> -{\t\t\t\t\t\t\t\\\n> -public:\t\t\t\t\t\t\t\\\n> -\tproxy##Factory() : IPAProxyFactory(#proxy) {}\t\\\n> -\tstd::unique_ptr create(IPAModule *ipam)\t\\\n> -\t{\t\t\t\t\t\t\\\n> -\t\treturn std::make_unique(ipam);\t\\\n> -\t}\t\t\t\t\t\t\\\n> -};\t\t\t\t\t\t\t\\\n> +#define REGISTER_IPA_PROXY(proxy)\t\t\t\t\t\\\n> +class proxy##Factory final : public IPAProxyFactory\t\t\t\\\n> +{\t\t\t\t\t\t\t\t\t\\\n> +public:\t\t\t\t\t\t\t\t\t\\\n> +\tproxy##Factory() : IPAProxyFactory(#proxy) {}\t\t\t\\\n> +\tstd::unique_ptr create(IPAModule *ipam, bool isolate)\t\\\n> +\t{\t\t\t\t\t\t\t\t\\\n> +\t\treturn std::make_unique(ipam, isolate);\t\t\\\n> +\t}\t\t\t\t\t\t\t\t\\\n> +};\t\t\t\t\t\t\t\t\t\\\n> static proxy##Factory global_##proxy##Factory;\n> \n> } /* namespace libcamera */\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81237BF01C\n\tfor ;\n\tSat, 19 Sep 2020 11:40:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CC1762FAD;\n\tSat, 19 Sep 2020 13:40:56 +0200 (CEST)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 116C960367\n\tfor ;\n\tSat, 19 Sep 2020 13:40:55 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id b12so8923088lfp.9\n\tfor ;\n\tSat, 19 Sep 2020 04:40:55 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tk205sm1240910lfk.19.2020.09.19.04.40.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 19 Sep 2020 04:40:53 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"NfdgN0KX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=mSnMlvLBcOCRZY+rMhfxMebEFlBPEfqCcE4bBqWb4mk=;\n\tb=NfdgN0KXcyD0ORvfCudupvHcOjAjRo9ojuVngxeRo2G8CjQbJ6f0fRqMmnCQwcTPJA\n\tIVze4S2Qjo0u6pVFjAA+SqZy2Gywx4+Mm305AL6afsYPgk+f2F6o1YVxUmJS1ywIyVsl\n\tqp8W6xhkbbS5jTcsTY5MtpWK5Q9NLz99Yy6pD7vAwUjXrFnEEis4Oa+z1jHykddvsCSE\n\t005+Cg+Ii0XpWDQZRK161VRWy6vGyIzuCrRDMqXAU9EMZuDJsTq1hh4KttwFQC6tWYTr\n\teGEFspe9A0ZZZUyyFlHKKsKCbppCxiO7SoLsuwx3mxA4NvXB2u/UpcmkOkELtUesqrKp\n\tCW4w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=mSnMlvLBcOCRZY+rMhfxMebEFlBPEfqCcE4bBqWb4mk=;\n\tb=X5x/zQVb2RUpmdnSihSZ/ZMUBIDgRf/rsRIm5HwOaJ6ioDcvvMtmQgeysmieZ0P2Fa\n\tsPIw1juLIUV+CSFPRqXY0dGoAbDHCT3rawRzXtyRntcDWGMlaY39s2+2vRJKC+C78ESQ\n\tHCTPykTB1OrOIC8KxzIuTb17l77WfklqUYvz7jP4hb4fT1bIESgOM7NM2RfRmn9bXEdm\n\t/8KNA3kAziudGmw9f+GK9ygAkyuPs+0KhuMgc5Cagg6l2WPWF48VUiYnJF4DfixpmCFE\n\tk4xF49KsyVA/aeBriY875nImYXWbi9FfP4BQuUv2QGMuZOWmacWG/RD16vdAubzW0CjO\n\tbvCQ==","X-Gm-Message-State":"AOAM532FLlTrYiPHJXdxIv7IjPL5cH3avUq444PSRjpDG3if67SxlB6v\n\tF8dqdCNrKPV5sfs1HrWkYuPAsA==","X-Google-Smtp-Source":"ABdhPJyrlqktxIXYMjzkLr73yoD+QfmgT2z8GnJGTwWsiVGY5RiDjjY7gyxkVQtiTP9lzvASa8ZHkA==","X-Received":"by 2002:a19:8242:: with SMTP id\n\te63mr11129025lfd.226.1600515654339; \n\tSat, 19 Sep 2020 04:40:54 -0700 (PDT)","Date":"Sat, 19 Sep 2020 13:40:53 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"<20200919114053.GO1850958@oden.dyn.berto.se>","References":"<20200915142038.28757-1-paul.elder@ideasonboard.com>\n\t<20200915142038.28757-12-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200915142038.28757-12-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 11/23] libcamera: IPAProxy: Add\n\tisolate parameter to create()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]