[{"id":12581,"web_url":"https://patchwork.libcamera.org/comment/12581/","msgid":"<20200919113914.GN1850958@oden.dyn.berto.se>","date":"2020-09-19T11:39:14","subject":"Re: [libcamera-devel] [PATCH 10/23] libcamera: IPAProxy: Remove\n\tstop() override","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your patch.\n\nOn 2020-09-15 23:20:25 +0900, Paul Elder wrote:\n> Since stop() is part of the IPA interface, and the IPA interface is now\n> generated based on the data definition file per pipeline, this no longer\n> needs to be overrided by the base IPAProxy. Remove it.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/ipa_proxy.h | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index b429ce5a..aec8f04f 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -27,8 +27,6 @@ public:\n> \n> \tstd::string configurationFile(const std::string &file) const;\n> \n> -\tvoid stop() override = 0;\n> -\n> protected:\n> \tstd::string resolvePath(const std::string &file) const;\n> \n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CEF9C3B5B\n\tfor ;\n\tSat, 19 Sep 2020 11:39:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFC2162FBC;\n\tSat, 19 Sep 2020 13:39:16 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C98460367\n\tfor ;\n\tSat, 19 Sep 2020 13:39:16 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id u21so7169547ljl.6\n\tfor ;\n\tSat, 19 Sep 2020 04:39:16 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\th20sm1230068ljg.51.2020.09.19.04.39.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 19 Sep 2020 04:39:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"a8mi/3vi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=kceqUuzqDFDqA6OjRMq7gKSBsRytsKv76tUN9xQ72xU=;\n\tb=a8mi/3viIGma7IHZjMnfKaz2124ZtugvSb0xowLtYwtLLxTXSoUP9kimAQiHGgY91h\n\tVX3W/MVjT4VTfiAbBACBbKe9pl6ZPgt0L5N0C4QjZhlo68S/uUfOqnARV4WXR+BouMq1\n\tK27b5ouWRwfiZc2Ep2wXeOFv1c1QyRDIptNilTOtb2DMY9Uf/rQPA+fMZrkmUoHdgZ2B\n\tSkGxy2CT6RH0FdAWUNCSHMgqNn0TbOS4y1tQLTXNbEhqLlbLkZs6gMc9Q/vw0Ipyixw9\n\tZDQNnxcL320ndQtPRc7taC2ba1FvhdxmF9BOHOqvQYdiK7nc/lxfIBLUpAaYV0+HkXBM\n\tLj2Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=kceqUuzqDFDqA6OjRMq7gKSBsRytsKv76tUN9xQ72xU=;\n\tb=lBMZGUBKRX0uglxP9JjahANAnhR0O48H8C6AN/YeDi2Agvoj2YfZJW3zaKfp0VgXkc\n\tk2Jvn7Nc3H7icPxpEcAMq/G7/Q23fHKBZr04M80OXTAEw1WLa86g7oyFuDDNRvLQhdt/\n\tfzEtPKd+LzfJ9PqwJ45DJuqFNS8xdNWm8EPtBCofq1gBAIymFTPnzS/M62P/O+ecIjsK\n\tuntyLgRs5CTsHGo/x8MAKSnkXMjMVfM2L/qbEbjrZJHqPceSXA5FXApsV3AahzIvRGZr\n\tvrkA2HtlgRR6od6J8uF5hV30ksVvQxpFu0MqoGvYbIuqGdJGKHTWGXbbov3wbynlz68x\n\tOPTg==","X-Gm-Message-State":"AOAM531oaIyoa7oKyvqAlxA9EOULtwKr8qW1THkdR0VKOF8qWDrNgGkp\n\tmTSjLn76VPq3exOGdUGmPT0hhVP3gpTasg==","X-Google-Smtp-Source":"ABdhPJyT70zP0xvnn5/w/rtT1rAldKs+2ctWxMDUV/RqanYu0BmFazSOomI4GxSvOxaggGMQQ8ONng==","X-Received":"by 2002:a2e:86d3:: with SMTP id\n\tn19mr14102792ljj.368.1600515555559; \n\tSat, 19 Sep 2020 04:39:15 -0700 (PDT)","Date":"Sat, 19 Sep 2020 13:39:14 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"<20200919113914.GN1850958@oden.dyn.berto.se>","References":"<20200915142038.28757-1-paul.elder@ideasonboard.com>\n\t<20200915142038.28757-11-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200915142038.28757-11-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 10/23] libcamera: IPAProxy: Remove\n\tstop() override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]