[{"id":1334,"web_url":"https://patchwork.libcamera.org/comment/1334/","msgid":"<20190414200641.GL1980@bigcity.dyn.berto.se>","date":"2019-04-14T20:06:41","subject":"Re: [libcamera-devel] [PATCH v4 07/12] libcamera: request: Add\n\tempty() method","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-04-09 21:25:43 +0200, Jacopo Mondi wrote:\n> Add method to verify if a request has pending buffers yet to be\n> completed or it is empty and ready from completion.\n> \n> Signed-off-by: Jacopo Mondi \n\nIf it make sens I think this could be merged/handled outside of this \nseries.\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/request.h | 2 ++\n> src/libcamera/request.cpp | 11 +++++++++--\n> 2 files changed, 11 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 2004312a2233..37f9a3b27482 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -37,6 +37,8 @@ public:\n> \n> \tStatus status() const { return status_; }\n> \n> +\tbool empty() const { return pending_.empty(); }\n> +\n> \tconst std::map &bufferMap() const { return bufferMap_; }\n> \n> private:\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 46f9add98fde..3e10c995a6fa 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -106,6 +106,13 @@ Buffer *Request::findBuffer(Stream *stream) const\n> * \\return The request completion status\n> */\n> \n> +/**\n> + * \\fn Request::empty()\n> + * \\brief Retrieve if a request has buffers yet to be completed\n> + *\n> + * \\return True if no buffer is pending for completion, false otherwise\n> + */\n> +\n> /**\n> * \\fn Request::bufferMap()\n> * \\brief Retrieve the request' stream to buffer map\n> @@ -137,7 +144,7 @@ int Request::prepare()\n> */\n> void Request::complete(Status status)\n> {\n> -\tASSERT(pending_.empty());\n> +\tASSERT(empty());\n> \tstatus_ = status;\n> }\n> \n> @@ -159,7 +166,7 @@ bool Request::completeBuffer(Buffer *buffer)\n> \tint ret = pending_.erase(buffer);\n> \tASSERT(ret == 1);\n> \n> -\treturn pending_.empty();\n> +\treturn empty();\n> }\n> \n> } /* namespace libcamera */\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x132.google.com (mail-lf1-x132.google.com\n\t[IPv6:2a00:1450:4864:20::132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6959B60DBE\n\tfor ;\n\tSun, 14 Apr 2019 22:06:43 +0200 (CEST)","by mail-lf1-x132.google.com with SMTP id h18so11356824lfj.11\n\tfor ;\n\tSun, 14 Apr 2019 13:06:43 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tk10sm9721350ljh.86.2019.04.14.13.06.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 14 Apr 2019 13:06:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=p3qAlCXtwRqSEmgUXGBYZDI/l9odjfI3YG0vSP+uP5k=;\n\tb=wb/0Jr5YfPeT7hk8TzKfqw/kFDb/TZiPZa5+65pOJaSpDJk4rcHw4bTv4sIvCbCjqL\n\tWdGzHWMNhh0K6hsmXQ5+5EHbSst9fcbgCxuYbXf3dkMCgbZLXNPD/eJubFdocmkcgK6N\n\t5SjfZQmKcqcPClHsNVNLDbJv4nK0HZUte/x3m6kB6BtfKGr502rVQqSTXW6HubW1SuiB\n\tWJkZGmct8jL1cTCp99+gVwIStqEIV0dFtLRhZoI27bqaTR9Qa+1aD44LMIuHfaQLvpZ5\n\t7EPmFxpy/DJZwf26eFnshMhhj+AXOXPipRkYj0+AgRwiveCmuS4C0u1j65gYd8vX9z6z\n\tfDTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=p3qAlCXtwRqSEmgUXGBYZDI/l9odjfI3YG0vSP+uP5k=;\n\tb=uVcpXatGSbn0qKj5vHnI8lUUGq4BfqscLq7GIt6MGx1C8/fRp55MVVc6lZNUXtlV1n\n\tGYG2zX0LkS3foWCAQ2+JscTct/qXqr096+JEtVTgdNczJEusexmJ2xqaa/qbIM2Tep4g\n\tFH+Yik1w6bhOKaGjVAhDQW16x/vRa4082hbHASp/KaiyM2YO2EHzCtwWAzoWSlUWbAbr\n\tDrygt0/tfjBlyBGAswhwBaA13Ys7ji3ip8N+wI8R47NaAOdrh/R1UZOX0rIiLXjsVvJN\n\tDYhlLeyp7CdEB2g4BLfmUTPbtz6JBX0KMPLKg2iZY49Nsu6Vmrrui15u5e/EKuICX2MT\n\tPdow==","X-Gm-Message-State":"APjAAAVXSg1RBO+vMmpFEHZO60FQrlOPccMg1Sf1YO8mUcg/fxW7z52n\n\tPAjVAC469ZH/PBOuUncU1ZlJc7eVtC0=","X-Google-Smtp-Source":"APXvYqzMAquVqzg4uuy55+qHdi1wjRDEVnmiIFjs0hQrlMd4PaBHudgqT5rBEa3y5RM7IkkV9Rt2lg==","X-Received":"by 2002:a19:ae0a:: with SMTP id\n\tf10mr35893338lfc.118.1555272402828; \n\tSun, 14 Apr 2019 13:06:42 -0700 (PDT)","Date":"Sun, 14 Apr 2019 22:06:41 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190414200641.GL1980@bigcity.dyn.berto.se>","References":"<20190409192548.20325-1-jacopo@jmondi.org>\n\t<20190409192548.20325-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190409192548.20325-8-jacopo@jmondi.org>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v4 07/12] libcamera: request: Add\n\tempty() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 14 Apr 2019 20:06:43 -0000"}},{"id":1350,"web_url":"https://patchwork.libcamera.org/comment/1350/","msgid":"<20190415132308.GH4809@pendragon.ideasonboard.com>","date":"2019-04-15T13:23:08","subject":"Re: [libcamera-devel] [PATCH v4 07/12] libcamera: request: Add\n\tempty() method","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Apr 09, 2019 at 09:25:43PM +0200, Jacopo Mondi wrote:\n> Add method to verify if a request has pending buffers yet to be\n> completed or it is empty and ready from completion.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/request.h | 2 ++\n> src/libcamera/request.cpp | 11 +++++++++--\n> 2 files changed, 11 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 2004312a2233..37f9a3b27482 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -37,6 +37,8 @@ public:\n> \n> \tStatus status() const { return status_; }\n> \n> +\tbool empty() const { return pending_.empty(); }\n> +\n> \tconst std::map &bufferMap() const { return bufferMap_; }\n> \n> private:\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 46f9add98fde..3e10c995a6fa 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -106,6 +106,13 @@ Buffer *Request::findBuffer(Stream *stream) const\n> * \\return The request completion status\n> */\n> \n> +/**\n> + * \\fn Request::empty()\n> + * \\brief Retrieve if a request has buffers yet to be completed\n> + *\n> + * \\return True if no buffer is pending for completion, false otherwise\n> + */\n\nI wouldn't call this empty(), as it doesn't check if the request is\nempty.\n\nWould it make sense to add a new state, between RequestPending and\nRequestComplete, to indicate this ? RequestBuffersReady ? Or you can\nalso keep this method but rename it.\n\n> +\n> /**\n> * \\fn Request::bufferMap()\n> * \\brief Retrieve the request' stream to buffer map\n> @@ -137,7 +144,7 @@ int Request::prepare()\n> */\n> void Request::complete(Status status)\n> {\n> -\tASSERT(pending_.empty());\n> +\tASSERT(empty());\n> \tstatus_ = status;\n> }\n> \n> @@ -159,7 +166,7 @@ bool Request::completeBuffer(Buffer *buffer)\n> \tint ret = pending_.erase(buffer);\n> \tASSERT(ret == 1);\n> \n> -\treturn pending_.empty();\n> +\treturn empty();\n> }\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B66E1600F9\n\tfor ;\n\tMon, 15 Apr 2019 15:23:17 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22474333;\n\tMon, 15 Apr 2019 15:23:17 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555334597;\n\tbh=KhTGnmoG68p/zfJ2R8BbCEqGHb0kXgcNJjPNfbumVGw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=K7GK7SztczzvF42ceel7uT/B5Wh/qz9snuqS2c4hmVUukm5XMNizHWjEH0XcHht5j\n\tMD3/YcNqUXzXKGufnSp+WLm8fcL86kk3qfnBlJuajzLmFrdVR05DWGTaJcHNgW7QkY\n\tdy16gaO3JyfKgPRgF1bsdIoLszfbjLSUC52b6bJk=","Date":"Mon, 15 Apr 2019 16:23:08 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190415132308.GH4809@pendragon.ideasonboard.com>","References":"<20190409192548.20325-1-jacopo@jmondi.org>\n\t<20190409192548.20325-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190409192548.20325-8-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 07/12] libcamera: request: Add\n\tempty() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Apr 2019 13:23:17 -0000"}}]