{"id":962,"url":"https://patchwork.libcamera.org/api/patches/962/?format=json","web_url":"https://patchwork.libcamera.org/patch/962/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190409192548.20325-8-jacopo@jmondi.org>","date":"2019-04-09T19:25:43","name":"[libcamera-devel,v4,07/12] libcamera: request: Add empty() method","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"637576d4014e47c77bacd0b58a171ab3ef7de767","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/962/mbox/","series":[{"id":247,"url":"https://patchwork.libcamera.org/api/series/247/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=247","date":"2019-04-09T19:25:36","name":"libcamera: ipu3: Multiple streams support","version":4,"mbox":"https://patchwork.libcamera.org/series/247/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/962/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/962/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B55E460004\n\tfor ;\n\tTue, 9 Apr 2019 21:25:09 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 4CF9B20000B;\n\tTue, 9 Apr 2019 19:25:09 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 9 Apr 2019 21:25:43 +0200","Message-Id":"<20190409192548.20325-8-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190409192548.20325-1-jacopo@jmondi.org>","References":"<20190409192548.20325-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 07/12] libcamera: request: Add empty()\n\tmethod","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 09 Apr 2019 19:25:11 -0000"},"content":"Add method to verify if a request has pending buffers yet to be\ncompleted or it is empty and ready from completion.\n\nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/request.h | 2 ++\n src/libcamera/request.cpp | 11 +++++++++--\n 2 files changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 2004312a2233..37f9a3b27482 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -37,6 +37,8 @@ public:\n \n \tStatus status() const { return status_; }\n \n+\tbool empty() const { return pending_.empty(); }\n+\n \tconst std::map &bufferMap() const { return bufferMap_; }\n \n private:\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 46f9add98fde..3e10c995a6fa 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -106,6 +106,13 @@ Buffer *Request::findBuffer(Stream *stream) const\n * \\return The request completion status\n */\n \n+/**\n+ * \\fn Request::empty()\n+ * \\brief Retrieve if a request has buffers yet to be completed\n+ *\n+ * \\return True if no buffer is pending for completion, false otherwise\n+ */\n+\n /**\n * \\fn Request::bufferMap()\n * \\brief Retrieve the request' stream to buffer map\n@@ -137,7 +144,7 @@ int Request::prepare()\n */\n void Request::complete(Status status)\n {\n-\tASSERT(pending_.empty());\n+\tASSERT(empty());\n \tstatus_ = status;\n }\n \n@@ -159,7 +166,7 @@ bool Request::completeBuffer(Buffer *buffer)\n \tint ret = pending_.erase(buffer);\n \tASSERT(ret == 1);\n \n-\treturn pending_.empty();\n+\treturn empty();\n }\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v4","07/12"]}