[{"id":1332,"web_url":"https://patchwork.libcamera.org/comment/1332/","msgid":"<20190414195755.GJ1980@bigcity.dyn.berto.se>","date":"2019-04-14T19:57:55","subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-04-09 21:25:41 +0200, Jacopo Mondi wrote:\n> Add to the Request class a method to access the map to Stream to Buffer.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/request.h | 2 ++\n> src/libcamera/request.cpp | 10 ++++++++++\n> 2 files changed, 12 insertions(+)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 0dbd425115e8..2004312a2233 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -37,6 +37,8 @@ public:\n> \n> \tStatus status() const { return status_; }\n> \n> +\tconst std::map &bufferMap() const { return bufferMap_; }\n> +\n> private:\n> \tfriend class Camera;\n> \tfriend class PipelineHandler;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index e0e77e972411..46f9add98fde 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -106,6 +106,16 @@ Buffer *Request::findBuffer(Stream *stream) const\n> * \\return The request completion status\n> */\n> \n> +/**\n> + * \\fn Request::bufferMap()\n> + * \\brief Retrieve the request' stream to buffer map\n> + *\n> + * Return a reference to the map that associates each Stream part of the\n> + * request to the Buffer the Stream output should be directed to.\n> + *\n> + * \\return The map of Stream to Buffers\n> + */\n> +\n> /**\n> * \\brief Prepare the resources for the completion handler\n> */\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 349DD60DBE\n\tfor ;\n\tSun, 14 Apr 2019 21:57:57 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id y6so13586356ljd.12\n\tfor ;\n\tSun, 14 Apr 2019 12:57:57 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\td192sm243743lfg.79.2019.04.14.12.57.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 14 Apr 2019 12:57:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=kT16Rv2ia6Hfe4C5edBZatm2vF6i/whXtwdOA0UZYyI=;\n\tb=aqVzx5EyEI4NjimlQxLGweoTo2egMpvHuUdFYLGQzxDrEFK+5D2L9qq/nDZzPYWzY6\n\tkd5ATWba1zvqVILO53kOb56iEzZ1V+Ml+0Z9dJ0xyd1QMhg/mCaIofXe+m2Ty7vvUn9T\n\tlsIdWERixQvRBNMLiXYOfGvfSLcuwG+5tT1pRvS5p89hJRyvx/K8KRTH+M6MkVNRg5pE\n\t/Vh5h1OmWLGrPRAxcURJ1fcLnvd0w9BT6K+4il4QRayDf877SxeJsHj+r4FkOXxlWumb\n\tqry9/NRtm/MA9dD7Nfna/N8HXzJxcaI79rhUIdCekOAo1zBS20yQcNNf33lUTBh8IY1w\n\taKVg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=kT16Rv2ia6Hfe4C5edBZatm2vF6i/whXtwdOA0UZYyI=;\n\tb=B1rDcpSSME53fkp2mZMJyv3iH8qbJa+9SyzeV61cK4KpVyYLogUDVt9wT2ZzJ3KhHm\n\tKczD3cKkaqsk6S5MMIBd2nSMeIx8JjakbEeG48ayURy9qBp72XMhrr20QagoxywsXQdd\n\tvwV8+PZnSuJ0FA/O8nQJIkDXSygZdX+T8hHg1caJtBk2hUJ8E8toPMIypa128TxneXID\n\tMbdQfN5hVp04uNY4OgdM4ofHsXp5TcGEOg0Zw5Ny5+0z89j9dPyYDdthkUfc2/vqBYXE\n\taoOQsEE54u883U2QjCC7D6vNLH14AC/DfepNxIlEmJ7Lxod2KB6R4CdEzewfX+CZTQru\n\t353g==","X-Gm-Message-State":"APjAAAVym1yKkdxvVCk5Je+f9BnJ9+PRt+GoHiNaiw9d0oNgyt5sGnuE\n\tCFpm4B55PpD18VdbDHRrufuN3Q==","X-Google-Smtp-Source":"APXvYqxWAaRbSsBzQdf7fS12re5R1kuAceJJ36GLsRgxBnMsO6AuS1bLv4O387MqPNPziAPIrPE3ow==","X-Received":"by 2002:a2e:8ece:: with SMTP id\n\te14mr20795109ljl.66.1555271876415; \n\tSun, 14 Apr 2019 12:57:56 -0700 (PDT)","Date":"Sun, 14 Apr 2019 21:57:55 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190414195755.GJ1980@bigcity.dyn.berto.se>","References":"<20190409192548.20325-1-jacopo@jmondi.org>\n\t<20190409192548.20325-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190409192548.20325-6-jacopo@jmondi.org>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 14 Apr 2019 19:57:57 -0000"}},{"id":1348,"web_url":"https://patchwork.libcamera.org/comment/1348/","msgid":"<20190415130643.GF4809@pendragon.ideasonboard.com>","date":"2019-04-15T13:06:43","subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Apr 09, 2019 at 09:25:41PM +0200, Jacopo Mondi wrote:\n> Add to the Request class a method to access the map to Stream to Buffer.\n\ns/to Stream/of Stream/\n\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/request.h | 2 ++\n> src/libcamera/request.cpp | 10 ++++++++++\n> 2 files changed, 12 insertions(+)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 0dbd425115e8..2004312a2233 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -37,6 +37,8 @@ public:\n> \n> \tStatus status() const { return status_; }\n> \n> +\tconst std::map &bufferMap() const { return bufferMap_; }\n> +\n> private:\n> \tfriend class Camera;\n> \tfriend class PipelineHandler;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index e0e77e972411..46f9add98fde 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -106,6 +106,16 @@ Buffer *Request::findBuffer(Stream *stream) const\n> * \\return The request completion status\n> */\n> \n> +/**\n> + * \\fn Request::bufferMap()\n> + * \\brief Retrieve the request' stream to buffer map\n\ns/request' stream to buffer/request's streams to buffer/\n\n> + *\n> + * Return a reference to the map that associates each Stream part of the\n> + * request to the Buffer the Stream output should be directed to.\n> + *\n> + * \\return The map of Stream to Buffers\n\nIf you use class names I wouldn't make them plural. \"streams to buffers\"\nor \"Stream to Buffer\".\n\nReviewed-by: Laurent Pinchart \n\n> + */\n> +\n> /**\n> * \\brief Prepare the resources for the completion handler\n> */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDD14600F9\n\tfor ;\n\tMon, 15 Apr 2019 15:06:52 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17F45333;\n\tMon, 15 Apr 2019 15:06:52 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555333612;\n\tbh=EsznOR24dcTGxg7+QA5WfJ2CqW4vn7NZmGAtb1puU1A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LAWgKiqCQOXKymN9A1nMYX8p2MGlmvvrrC0B3/zbVimaO1IEa1v/l807cFkBOybkO\n\tm8tisJ77df+kqvx3U7mwtxsm/Um3ZCe9R+VEoTMlrRjN0JXX92l+9B8wg/0O7/xM7l\n\tUsMEzHlaS4i2JYBULmmvtcRBJhYPn6NwKKGEXL7k=","Date":"Mon, 15 Apr 2019 16:06:43 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190415130643.GF4809@pendragon.ideasonboard.com>","References":"<20190409192548.20325-1-jacopo@jmondi.org>\n\t<20190409192548.20325-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190409192548.20325-6-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Apr 2019 13:06:53 -0000"}},{"id":1351,"web_url":"https://patchwork.libcamera.org/comment/1351/","msgid":"<20190415132550.GI4809@pendragon.ideasonboard.com>","date":"2019-04-15T13:25:50","subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Apr 15, 2019 at 04:06:43PM +0300, Laurent Pinchart wrote:\n> On Tue, Apr 09, 2019 at 09:25:41PM +0200, Jacopo Mondi wrote:\n> > Add to the Request class a method to access the map to Stream to Buffer.\n> \n> s/to Stream/of Stream/\n> \n> > \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/request.h | 2 ++\n> > src/libcamera/request.cpp | 10 ++++++++++\n> > 2 files changed, 12 insertions(+)\n> > \n> > diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> > index 0dbd425115e8..2004312a2233 100644\n> > --- a/include/libcamera/request.h\n> > +++ b/include/libcamera/request.h\n> > @@ -37,6 +37,8 @@ public:\n> > \n> > \tStatus status() const { return status_; }\n> > \n> > +\tconst std::map &bufferMap() const { return bufferMap_; }\n\nI forgot to mention that I would move this above the setBuffers()\nmethod, and maybe rename it to buffers() to match setBuffers(). How\nabout also removing the findBuffer() method ?\n\n> > +\n> > private:\n> > \tfriend class Camera;\n> > \tfriend class PipelineHandler;\n> > diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> > index e0e77e972411..46f9add98fde 100644\n> > --- a/src/libcamera/request.cpp\n> > +++ b/src/libcamera/request.cpp\n> > @@ -106,6 +106,16 @@ Buffer *Request::findBuffer(Stream *stream) const\n> > * \\return The request completion status\n> > */\n> > \n> > +/**\n> > + * \\fn Request::bufferMap()\n> > + * \\brief Retrieve the request' stream to buffer map\n> \n> s/request' stream to buffer/request's streams to buffer/\n> \n> > + *\n> > + * Return a reference to the map that associates each Stream part of the\n> > + * request to the Buffer the Stream output should be directed to.\n> > + *\n> > + * \\return The map of Stream to Buffers\n> \n> If you use class names I wouldn't make them plural. \"streams to buffers\"\n> or \"Stream to Buffer\".\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > + */\n> > +\n> > /**\n> > * \\brief Prepare the resources for the completion handler\n> > */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8600D600F9\n\tfor ;\n\tMon, 15 Apr 2019 15:25:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F03CD333;\n\tMon, 15 Apr 2019 15:25:58 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555334759;\n\tbh=ci5PKZ6M3jXdWmirX4f2fNYYU4uaszK+9l+bpbjp7OQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H7/VS8NRt8VZIBvGhCfuP93Xmzuof30DS8S0f9PT2Kl8yXsf4Qx6ocTvlde0Colaz\n\twJvNsaMtt7oWEyMFz20e8CcqW4tlQIVtVslmFQPgIf6n1r579zMj6gC8glTVklKkAf\n\tDs/o9XZ6/oWnNcI96Jm2zz6vIUvC4/HAkyKw6K6s=","Date":"Mon, 15 Apr 2019 16:25:50 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190415132550.GI4809@pendragon.ideasonboard.com>","References":"<20190409192548.20325-1-jacopo@jmondi.org>\n\t<20190409192548.20325-6-jacopo@jmondi.org>\n\t<20190415130643.GF4809@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190415130643.GF4809@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Apr 2019 13:25:59 -0000"}},{"id":1356,"web_url":"https://patchwork.libcamera.org/comment/1356/","msgid":"<20190415150516.cbhi3wqwsj4ge6s3@uno.localdomain>","date":"2019-04-15T15:05:16","subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Apr 15, 2019 at 04:25:50PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Mon, Apr 15, 2019 at 04:06:43PM +0300, Laurent Pinchart wrote:\n> > On Tue, Apr 09, 2019 at 09:25:41PM +0200, Jacopo Mondi wrote:\n> > > Add to the Request class a method to access the map to Stream to Buffer.\n> >\n> > s/to Stream/of Stream/\n> >\n> > >\n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > include/libcamera/request.h | 2 ++\n> > > src/libcamera/request.cpp | 10 ++++++++++\n> > > 2 files changed, 12 insertions(+)\n> > >\n> > > diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> > > index 0dbd425115e8..2004312a2233 100644\n> > > --- a/include/libcamera/request.h\n> > > +++ b/include/libcamera/request.h\n> > > @@ -37,6 +37,8 @@ public:\n> > >\n> > > \tStatus status() const { return status_; }\n> > >\n> > > +\tconst std::map &bufferMap() const { return bufferMap_; }\n>\n> I forgot to mention that I would move this above the setBuffers()\n> method, and maybe rename it to buffers() to match setBuffers(). How\n\nI considered that, but I was thinking that from a 'buffers()' methods\nI would expect a list/vector/container of buffers to be returned, not\na map.... If you all don't think this is confusing I'll change it\n\n> about also removing the findBuffer() method ?\n\nThat would indeed be stale with a 'buffers()' methods, so let's remove\nit before it gets used in other places.\n\nThanks\n j\n\n>\n> > > +\n> > > private:\n> > > \tfriend class Camera;\n> > > \tfriend class PipelineHandler;\n> > > diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> > > index e0e77e972411..46f9add98fde 100644\n> > > --- a/src/libcamera/request.cpp\n> > > +++ b/src/libcamera/request.cpp\n> > > @@ -106,6 +106,16 @@ Buffer *Request::findBuffer(Stream *stream) const\n> > > * \\return The request completion status\n> > > */\n> > >\n> > > +/**\n> > > + * \\fn Request::bufferMap()\n> > > + * \\brief Retrieve the request' stream to buffer map\n> >\n> > s/request' stream to buffer/request's streams to buffer/\n> >\n> > > + *\n> > > + * Return a reference to the map that associates each Stream part of the\n> > > + * request to the Buffer the Stream output should be directed to.\n> > > + *\n> > > + * \\return The map of Stream to Buffers\n> >\n> > If you use class names I wouldn't make them plural. \"streams to buffers\"\n> > or \"Stream to Buffer\".\n> >\n> > Reviewed-by: Laurent Pinchart \n> >\n> > > + */\n> > > +\n> > > /**\n> > > * \\brief Prepare the resources for the completion handler\n> > > */\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5AB8600F9\n\tfor ;\n\tMon, 15 Apr 2019 17:04:25 +0200 (CEST)","from uno.localdomain (unknown [31.159.28.121])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 8669D100010;\n\tMon, 15 Apr 2019 15:04:24 +0000 (UTC)"],"Date":"Mon, 15 Apr 2019 17:05:16 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190415150516.cbhi3wqwsj4ge6s3@uno.localdomain>","References":"<20190409192548.20325-1-jacopo@jmondi.org>\n\t<20190409192548.20325-6-jacopo@jmondi.org>\n\t<20190415130643.GF4809@pendragon.ideasonboard.com>\n\t<20190415132550.GI4809@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ogqpt42akeqd6agb\"","Content-Disposition":"inline","In-Reply-To":"<20190415132550.GI4809@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Apr 2019 15:04:26 -0000"}},{"id":1358,"web_url":"https://patchwork.libcamera.org/comment/1358/","msgid":"<20190415153431.GD17083@pendragon.ideasonboard.com>","date":"2019-04-15T15:34:31","subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Apr 15, 2019 at 05:05:16PM +0200, Jacopo Mondi wrote:\n> On Mon, Apr 15, 2019 at 04:25:50PM +0300, Laurent Pinchart wrote:\n> > On Mon, Apr 15, 2019 at 04:06:43PM +0300, Laurent Pinchart wrote:\n> >> On Tue, Apr 09, 2019 at 09:25:41PM +0200, Jacopo Mondi wrote:\n> >>> Add to the Request class a method to access the map to Stream to Buffer.\n> >>\n> >> s/to Stream/of Stream/\n> >>\n> >>>\n> >>> Signed-off-by: Jacopo Mondi \n> >>> ---\n> >>> include/libcamera/request.h | 2 ++\n> >>> src/libcamera/request.cpp | 10 ++++++++++\n> >>> 2 files changed, 12 insertions(+)\n> >>>\n> >>> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> >>> index 0dbd425115e8..2004312a2233 100644\n> >>> --- a/include/libcamera/request.h\n> >>> +++ b/include/libcamera/request.h\n> >>> @@ -37,6 +37,8 @@ public:\n> >>>\n> >>> \tStatus status() const { return status_; }\n> >>>\n> >>> +\tconst std::map &bufferMap() const { return bufferMap_; }\n> >\n> > I forgot to mention that I would move this above the setBuffers()\n> > method, and maybe rename it to buffers() to match setBuffers(). How\n> \n> I considered that, but I was thinking that from a 'buffers()' methods\n> I would expect a list/vector/container of buffers to be returned, not\n> a map.... If you all don't think this is confusing I'll change it\n\nsetBuffers() takes a map already, so I think it should be OK.\n\n> \n> > about also removing the findBuffer() method ?\n> \n> That would indeed be stale with a 'buffers()' methods, so let's remove\n> it before it gets used in other places.\n\nThank you.\n\n> >>> +\n> >>> private:\n> >>> \tfriend class Camera;\n> >>> \tfriend class PipelineHandler;\n> >>> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> >>> index e0e77e972411..46f9add98fde 100644\n> >>> --- a/src/libcamera/request.cpp\n> >>> +++ b/src/libcamera/request.cpp\n> >>> @@ -106,6 +106,16 @@ Buffer *Request::findBuffer(Stream *stream) const\n> >>> * \\return The request completion status\n> >>> */\n> >>>\n> >>> +/**\n> >>> + * \\fn Request::bufferMap()\n> >>> + * \\brief Retrieve the request' stream to buffer map\n> >>\n> >> s/request' stream to buffer/request's streams to buffer/\n> >>\n> >>> + *\n> >>> + * Return a reference to the map that associates each Stream part of the\n> >>> + * request to the Buffer the Stream output should be directed to.\n> >>> + *\n> >>> + * \\return The map of Stream to Buffers\n> >>\n> >> If you use class names I wouldn't make them plural. \"streams to buffers\"\n> >> or \"Stream to Buffer\".\n> >>\n> >> Reviewed-by: Laurent Pinchart \n> >>\n> >>> + */\n> >>> +\n> >>> /**\n> >>> * \\brief Prepare the resources for the completion handler\n> >>> */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10518600F9\n\tfor ;\n\tMon, 15 Apr 2019 17:34:41 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 904EA333;\n\tMon, 15 Apr 2019 17:34:40 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555342480;\n\tbh=tPyfAwyDlgJJypglUYgKikMzQ8cvPCCZiD/3cun0P80=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LgPlpRkA7ngksO+Ja9fJLmJ4RFwP2busH6v1ZERL9l/HwvMlFjcuCjsQZ7nSgxHxV\n\tpxE/b0N85Gm9d8NIIGO0WYfQCJDoBmdDUaTShNwOQ2PiDxnbRPn+vq0CkJJNSYuxeA\n\te3egdvlntBoBjB000csYh6eO1p9+Kjh/wuT8Si1M=","Date":"Mon, 15 Apr 2019 18:34:31 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190415153431.GD17083@pendragon.ideasonboard.com>","References":"<20190409192548.20325-1-jacopo@jmondi.org>\n\t<20190409192548.20325-6-jacopo@jmondi.org>\n\t<20190415130643.GF4809@pendragon.ideasonboard.com>\n\t<20190415132550.GI4809@pendragon.ideasonboard.com>\n\t<20190415150516.cbhi3wqwsj4ge6s3@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190415150516.cbhi3wqwsj4ge6s3@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 05/12] libcamera: request: Expose\n\tthe Stream to Buffers map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Apr 2019 15:34:41 -0000"}}]