[{"id":12509,"web_url":"https://patchwork.libcamera.org/comment/12509/","msgid":"<20200915004419.GT15543@pendragon.ideasonboard.com>","date":"2020-09-15T00:44:19","subject":"Re: [libcamera-devel] [PATCH v2 07/13] libcamera: pipeline: rkisp1:\n\tSet the crop rectangle","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Sep 14, 2020 at 04:21:43PM +0200, Niklas Söderlund wrote:\n> Changing resolutions back and forth can provoke the crop rectangle to go\n> out of sync, set it as port of format configuration.\n\ns/port/part/\n\n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index a6cb16c0638f8d85..45c5e40186df693d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -634,6 +634,11 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> +\tRectangle rect(0, 0, format.size);\n> +\tret = isp_->setSelection(0, V4L2_SEL_TGT_CROP, &rect);\n> +\tif (ret < 0)\n> +\t\treturn ret;\n> +\n> \tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n> \n> \t/* YUYV8_2X8 is required on the ISP source path pad for YUV output. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01EB8C3B5B\n\tfor ;\n\tTue, 15 Sep 2020 00:44:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C582562DAB;\n\tTue, 15 Sep 2020 02:44:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46A2462901\n\tfor ;\n\tTue, 15 Sep 2020 02:44:47 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D905E275;\n\tTue, 15 Sep 2020 02:44:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"odslutfz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600130687;\n\tbh=uFTflK6ZxpdnezrGziFnYOonOeEPtcrlS12eOQE9Itw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=odslutfzseM5jk/JMtasM9WY9s3xyIthpDQp+sNLhJ8A4am5ZUI5dz2GDd1LmBn5s\n\tBGSpr3/6oT9XT0nxlIooae2beF5FTWkuzn+EehfdlcV5L3iCgowYwSOJQXOsutAm1i\n\tvZsqPWVV6YGq5UhnFGVx4loZQEYDpMcNAw8bccRA=","Date":"Tue, 15 Sep 2020 03:44:19 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200915004419.GT15543@pendragon.ideasonboard.com>","References":"<20200914142149.63857-1-niklas.soderlund@ragnatech.se>\n\t<20200914142149.63857-8-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200914142149.63857-8-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 07/13] libcamera: pipeline: rkisp1:\n\tSet the crop rectangle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]