[{"id":12508,"web_url":"https://patchwork.libcamera.org/comment/12508/","msgid":"<20200915004329.GS15543@pendragon.ideasonboard.com>","date":"2020-09-15T00:43:29","subject":"Re: [libcamera-devel] [PATCH v2 06/13] libcamera: pipeline: rkisp1:\n\tExport stream formats to applications","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Sep 14, 2020 at 04:21:42PM +0200, Niklas Söderlund wrote:\n> The information about stream format is available but not exported to\n> applications, fix this.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> * Changes since v1\n> - Fix s/applicaitons/applications/ in subject\n> - Cap the max resolution reported to the sensor resolution.\n\nI really like how you provide per-patch changelogs, it clearly helps\nduring review. Thank you.\n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +++++++-\n> 1 file changed, 7 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index e3802c76003268f6..a6cb16c0638f8d85 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -587,7 +587,13 @@ CameraConfiguration *PipelineHandlerRkISP1::generateConfiguration(Camera *camera\n> \tif (roles.empty())\n> \t\treturn config;\n> \n> -\tStreamConfiguration cfg{};\n> +\tstd::map> streamFormats;\n> +\tfor (const PixelFormat &format : RKISP1_RSZ_MP_FORMATS)\n> +\t\tstreamFormats[format] =\n> +\t\t\t{ { RKISP1_RSZ_MP_SRC_MIN, data->sensor_->resolution() } };\n\nThis assumes that the sensor resolution is larger than 32x16, but I\nthink that's fine :-)\n\nReviewed-by: Laurent Pinchart \n\n> +\n> +\tStreamFormats formats(streamFormats);\n> +\tStreamConfiguration cfg(formats);\n> \tcfg.pixelFormat = formats::NV12;\n> \tcfg.size = data->sensor_->resolution();\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD1FDBF01C\n\tfor ;\n\tTue, 15 Sep 2020 00:43:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6759762D27;\n\tTue, 15 Sep 2020 02:43:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7D0562901\n\tfor ;\n\tTue, 15 Sep 2020 02:43:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5765D275;\n\tTue, 15 Sep 2020 02:43:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hk+StBTf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600130637;\n\tbh=f6LhJksxG/r862YKgU7oa7b8tgBaJaAVvBRk8I7bWc0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hk+StBTf44ZdeySvuaoTLoVBBUrkFux3SI3QrDUJo+LEsNjq21+RXwOMrgLXyfjgJ\n\tlBoA7+VKoe/IfFUkZwYPJ7MdsCz7j6e+A0V0C6kQtzwzMePuXJTnFtGnzdt6fxRVd3\n\tIk7DoAwyuf2u2MsHcvfdp3GV20ZeB2HvUBbNDrGU=","Date":"Tue, 15 Sep 2020 03:43:29 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200915004329.GS15543@pendragon.ideasonboard.com>","References":"<20200914142149.63857-1-niklas.soderlund@ragnatech.se>\n\t<20200914142149.63857-7-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200914142149.63857-7-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 06/13] libcamera: pipeline: rkisp1:\n\tExport stream formats to applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]