{"id":9598,"url":"https://patchwork.libcamera.org/api/patches/9598/?format=json","web_url":"https://patchwork.libcamera.org/patch/9598/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200914142149.63857-7-niklas.soderlund@ragnatech.se>","date":"2020-09-14T14:21:42","name":"[libcamera-devel,v2,06/13] libcamera: pipeline: rkisp1: Export stream formats to applications","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"78cffab3bda3a815d2e4b4e0e6b8d02030a1ef15","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9598/mbox/","series":[{"id":1289,"url":"https://patchwork.libcamera.org/api/series/1289/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1289","date":"2020-09-14T14:21:36","name":"libcamera: pipeline: rkisp1: Extend to support two streams","version":2,"mbox":"https://patchwork.libcamera.org/series/1289/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9598/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9598/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8B99C3B5D\n\tfor ;\n\tMon, 14 Sep 2020 14:22:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 884BF62E15;\n\tMon, 14 Sep 2020 16:22:11 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F6A862DF9\n\tfor ;\n\tMon, 14 Sep 2020 16:22:10 +0200 (CEST)","from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid acc0ddfd-f695-11ea-a39b-005056917f90;\n\tMon, 14 Sep 2020 16:22:10 +0200 (CEST)"],"X-Halon-ID":"acc0ddfd-f695-11ea-a39b-005056917f90","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 14 Sep 2020 16:21:42 +0200","Message-Id":"<20200914142149.63857-7-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200914142149.63857-1-niklas.soderlund@ragnatech.se>","References":"<20200914142149.63857-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 06/13] libcamera: pipeline: rkisp1:\n\tExport stream formats to applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The information about stream format is available but not exported to\napplications, fix this.\n\nSigned-off-by: Niklas Söderlund \n---\n* Changes since v1\n- Fix s/applicaitons/applications/ in subject\n- Cap the max resolution reported to the sensor resolution.\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex e3802c76003268f6..a6cb16c0638f8d85 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -587,7 +587,13 @@ CameraConfiguration *PipelineHandlerRkISP1::generateConfiguration(Camera *camera\n \tif (roles.empty())\n \t\treturn config;\n \n-\tStreamConfiguration cfg{};\n+\tstd::map> streamFormats;\n+\tfor (const PixelFormat &format : RKISP1_RSZ_MP_FORMATS)\n+\t\tstreamFormats[format] =\n+\t\t\t{ { RKISP1_RSZ_MP_SRC_MIN, data->sensor_->resolution() } };\n+\n+\tStreamFormats formats(streamFormats);\n+\tStreamConfiguration cfg(formats);\n \tcfg.pixelFormat = formats::NV12;\n \tcfg.size = data->sensor_->resolution();\n \n","prefixes":["libcamera-devel","v2","06/13"]}