[{"id":12505,"web_url":"https://patchwork.libcamera.org/comment/12505/","msgid":"<20200915002710.GP15543@pendragon.ideasonboard.com>","date":"2020-09-15T00:27:10","subject":"Re: [libcamera-devel] [PATCH v2 01/13] libcamera: pipeline: rkisp1:\n\tSet number of planes based on format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Sep 14, 2020 at 04:21:37PM +0200, Niklas Söderlund wrote:\n> The RkISP1 pipeline originally only supported NV formats which have 2\n> planes. When support for YUV formats was added the plane count on the\n> output format was not made to reflect this. Instead of hard coding the\n> plane count to 2 fetch the number of planes from the format information.\n> \n> Reported-by: Jacopo Mondi \n> Fixes: 2b1a908b5222e263 (\"libcamera: camera: Add a validation API to the CameraConfiguration class\")\n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index a6fc3b8e36f3b00a..009d190d3ec828f0 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -667,10 +667,11 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \n> \tLOG(RkISP1, Debug) << \"Resizer output pad configured with \" << format.toString();\n> \n> +\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n> \tV4L2DeviceFormat outputFormat = {};\n> \toutputFormat.fourcc = video_->toV4L2PixelFormat(cfg.pixelFormat);\n> \toutputFormat.size = cfg.size;\n> -\toutputFormat.planesCount = 2;\n> +\toutputFormat.planesCount = info.numPlanes();\n> \n> \tret = video_->setFormat(&outputFormat);\n> \tif (ret)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64B01BF01C\n\tfor ;\n\tTue, 15 Sep 2020 00:27:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D902362DAB;\n\tTue, 15 Sep 2020 02:27:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E97FE62901\n\tfor ;\n\tTue, 15 Sep 2020 02:27:39 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D378E275;\n\tTue, 15 Sep 2020 02:27:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iFCMH0WU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600129658;\n\tbh=K5kEbsmU1sOfp7EVTMy/youZC+eqbTHayOPZkfr5I8k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iFCMH0WU9hZv92uZm7hGQLSNQRYSwJ5ucHp2gsmsnsv66/uGupin0PcozWD5YMo9o\n\t10+e8a5vLzoB+IRezwn+p260O6eYRlQJyTDsVBUyWRqZwZ+6TZEUse2ekooK4dmoQl\n\tw991FLcOZLLXp9sNalWp8rlZQu3wt1AXvQjji/sE=","Date":"Tue, 15 Sep 2020 03:27:10 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200915002710.GP15543@pendragon.ideasonboard.com>","References":"<20200914142149.63857-1-niklas.soderlund@ragnatech.se>\n\t<20200914142149.63857-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200914142149.63857-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 01/13] libcamera: pipeline: rkisp1:\n\tSet number of planes based on format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]