{"id":9579,"url":"https://patchwork.libcamera.org/api/patches/9579/?format=json","web_url":"https://patchwork.libcamera.org/patch/9579/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200911162039.61933-7-jacopo@jmondi.org>","date":"2020-09-11T16:20:39","name":"[libcamera-devel,RFC,6/6] libcamera: ipu3: Report pipeline depth","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"b3655ef7fd425bbaaf75052d829012bcdf941ac5","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/9579/mbox/","series":[{"id":1286,"url":"https://patchwork.libcamera.org/api/series/1286/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1286","date":"2020-09-11T16:20:33","name":"libcamera: Define draft controls and properties","version":1,"mbox":"https://patchwork.libcamera.org/series/1286/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9579/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9579/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E283BDB1D\n\tfor ;\n\tFri, 11 Sep 2020 16:17:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AB9B62D86;\n\tFri, 11 Sep 2020 18:17:04 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27E5062DA1\n\tfor ;\n\tFri, 11 Sep 2020 18:17:01 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 38722240006;\n\tFri, 11 Sep 2020 16:17:00 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 11 Sep 2020 18:20:39 +0200","Message-Id":"<20200911162039.61933-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200911162039.61933-1-jacopo@jmondi.org>","References":"<20200911162039.61933-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC 6/6] libcamera: ipu3: Report pipeline depth","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report for each request the pipeline depth describing the number of\nprocessing steps the frames went into.\n\nThis change shows a limitation in the current implementation as the\nnumber of processing steps a frame has been run through is a property\nof each Stream. Currently we report the maximum depth among all the\nreturned frames.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 9ce329a83f5d..26ea26430f8e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -12,6 +12,7 @@\n #include \n \n #include \n+#include \n #include \n #include \n #include \n@@ -41,6 +42,10 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_ALIGN = 4;\n static constexpr unsigned int IMGU_OUTPUT_WIDTH_MARGIN = 64;\n static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n \n+static const ControlInfoMap IPU3Controls = {\n+\t{ &controls::DraftPipelineDepth, ControlInfo(2, 3) }\n+};\n+\n class IPU3CameraData : public CameraData\n {\n public:\n@@ -786,6 +791,8 @@ int PipelineHandlerIPU3::registerCameras()\n \t\tdata->properties_.set(properties::DraftAvailableColorCorrectionAberrationModes,\n \t\t\t\t { static_cast(properties::DRAFT_COLOR_CORRECTION_ABERRATION_OFF) });\n \n+\t\tdata->controlInfo_ = IPU3Controls;\n+\n \t\t/**\n \t\t * \\todo Dynamically assign ImgU and output devices to each\n \t\t * stream and camera; as of now, limit support to two cameras\n@@ -848,6 +855,7 @@ void IPU3CameraData::imguOutputBufferReady(FrameBuffer *buffer)\n \t\treturn;\n \n \t/* Mark the request as complete. */\n+\trequest->controls().set(controls::DraftPipelineDepth, 3);\n \tpipe_->completeRequest(camera_, request);\n }\n \n@@ -873,6 +881,7 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n \tif (request->findBuffer(&rawStream_)) {\n \t\tbool isComplete = pipe_->completeBuffer(camera_, request, buffer);\n \t\tif (isComplete) {\n+\t\t\trequest->controls().set(controls::DraftPipelineDepth, 2);\n \t\t\tpipe_->completeRequest(camera_, request);\n \t\t\treturn;\n \t\t}\n","prefixes":["libcamera-devel","RFC","6/6"]}