[{"id":12480,"web_url":"https://patchwork.libcamera.org/comment/12480/","msgid":"<20200913113950.GH695456@oden.dyn.berto.se>","date":"2020-09-13T11:39:50","subject":"Re: [libcamera-devel] [RFC 5/6] libcamera: ipu3: Initialize draft\n\tproperties","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-09-11 18:20:38 +0200, Jacopo Mondi wrote:\n> Initialize three draft properties for the IPU3 platform.\n> \n> IPU3 reports a maximum of three processing stages: exposure, capture and\n> ISP processing and does not support noise reduction and color\n> aberration.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 2d881fe28f98..9ce329a83f5d 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -13,6 +13,7 @@\n> \n> #include \n> #include \n> +#include \n> #include \n> #include \n> \n> @@ -776,7 +777,14 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t\tcontinue;\n> \n> \t\t/* Initialize the camera properties. */\n> -\t\tdata->properties_ = cio2->sensor()->properties();\n> +\t\tfor (const auto &sensorProperty : cio2->sensor()->properties())\n> +\t\t\tdata->properties_.set(sensorProperty.first,\n> +\t\t\t\t\t sensorProperty.second);\n> +\t\tdata->properties_.set(properties::DraftPipelineMaxDepth, 3);\n> +\t\tdata->properties_.set(properties::DraftAvailableNoiseReductionModes,\n> +\t\t\t\t { static_cast(properties::DRAFT_NOISE_REDUCTION_MODE_OFF) });\n> +\t\tdata->properties_.set(properties::DraftAvailableColorCorrectionAberrationModes,\n> +\t\t\t\t { static_cast(properties::DRAFT_COLOR_CORRECTION_ABERRATION_OFF) });\n> \n> \t\t/**\n> \t\t * \\todo Dynamically assign ImgU and output devices to each\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD9A4C3B5B\n\tfor ;\n\tSun, 13 Sep 2020 11:39:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A866562D27;\n\tSun, 13 Sep 2020 13:39:53 +0200 (CEST)","from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com\n\t[IPv6:2a00:1450:4864:20::22a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A261762D27\n\tfor ;\n\tSun, 13 Sep 2020 13:39:51 +0200 (CEST)","by mail-lj1-x22a.google.com with SMTP id r24so16210143ljm.3\n\tfor ;\n\tSun, 13 Sep 2020 04:39:51 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tf25sm2784664ljn.29.2020.09.13.04.39.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 13 Sep 2020 04:39:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"pwlQp5jM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=H/SncUtAQ38Ui6kkrixIiwfXXc1poLOyVHZnCfMHBJ4=;\n\tb=pwlQp5jMuuPWBw7f8LAiWrVaqA+TEB4+JreovJH83ZyccGibmhIbpj0CbyMRDroCs8\n\tMwfuYAbtnvsvqhFfqDonaVjHo0hByi7EEP19tkPPCfMC7y9TwQyQ+bdUhFXJucAkcSU2\n\tFVXguPXO1+2+0eIzPRiLvnTs2otQsyDzX6dzRcTxTcPgO4bv8FjToWsNZE0wjUCF5L1I\n\tjdXMkl96Uhb99nuCUofOPIMXJ+XKjDdp2Ql4ZcgecBn+iTAbyrCWaxIzalPX1j009T1+\n\tk77duJLotuyTL6jSgpMPf1m+eNmOTeDSJ0iwuo/ngTrgE028WL6STbVxmcZ83C4bi0BB\n\tZu0w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=H/SncUtAQ38Ui6kkrixIiwfXXc1poLOyVHZnCfMHBJ4=;\n\tb=MZOdKcr8nz3FPSRPKvP0xR1oLEccGbjqqZzA+t+6eFZMI2KkEyyRdRaVetJwqUAwmJ\n\tZmpddq6hP0PJrfVAWcKjGAB57ry7KJBs0rdrVK0wZFfqCLTrE9JjpsVz2yxUqFb5h70X\n\tTaXl4pNKRemvDCSDcFU/jCxiFeSa74f/DC/qmT1qyqOprEV/zWapjGQF/lmPSJmskCnU\n\tzYCNr23C4dWwGKKTYXuxJNDxNIFoL0GIG221NZ2rNMeWrPxj4pi/mquaqhQ36aPfUoCl\n\tTKLAyi5tLLxEHJRmaynId4qPbyScdybomWoSOp0w2nvICScNHVXM13CYFMC4C8jiFXvS\n\t7gqQ==","X-Gm-Message-State":"AOAM532434ButVFB57rg3jSFxrQiFr6XTuB1sv3Ja+aMTrjJLXDvK5Pp\n\tmDEwPRHZ+UMEsmmFt6Wj2zel8g==","X-Google-Smtp-Source":"ABdhPJwId2a5Dn2nGuSZ6c72txe2pwYTi5I8ZUbkqyCr/vVZNzPCyoBp7F8qXMAwQkCwmv/CppOgyA==","X-Received":"by 2002:a2e:85a:: with SMTP id g26mr3710541ljd.294.1599997191144;\n\tSun, 13 Sep 2020 04:39:51 -0700 (PDT)","Date":"Sun, 13 Sep 2020 13:39:50 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200913113950.GH695456@oden.dyn.berto.se>","References":"<20200911162039.61933-1-jacopo@jmondi.org>\n\t<20200911162039.61933-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200911162039.61933-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [RFC 5/6] libcamera: ipu3: Initialize draft\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13089,"web_url":"https://patchwork.libcamera.org/comment/13089/","msgid":"<431173b1-ad2c-6588-0800-aa04d747b212@ideasonboard.com>","date":"2020-10-07T18:36:41","subject":"Re: [libcamera-devel] [RFC 5/6] libcamera: ipu3: Initialize draft\n\tproperties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 13/09/2020 12:39, Niklas Söderlund wrote:\n> Hi Jacopo,\n> \n> Thanks for your work.\n> \n> On 2020-09-11 18:20:38 +0200, Jacopo Mondi wrote:\n>> Initialize three draft properties for the IPU3 platform.\n>>\n>> IPU3 reports a maximum of three processing stages: exposure, capture and\n>> ISP processing and does not support noise reduction and color\n>> aberration.\n>>\n>> Signed-off-by: Jacopo Mondi \n> \n> Reviewed-by: Niklas Söderlund \n> \n>> ---\n>> src/libcamera/pipeline/ipu3/ipu3.cpp | 10 +++++++++-\n>> 1 file changed, 9 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> index 2d881fe28f98..9ce329a83f5d 100644\n>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> @@ -13,6 +13,7 @@\n>> \n>> #include \n>> #include \n>> +#include \n>> #include \n>> #include \n>> \n>> @@ -776,7 +777,14 @@ int PipelineHandlerIPU3::registerCameras()\n>> \t\t\tcontinue;\n>> \n>> \t\t/* Initialize the camera properties. */\n>> -\t\tdata->properties_ = cio2->sensor()->properties();\n>> +\t\tfor (const auto &sensorProperty : cio2->sensor()->properties())\n>> +\t\t\tdata->properties_.set(sensorProperty.first,\n>> +\t\t\t\t\t sensorProperty.second);\n\nWhy does this need to change here?\n\nPerhaps that's because of the previous patch... I guess the previous\npatch has set data->properties to be initialised with all properties and\ntheir defaults? (I'm still confused if that's needed.) - so this only\nupdates properties that are in the sensor...\n\n\n\n\n>> +\t\tdata->properties_.set(properties::DraftPipelineMaxDepth, 3);\n>> +\t\tdata->properties_.set(properties::DraftAvailableNoiseReductionModes,\n>> +\t\t\t\t { static_cast(properties::DRAFT_NOISE_REDUCTION_MODE_OFF) });\n\nIs the cast necessary here?\n\n>> +\t\tdata->properties_.set(properties::DraftAvailableColorCorrectionAberrationModes,\n>> +\t\t\t\t { static_cast(properties::DRAFT_COLOR_CORRECTION_ABERRATION_OFF) });\n>> \n>> \t\t/**\n>> \t\t * \\todo Dynamically assign ImgU and output devices to each\n>> -- \n>> 2.28.0\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17B41BEEDF\n\tfor ;\n\tWed, 7 Oct 2020 18:36:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A561D605AF;\n\tWed, 7 Oct 2020 20:36:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C53CE60580\n\tfor ;\n\tWed, 7 Oct 2020 20:36:44 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 002CA9DA;\n\tWed, 7 Oct 2020 20:36:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sqP06BNF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602095804;\n\tbh=4Y5khBlPg+ioYwA6zcqmdW82mS793K/3FQ3X0AOU7hI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=sqP06BNF2rmnOHlmxQbEkYLAwy9VG0l9/bMPwTjdEEJnybf5TsKYrDWafjTz2EwUc\n\ttwCRv2zkZSzhIxJGnDUwsnY20zZCWYulH9thvuSs5yrO6pWm/v8tx8f4+aDYbHHzCY\n\tfZthGSGxKn+rrnDpsweyVzAgBMcSm+9ghGWBk/Uc=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tJacopo Mondi ","References":"<20200911162039.61933-1-jacopo@jmondi.org>\n\t<20200911162039.61933-6-jacopo@jmondi.org>\n\t<20200913113950.GH695456@oden.dyn.berto.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<431173b1-ad2c-6588-0800-aa04d747b212@ideasonboard.com>","Date":"Wed, 7 Oct 2020 19:36:41 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200913113950.GH695456@oden.dyn.berto.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC 5/6] libcamera: ipu3: Initialize draft\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13104,"web_url":"https://patchwork.libcamera.org/comment/13104/","msgid":"<20201008102929.27yvygq2kt2uf7w6@uno.localdomain>","date":"2020-10-08T10:29:29","subject":"Re: [libcamera-devel] [RFC 5/6] libcamera: ipu3: Initialize draft\n\tproperties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Wed, Oct 07, 2020 at 07:36:41PM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 13/09/2020 12:39, Niklas Söderlund wrote:\n> > Hi Jacopo,\n> >\n> > Thanks for your work.\n> >\n> > On 2020-09-11 18:20:38 +0200, Jacopo Mondi wrote:\n> >> Initialize three draft properties for the IPU3 platform.\n> >>\n> >> IPU3 reports a maximum of three processing stages: exposure, capture and\n> >> ISP processing and does not support noise reduction and color\n> >> aberration.\n> >>\n> >> Signed-off-by: Jacopo Mondi \n> >\n> > Reviewed-by: Niklas Söderlund \n> >\n> >> ---\n> >> src/libcamera/pipeline/ipu3/ipu3.cpp | 10 +++++++++-\n> >> 1 file changed, 9 insertions(+), 1 deletion(-)\n> >>\n> >> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> >> index 2d881fe28f98..9ce329a83f5d 100644\n> >> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> >> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> >> @@ -13,6 +13,7 @@\n> >>\n> >> #include \n> >> #include \n> >> +#include \n> >> #include \n> >> #include \n> >>\n> >> @@ -776,7 +777,14 @@ int PipelineHandlerIPU3::registerCameras()\n> >> \t\t\tcontinue;\n> >>\n> >> \t\t/* Initialize the camera properties. */\n> >> -\t\tdata->properties_ = cio2->sensor()->properties();\n> >> +\t\tfor (const auto &sensorProperty : cio2->sensor()->properties())\n> >> +\t\t\tdata->properties_.set(sensorProperty.first,\n> >> +\t\t\t\t\t sensorProperty.second);\n>\n> Why does this need to change here?\n>\n> Perhaps that's because of the previous patch... I guess the previous\n> patch has set data->properties to be initialised with all properties and\n> their defaults? (I'm still confused if that's needed.) - so this only\n> updates properties that are in the sensor...\n\nNo the previous patch initialized properties_ with an idmap, but the\n'content' is empty until you don't add Control and ControlValues to\nthe list by calling ControlList::set().\n\nOn this change: I could have kept the original line, i felt it was\nclearer to add sensor controls one by one to the properties list. I\ncan drop this line and just add the pipeline controls has it's done\nhere below.\n\nThanks\n j\n\n>\n>\n>\n>\n> >> +\t\tdata->properties_.set(properties::DraftPipelineMaxDepth, 3);\n> >> +\t\tdata->properties_.set(properties::DraftAvailableNoiseReductionModes,\n> >> +\t\t\t\t { static_cast(properties::DRAFT_NOISE_REDUCTION_MODE_OFF) });\n>\n> Is the cast necessary here?\n>\n> >> +\t\tdata->properties_.set(properties::DraftAvailableColorCorrectionAberrationModes,\n> >> +\t\t\t\t { static_cast(properties::DRAFT_COLOR_CORRECTION_ABERRATION_OFF) });\n> >>\n> >> \t\t/**\n> >> \t\t * \\todo Dynamically assign ImgU and output devices to each\n> >> --\n> >> 2.28.0\n> >>\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93EF1BEEDF\n\tfor ;\n\tThu, 8 Oct 2020 10:25:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F420605BB;\n\tThu, 8 Oct 2020 12:25:32 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6AEF160391\n\tfor ;\n\tThu, 8 Oct 2020 12:25:30 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 7B505240009;\n\tThu, 8 Oct 2020 10:25:29 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Thu, 8 Oct 2020 12:29:29 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20201008102929.27yvygq2kt2uf7w6@uno.localdomain>","References":"<20200911162039.61933-1-jacopo@jmondi.org>\n\t<20200911162039.61933-6-jacopo@jmondi.org>\n\t<20200913113950.GH695456@oden.dyn.berto.se>\n\t<431173b1-ad2c-6588-0800-aa04d747b212@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<431173b1-ad2c-6588-0800-aa04d747b212@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC 5/6] libcamera: ipu3: Initialize draft\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]