{"id":9578,"url":"https://patchwork.libcamera.org/api/patches/9578/?format=json","web_url":"https://patchwork.libcamera.org/patch/9578/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200911162039.61933-6-jacopo@jmondi.org>","date":"2020-09-11T16:20:38","name":"[libcamera-devel,RFC,5/6] libcamera: ipu3: Initialize draft properties","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"a90e44bbfc20955e897d692c38538446e7309d6f","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/9578/mbox/","series":[{"id":1286,"url":"https://patchwork.libcamera.org/api/series/1286/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1286","date":"2020-09-11T16:20:33","name":"libcamera: Define draft controls and properties","version":1,"mbox":"https://patchwork.libcamera.org/series/1286/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9578/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9578/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41065BDB1D\n\tfor ;\n\tFri, 11 Sep 2020 16:17:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17F5E62DEF;\n\tFri, 11 Sep 2020 18:17:02 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2448A60534\n\tfor ;\n\tFri, 11 Sep 2020 18:17:00 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2FF9524000A;\n\tFri, 11 Sep 2020 16:16:59 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 11 Sep 2020 18:20:38 +0200","Message-Id":"<20200911162039.61933-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200911162039.61933-1-jacopo@jmondi.org>","References":"<20200911162039.61933-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC 5/6] libcamera: ipu3: Initialize draft\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialize three draft properties for the IPU3 platform.\n\nIPU3 reports a maximum of three processing stages: exposure, capture and\nISP processing and does not support noise reduction and color\naberration.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 2d881fe28f98..9ce329a83f5d 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -13,6 +13,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n \n@@ -776,7 +777,14 @@ int PipelineHandlerIPU3::registerCameras()\n \t\t\tcontinue;\n \n \t\t/* Initialize the camera properties. */\n-\t\tdata->properties_ = cio2->sensor()->properties();\n+\t\tfor (const auto &sensorProperty : cio2->sensor()->properties())\n+\t\t\tdata->properties_.set(sensorProperty.first,\n+\t\t\t\t\t sensorProperty.second);\n+\t\tdata->properties_.set(properties::DraftPipelineMaxDepth, 3);\n+\t\tdata->properties_.set(properties::DraftAvailableNoiseReductionModes,\n+\t\t\t\t { static_cast(properties::DRAFT_NOISE_REDUCTION_MODE_OFF) });\n+\t\tdata->properties_.set(properties::DraftAvailableColorCorrectionAberrationModes,\n+\t\t\t\t { static_cast(properties::DRAFT_COLOR_CORRECTION_ABERRATION_OFF) });\n \n \t\t/**\n \t\t * \\todo Dynamically assign ImgU and output devices to each\n","prefixes":["libcamera-devel","RFC","5/6"]}