[{"id":12479,"web_url":"https://patchwork.libcamera.org/comment/12479/","msgid":"<20200913113915.GG695456@oden.dyn.berto.se>","date":"2020-09-13T11:39:15","subject":"Re: [libcamera-devel] [RFC 4/6] libcamera: pipeline_handler:\n\tInitialize properties_","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-09-11 18:20:37 +0200, Jacopo Mondi wrote:\n> Initialize the CameraData::properties_ field with the list of\n> libcamera defined properties.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  include/libcamera/internal/pipeline_handler.h | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index a4e1b529c461..e579da711b33 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -17,6 +17,7 @@\n>  \n>  #include <libcamera/controls.h>\n>  #include <libcamera/object.h>\n> +#include <libcamera/property_ids.h>\n>  #include <libcamera/stream.h>\n>  \n>  #include \"libcamera/internal/ipa_proxy.h\"\n> @@ -37,7 +38,7 @@ class CameraData\n>  {\n>  public:\n>  \texplicit CameraData(PipelineHandler *pipe)\n> -\t\t: pipe_(pipe)\n> +\t\t: pipe_(pipe), properties_(properties::properties)\n>  \t{\n>  \t}\n>  \tvirtual ~CameraData() {}\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96EA9C3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 13 Sep 2020 11:39:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2076462D99;\n\tSun, 13 Sep 2020 13:39:18 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07BBF62901\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 13 Sep 2020 13:39:17 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id x69so10440554lff.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 13 Sep 2020 04:39:16 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tq24sm2800731ljm.60.2020.09.13.04.39.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 13 Sep 2020 04:39:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"0ao4vokO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=6NktKJjTxoyfrc2uUbSa/f/gxw6PPca5AmhrRXI9FWc=;\n\tb=0ao4vokOB/YbEQavQgUQ7q92kiXtvE8S1nO/Bl7QZ4A2Dli2wAMCNsZ7M+8rpPx04i\n\tbMU31a8WWfeLTkMeGQsoj/6igwW7WTjF+vFRI+bCyPvh7HOtOu90OghsLZlsXCCwjFBT\n\tcbzOcnciYYVhiigGp5XlqJG3/OGLBt5gHJzNq1AIZlN2wNgkhgQRFGkDdNW9Nj6lMBQJ\n\trAKvpY9c8Qjw7wplBvkbOi0jXcAJ1fp3WSByL6K6urjUe3edL8Ied6k61TwBIkvIuT/2\n\telarxZGBaiEMO96mAW+6WsIJsXfBjHPBMFVtYtgRB6OJTrvEntyHeBxv+QgPFqtWhePF\n\tVPxw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=6NktKJjTxoyfrc2uUbSa/f/gxw6PPca5AmhrRXI9FWc=;\n\tb=frjOasDxXaUeY2OkOi0MBCzPCX4g+aSmxyniB2YTHoZm0IeY95HpfQk1l+REnNZJ3A\n\tYrH+zr2Z9+4mqHZTr/XCYjhyj3mkgV2XSEH+P5JgwT1gUldPGhWLka5pAUK2f1vMPKxt\n\t7Qft7FycdaZN6exXujjsTQVIsEGiK82IZt2gGA/tCg0QBs6+X75kpf0V9lmQEC8Zz9KL\n\tJWUTUVOmXVDbYFBYgy/txHWSJAgrjTdHfUmea7VbYARVxH4a/KG1IrELRv1SjGST89UM\n\tXKsfFzTOcjHUnKsPMVnEANJX1sDIBlLHfwfu2Eb4aUcCPuv1AmkLpQ6iBOwugUI/3nvy\n\tKqfw==","X-Gm-Message-State":"AOAM5333TxD+fAZCSm+ZSII9ljCs98B/YCAEWgqfXuoZ3ByollsY9gVg\n\t31PtbIB0w0dCRwM26RJF4mlOjQ==","X-Google-Smtp-Source":"ABdhPJwxemE9e7JuVdWpCmZxyas3awY3s/A9WKC4HMjswQ6aNfD1ayEtpqH4SLmln7AHui5+WtiDfw==","X-Received":"by 2002:ac2:434b:: with SMTP id o11mr762877lfl.576.1599997156438;\n\tSun, 13 Sep 2020 04:39:16 -0700 (PDT)","Date":"Sun, 13 Sep 2020 13:39:15 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<20200913113915.GG695456@oden.dyn.berto.se>","References":"<20200911162039.61933-1-jacopo@jmondi.org>\n\t<20200911162039.61933-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200911162039.61933-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [RFC 4/6] libcamera: pipeline_handler:\n\tInitialize properties_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13091,"web_url":"https://patchwork.libcamera.org/comment/13091/","msgid":"<f99871c9-9e0c-5da3-f9ca-b25dd62e78f7@ideasonboard.com>","date":"2020-10-07T19:38:17","subject":"Re: [libcamera-devel] [RFC 4/6] libcamera: pipeline_handler:\n\tInitialize properties_","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 11/09/2020 17:20, Jacopo Mondi wrote:\n> Initialize the CameraData::properties_ field with the list of\n> libcamera defined properties.\n> \n\nMaybe it will be clearer in the following patches, but what is the\npurpose of this?\n\nThis doesn't initialise it with any specific default values - just sets\nthe properties are available. And perhaps not all properties will be\navailable on every pipeline ? Or have I missed something obvious...\n\nThis seems odd to me at the moment ;(\n\n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n>  include/libcamera/internal/pipeline_handler.h | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index a4e1b529c461..e579da711b33 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -17,6 +17,7 @@\n>  \n>  #include <libcamera/controls.h>\n>  #include <libcamera/object.h>\n> +#include <libcamera/property_ids.h>\n>  #include <libcamera/stream.h>\n>  \n>  #include \"libcamera/internal/ipa_proxy.h\"\n> @@ -37,7 +38,7 @@ class CameraData\n>  {\n>  public:\n>  \texplicit CameraData(PipelineHandler *pipe)\n> -\t\t: pipe_(pipe)\n> +\t\t: pipe_(pipe), properties_(properties::properties)\n>  \t{\n>  \t}\n>  \tvirtual ~CameraData() {}\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D172CBEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  7 Oct 2020 19:38:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5ACF0605B2;\n\tWed,  7 Oct 2020 21:38:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95F616039B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  7 Oct 2020 21:38:20 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE0139DA;\n\tWed,  7 Oct 2020 21:38:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iqWH9WD0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602099500;\n\tbh=Wc5MnnZGviyuvqIJtNxl6OuR99lIW4VSqPjYh2lKq6Y=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=iqWH9WD02jcPLNW9jVOXZ6l/swHqsVdFRP7cCJTkx0ASzFJeN2Bo/rxFI+eXARE2E\n\tHTp4y7/CUwaxBKsHqZ639iStYdKQUzjfeNhY++BDCzssf46SczCuhDct2fnkmDOsbq\n\teJuBTwZWyb331EUqxfjykpiB9JWqgLwbv56KCjlM=","To":"Jacopo Mondi <jacopo@jmondi.org>, libcamera-devel@lists.libcamera.org","References":"<20200911162039.61933-1-jacopo@jmondi.org>\n\t<20200911162039.61933-5-jacopo@jmondi.org>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<f99871c9-9e0c-5da3-f9ca-b25dd62e78f7@ideasonboard.com>","Date":"Wed, 7 Oct 2020 20:38:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200911162039.61933-5-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC 4/6] libcamera: pipeline_handler:\n\tInitialize properties_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13103,"web_url":"https://patchwork.libcamera.org/comment/13103/","msgid":"<20201008102458.zp44tgk5a3ot4t7f@uno.localdomain>","date":"2020-10-08T10:24:58","subject":"Re: [libcamera-devel] [RFC 4/6] libcamera: pipeline_handler:\n\tInitialize properties_","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Wed, Oct 07, 2020 at 08:38:17PM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 11/09/2020 17:20, Jacopo Mondi wrote:\n> > Initialize the CameraData::properties_ field with the list of\n> > libcamera defined properties.\n> >\n>\n> Maybe it will be clearer in the following patches, but what is the\n> purpose of this?\n>\n> This doesn't initialise it with any specific default values - just sets\n> the properties are available. And perhaps not all properties will be\n> available on every pipeline ? Or have I missed something obvious...\n>\n> This seems odd to me at the moment ;(\n\nIt is, it has puzzled me for the last hour or so.\n\nMy recollection was that every control list should be initialized with\nan idMap_ to support the id-based interface. The id-based interface is\nused by the CameraSensor to set/get controls on the subdevice and by\nclosed source IPAs that use custom controls.\n\nI'm currently failing to find is where the idmap_ is used in the whole\nControlList or ControlSerializer.\n\nI might have mixed up how the PipelineHandler::controls_ ControlInfoMap needs\nto be initialized to specify control limits for application-modifiable\nControlList associated with a Request, and how\nPipelineHandler::properties_, being immutable from application\nperspective, just need to be filled in with ControlValues (and being\napplication visibile, it should only be inspected using libcamera\ncontrols).\n\nI've tested without this change, and it seems not required.\nI'll keep looking as I've the feeling I'm really missing something\nnow, or got something mixed up at the time I implemented this.\n\n>\n> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> > ---\n> >  include/libcamera/internal/pipeline_handler.h | 3 ++-\n> >  1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> > index a4e1b529c461..e579da711b33 100644\n> > --- a/include/libcamera/internal/pipeline_handler.h\n> > +++ b/include/libcamera/internal/pipeline_handler.h\n> > @@ -17,6 +17,7 @@\n> >\n> >  #include <libcamera/controls.h>\n> >  #include <libcamera/object.h>\n> > +#include <libcamera/property_ids.h>\n> >  #include <libcamera/stream.h>\n> >\n> >  #include \"libcamera/internal/ipa_proxy.h\"\n> > @@ -37,7 +38,7 @@ class CameraData\n> >  {\n> >  public:\n> >  \texplicit CameraData(PipelineHandler *pipe)\n> > -\t\t: pipe_(pipe)\n> > +\t\t: pipe_(pipe), properties_(properties::properties)\n> >  \t{\n> >  \t}\n> >  \tvirtual ~CameraData() {}\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3242BEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  8 Oct 2020 10:21:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5747B605BD;\n\tThu,  8 Oct 2020 12:21:01 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBAD660391\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  8 Oct 2020 12:20:59 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 48F6BFF805;\n\tThu,  8 Oct 2020 10:20:58 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Thu, 8 Oct 2020 12:24:58 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20201008102458.zp44tgk5a3ot4t7f@uno.localdomain>","References":"<20200911162039.61933-1-jacopo@jmondi.org>\n\t<20200911162039.61933-5-jacopo@jmondi.org>\n\t<f99871c9-9e0c-5da3-f9ca-b25dd62e78f7@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<f99871c9-9e0c-5da3-f9ca-b25dd62e78f7@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC 4/6] libcamera: pipeline_handler:\n\tInitialize properties_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]