[{"id":12459,"web_url":"https://patchwork.libcamera.org/comment/12459/","msgid":"<20200911173827.GF6808@pendragon.ideasonboard.com>","date":"2020-09-11T17:38:27","subject":"Re: [libcamera-devel] [PATCH] qcam: format_converter: Support R8\n\tGreyscale","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Sep 11, 2020 at 02:28:24PM +0100, Kieran Bingham wrote:\n> Support Greyscale images in the format converter by expanding the R8\n> component to each of the output RGB components.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> This enables viewing of my IR camera with Qcam.\n> \n> src/qcam/format_converter.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\n> index 4b9722d4ecf7..b63d077e41cc 100644\n> --- a/src/qcam/format_converter.cpp\n> +++ b/src/qcam/format_converter.cpp\n> @@ -68,6 +68,13 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> \t\tnvSwap_ = true;\n> \t\tbreak;\n> \n> +\tcase libcamera::formats::R8:\n> +\t\tformatFamily_ = RGB;\n> +\t\tr_pos_ = 0;\n> +\t\tg_pos_ = 0;\n> +\t\tb_pos_ = 0;\n> +\t\tbpp_= 1;\n> +\t\tbreak;\n> \tcase libcamera::formats::RGB888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 2;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B388BDB1D\n\tfor ;\n\tFri, 11 Sep 2020 17:38:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C707262D86;\n\tFri, 11 Sep 2020 19:38:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D13EC60534\n\tfor ;\n\tFri, 11 Sep 2020 19:38:56 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A2F7A17;\n\tFri, 11 Sep 2020 19:38:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i44Mi5ph\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599845935;\n\tbh=rug+Fot1UfffeiG2/VwvM2SXRvYpfX0XSFk/EYJxknA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i44Mi5ph6ODv10a8+5IQCMhxpqqqiDUMGjxYL2nfMGF+Ow36WaCLXiUyRVRn49hbU\n\tZfVov9mjdV8CcE0CFBjwKcw9z3Y1eWUWL12gk+PiryBUzQ9Jr3NaBL6lyEnpVWL6IU\n\tr17mtbakaJJlRNSKbmYHnL++c7xKIE4PGIMgF66E=","Date":"Fri, 11 Sep 2020 20:38:27 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200911173827.GF6808@pendragon.ideasonboard.com>","References":"<20200911132824.1287513-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200911132824.1287513-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] qcam: format_converter: Support R8\n\tGreyscale","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12471,"web_url":"https://patchwork.libcamera.org/comment/12471/","msgid":"<20200912135954.GA695456@oden.dyn.berto.se>","date":"2020-09-12T13:59:54","subject":"Re: [libcamera-devel] [PATCH] qcam: format_converter: Support R8\n\tGreyscale","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-09-11 14:28:24 +0100, Kieran Bingham wrote:\n> Support Greyscale images in the format converter by expanding the R8\n> component to each of the output RGB components.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> This enables viewing of my IR camera with Qcam.\n> \n> src/qcam/format_converter.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\n> index 4b9722d4ecf7..b63d077e41cc 100644\n> --- a/src/qcam/format_converter.cpp\n> +++ b/src/qcam/format_converter.cpp\n> @@ -68,6 +68,13 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> \t\tnvSwap_ = true;\n> \t\tbreak;\n> \n> +\tcase libcamera::formats::R8:\n> +\t\tformatFamily_ = RGB;\n> +\t\tr_pos_ = 0;\n> +\t\tg_pos_ = 0;\n> +\t\tb_pos_ = 0;\n> +\t\tbpp_= 1;\n> +\t\tbreak;\n> \tcase libcamera::formats::RGB888:\n> \t\tformatFamily_ = RGB;\n> \t\tr_pos_ = 2;\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4DE4C3B5B\n\tfor ;\n\tSat, 12 Sep 2020 13:59:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58C7662D27;\n\tSat, 12 Sep 2020 15:59:58 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E93D562C8C\n\tfor ;\n\tSat, 12 Sep 2020 15:59:56 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id a22so14798510ljp.13\n\tfor ;\n\tSat, 12 Sep 2020 06:59:56 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\te65sm1001835lfd.143.2020.09.12.06.59.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 12 Sep 2020 06:59:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"xld/Iqg6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=BWXhhzkvHCzYZMOkNAFMv6+X8AURO+qv6Hgo3uz1i00=;\n\tb=xld/Iqg6ca+ZzeW14LavCB05kX0XQkJrqKkIWw0Zo4uBDd8x6eJAQdJY4Qk9vfve+6\n\tVqoys0JrVDwnQ//SNaXf9yMRAw+PjSp+OYulb57I6Niep0Q9nLd/wKbpm0e8iRkkU4wS\n\tKk5lLNa1jzDItHfi0glvO9mtT5gBDWfeSvKv3xguSiU505ulx5bhEMkNpqUiwWTR+aBs\n\tmvO/M1nCmMe3Ce/6DNJNf8ut5ZkYj9hyrNCOuhw3uSKP5YSEuHPzgiE/jrpwnm0tSHDC\n\tt00xlUT88eG5BS4A7PdPb8EVBM4cCwgG/au3ixOeL9EvNd9FN31CtpKrIq1MgusyupqC\n\t5MZg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=BWXhhzkvHCzYZMOkNAFMv6+X8AURO+qv6Hgo3uz1i00=;\n\tb=oh8K6E0EGqy4OqDyAKQ1csqXbDvPvWBLyoYfTcB0dJ6LnwUQhBD1t5JvURq0n3IG6t\n\tiUC9agF3P+aDgqcJIBrmH+aOmdxnXaz7TKUgblUt+mFko1Rvtwit+T2hGB9J2398FTjx\n\t5ZrrgKFsrrsJQyXCTiMGWK8YF0THsNkYVskM8Ir7RHd2Pfmw5JyZ4KLzYtt0Y4fpSjzN\n\t6sQ1aQyrnXhvrbE3Fm8MxJhNnNFmBUhB4hB3Vmt4JeRgEcgeNazxOAtJokHpGmkbfV4d\n\t7OPoWA4Spi7bcgW0WB5Zlf2/fEhTjOhpDgN/PsUTqu3yAoeytIYq/V+WcixnoxnBAtd0\n\ttFpQ==","X-Gm-Message-State":"AOAM533t5glq0tqGGwPsHucT0J0LChfMA39a0H8quaFf2lRFD94InQlF\n\tQCOvUbdLSEJgRtTADX2AlwziitB0xRDDPw==","X-Google-Smtp-Source":"ABdhPJwOz447VXNX79FU7b3ZxzMFqmxRUC2SoglrnkDTuK5tN0m8aZgJwmXyJMfDJOGG7KLstLtggw==","X-Received":"by 2002:a2e:5d2:: with SMTP id 201mr2310617ljf.73.1599919196385; \n\tSat, 12 Sep 2020 06:59:56 -0700 (PDT)","Date":"Sat, 12 Sep 2020 15:59:54 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20200912135954.GA695456@oden.dyn.berto.se>","References":"<20200911132824.1287513-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200911132824.1287513-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] qcam: format_converter: Support R8\n\tGreyscale","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]