{"id":9572,"url":"https://patchwork.libcamera.org/api/patches/9572/?format=json","web_url":"https://patchwork.libcamera.org/patch/9572/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200911132824.1287513-1-kieran.bingham@ideasonboard.com>","date":"2020-09-11T13:28:24","name":"[libcamera-devel] qcam: format_converter: Support R8 Greyscale","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a862eb03f14c50d1412f8e1426c87dadb2703998","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9572/mbox/","series":[{"id":1285,"url":"https://patchwork.libcamera.org/api/series/1285/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1285","date":"2020-09-11T13:28:24","name":"[libcamera-devel] qcam: format_converter: Support R8 Greyscale","version":1,"mbox":"https://patchwork.libcamera.org/series/1285/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9572/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9572/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96D1DC3B5B\n\tfor ;\n\tFri, 11 Sep 2020 13:28:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1479962D86;\n\tFri, 11 Sep 2020 15:28:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59DEB60534\n\tfor ;\n\tFri, 11 Sep 2020 15:28:29 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D44F4A17;\n\tFri, 11 Sep 2020 15:28:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YXoZSIyp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599830909;\n\tbh=X6SINdmhevs82wSE9tb5ikQe8KefPmfatqN8+d2opKc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=YXoZSIypWaDGdSSCEKwOBkgukmGGu1aQonmscvqIa3ZaX5ZaUoV0es7MMv0Oe6CcT\n\tLg3dXlYQXjuMQgjfOuuGZIRiZSQXvtq7GbH/+Zp7UFQannQ+S3/Dz9Bjg5peTti2Be\n\tWsP7ePy0CTV5GMQ19EvV/4hFMt9MeLoxOrqlPY5w=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 11 Sep 2020 14:28:24 +0100","Message-Id":"<20200911132824.1287513-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] qcam: format_converter: Support R8\n\tGreyscale","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Support Greyscale images in the format converter by expanding the R8\ncomponent to each of the output RGB components.\n\nSigned-off-by: Kieran Bingham \n---\nThis enables viewing of my IR camera with Qcam.\n\n src/qcam/format_converter.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\nindex 4b9722d4ecf7..b63d077e41cc 100644\n--- a/src/qcam/format_converter.cpp\n+++ b/src/qcam/format_converter.cpp\n@@ -68,6 +68,13 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n \t\tnvSwap_ = true;\n \t\tbreak;\n \n+\tcase libcamera::formats::R8:\n+\t\tformatFamily_ = RGB;\n+\t\tr_pos_ = 0;\n+\t\tg_pos_ = 0;\n+\t\tb_pos_ = 0;\n+\t\tbpp_= 1;\n+\t\tbreak;\n \tcase libcamera::formats::RGB888:\n \t\tformatFamily_ = RGB;\n \t\tr_pos_ = 2;\n","prefixes":["libcamera-devel"]}