{"id":9563,"url":"https://patchwork.libcamera.org/api/patches/9563/?format=json","web_url":"https://patchwork.libcamera.org/patch/9563/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200909155457.153907-7-jacopo@jmondi.org>","date":"2020-09-09T15:54:55","name":"[libcamera-devel,6/8] android: camera_device: Allocate buffer pool","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f73e44592d7c153824a88db3e3e405d442914a91","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9563/mbox/","series":[{"id":1282,"url":"https://patchwork.libcamera.org/api/series/1282/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1282","date":"2020-09-09T15:54:49","name":"android: camera_device: Allocate internal buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/1282/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9563/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9563/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F7D9BDB1D\n\tfor ;\n\tWed, 9 Sep 2020 15:51:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D1E762D70;\n\tWed, 9 Sep 2020 17:51:26 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B7EE62D62\n\tfor ;\n\tWed, 9 Sep 2020 17:51:24 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 357361BF20E;\n\tWed, 9 Sep 2020 15:51:23 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 9 Sep 2020 17:54:55 +0200","Message-Id":"<20200909155457.153907-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200909155457.153907-1-jacopo@jmondi.org>","References":"<20200909155457.153907-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 6/8] android: camera_device: Allocate\n\tbuffer pool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"CameraStream instances that are not directly mapped to application\nfacing Android streams need memory to be reserved in libcamera on their\nbehalf.\n\nAfter the libcamera::Camera has been configured, reserve memory for the\nCameraStream isntances that need a pool of libcamera allocated buffers.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d35c6b93b654..a7cb1be03b9a 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1329,6 +1329,26 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\treturn ret;\n \t}\n \n+\t/*\n+\t * Allocate buffers in libcamera for stream not directly mapped to\n+\t * Android streams.\n+\t */\n+\tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n+\t\tcamera3_stream_t *camera3Stream = stream_list->streams[i];\n+\t\tCameraStream *cameraStream = static_cast(camera3Stream->priv);\n+\t\tStreamConfiguration &cfg = config_->at(cameraStream->index());\n+\n+\t\tif (cameraStream->type() != CameraStream::Type::Internal)\n+\t\t\tcontinue;\n+\n+\t\tint ret = allocator_.allocate(cfg.stream());\n+\t\tif (ret < 0) {\n+\t\t\tLOG(HAL, Error)\n+\t\t\t\t<< \"Failed to allocate buffers for stream \" << i;\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","6/8"]}