[{"id":12421,"web_url":"https://patchwork.libcamera.org/comment/12421/","msgid":"<20200910112041.GQ4095624@oden.dyn.berto.se>","date":"2020-09-10T11:20:41","subject":"Re: [libcamera-devel] [PATCH 4/8] android: camera_device: Clear\n\tallocator at configureStream","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2020-09-09 17:54:53 +0200, Jacopo Mondi wrote:\n> The configureStream operation might be called by the Android framework\n> in two successive capture session without going through a close().\n> \n> Clear all the allocated buffers before configuring the camera streams.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 98cfa3d5aa59..d35c6b93b654 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1187,6 +1187,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t */\n> \tstreams_.clear();\n> \tstreams_.reserve(stream_list->num_streams);\n> +\tallocator_.clear();\n> \n> \t/* First handle all non-MJPEG streams. */\n> \tcamera3_stream_t *jpegStream = nullptr;\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5390C3B5B\n\tfor ;\n\tThu, 10 Sep 2020 11:20:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94DE062D8E;\n\tThu, 10 Sep 2020 13:20:44 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D6AB62D27\n\tfor ;\n\tThu, 10 Sep 2020 13:20:43 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id c2so7609493ljj.12\n\tfor ;\n\tThu, 10 Sep 2020 04:20:43 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty14sm1499051ljm.32.2020.09.10.04.20.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 10 Sep 2020 04:20:41 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"RWypGSVu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=54GCLYN9/e1hOKvvv3wlGbCm/UjtKvDva3d09TNwRz0=;\n\tb=RWypGSVuifI+B8fT8TtXJedtgMvCBmezLRDiV1u5QARSk35uhorEfty9Lov3GFmh/b\n\tOP6pTdC8wYrWzCB6ZtZVUzLS9MqsP/PeRg9e9nfAJVycf9TmRpoasITG0oqPKqX5XKVC\n\tV7ScokyvSFtVkWB46RvbguGnrEpUmLAYT9nbBzSl8Jq3Ne+rgeI1lLH8fEyGnImPqRsO\n\tXxF40LDNSk7rVF0M9u4OUEk9CL/ZISadG18CFSo5lQyot4gLDJhb3cVSrdD9yQbiFyU8\n\tHEVMi2WJxNewlxGDOzDWVFBEotzh3rJKnicp/XVJnfh9nmTAyg3rUykOwhM8Wp2E/w4k\n\tUvug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=54GCLYN9/e1hOKvvv3wlGbCm/UjtKvDva3d09TNwRz0=;\n\tb=n82JejhMdylT4WrrW6hU6AGpSjhPyu7zboxFUAMw8VJ22yJG/Be4sn136EPG2hnNf5\n\t3bVKfW4azZWwYy4OJKOUvninGFgmb64J6BnSOb+HORkoKr2NRYe5lOjTAVGwBbsUAGUG\n\tlHFWGFP0IG4AyrCYyxEjuai93dmkCeJpa1VOGFKgg57a6mRx9xxOxj71tyMdkFCK3crI\n\tnGyr0j31+eP8v+pgLthoi9Sww0PBOGhoMMc7Y7fQsPkD2Z4KkssbFEPE5UVRV0Ptmlon\n\tNp7rl6wiwZeD0cLotU1FL/piZXaeCFbQ+MQ8vMTbhLhMt4Oc8Knou2yXI6LgeDPlZ3Xt\n\t40jQ==","X-Gm-Message-State":"AOAM533sA52uaKgUioJTymmZ+SeBItQ+rEM6wJRP8MUd5F+i83RyXzpQ\n\tSebSyLKAflMBgdscWv4WUVzPCQ==","X-Google-Smtp-Source":"ABdhPJwmtmq18iASnlLr1pZN+Fmv8m5mPxqx1NJXWRjwgypL4/XjowYfbpsiA+EooxfAPIWit6JI4g==","X-Received":"by 2002:a05:651c:200b:: with SMTP id\n\ts11mr4090092ljo.196.1599736842292; \n\tThu, 10 Sep 2020 04:20:42 -0700 (PDT)","Date":"Thu, 10 Sep 2020 13:20:41 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200910112041.GQ4095624@oden.dyn.berto.se>","References":"<20200909155457.153907-1-jacopo@jmondi.org>\n\t<20200909155457.153907-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200909155457.153907-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 4/8] android: camera_device: Clear\n\tallocator at configureStream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12445,"web_url":"https://patchwork.libcamera.org/comment/12445/","msgid":"","date":"2020-09-11T07:37:08","subject":"Re: [libcamera-devel] [PATCH 4/8] android: camera_device: Clear\n\tallocator at configureStream","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo.\nThanks for your patch.\n\nOn Thu, Sep 10, 2020 at 8:20 PM Niklas Söderlund\n wrote:\n>\n> Hi Jacopo,\n>\n> Thanks for your patch.\n>\n> On 2020-09-09 17:54:53 +0200, Jacopo Mondi wrote:\n> > The configureStream operation might be called by the Android framework\n> > in two successive capture session without going through a close().\n> >\n> > Clear all the allocated buffers before configuring the camera streams.\n> >\n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Niklas Söderlund \n>\n\nReviewed-by: Hirokazu Honda \n\n> > ---\n> > src/android/camera_device.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 98cfa3d5aa59..d35c6b93b654 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1187,6 +1187,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > */\n> > streams_.clear();\n> > streams_.reserve(stream_list->num_streams);\n> > + allocator_.clear();\n> >\n> > /* First handle all non-MJPEG streams. */\n> > camera3_stream_t *jpegStream = nullptr;\n> > --\n> > 2.28.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8465DBDB1D\n\tfor ;\n\tFri, 11 Sep 2020 07:37:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E85B962C8C;\n\tFri, 11 Sep 2020 09:37:21 +0200 (CEST)","from mail-ej1-x644.google.com (mail-ej1-x644.google.com\n\t[IPv6:2a00:1450:4864:20::644])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4AA062901\n\tfor ;\n\tFri, 11 Sep 2020 09:37:19 +0200 (CEST)","by mail-ej1-x644.google.com with SMTP id lo4so12443772ejb.8\n\tfor ;\n\tFri, 11 Sep 2020 00:37:19 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"FPcCWulo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=lxEnEVNP9cxQ+j7fDH31sgyHxHKa0SxoPF86uvXzdsM=;\n\tb=FPcCWuloFqQC1qm3oRSSrapR1eNQIIP/7NseGYOHwOq9I9MDooSXz9+oOu3Tt37tHB\n\tFbhce672wrK2uiolMFNmxepVS1kv9w1QrNkigRoQfs2x+M69rFtLx0Kg96nxwHaeQF8n\n\tMD4iN6Kt7YzmBAs/duupTDhqNJX4BTnIKxD/w=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=lxEnEVNP9cxQ+j7fDH31sgyHxHKa0SxoPF86uvXzdsM=;\n\tb=X6UjPHNSzMEdI3ML0wAGnLYgCOpuq9Y8a1JgSQl3kjFaEDwOfa8CLObVp5tnPsIJDX\n\tThUnfIilmTjCV7jwLm5tsEKq0GHMnxj29HqXVZ2/w6LlZ3zcXKc1FXEfadZRnMLKgbYV\n\tmf5HzQPycpez3i4Kzj3O4SVef9eVkCaVLy/aqL3ntwvPczG9pjeIDxMKeUqqK7++UtWQ\n\tXUlshs6yHYeAzPqX0cbpj9f+vQYViHuexH/sPsLKMFmkfdwIBXx9eEERlhi5t4u8p6ee\n\tZOfosGAKG9wQmpKcF05ZM0W9feEm8g3K7o9i89Z6lPf2AT6tsDA/NTw/2R2UnPNb3GQY\n\tPYPA==","X-Gm-Message-State":"AOAM531T7gECP1M0qoLZBuZ/ZnWjopiuZpQWCKHvywUEcX4ViQ28Z1a0\n\tlG1yW1utj5oblHnJJSttTyOUApO6G/kfYm24OIh2EA==","X-Google-Smtp-Source":"ABdhPJyoN68NfcJ9yenp/5uJO0lDArcmy3SZvCdn4fFALbsb/+nCzL7FWXm89My8HF0x1XrTjvBy52ESSLnOxiAry00=","X-Received":"by 2002:a17:906:4d4d:: with SMTP id\n\tb13mr747987ejv.221.1599809839451; \n\tFri, 11 Sep 2020 00:37:19 -0700 (PDT)","MIME-Version":"1.0","References":"<20200909155457.153907-1-jacopo@jmondi.org>\n\t<20200909155457.153907-5-jacopo@jmondi.org>\n\t<20200910112041.GQ4095624@oden.dyn.berto.se>","In-Reply-To":"<20200910112041.GQ4095624@oden.dyn.berto.se>","From":"Hirokazu Honda ","Date":"Fri, 11 Sep 2020 16:37:08 +0900","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH 4/8] android: camera_device: Clear\n\tallocator at configureStream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hanlin Chen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]