[{"id":12419,"web_url":"https://patchwork.libcamera.org/comment/12419/","msgid":"<20200910111916.GO4095624@oden.dyn.berto.se>","date":"2020-09-10T11:19:16","subject":"Re: [libcamera-devel] [PATCH 2/8] android: camera_device: Add frame\n\tallocator","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-09-09 17:54:51 +0200, Jacopo Mondi wrote:\n> Add to the CameraDevice class a FrameBufferAllocator class member.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 5 +++--\n> src/android/camera_device.h | 2 ++\n> 2 files changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 3c58523e528e..98cfa3d5aa59 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -14,6 +14,7 @@\n> \n> #include \n> #include \n> +#include \n> #include \n> \n> #include \"libcamera/internal/formats.h\"\n> @@ -210,8 +211,8 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n> */\n> \n> CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr &camera)\n> -\t: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n> -\t facing_(CAMERA_FACING_FRONT), orientation_(0)\n> +\t: id_(id), running_(false), camera_(camera), allocator_(camera),\n> +\t staticMetadata_(nullptr), facing_(CAMERA_FACING_FRONT), orientation_(0)\n> {\n> \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n> \n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 9dea7c42bdb5..0e912030d7f2 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -16,6 +16,7 @@\n> \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -206,6 +207,7 @@ private:\n> \tbool running_;\n> \tstd::shared_ptr camera_;\n> \tstd::unique_ptr config_;\n> +\tlibcamera::FrameBufferAllocator allocator_;\n> \n> \tCameraMetadata *staticMetadata_;\n> \tstd::map requestTemplates_;\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2ED37C3B5B\n\tfor ;\n\tThu, 10 Sep 2020 11:19:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C25ED62D60;\n\tThu, 10 Sep 2020 13:19:19 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 513D462D27\n\tfor ;\n\tThu, 10 Sep 2020 13:19:18 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id u21so7639191ljl.6\n\tfor ;\n\tThu, 10 Sep 2020 04:19:18 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\td1sm1500691ljj.68.2020.09.10.04.19.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 10 Sep 2020 04:19:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ILY655vJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=CG9cl3VTQ43FVfYdvzeeL/Kw/Ba6m19Q7KrrHX+01mk=;\n\tb=ILY655vJc2zSUR2//RdcBLfUAgjhJhzrhPHmZfSCn0+l9sSiAvJFcR8eqK9X77R6R3\n\tRcsncvxPj6LW5lKc/HRuqW/RY4p0nNPLsG+3IrOVdP2TDJU2qziAxnkj4SvLh3RYYTsX\n\tdWIWhtIplcqRtKnRPMejwy7AvnnDRz9FNzfsXTA0Ky8BbkrYTM36xutQg9QfaezJO+w9\n\tlHhG2uUrL5JVYIOsI4S/fWq7loZifHcBCfWP3v+ylvLw7pe4Eyy4TW+SiZ0mw9A7SCVd\n\teCnAEWxrt4YEQjclCKrXQO5gavIAMRsG39/ZfRygklqOq/JtI9f/mCgizqcg70fdlu0h\n\t7x8A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=CG9cl3VTQ43FVfYdvzeeL/Kw/Ba6m19Q7KrrHX+01mk=;\n\tb=rd4xg8vFzaMZZyha2paEee203CF5kOrLDJMalG0d43oGXazSM+Kd9rzo96X9+LeYXY\n\tyiic4kb61ElZytBfkluXzuUlriKL6irTnCaWiXX5O+9tFIR4JlUD9ExE5xZusSxY9Rle\n\tbiY0zpny6haLcI7nJ5OlMTaaD4ADRnvN6zS8YxfUEfPiaQCt256vEwrrXvfTqhZDczuN\n\tdtRMWU7mVod+OYfqOFcfEMzD2uvvLzHSLBiWLkfyBylIZz5/ZMMwHUoV2yCRRVkqFkPz\n\tnCtD7Ahwg19WQh533O9auuj9cbmysHlKwI0iinglW+MEQ/Ub8B7yf0TOxDRMtTqiuTHo\n\tEMxw==","X-Gm-Message-State":"AOAM531ryM/p6vmHngOOf+DAYGDu7qP/ogFf6x4WYRwc7P6Lew4TaJzL\n\tdTgz2SdxKNRVBCYlpaqyAdnc+A==","X-Google-Smtp-Source":"ABdhPJyDx7cJWzD5SpWXrgPpH2U7nQ+0TertxKdnPoEF2sTSgv7cRhC9jHalXEM5rMJ9AKAIRpUJkQ==","X-Received":"by 2002:a2e:9e8a:: with SMTP id\n\tf10mr4021159ljk.330.1599736757804; \n\tThu, 10 Sep 2020 04:19:17 -0700 (PDT)","Date":"Thu, 10 Sep 2020 13:19:16 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200910111916.GO4095624@oden.dyn.berto.se>","References":"<20200909155457.153907-1-jacopo@jmondi.org>\n\t<20200909155457.153907-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200909155457.153907-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/8] android: camera_device: Add frame\n\tallocator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12443,"web_url":"https://patchwork.libcamera.org/comment/12443/","msgid":"","date":"2020-09-11T04:29:05","subject":"Re: [libcamera-devel] [PATCH 2/8] android: camera_device: Add frame\n\tallocator","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Thanks for the patch!\n\nOn Thu, Sep 10, 2020 at 8:19 PM Niklas Söderlund\n wrote:\n>\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2020-09-09 17:54:51 +0200, Jacopo Mondi wrote:\n> > Add to the CameraDevice class a FrameBufferAllocator class member.\n> >\n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Niklas Söderlund \n>\n\nReviewed-by: Hirokazu Honda \n> > ---\n> > src/android/camera_device.cpp | 5 +++--\n> > src/android/camera_device.h | 2 ++\n> > 2 files changed, 5 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 3c58523e528e..98cfa3d5aa59 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -14,6 +14,7 @@\n> >\n> > #include \n> > #include \n> > +#include \n> > #include \n> >\n> > #include \"libcamera/internal/formats.h\"\n> > @@ -210,8 +211,8 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n> > */\n> >\n> > CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr &camera)\n> > - : id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n> > - facing_(CAMERA_FACING_FRONT), orientation_(0)\n> > + : id_(id), running_(false), camera_(camera), allocator_(camera),\n> > + staticMetadata_(nullptr), facing_(CAMERA_FACING_FRONT), orientation_(0)\n> > {\n> > camera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n> >\n> > diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> > index 9dea7c42bdb5..0e912030d7f2 100644\n> > --- a/src/android/camera_device.h\n> > +++ b/src/android/camera_device.h\n> > @@ -16,6 +16,7 @@\n> >\n> > #include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > #include \n> > @@ -206,6 +207,7 @@ private:\n> > bool running_;\n> > std::shared_ptr camera_;\n> > std::unique_ptr config_;\n> > + libcamera::FrameBufferAllocator allocator_;\n> >\n> > CameraMetadata *staticMetadata_;\n> > std::map requestTemplates_;\n> > --\n> > 2.28.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AEC75BDB1D\n\tfor ;\n\tFri, 11 Sep 2020 04:29:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5305B62D38;\n\tFri, 11 Sep 2020 06:29:17 +0200 (CEST)","from mail-ed1-x543.google.com (mail-ed1-x543.google.com\n\t[IPv6:2a00:1450:4864:20::543])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 451E26036C\n\tfor ;\n\tFri, 11 Sep 2020 06:29:16 +0200 (CEST)","by mail-ed1-x543.google.com with SMTP id ay8so8566913edb.8\n\tfor ;\n\tThu, 10 Sep 2020 21:29:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ktkxo7V+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=PnwZJhV1VMFhhuiJlsnR4/a0c4yQAiY7NUiTXWV0pig=;\n\tb=ktkxo7V+AHgIWksieBeaqiXUWheEa0KfbdgxuCqKy24s1LKlNYvjLyaefv8E31Ingw\n\tIKip3DvmefXOzHbNekAu7tEwDQWk55Ujr/rAucA1vcpi36lDw7HYiH87KmFKOqxinxBs\n\to24rdngq3nSjejajr7n3f1mgX+lptVBgqQe9A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=PnwZJhV1VMFhhuiJlsnR4/a0c4yQAiY7NUiTXWV0pig=;\n\tb=YDNG+ShTeNq+Y5tMqSPQEQEB/yYxc5vQaO47XACE2b6hUW4iQCZXP98cLVNMCAzE6+\n\tq7KomkKDYLgtgdOU5okGXrngThuJI+IRRA+6AEyGXd2MUH6AQc4e/rw2oYupPD67D2Ux\n\tpKLBwmuWyn60E+hHnaTFpCY3qRU1YKkY3cPA3obZymgNRKKzys4/TuFh8HkdwmvxcB9F\n\tJIBiYqf6ZwMizJAH7TJ9HWXLol17TamOkQ6GBaXl0lVgBau1MsPNA8rUhjPyKNf9jaDt\n\tLwcqBX3nFMYPN0h0vw+QVDFx4mPvHW4D58Sc8C67Ua5eQXfcGCrZNxbTF7xUQj5eYnjq\n\t3P1A==","X-Gm-Message-State":"AOAM531bUiBVWhAoE2OdcLCGsd+as4v8XWUNQRnLPtirCCLXu4fY8nLE\n\t7YiM9YJEo3lm4b1kHybn082vaYbOGo8rQc99nHY3ug==","X-Google-Smtp-Source":"ABdhPJwa8yxaPYEVEQR2G3FO0tO4Tw4w32MvU0HsznwEn0MeCvgAKu/wYFQMKDcSvGiaUGbMM8cd2/Jh0ktYK4TlF4w=","X-Received":"by 2002:aa7:d296:: with SMTP id w22mr76408edq.327.1599798555915; \n\tThu, 10 Sep 2020 21:29:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20200909155457.153907-1-jacopo@jmondi.org>\n\t<20200909155457.153907-3-jacopo@jmondi.org>\n\t<20200910111916.GO4095624@oden.dyn.berto.se>","In-Reply-To":"<20200910111916.GO4095624@oden.dyn.berto.se>","From":"Hirokazu Honda ","Date":"Fri, 11 Sep 2020 13:29:05 +0900","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH 2/8] android: camera_device: Add frame\n\tallocator","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hanlin Chen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]