[{"id":12396,"web_url":"https://patchwork.libcamera.org/comment/12396/","msgid":"<20200910043959.GG4009@pendragon.ideasonboard.com>","date":"2020-09-10T04:39:59","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: Move Header generation\n\tutilities to utils","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Sep 09, 2020 at 02:05:58PM +0100, Kieran Bingham wrote:\n> Move the GPL2 utilities which handle generation of controls, formats and\n\ns/GPL2/GPLv2/\n\n> the top level libcamera header to the utils subtree.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> Move the GPL2 utility library out of the libcamera source directory\n> and into the utils subdirectory.\n\nI think you've mentioned this already :-)\n\n> ---\n>  include/libcamera/meson.build               | 6 ------\n>  src/libcamera/meson.build                   | 2 --\n>  {src/libcamera => utils}/gen-controls.py    | 0\n>  {include/libcamera => utils}/gen-formats.py | 0\n>  {include/libcamera => utils}/gen-header.sh  | 0\n>  utils/meson.build                           | 9 +++++++++\n>  6 files changed, 9 insertions(+), 8 deletions(-)\n>  rename {src/libcamera => utils}/gen-controls.py (100%)\n>  rename {include/libcamera => utils}/gen-formats.py (100%)\n>  rename {include/libcamera => utils}/gen-header.sh (100%)\n> \n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index cdb8e0372e77..692931a5a639 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -34,8 +34,6 @@ install_headers(libcamera_public_headers,\n>  #\n>  \n>  # control_ids.h and property_ids.h\n> -gen_controls = files('../../src/libcamera/gen-controls.py')\n> -\n>  control_source_files = [\n>      'control_ids',\n>      'property_ids',\n> @@ -57,8 +55,6 @@ endforeach\n>  libcamera_public_headers += control_headers\n>  \n>  # formats.h\n> -gen_formats = files('gen-formats.py')\n> -\n>  formats_h = custom_target('formats_h',\n>                            input : files(\n>                                '../../src/libcamera/formats.yaml',\n> @@ -72,8 +68,6 @@ formats_h = custom_target('formats_h',\n>  libcamera_public_headers += formats_h\n>  \n>  # libcamera.h\n> -gen_header = files('gen-header.sh')\n> -\n>  libcamera_h = custom_target('gen-header',\n>                              input : 'meson.build',\n>                              output : 'libcamera.h',\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index af2f3d950be6..d54ee979418b 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -77,8 +77,6 @@ if libudev.found()\n>      ])\n>  endif\n>  \n> -gen_controls = files('gen-controls.py')\n> -\n>  control_sources = []\n>  \n>  foreach source : control_source_files\n> diff --git a/src/libcamera/gen-controls.py b/utils/gen-controls.py\n> similarity index 100%\n> rename from src/libcamera/gen-controls.py\n> rename to utils/gen-controls.py\n> diff --git a/include/libcamera/gen-formats.py b/utils/gen-formats.py\n> similarity index 100%\n> rename from include/libcamera/gen-formats.py\n> rename to utils/gen-formats.py\n> diff --git a/include/libcamera/gen-header.sh b/utils/gen-header.sh\n> similarity index 100%\n> rename from include/libcamera/gen-header.sh\n> rename to utils/gen-header.sh\n> diff --git a/utils/meson.build b/utils/meson.build\n> index c3cd9d69f887..7689790eb1c1 100644\n> --- a/utils/meson.build\n> +++ b/utils/meson.build\n> @@ -1,3 +1,12 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n>  subdir('ipu3')\n> +\n> +## Generates control_ids.h and property_ids.h\n\nNot just .h but also .cpp. I'm not sure we need to detail this, I would\nhave gone for\n\n## Code generation\ngen_controls = files('gen-controls.py')\ngen_formats = files('gen-formats.py')\ngen_header = files('gen-header.sh')\n\nBut I don't mind either way.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> +gen_controls = files('gen-controls.py')\n> +\n> +## Generates formats.h\n> +gen_formats = files('gen-formats.py')\n> +\n> +## Generates libcamera.h\n> +gen_header = files('gen-header.sh')","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B1ABBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Sep 2020 04:40:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A211D62D4B;\n\tThu, 10 Sep 2020 06:40:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B833062B90\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Sep 2020 06:40:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34D383B;\n\tThu, 10 Sep 2020 06:40:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nxPFrrVc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599712826;\n\tbh=SjnT1pFG71BgDjjkqMIO8PJxVrvB3sSBN/t5BA8xhQA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nxPFrrVcXpzm0MHWeln3RRwONZzS/HL7PzN5RFrb7bgCylpj2OVwBN7GZPUBf2rvu\n\tRWvXwdxQcB7f1cj/qJ00RA54JosCqVl8gDobHXi1qnnK2PLBqxCGfjLll7I3VBM8IO\n\t1SeEt5bLolkiVLHEjoepRXB0JM4rGKdP9Cno9l7U=","Date":"Thu, 10 Sep 2020 07:39:59 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20200910043959.GG4009@pendragon.ideasonboard.com>","References":"<20200909130559.1122914-1-kieran.bingham@ideasonboard.com>\n\t<20200909130559.1122914-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200909130559.1122914-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: Move Header generation\n\tutilities to utils","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":12406,"web_url":"https://patchwork.libcamera.org/comment/12406/","msgid":"<00a4e64b-0314-72e3-6d6f-6dfee8c2ed40@ideasonboard.com>","date":"2020-09-10T10:39:36","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: Move Header generation\n\tutilities to utils","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 10/09/2020 05:39, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Wed, Sep 09, 2020 at 02:05:58PM +0100, Kieran Bingham wrote:\n>> Move the GPL2 utilities which handle generation of controls, formats and\n> \n> s/GPL2/GPLv2/\n> \n>> the top level libcamera header to the utils subtree.\n>>\n>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>>\n>> Move the GPL2 utility library out of the libcamera source directory\n>> and into the utils subdirectory.\n> \n> I think you've mentioned this already :-)\n\nOops, this was a squash of three near identical patches, looks like I\nmissed removal of one of the commits messages.\n\nDropped.\n\n\n> \n>> ---\n>>  include/libcamera/meson.build               | 6 ------\n>>  src/libcamera/meson.build                   | 2 --\n>>  {src/libcamera => utils}/gen-controls.py    | 0\n>>  {include/libcamera => utils}/gen-formats.py | 0\n>>  {include/libcamera => utils}/gen-header.sh  | 0\n>>  utils/meson.build                           | 9 +++++++++\n>>  6 files changed, 9 insertions(+), 8 deletions(-)\n>>  rename {src/libcamera => utils}/gen-controls.py (100%)\n>>  rename {include/libcamera => utils}/gen-formats.py (100%)\n>>  rename {include/libcamera => utils}/gen-header.sh (100%)\n>>\n>> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n>> index cdb8e0372e77..692931a5a639 100644\n>> --- a/include/libcamera/meson.build\n>> +++ b/include/libcamera/meson.build\n>> @@ -34,8 +34,6 @@ install_headers(libcamera_public_headers,\n>>  #\n>>  \n>>  # control_ids.h and property_ids.h\n>> -gen_controls = files('../../src/libcamera/gen-controls.py')\n>> -\n>>  control_source_files = [\n>>      'control_ids',\n>>      'property_ids',\n>> @@ -57,8 +55,6 @@ endforeach\n>>  libcamera_public_headers += control_headers\n>>  \n>>  # formats.h\n>> -gen_formats = files('gen-formats.py')\n>> -\n>>  formats_h = custom_target('formats_h',\n>>                            input : files(\n>>                                '../../src/libcamera/formats.yaml',\n>> @@ -72,8 +68,6 @@ formats_h = custom_target('formats_h',\n>>  libcamera_public_headers += formats_h\n>>  \n>>  # libcamera.h\n>> -gen_header = files('gen-header.sh')\n>> -\n>>  libcamera_h = custom_target('gen-header',\n>>                              input : 'meson.build',\n>>                              output : 'libcamera.h',\n>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n>> index af2f3d950be6..d54ee979418b 100644\n>> --- a/src/libcamera/meson.build\n>> +++ b/src/libcamera/meson.build\n>> @@ -77,8 +77,6 @@ if libudev.found()\n>>      ])\n>>  endif\n>>  \n>> -gen_controls = files('gen-controls.py')\n>> -\n>>  control_sources = []\n>>  \n>>  foreach source : control_source_files\n>> diff --git a/src/libcamera/gen-controls.py b/utils/gen-controls.py\n>> similarity index 100%\n>> rename from src/libcamera/gen-controls.py\n>> rename to utils/gen-controls.py\n>> diff --git a/include/libcamera/gen-formats.py b/utils/gen-formats.py\n>> similarity index 100%\n>> rename from include/libcamera/gen-formats.py\n>> rename to utils/gen-formats.py\n>> diff --git a/include/libcamera/gen-header.sh b/utils/gen-header.sh\n>> similarity index 100%\n>> rename from include/libcamera/gen-header.sh\n>> rename to utils/gen-header.sh\n>> diff --git a/utils/meson.build b/utils/meson.build\n>> index c3cd9d69f887..7689790eb1c1 100644\n>> --- a/utils/meson.build\n>> +++ b/utils/meson.build\n>> @@ -1,3 +1,12 @@\n>>  # SPDX-License-Identifier: CC0-1.0\n>>  \n>>  subdir('ipu3')\n>> +\n>> +## Generates control_ids.h and property_ids.h\n> \n> Not just .h but also .cpp. I'm not sure we need to detail this, I would\n> have gone for\n> \n> ## Code generation\n> gen_controls = files('gen-controls.py')\n> gen_formats = files('gen-formats.py')\n> gen_header = files('gen-header.sh')\n> \n> But I don't mind either way.\n\nI was trying to bring the comments that were adjacent to the original\nlocations forward with it, but I like your grouping better.\n\nWill update to that.\n\n\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThanks\n\n> \n>> +gen_controls = files('gen-controls.py')\n>> +\n>> +## Generates formats.h\n>> +gen_formats = files('gen-formats.py')\n>> +\n>> +## Generates libcamera.h\n>> +gen_header = files('gen-header.sh')\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26D34BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Sep 2020 10:39:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEB1362D27;\n\tThu, 10 Sep 2020 12:39:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BC9E62C43\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Sep 2020 12:39:39 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C05553B;\n\tThu, 10 Sep 2020 12:39:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OitIKjC0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599734379;\n\tbh=AzVY1w+3uMLZS8jI6GZr2Gov1naM3Bs/ulMcaI0V8G0=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=OitIKjC02Zi3JUA/cFafHm1BlYVB4KJS88rmxZwqf67yalp9MWgTLIj5GUrKwtOom\n\t+gdEOkRuoQWuTz/sqpuTc/DFB7Uhctp+dHGGCGnBBF5kesKgcbwgeNyp3D1TjcrNGM\n\tHTkgCzFoE2SG+p1L85ruhnSVAUDWMOWroDDirXlE=","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20200909130559.1122914-1-kieran.bingham@ideasonboard.com>\n\t<20200909130559.1122914-3-kieran.bingham@ideasonboard.com>\n\t<20200910043959.GG4009@pendragon.ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<00a4e64b-0314-72e3-6d6f-6dfee8c2ed40@ideasonboard.com>","Date":"Thu, 10 Sep 2020 11:39:36 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200910043959.GG4009@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: Move Header generation\n\tutilities to utils","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]