[{"id":12395,"web_url":"https://patchwork.libcamera.org/comment/12395/","msgid":"<20200910043642.GF4009@pendragon.ideasonboard.com>","date":"2020-09-10T04:36:42","subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Process utils first","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Sep 09, 2020 at 02:05:57PM +0100, Kieran Bingham wrote:\n> The utils directory can contain helpers and support tools which are used\n> throughout other components of the build.\n> \n> Ensure that the utils subdir is parsed first allowing helpers to be\n> defined there.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> meson.build | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 1ea35e92ed67..510a6d3b44e6 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -100,9 +100,11 @@ add_project_link_arguments(cpp_arguments, language : 'cpp')\n> \n> libcamera_includes = include_directories('include')\n> \n> +# Utilities are parsed first to provide support for other components.\n> +subdir('utils')\n> +\n> subdir('include')\n> subdir('src')\n> -subdir('utils')\n> \n> # The documentation and test components are optional and can be disabled\n> # through configuration values. They are enabled by default.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E8E4BDB1D\n\tfor ;\n\tThu, 10 Sep 2020 04:37:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E6EB62C43;\n\tThu, 10 Sep 2020 06:37:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FF4462B90\n\tfor ;\n\tThu, 10 Sep 2020 06:37:10 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 604A33B;\n\tThu, 10 Sep 2020 06:37:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F8fdC1Ka\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599712629;\n\tbh=/PVS4zYRh3hjIFmYPcJ3yhpVKAzr7PsxDKRJxa5C0rQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=F8fdC1Ka8v5aNhS1WetWAed0xUh9qjaz8nMJ31HMZiLGcS5u0wkpjfZhjVySlExEg\n\t89Eq+4tyrMJXfkMJrueYNJG3a3xqvPmowVhzwa+vF+yERO3PWFCKQOn8oSsAIM4FuC\n\tMZRPhvDKmI9JgZG6V5MhW+5DbAxRLm0rWWgZqyUo=","Date":"Thu, 10 Sep 2020 07:36:42 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200910043642.GF4009@pendragon.ideasonboard.com>","References":"<20200909130559.1122914-1-kieran.bingham@ideasonboard.com>\n\t<20200909130559.1122914-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200909130559.1122914-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Process utils first","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]