{"id":9542,"url":"https://patchwork.libcamera.org/api/patches/9542/?format=json","web_url":"https://patchwork.libcamera.org/patch/9542/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200908134142.27470-12-jacopo@jmondi.org>","date":"2020-09-08T13:41:42","name":"[libcamera-devel,v3,11/11] android: camera_device: Make CameraStream a class","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9518e404ec50d60eb9fd53473566e5bc18bc3fb4","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9542/mbox/","series":[{"id":1274,"url":"https://patchwork.libcamera.org/api/series/1274/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1274","date":"2020-09-08T13:41:31","name":"android: camera_device: Fix JPEG/RAW sizes","version":3,"mbox":"https://patchwork.libcamera.org/series/1274/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9542/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9542/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CC56BDB1D\n\tfor ;\n\tTue, 8 Sep 2020 13:38:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B44D62C74;\n\tTue, 8 Sep 2020 15:38:23 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3981F62C5E\n\tfor ;\n\tTue, 8 Sep 2020 15:38:21 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E12E81C000C;\n\tTue, 8 Sep 2020 13:38:19 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 8 Sep 2020 15:41:42 +0200","Message-Id":"<20200908134142.27470-12-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200908134142.27470-1-jacopo@jmondi.org>","References":"<20200908134142.27470-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 11/11] android: camera_device: Make\n\tCameraStream a class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Complete the transformation of CameraStream into a class and provide\na read-only interface that allows to access its parameters but not\nmodify them at run-time.\n\nNo functional changes intended but this change aims to make the code\nmore robust by enforcing a stricter interface in the CameraStream class.\n\nReviewed-by: Hirokazu Honda \nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 9 +++++----\n src/android/camera_device.h | 14 ++++++++------\n 2 files changed, 13 insertions(+), 10 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 4c1416913d00..50923df22a8f 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -168,8 +168,9 @@ MappedCamera3Buffer::MappedCamera3Buffer(const buffer_handle_t camera3buffer,\n \t}\n }\n \n-CameraStream::CameraStream(PixelFormat f, Size s, unsigned int i, Encoder *encoder)\n-\t: format(f), size(s), index_(i), encoder_(encoder)\n+CameraStream::CameraStream(PixelFormat format, Size size,\n+\t\t\t unsigned int index, Encoder *encoder)\n+\t: format_(format), size_(size), index_(index), encoder_(encoder)\n {\n }\n \n@@ -1402,7 +1403,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t\tdescriptor->buffers[i].buffer = camera3Buffers[i].buffer;\n \n \t\t/* Software streams are handled after hardware streams complete. */\n-\t\tif (cameraStream->format == formats::MJPEG)\n+\t\tif (cameraStream->format() == formats::MJPEG)\n \t\t\tcontinue;\n \n \t\t/*\n@@ -1466,7 +1467,7 @@ void CameraDevice::requestComplete(Request *request)\n \t\tCameraStream *cameraStream =\n \t\t\tstatic_cast(descriptor->buffers[i].stream->priv);\n \n-\t\tif (cameraStream->format != formats::MJPEG)\n+\t\tif (cameraStream->format() != formats::MJPEG)\n \t\t\tcontinue;\n \n \t\tEncoder *encoder = cameraStream->encoder();\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 5ac8f05e5a07..912c59aeb5a8 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -27,18 +27,20 @@\n \n class CameraMetadata;\n \n-struct CameraStream {\n+class CameraStream\n+{\n public:\n-\tCameraStream(libcamera::PixelFormat, libcamera::Size, unsigned int i,\n-\t\t Encoder *encoder = nullptr);\n+\tCameraStream(libcamera::PixelFormat format, libcamera::Size size,\n+\t\t unsigned int index, Encoder *encoder = nullptr);\n \n+\tconst libcamera::PixelFormat &format() const { return format_; }\n+\tconst libcamera::Size &size() const { return size_; }\n \tunsigned int index() const { return index_; }\n \tEncoder *encoder() const { return encoder_.get(); }\n \n-\tlibcamera::PixelFormat format;\n-\tlibcamera::Size size;\n-\n private:\n+\tlibcamera::PixelFormat format_;\n+\tlibcamera::Size size_;\n \t/*\n \t * The index of the libcamera StreamConfiguration as added during\n \t * configureStreams(). A single libcamera Stream may be used to deliver\n","prefixes":["libcamera-devel","v3","11/11"]}