[{"id":12411,"web_url":"https://patchwork.libcamera.org/comment/12411/","msgid":"<20200910105247.GJ4095624@oden.dyn.berto.se>","date":"2020-09-10T10:52:47","subject":"Re: [libcamera-devel] [PATCH v3 08/11] android: camera_device: Use\n\tAndroid format","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-09-08 15:41:39 +0200, Jacopo Mondi wrote:\n> We assumed HAL_PIXEL_FORMAT_BLOB is always mapped to libcamera::MJPEG\n> and at the moment this is true. To protect against future changes in the\n> mapping, inspect the Android format instead of the libcamera one.\n> \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 2cad4fe76c3c..eab01d808917 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1210,7 +1210,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\tstream->priv = static_cast(&streams_[i]);\n> \n> \t\t/* Defer handling of MJPEG streams until all others are known. */\n> -\t\tif (format == formats::MJPEG)\n> +\t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB)\n> \t\t\tcontinue;\n> \n> \t\tStreamConfiguration streamConfiguration;\n> @@ -1225,10 +1225,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t/* Now handle MJPEG streams, adding a new stream if required. */\n> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> -\t\tPixelFormat format = toPixelFormat(stream->format);\n> \t\tbool match = false;\n> \n> -\t\tif (format != formats::MJPEG)\n> +\t\tif (stream->format != HAL_PIXEL_FORMAT_BLOB)\n> \t\t\tcontinue;\n> \n> \t\t/* Search for a compatible stream */\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E38AFBDB1D\n\tfor ;\n\tThu, 10 Sep 2020 10:52:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B36A862D72;\n\tThu, 10 Sep 2020 12:52:49 +0200 (CEST)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ED9462C8C\n\tfor ;\n\tThu, 10 Sep 2020 12:52:48 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id z19so3337812lfr.4\n\tfor ;\n\tThu, 10 Sep 2020 03:52:48 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tu14sm1482676lji.83.2020.09.10.03.52.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 10 Sep 2020 03:52:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"b/DgGmOD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=2nPrFFg0DxeV+4LzH+oESvYMEklNSiaSncIMGUT4udY=;\n\tb=b/DgGmODzIrCNVEEKLkoHgqnQn8Os2RL9Pw9ASeQJCsQ4iXGnp0NTzJWJDg7JNHTcd\n\tQCsTiQHn0Er5Ymf3ula3sOaA/79qUvU7dUqmkYPGgyBRNkPe1ib5fzatKKjWnoVn55fj\n\tQHBcLSQhwx95rs8Nk0akbrwnd4H6Tg+0KBIr1MYaOsk3JnwkSm4CCZ+SzdWlB3ImMSDf\n\tNmGzHaAoefpCRotxozHz1ZDP3+y02xA28ypW3Ljfg3k0bn4EFAYOeHGc3aIWNPiIM8dF\n\t+uixIhf2tmgPsHurkLuixsdEXLTCRA7apNwdZPmeD3r6glM/VWP7Bg4fhozkS+D8jx8L\n\tmorw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=2nPrFFg0DxeV+4LzH+oESvYMEklNSiaSncIMGUT4udY=;\n\tb=Am9j9BIGb3R8BmOd0rP4unYtNUA8ZlYRxMCVzjFTG2KvItxkPysgeijWovpCwL3U7V\n\taJll09RHjDo4IMHG4k+ucklB1mHejfCIu7oszDS2lizGrkaPA69zQFvPkhMlGXA01yoR\n\txUh+mLon5rxLYOBdUsleoKPl7+slMWvsTosQ1qv9h/CQLnvwraJw7VHcxufuRlYctkqi\n\tkvbKPVx9OJBj8cqOU0uEACP4kxQlCsBIP5Kg6G4fKAr7ExIwjOvXP5uIxsd5FOp6UaSU\n\trvQPU1bbvvZYxMTHVLD2PCfGrj7r/IyNYwWYrS8B5Q0Q/wERUNHb3Rak+qkI9ITIwuFl\n\t3Njw==","X-Gm-Message-State":"AOAM532v4r4ovOy7YnbRu6/kk8VJbG6IK/goLfqg4NDImTUoYXB9JA/Q\n\tr0tcXXcqcq+63J6uKwAr35IcK5NBTXamvA==","X-Google-Smtp-Source":"ABdhPJwm8RC/kcKMExLvYaf0yE0sBKSucqV5kvRoIbXrbDUwHeh32U9e4ZYyILXmOwHeXERcWTnWcQ==","X-Received":"by 2002:ac2:5dc5:: with SMTP id x5mr3926786lfq.186.1599735167990;\n\tThu, 10 Sep 2020 03:52:47 -0700 (PDT)","Date":"Thu, 10 Sep 2020 12:52:47 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200910105247.GJ4095624@oden.dyn.berto.se>","References":"<20200908134142.27470-1-jacopo@jmondi.org>\n\t<20200908134142.27470-9-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200908134142.27470-9-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 08/11] android: camera_device: Use\n\tAndroid format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12437,"web_url":"https://patchwork.libcamera.org/comment/12437/","msgid":"","date":"2020-09-11T02:34:36","subject":"Re: [libcamera-devel] [PATCH v3 08/11] android: camera_device: Use\n\tAndroid format","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Thanks for the patch.\n\nOn Thu, Sep 10, 2020 at 7:52 PM Niklas Söderlund\n wrote:\n>\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2020-09-08 15:41:39 +0200, Jacopo Mondi wrote:\n> > We assumed HAL_PIXEL_FORMAT_BLOB is always mapped to libcamera::MJPEG\n> > and at the moment this is true. To protect against future changes in the\n> > mapping, inspect the Android format instead of the libcamera one.\n> >\n> > Reviewed-by: Laurent Pinchart \n> > Reviewed-by: Kieran Bingham \n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Niklas Söderlund \n>\n> > ---\n> > src/android/camera_device.cpp | 5 ++---\n> > 1 file changed, 2 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 2cad4fe76c3c..eab01d808917 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1210,7 +1210,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > stream->priv = static_cast(&streams_[i]);\n> >\n> > /* Defer handling of MJPEG streams until all others are known. */\n> > - if (format == formats::MJPEG)\n> > + if (stream->format == HAL_PIXEL_FORMAT_BLOB)\n> > continue;\n> >\n> > StreamConfiguration streamConfiguration;\n> > @@ -1225,10 +1225,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > /* Now handle MJPEG streams, adding a new stream if required. */\n> > for (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> > camera3_stream_t *stream = stream_list->streams[i];\n> > - PixelFormat format = toPixelFormat(stream->format);\n> > bool match = false;\n> >\n> > - if (format != formats::MJPEG)\n> > + if (stream->format != HAL_PIXEL_FORMAT_BLOB)\n> > continue;\n> >\n> > /* Search for a compatible stream */\n> > --\n> > 2.28.0\n> >\n\nnit: This reverts the change on the patch 07/12.\nI would squash 07 and 08.\n\nReviewed-by: Hirokazu Honda \n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D19FBDB1D\n\tfor ;\n\tFri, 11 Sep 2020 02:34:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D0E862D38;\n\tFri, 11 Sep 2020 04:34:49 +0200 (CEST)","from mail-ej1-x642.google.com (mail-ej1-x642.google.com\n\t[IPv6:2a00:1450:4864:20::642])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 954976037B\n\tfor ;\n\tFri, 11 Sep 2020 04:34:47 +0200 (CEST)","by mail-ej1-x642.google.com with SMTP id i26so11673519ejb.12\n\tfor ;\n\tThu, 10 Sep 2020 19:34:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"HSRQHSgD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=1IuPIwJIdIv/ObfzuUr+2wpgnVJXyEuQgeBB4l+46P0=;\n\tb=HSRQHSgDFeyfm2zToDHJiPWYnbmcgzbqljv48nUZkyQLHgMjjbUQKC6dWpsySzTPBC\n\tTFdn+tH8mXW9YZS7AMH0A5/8DsDC74GOSQDLVZE0sia5g0Rm7w1ZTo5HqoqPoVkHglYj\n\timGpsVRjD4LQcV3pC1RpCcnspkzc1DtyfegRU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=1IuPIwJIdIv/ObfzuUr+2wpgnVJXyEuQgeBB4l+46P0=;\n\tb=nbCS+vaPIwCFiOgBYlEFNpR0NAQmBavR4KKXzky1k6awVia0YkV+a9rF77uHYf5SyC\n\tVKtXbAsNfi3F4eOt4E6L6rMFi57dw87Lm9LvExWOlocp2UMqkLO8Gzupsb5zuGnBoLrO\n\tPNnM73Kwsi3tGdCg0Bc9WsgJoZol3fIxVei/sNGakJmt5QMIHRh4zIIiynIR0n4rYzlx\n\txtTtI8kAEwGtruJRLt0htGv8Bk0AVlWk35YVEkDCWCTUA6KI1M3L8UixpExuh/V0LPt6\n\ta+DOwCTxgOqSF3lvXjWO1dZpbMyqk3bAhU/MMZNbve8k59m6m94ZgNRWf8G+ZLGo9syL\n\tSg2A==","X-Gm-Message-State":"AOAM533ty+g1aX2dauiKTVOEB0DEyemd59iBQ4g4e4IIcHVQ7effIXUA\n\tsqBHM72IptAXbDP7hi7CxIMatejU5f8N2qIcWwwErA==","X-Google-Smtp-Source":"ABdhPJxldStiLVnRktPapAVHRaisUUSnFsn1bB6vZbJokITiwAF6gerqmtwRdbY25UKs0adItWrfe3Ul940WXpIskWs=","X-Received":"by 2002:a17:906:4d4d:: with SMTP id\n\tb13mr11598806ejv.221.1599791687266; \n\tThu, 10 Sep 2020 19:34:47 -0700 (PDT)","MIME-Version":"1.0","References":"<20200908134142.27470-1-jacopo@jmondi.org>\n\t<20200908134142.27470-9-jacopo@jmondi.org>\n\t<20200910105247.GJ4095624@oden.dyn.berto.se>","In-Reply-To":"<20200910105247.GJ4095624@oden.dyn.berto.se>","From":"Hirokazu Honda ","Date":"Fri, 11 Sep 2020 11:34:36 +0900","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH v3 08/11] android: camera_device: Use\n\tAndroid format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hanlin Chen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]