[{"id":12410,"web_url":"https://patchwork.libcamera.org/comment/12410/","msgid":"<20200910105202.GI4095624@oden.dyn.berto.se>","date":"2020-09-10T10:52:02","subject":"Re: [libcamera-devel] [PATCH v3 07/11] android: camera_device: Use\n\tcamera3 stream format","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-09-08 15:41:38 +0200, Jacopo Mondi wrote:\n> When iterating the camera3_stream_t received from the Android camera\n> framework to identify the MJPEG streams, the format check was performed\n> on the CameraStream created when iterating the non-MJPEG streams and not\n> on the format actually requested by Android. As the next patches will\n> remove the creation of CameraStream instances for MJPEG streams, use the\n> camera3_stream format to prepare for that.\n> \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 562cbb3c415e..2cad4fe76c3c 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1225,9 +1225,10 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t/* Now handle MJPEG streams, adding a new stream if required. */\n> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> +\t\tPixelFormat format = toPixelFormat(stream->format);\n> \t\tbool match = false;\n> \n> -\t\tif (streams_[i].format != formats::MJPEG)\n> +\t\tif (format != formats::MJPEG)\n> \t\t\tcontinue;\n> \n> \t\t/* Search for a compatible stream */\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81C80C3B5B\n\tfor ;\n\tThu, 10 Sep 2020 10:52:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E3DB62D27;\n\tThu, 10 Sep 2020 12:52:05 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F06DF62C8C\n\tfor ;\n\tThu, 10 Sep 2020 12:52:03 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id v23so7593419ljd.1\n\tfor ;\n\tThu, 10 Sep 2020 03:52:03 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t68sm1485997ljj.135.2020.09.10.03.52.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 10 Sep 2020 03:52:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"i60VGuqw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=5CiET/gaw985wcOKFkZtdtQKcTqunGJyEwXJ6CCCZdY=;\n\tb=i60VGuqwI7NMUzd64nsuF43Gj3qJIqca3Tm+1JYQ8Uiu/PcxAFtMUGFVm6m4NhKp19\n\toLsT7LMfAy8XWASfRhaVHWE0rAGqTzSd15dJSikEjxigh9gutx3AFMZkrtVMNZl0Vvtd\n\trn8FdPROkJfqlVFNuStThixE4wj31FcZM9Gf9LOaLH1JSqG73RbcU88O6Fo2wC3AYXZG\n\tx0INcvNL7z2cDgKcTWrPPoPyZfYdWbowGTdefQAdGm3YEtyfujtbdqTw5xmTDzTbY9Az\n\th34BL7mS7CqCI65JOzMBj86S4zDYDg2Jv2anXn94IFmGVsETFacpYEUE3w/gaQe/GVxP\n\t7RVA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=5CiET/gaw985wcOKFkZtdtQKcTqunGJyEwXJ6CCCZdY=;\n\tb=sxZm54pLA+fx93OmghIrw7qj/LRpx/sWHqSZhkYZJR8hp8KK/9/y9QjWvgboRSZjTK\n\tbYzDY7yYHfv7ANWMPz/oYFvV9QXvaPBp/Dg8RTwFYAextb88gXJ8a+RjygSNIW9IiGJM\n\tdCsRJaDH68iz8ns446ePefTnd0I0kougWM+qYzflPz9RGsDUUOo4UY/fGMSWjFXyWUOC\n\thYCKHeEukD/ZM9PsXkgmBK2rzb7eAdUkbyW0aKmAeEPI6YV+VkQU8fNZtAfssueJFC23\n\tgeM8zZAkrU29nExii8hof9m3NVAzdXL3t9xcDVXA8KM8AhV3C3PlcahoUPHssfVOiH6l\n\t5vWA==","X-Gm-Message-State":"AOAM5312rSsaEGQBWN/vJTpuejuKDgvvCO8roZBJLvQbZd/6V0j1TCu5\n\tRHKBVpgEkYzs0rTJyVku5AeZFQ==","X-Google-Smtp-Source":"ABdhPJwl4i82B0OfdW8jsLJdmdnfjPDY43Yxx6H1oMIRyE77jkDNpgTrtD3xMDqRLddTz+CoajRF3g==","X-Received":"by 2002:a2e:90c3:: with SMTP id o3mr1371197ljg.147.1599735123194;\n\tThu, 10 Sep 2020 03:52:03 -0700 (PDT)","Date":"Thu, 10 Sep 2020 12:52:02 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200910105202.GI4095624@oden.dyn.berto.se>","References":"<20200908134142.27470-1-jacopo@jmondi.org>\n\t<20200908134142.27470-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200908134142.27470-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 07/11] android: camera_device: Use\n\tcamera3 stream format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12436,"web_url":"https://patchwork.libcamera.org/comment/12436/","msgid":"","date":"2020-09-11T02:32:09","subject":"Re: [libcamera-devel] [PATCH v3 07/11] android: camera_device: Use\n\tcamera3 stream format","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"On Thu, Sep 10, 2020 at 7:52 PM Niklas Söderlund\n wrote:\n>\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2020-09-08 15:41:38 +0200, Jacopo Mondi wrote:\n> > When iterating the camera3_stream_t received from the Android camera\n> > framework to identify the MJPEG streams, the format check was performed\n> > on the CameraStream created when iterating the non-MJPEG streams and not\n> > on the format actually requested by Android. As the next patches will\n> > remove the creation of CameraStream instances for MJPEG streams, use the\n> > camera3_stream format to prepare for that.\n> >\n> > Reviewed-by: Laurent Pinchart \n> > Reviewed-by: Kieran Bingham \n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Niklas Söderlund \n>\n\nReviewed-by: Hirokazu Honda \n\n> > ---\n> > src/android/camera_device.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 562cbb3c415e..2cad4fe76c3c 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1225,9 +1225,10 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > /* Now handle MJPEG streams, adding a new stream if required. */\n> > for (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> > camera3_stream_t *stream = stream_list->streams[i];\n> > + PixelFormat format = toPixelFormat(stream->format);\n> > bool match = false;\n> >\n> > - if (streams_[i].format != formats::MJPEG)\n> > + if (format != formats::MJPEG)\n> > continue;\n> >\n> > /* Search for a compatible stream */\n> > --\n> > 2.28.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22D5AC3B5B\n\tfor ;\n\tFri, 11 Sep 2020 02:32:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A96ED62D4B;\n\tFri, 11 Sep 2020 04:32:21 +0200 (CEST)","from mail-ed1-x542.google.com (mail-ed1-x542.google.com\n\t[IPv6:2a00:1450:4864:20::542])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5B046037B\n\tfor ;\n\tFri, 11 Sep 2020 04:32:20 +0200 (CEST)","by mail-ed1-x542.google.com with SMTP id l17so8371632edq.12\n\tfor ;\n\tThu, 10 Sep 2020 19:32:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"A08/BzF3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=U1z1ONdcvdlGs/1FKcUo62YeyzwRfBpZdpyBvXkwUWI=;\n\tb=A08/BzF3pyIvFm9c6QYAiwF/3BTZuvAfH6j0yJewxV3Dx2VXnI5VSCmt/MTnqLSf2V\n\tsg0OpQHexuoDZvLblTsytNKZszXzIeFPQD99U0JpHpV10NdUdXw56Q4uEwdZrTi2AMqL\n\twHDb9O7Wly9DViXBbGGV05SGWKw5xXt2RXyfs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=U1z1ONdcvdlGs/1FKcUo62YeyzwRfBpZdpyBvXkwUWI=;\n\tb=AAA8AkXWyfUdfwM2xD24Sizuzcu/9EXkHEmzLpL8Qo+ZkCF+uxIK8d2MQGEUzkINcP\n\tT90Y3zVSJpVrHTQrSSrv10mav5Dzp9RKRX1gzW6g6rw4wtYmFbYSywsOJPM1bz2rE3yP\n\trNpZeZua/tcJvZZFDcpIM5fTu6wLKT4bI18+fvw8ng4PK4tqGixs7OffdoyweoAMv9N5\n\tZ5VRcdjf0LIj1zzoUKBrVZTwvLCzPVV5k65afgUD4wIcocw5WKS03F07idUqbuLU7DEf\n\tJ+1Bco7aZmb5ljz9n+wlsohsCQxdftI74EbXd7ER2BnTf8uo2lGtUjlxesRk2EwC1I/f\n\tubPg==","X-Gm-Message-State":"AOAM531EZnPaifyX0q8EpwRs+EsRW1zkYzyfXiGCKnRYohoM8j6CsByR\n\t80vPWJPcZbh6UfQ+5AG3HFaGSfu6PxhwoMc+bfIfpA==","X-Google-Smtp-Source":"ABdhPJyFQaRktWl+nbnO9GMDbvZuVn1rAW/Jq5g5kOQlJUkvBWUqe5uiRbVzgKKpoGflZWoQJ2TlAGnlUqjT2DYx+4E=","X-Received":"by 2002:a50:e44b:: with SMTP id\n\te11mr12842788edm.73.1599791540294; \n\tThu, 10 Sep 2020 19:32:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20200908134142.27470-1-jacopo@jmondi.org>\n\t<20200908134142.27470-8-jacopo@jmondi.org>\n\t<20200910105202.GI4095624@oden.dyn.berto.se>","In-Reply-To":"<20200910105202.GI4095624@oden.dyn.berto.se>","From":"Hirokazu Honda ","Date":"Fri, 11 Sep 2020 11:32:09 +0900","Message-ID":"","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","Subject":"Re: [libcamera-devel] [PATCH v3 07/11] android: camera_device: Use\n\tcamera3 stream format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hanlin Chen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]