[{"id":12473,"web_url":"https://patchwork.libcamera.org/comment/12473/","msgid":"<20200912144823.GC695456@oden.dyn.berto.se>","date":"2020-09-12T14:48:23","subject":"Re: [libcamera-devel] [PATCH v7 11/12] pipeline: raspberrypi: Use\n\tan unordered_set to store IPA buffer ids","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Naushir,\n\nThanks for your patch.\n\nOn 2020-09-08 08:49:11 +0100, Naushir Patuck wrote:\n> By using a set container, we can easily insert/remove buffer ids that have\n> been mmaped by the IPA. This will be required to track buffers allocated\n> externally and passed to the pipeline handler through a Request.\n> \n> Move the IPA buffer mapping code into a function to remove duplicated\n> code.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> .../pipeline/raspberrypi/raspberrypi.cpp | 48 +++++++++++--------\n> 1 file changed, 28 insertions(+), 20 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 6aa13034..5621f182 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -10,6 +10,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> #include \n> @@ -158,8 +159,8 @@ public:\n> \tRPi::RPiDevice isp_;\n> \t/* The vector below is just for convenience when iterating over all streams. */\n> \tstd::vector streams_;\n> -\t/* Buffers passed to the IPA. */\n> -\tstd::vector ipaBuffers_;\n> +\t/* Stores the ids of the buffers mapped in the IPA. */\n> +\tstd::unordered_set ipaBuffers_;\n> \n> \t/* DMAHEAP allocation helper. */\n> \tRPi::DmaHeap dmaHeap_;\n> @@ -230,6 +231,7 @@ private:\n> \tint queueAllBuffers(Camera *camera);\n> \tint prepareBuffers(Camera *camera);\n> \tvoid freeBuffers(Camera *camera);\n> +\tvoid mapBuffers(Camera *camera, const RPi::BufferMap &buffers, unsigned int mask);\n> \n> \tMediaDevice *unicam_;\n> \tMediaDevice *isp_;\n> @@ -910,36 +912,42 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n> \t}\n> \n> \t/*\n> -\t * Link the FrameBuffers with the index of their position in the vector\n> -\t * stored in the RPi stream object.\n> +\t * Pass the stats and embedded data buffers to the IPA. No other\n> +\t * buffers need to be passed.\n> +\t */\n> +\tmapBuffers(camera, data->isp_[Isp::Stats].getBuffers(), RPiIpaMask::STATS);\n> +\tmapBuffers(camera, data->unicam_[Unicam::Embedded].getBuffers(), RPiIpaMask::EMBEDDED_DATA);\n> +\n> +\treturn 0;\n> +}\n> +\n> +void PipelineHandlerRPi::mapBuffers(Camera *camera, const RPi::BufferMap &buffers, unsigned int mask)\n> +{\n> +\tRPiCameraData *data = cameraData(camera);\n> +\tstd::vector ipaBuffers;\n> +\t/*\n> +\t * Link the FrameBuffers with the id (key value) in the map stored in\n> +\t * the RPi stream object - along with an identifer mask.\n> \t *\n> \t * This will allow us to identify buffers passed between the pipeline\n> \t * handler and the IPA.\n> \t */\n> -\tfor (auto const &b : data->isp_[Isp::Stats].getBuffers()) {\n> -\t\tdata->ipaBuffers_.push_back({ .id = RPiIpaMask::STATS | b.first,\n> -\t\t\t\t\t .planes = b.second->planes() });\n> -\t}\n> -\n> -\tfor (auto const &b : data->unicam_[Unicam::Embedded].getBuffers()) {\n> -\t\tdata->ipaBuffers_.push_back({ .id = RPiIpaMask::EMBEDDED_DATA | b.first,\n> -\t\t\t\t\t .planes = b.second->planes() });\n> +\tfor (auto const &it : buffers) {\n> +\t\tipaBuffers.push_back({ .id = mask | it.first,\n> +\t\t\t\t .planes = it.second->planes() });\n> +\t\tdata->ipaBuffers_.insert(mask | it.first);\n> \t}\n> \n> -\tdata->ipa_->mapBuffers(data->ipaBuffers_);\n> -\n> -\treturn 0;\n> +\tdata->ipa_->mapBuffers(ipaBuffers);\n> }\n> \n> void PipelineHandlerRPi::freeBuffers(Camera *camera)\n> {\n> \tRPiCameraData *data = cameraData(camera);\n> \n> -\tstd::vector ids;\n> -\tfor (IPABuffer &ipabuf : data->ipaBuffers_)\n> -\t\tids.push_back(ipabuf.id);\n> -\n> -\tdata->ipa_->unmapBuffers(ids);\n> +\t/* Copy the buffer ids from the unordered_set to a vector to pass to the IPA. */\n> +\tstd::vector ipaBuffers(data->ipaBuffers_.begin(), data->ipaBuffers_.end());\n> +\tdata->ipa_->unmapBuffers(ipaBuffers);\n> \tdata->ipaBuffers_.clear();\n> \n> \tfor (auto const stream : data->streams_)\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FAD5C3B5B\n\tfor ;\n\tSat, 12 Sep 2020 14:48:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92F6962D86;\n\tSat, 12 Sep 2020 16:48:26 +0200 (CEST)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D70762C8C\n\tfor ;\n\tSat, 12 Sep 2020 16:48:25 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id z19so8835770lfr.4\n\tfor ;\n\tSat, 12 Sep 2020 07:48:25 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t123sm1413154lfo.7.2020.09.12.07.48.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 12 Sep 2020 07:48:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"F8VTSJ4J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=37dyzLTwkNSkySd/LMPhSy7vZrI3jhAHIa8ht6WXfNA=;\n\tb=F8VTSJ4Jlc2cQcHioUTMVWHGjAYoW6wCePVBGPvVQIksX9Io9wUQp16Oe1UoBexqVH\n\tjTtRs1YXiJONCpJWaSFBLtUni3DJDxZP1cWvgTlcfpCdm85lCVDX6KMTJ9wwAVGSBHVj\n\tSK8rvU2eUbrGreQcSKO0y/N2gMOtIj6Cwjv5wB4w9xEJU71tA2TLt2lq5jYC23ka6qvk\n\tUMatOy/zIAqMSkDI7kQt1p6BysKlrFd/j64PX4RcghaLBybaU0YXpQytD/f+eFGdZhdk\n\t8pKpUz7VomEgxEiE9zWiHqpV28h66Npq9uP5dd4U2KJ5qjfdVNKSeQzOKYOeFlieAhw6\n\tnFgQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=37dyzLTwkNSkySd/LMPhSy7vZrI3jhAHIa8ht6WXfNA=;\n\tb=r9LIBZDwXs1rUURWU/Blpzbtpj7cB+y7MutPl6RzM6Selk8RkLLQzsnS8LU+UhRxxT\n\tOSonJQlOu0U0Xfy0Z8ggIu/d6VKlWJSo4/19EDEAsKMa7wqUCGPGcwRps8KY3XtS46G5\n\tzup+fOOit8Am08sbgMEXzax/R/Qk2J1jQVu4Z0u/2wNAkJjEYM+rtt3E8s8GFsJyeIhy\n\trSJDxDXAhAf3LBxNgT7mHIe73kt6XgcbZNzib4z2UjxbIdT85jhBAAOUStclAbApvk2D\n\tKdksEdCEhHJ1NE6bQlAvpcXHD6dC9L1xOsp79HvVNRZnhZ9wnfOId+qPY7zrJ1Q5nb4h\n\t468A==","X-Gm-Message-State":"AOAM5335ZOuOlT1hwX8THC5l9oir3R3f/eRSiuRXohIHFWqq1Z11i8uf\n\tbIIEht7IX9EDBIjDFyQrjChSOA==","X-Google-Smtp-Source":"ABdhPJxhlBVwhGt+ly6E2KTAmiway+3LHWgRgrn+2YhT36fGzTt8g22Bf7E0M+wSYHpYlJFyQbRqwQ==","X-Received":"by 2002:a19:4bd6:: with SMTP id\n\ty205mr2384816lfa.182.1599922104610; \n\tSat, 12 Sep 2020 07:48:24 -0700 (PDT)","Date":"Sat, 12 Sep 2020 16:48:23 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Naushir Patuck ","Message-ID":"<20200912144823.GC695456@oden.dyn.berto.se>","References":"<20200908074913.109244-1-naush@raspberrypi.com>\n\t<20200908074913.109244-12-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200908074913.109244-12-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v7 11/12] pipeline: raspberrypi: Use\n\tan unordered_set to store IPA buffer ids","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12523,"web_url":"https://patchwork.libcamera.org/comment/12523/","msgid":"","date":"2020-09-15T13:48:39","subject":"Re: [libcamera-devel] [PATCH v7 11/12] pipeline: raspberrypi: Use\n\tan unordered_set to store IPA buffer ids","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 08/09/2020 08:49, Naushir Patuck wrote:\n> By using a set container, we can easily insert/remove buffer ids that have\n> been mmaped by the IPA. This will be required to track buffers allocated\n> externally and passed to the pipeline handler through a Request.\n> \n> Move the IPA buffer mapping code into a function to remove duplicated\n> code.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> .../pipeline/raspberrypi/raspberrypi.cpp | 48 +++++++++++--------\n> 1 file changed, 28 insertions(+), 20 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 6aa13034..5621f182 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -10,6 +10,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> #include \n> @@ -158,8 +159,8 @@ public:\n> \tRPi::RPiDevice isp_;\n> \t/* The vector below is just for convenience when iterating over all streams. */\n> \tstd::vector streams_;\n> -\t/* Buffers passed to the IPA. */\n> -\tstd::vector ipaBuffers_;\n> +\t/* Stores the ids of the buffers mapped in the IPA. */\n> +\tstd::unordered_set ipaBuffers_;\n> \n> \t/* DMAHEAP allocation helper. */\n> \tRPi::DmaHeap dmaHeap_;\n> @@ -230,6 +231,7 @@ private:\n> \tint queueAllBuffers(Camera *camera);\n> \tint prepareBuffers(Camera *camera);\n> \tvoid freeBuffers(Camera *camera);\n> +\tvoid mapBuffers(Camera *camera, const RPi::BufferMap &buffers, unsigned int mask);\n> \n> \tMediaDevice *unicam_;\n> \tMediaDevice *isp_;\n> @@ -910,36 +912,42 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera)\n> \t}\n> \n> \t/*\n> -\t * Link the FrameBuffers with the index of their position in the vector\n> -\t * stored in the RPi stream object.\n> +\t * Pass the stats and embedded data buffers to the IPA. No other\n> +\t * buffers need to be passed.\n> +\t */\n> +\tmapBuffers(camera, data->isp_[Isp::Stats].getBuffers(), RPiIpaMask::STATS);\n> +\tmapBuffers(camera, data->unicam_[Unicam::Embedded].getBuffers(), RPiIpaMask::EMBEDDED_DATA);\n> +\n> +\treturn 0;\n> +}\n> +\n> +void PipelineHandlerRPi::mapBuffers(Camera *camera, const RPi::BufferMap &buffers, unsigned int mask)\n> +{\n> +\tRPiCameraData *data = cameraData(camera);\n> +\tstd::vector ipaBuffers;\n> +\t/*\n> +\t * Link the FrameBuffers with the id (key value) in the map stored in\n> +\t * the RPi stream object - along with an identifer mask.\n\nTrivial nit: s/identifer/identifier/\n\nHopefully that can be fixed while applying.\n\nReviewed-by: Kieran Bingham \n\n> \t *\n> \t * This will allow us to identify buffers passed between the pipeline\n> \t * handler and the IPA.\n> \t */\n> -\tfor (auto const &b : data->isp_[Isp::Stats].getBuffers()) {\n> -\t\tdata->ipaBuffers_.push_back({ .id = RPiIpaMask::STATS | b.first,\n> -\t\t\t\t\t .planes = b.second->planes() });\n> -\t}\n> -\n> -\tfor (auto const &b : data->unicam_[Unicam::Embedded].getBuffers()) {\n> -\t\tdata->ipaBuffers_.push_back({ .id = RPiIpaMask::EMBEDDED_DATA | b.first,\n> -\t\t\t\t\t .planes = b.second->planes() });\n> +\tfor (auto const &it : buffers) {\n> +\t\tipaBuffers.push_back({ .id = mask | it.first,\n> +\t\t\t\t .planes = it.second->planes() });\n> +\t\tdata->ipaBuffers_.insert(mask | it.first);\n> \t}\n> \n> -\tdata->ipa_->mapBuffers(data->ipaBuffers_);\n> -\n> -\treturn 0;\n> +\tdata->ipa_->mapBuffers(ipaBuffers);\n> }\n> \n> void PipelineHandlerRPi::freeBuffers(Camera *camera)\n> {\n> \tRPiCameraData *data = cameraData(camera);\n> \n> -\tstd::vector ids;\n> -\tfor (IPABuffer &ipabuf : data->ipaBuffers_)\n> -\t\tids.push_back(ipabuf.id);\n> -\n> -\tdata->ipa_->unmapBuffers(ids);\n> +\t/* Copy the buffer ids from the unordered_set to a vector to pass to the IPA. */\n> +\tstd::vector ipaBuffers(data->ipaBuffers_.begin(), data->ipaBuffers_.end());\n> +\tdata->ipa_->unmapBuffers(ipaBuffers);\n> \tdata->ipaBuffers_.clear();\n> \n> \tfor (auto const stream : data->streams_)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8770BF01C\n\tfor ;\n\tTue, 15 Sep 2020 13:48:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3122C62E13;\n\tTue, 15 Sep 2020 15:48:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04BF76036C\n\tfor ;\n\tTue, 15 Sep 2020 15:48:45 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA97A275;\n\tTue, 15 Sep 2020 15:48:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RKmfuaVZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600177723;\n\tbh=l0piP4NIEDNFfRWL0kinDgO9jemlsf0iHnXkmH8JCGQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=RKmfuaVZRWZSK3iv5PsynZgrpEY1ukRvS0hBSY90WBffcOjl7E2xj6qs1H/2sPwph\n\tfqsxtEPV/dxjhWyJYg/MKVUeCez64ajhpFFUHLRC48wsrEL5SHJL9u5nHmReNIwEWQ\n\trXPyZ2cIcuME5858iCPYNtPOFhBItDiuIaQo99Lo=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200908074913.109244-1-naush@raspberrypi.com>\n\t<20200908074913.109244-12-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 15 Sep 2020 14:48:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200908074913.109244-12-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v7 11/12] pipeline: raspberrypi: Use\n\tan unordered_set to store IPA buffer ids","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]