{"id":9523,"url":"https://patchwork.libcamera.org/api/patches/9523/?format=json","web_url":"https://patchwork.libcamera.org/patch/9523/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200908074913.109244-8-naush@raspberrypi.com>","date":"2020-09-08T07:49:07","name":"[libcamera-devel,v7,07/12] libcamera: pipeline: raspberrypi: Fix bug in passing configuration to IPA","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ef49a90f1640831fa6144d3171847607fbe9e2bd","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9523/mbox/","series":[{"id":1271,"url":"https://patchwork.libcamera.org/api/series/1271/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1271","date":"2020-09-08T07:49:00","name":"Zero-copy RAW stream work","version":7,"mbox":"https://patchwork.libcamera.org/series/1271/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9523/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9523/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB8F2BDB1C\n\tfor ;\n\tTue, 8 Sep 2020 07:49:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8133D62C11;\n\tTue, 8 Sep 2020 09:49:27 +0200 (CEST)","from mail-wr1-x441.google.com (mail-wr1-x441.google.com\n\t[IPv6:2a00:1450:4864:20::441])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04FAC60534\n\tfor ;\n\tTue, 8 Sep 2020 09:49:26 +0200 (CEST)","by mail-wr1-x441.google.com with SMTP id z4so18025383wrr.4\n\tfor ;\n\tTue, 08 Sep 2020 00:49:26 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tq15sm32534502wrr.8.2020.09.08.00.49.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 08 Sep 2020 00:49:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ak0IohM9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=HY410+IGo+p0b3nplNTrR4E7HZ5Bkkrqd9Tftr8OvXc=;\n\tb=ak0IohM92t0pdyKbWRuv3xwnmC6CSCrYJTkHCGjDuWzxuXz6ehvlsObnfxS4dVKl1i\n\tO8qHwaQbIi5C0scgopOz47P94T8daHy6kKVeL5+foovcWv9iwcr8P0j9A8Q5oL6f/pPs\n\tWTMq4lT1D2mDAZNSzBmeE6Irv4stq8zJhCQMlAuy+gLlMYBrfsgI2TIY1AnjbnMyU7vH\n\t6eKkmb4ifMauS1/yGTt+kpJCKM8EB/z4UOybVKBZNTofRuXRjIEdIBWPxFwWnJL07SX5\n\tBSAKXGMcLnZKvdvlInyKNEUvnGnS1H8XHh/2vh/49sXmcUnJYyp+H8p0+NRlOEyqioNd\n\tSZfw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=HY410+IGo+p0b3nplNTrR4E7HZ5Bkkrqd9Tftr8OvXc=;\n\tb=Tli8vgF6ToOiSlkK1Af1Tv9zY1Vtk0iGo2o8mJ0Rrbz8HiXmjGVUQD2RLevWdCBTp6\n\tYL5iMV013FYrThIenLv2qB4aQskdVxlv0EOkGWQFZ/N7AVnrvG6DW0SfQN29QkXNGuPA\n\tsEi8VPESkApnk9BVhRT3RS6FXZCAsKLtNNfe5Euang9TRy0z6O3dzOaiDpktr8gBU6aX\n\tbCYaEiMBXEf/2pZ+iwZ8DP9VYwidbqTQ+a9J+57neU8xwf3lDvbohpE35RMudwiwD09h\n\tAqIL8K0knQZWROSgWNkMKW+JZRSVdVeW1qYx5wkTmaWEFivyGrkV6EfjwltS9YIQjS42\n\t/48A==","X-Gm-Message-State":"AOAM531SqAuHd9iLBWIchk4q4vf/2iM1z6Vdv3C1s/WryxHDv6nfXRg1\n\tBnWVCC248Ka7nbiLrzVNUrjFMdsfzl9Y5Q==","X-Google-Smtp-Source":"ABdhPJxeXupKueWC12zhsxHP4BMPEg6SHIN6BtpOUkHnHby6YJ11vKx0HJKJdj1PpjpIsn+27shO/A==","X-Received":"by 2002:a5d:50c3:: with SMTP id\n\tf3mr24915254wrt.125.1599551365417; \n\tTue, 08 Sep 2020 00:49:25 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 8 Sep 2020 08:49:07 +0100","Message-Id":"<20200908074913.109244-8-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200908074913.109244-1-naush@raspberrypi.com>","References":"<20200908074913.109244-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v7 07/12] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The counter was not incremented, so multiple streams would only pass the\nlast stream config to the IPA.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nTested-by: David Plowman \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex ea61df27..2a876c3e 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -992,12 +992,13 @@ int RPiCameraData::configureIPA()\n \tunsigned int i = 0;\n \tfor (auto const &stream : isp_) {\n \t\tif (stream.isExternal()) {\n-\t\t\tstreamConfig[i] = {\n+\t\t\tstreamConfig[i++] = {\n \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n \t\t\t\t.size = stream.configuration().size\n \t\t\t};\n \t\t}\n \t}\n+\n \tentityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n \tentityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n \n","prefixes":["libcamera-devel","v7","07/12"]}