[{"id":12310,"web_url":"https://patchwork.libcamera.org/comment/12310/","msgid":"<20200904204355.GN14354@scaer>","date":"2020-09-04T20:43:55","subject":"Re: [libcamera-devel] [PATCH v2] package/libcamera: bump version to\n\te59713c6","submitter":{"id":11,"url":"https://patchwork.libcamera.org/api/people/11/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Kieran, All,\n\nOn 2020-09-04 15:01 +0100, Kieran Bingham spake thusly:\n> The libcamera project has moved to C++17, therefore also update the\n> toolchain requirements accordingly.\n> \n> Signed-off-by: Kieran Bingham \n\nApplied tom aster, thanks. But see below for a nit...\n\n> ---\n> package/libcamera/Config.in | 6 +++---\n> package/libcamera/libcamera.hash | 2 +-\n> package/libcamera/libcamera.mk | 2 +-\n> 3 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in\n> index 1ea747d1c57e..262ea49a0ead 100644\n> --- a/package/libcamera/Config.in\n> +++ b/package/libcamera/Config.in\n> @@ -2,7 +2,7 @@ menuconfig BR2_PACKAGE_LIBCAMERA\n> \tbool \"libcamera\"\n> \tdepends on BR2_INSTALL_LIBSTDCPP\n> \tdepends on BR2_TOOLCHAIN_HAS_THREADS\n> -\tdepends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14\n> +\tdepends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17\n> \tdepends on !BR2_STATIC_LIBS # gnutls\n> \tdepends on BR2_USE_WCHAR # gnutls\n> \t# Invalid packing size of ControlValue struct on m68k\n> @@ -65,6 +65,6 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_VIMC\n> \n> endif # BR2_PACKAGE_LIBCAMERA\n> \n> -comment \"libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 5\"\n> +comment \"libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7\"\n> \tdepends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \\\n> -\t\t!BR2_TOOLCHAIN_GCC_AT_LEAST_5 || BR2_STATIC_LIBS || !BR2_USE_WCHAR\n> +\t\t!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR\n> diff --git a/package/libcamera/libcamera.hash b/package/libcamera/libcamera.hash\n> index 676d3ac73907..bc9122315166 100644\n> --- a/package/libcamera/libcamera.hash\n> +++ b/package/libcamera/libcamera.hash\n> @@ -1,4 +1,4 @@\n> -sha256 55b7d7e5d8c70b2586b31544e6c4891a994c4e69c18d0ebd760e87b75277c348 libcamera-565f95d64ff92e8712e8090988180c343dd3bcb5.tar.gz\n> +sha256\ta7800b54584dee321874610ef70b1b7690c79d8340c5b134ea35176657681e29 libcamera-e59713c68678f3eb6b6ebe97cabdc88c7042567f.tar.gz\n\nYou reintroduce a TAB in lieue of two spaces, so I fixed that when\napplying.\n\nThanks!\n\nRegards,\nYann E. MORIN.\n\n> # license files\n> sha256 fd38b2c053c0cce46d9c5ef3545a6e34d157a240ba99c9b8dca5d37a8147da6c LICENSES/BSD-2-Clause.txt\n> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk\n> index 4a4bc4ea90aa..e6cd71420774 100644\n> --- a/package/libcamera/libcamera.mk\n> +++ b/package/libcamera/libcamera.mk\n> @@ -5,7 +5,7 @@\n> ################################################################################\n> \n> LIBCAMERA_SITE = https://git.linuxtv.org/libcamera.git\n> -LIBCAMERA_VERSION = 565f95d64ff92e8712e8090988180c343dd3bcb5\n> +LIBCAMERA_VERSION = e59713c68678f3eb6b6ebe97cabdc88c7042567f\n> LIBCAMERA_SITE_METHOD = git\n> LIBCAMERA_DEPENDENCIES = \\\n> \thost-openssl \\\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49419BE174\n\tfor ;\n\tFri, 4 Sep 2020 20:44:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAEE462B5B;\n\tFri, 4 Sep 2020 22:44:05 +0200 (CEST)","from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D95260599\n\tfor ;\n\tFri, 4 Sep 2020 22:44:04 +0200 (CEST)","from ymorin.is-a-geek.org (unknown\n\t[IPv6:2a01:cb19:8b51:cb00:5967:c4ae:80bb:c858])\n\t(Authenticated sender: yann.morin.1998)\n\tby smtp3-g21.free.fr (Postfix) with ESMTPSA id 005E913F89C;\n\tFri, 4 Sep 2020 22:43:55 +0200 (CEST)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tFri, 04 Sep 2020 22:43:55 +0200"],"Date":"Fri, 4 Sep 2020 22:43:55 +0200","From":"\"Yann E. MORIN\" ","To":"Kieran Bingham ","Message-ID":"<20200904204355.GN14354@scaer>","References":"<20200904140129.938216-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200904140129.938216-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.5.22 (2013-10-16)","Subject":"Re: [libcamera-devel] [PATCH v2] package/libcamera: bump version to\n\te59713c6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tThomas Petazzoni , buildroot@buildroot.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]