{"id":9492,"url":"https://patchwork.libcamera.org/api/patches/9492/?format=json","web_url":"https://patchwork.libcamera.org/patch/9492/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200904103042.1593-3-david.plowman@raspberrypi.com>","date":"2020-09-04T10:30:36","name":"[libcamera-devel,v7,2/8] libcamera: Allow access to v4l2_query_ext_ctrl structure for a V4L2 control","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b5e8c109142ba2d33dd396c5f9721b1670db5af9","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9492/mbox/","series":[{"id":1265,"url":"https://patchwork.libcamera.org/api/series/1265/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1265","date":"2020-09-04T10:30:34","name":"2D transforms","version":7,"mbox":"https://patchwork.libcamera.org/series/1265/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9492/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9492/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC3E5BE174\n\tfor ;\n\tFri, 4 Sep 2020 10:30:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE81F629E4;\n\tFri, 4 Sep 2020 12:30:49 +0200 (CEST)","from mail-wr1-x443.google.com (mail-wr1-x443.google.com\n\t[IPv6:2a00:1450:4864:20::443])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D09FC628EE\n\tfor ;\n\tFri, 4 Sep 2020 12:30:48 +0200 (CEST)","by mail-wr1-x443.google.com with SMTP id m6so6255821wrn.0\n\tfor ;\n\tFri, 04 Sep 2020 03:30:48 -0700 (PDT)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tq4sm10294542wru.65.2020.09.04.03.30.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 04 Sep 2020 03:30:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"r642ngf3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=2r26cquJvFEGijK6A1Qt2id7HpC8ABt6M/5TpJ40vpQ=;\n\tb=r642ngf37LSt1rMNCTHXcsFSgpatXnqpsOPMm8SX5fkVqftbzI/gJ717t3LHd2dg2D\n\tXuhRiaUhwVJheVBqLkvOndgXIo6cA4esZGh1HNk4KmVKG3+BTcDVrmiBJYlb1t1DlJzM\n\t3njAh0vOpMcGy1e+Stp3EwAaguUEMKzpfvTNd69G0V70/1BJUZhhFGpMpFeNxC4TDtO4\n\taH9i3sDtLAJWgMI11d3q+LvFRbiA8c7Fyuu7hZaZQNp6ZkZCPfeTtnlsXQYUEVrdeqBH\n\tJgT99GjUB25K5xA7e34cJJteAi7h2Q0JNW6qPJwrlRA5fiFc2d8s2C5YIugkitO0io56\n\tLNYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=2r26cquJvFEGijK6A1Qt2id7HpC8ABt6M/5TpJ40vpQ=;\n\tb=hd1KrTuZKX56atJsY7Eijf5c1YDPXoz6ikhXh4M2TI40ABeLHu1DR2wW/Yd3g9jAx9\n\tE4NvoTsM+znhCOZx7nibtiUbpcx+wn0v9KddWvnBMgQrNFh9wy3JUBQJzPpCthNNUlRm\n\tFqmIs01MCQPy5R1R7UOy0D3ppVkkQfVs8hAsWeGeftLHTHPEPkI/j302JceSCz06u4sf\n\tFlzSUfaDO4r15alWSgAzUGTvfre3eNeIXwBRheh0/GddzaY4tRI3cd28cIHg1ybfyNo/\n\tHgUyELe2aG/QLiB/9FjGxP36sJo9rCEj02P5HiOFUJG9EKK9qxWaozIyHOJ+qDRg8T2b\n\tOaMQ==","X-Gm-Message-State":"AOAM533x/Ezh9bcCp0+5ORlNRs3gl8StZpHFUVbuXzWEtXDRod7LZMbB\n\tOh22rrYvxDtmlGX4orFYF9K+7moabaTstw==","X-Google-Smtp-Source":"ABdhPJyIHihT6aeCPunHX2VKJZJ+iA/ZRY70JdyjUw4Wr7kmw3lNG8AHDIsKhG3jxHfY2rSeuAM0gg==","X-Received":"by 2002:adf:fa02:: with SMTP id m2mr6898860wrr.273.1599215448275;\n\tFri, 04 Sep 2020 03:30:48 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 4 Sep 2020 11:30:36 +0100","Message-Id":"<20200904103042.1593-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20200904103042.1593-1-david.plowman@raspberrypi.com>","References":"<20200904103042.1593-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v7 2/8] libcamera: Allow access to\n\tv4l2_query_ext_ctrl structure for a V4L2 control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The V4L2Device::controlInfo method simply returns a pointer to the\nv4l2_query_ext_ctrl structure for the given control, which has already\nbeen retrieved and stored.\n\nSigned-off-by: David Plowman \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n include/libcamera/internal/v4l2_device.h | 2 ++\n src/libcamera/v4l2_device.cpp | 15 +++++++++++++++\n 2 files changed, 17 insertions(+)","diff":"diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex 3b605aa..722fb72 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -29,6 +29,8 @@ public:\n \tControlList getControls(const std::vector &ids);\n \tint setControls(ControlList *ctrls);\n \n+\tconst struct v4l2_query_ext_ctrl *controlInfo(uint32_t id) const;\n+\n \tconst std::string &deviceNode() const { return deviceNode_; }\n \tstd::string devicePath() const;\n \ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 65830d4..e8399c4 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -353,6 +353,21 @@ int V4L2Device::setControls(ControlList *ctrls)\n \treturn ret;\n }\n \n+/**\n+ * \\brief Return the v4l2_query_ext_ctrl information for the given control.\n+ * \\param[in] id The V4L2 control id\n+ * \\return A pointer to the v4l2_query_ext_ctrl structure for the given\n+ * control, or a null pointer if not found\n+ */\n+const struct v4l2_query_ext_ctrl *V4L2Device::controlInfo(uint32_t id) const\n+{\n+\tconst auto it = controlInfo_.find(id);\n+\tif (it == controlInfo_.end())\n+\t\treturn nullptr;\n+\n+\treturn &it->second;\n+}\n+\n /**\n * \\brief Retrieve the device path in sysfs\n *\n","prefixes":["libcamera-devel","v7","2/8"]}