[{"id":12297,"web_url":"https://patchwork.libcamera.org/comment/12297/","msgid":"<7162b8ae-d23e-803d-a884-92783a960978@ideasonboard.com>","date":"2020-09-04T12:52:35","subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Thomas,\n\nOn 04/09/2020 13:50, Thomas Petazzoni wrote:\n> On Fri, 4 Sep 2020 10:51:45 +0100\n> Kieran Bingham wrote:\n> \n>> The ControlValue structure is currently defined with a 16-bit hole\n>> (causing unaligned access to the numElements_ field, though that's a\n>> separate topic).\n>>\n>> This structure has a static assertion to ensure that its size does not\n>> change without due care, as it forms part of our ABI and is used in\n>> Serialisation between the pipeline handlers and IPA componenents.\n>>\n>> The m68k architecture is the only target which fails this assertion,\n>> which is likely because it can pack the structure more efficiently,\n>> producing a different binary size.\n>>\n>> This is likely an area we will tackle before stabilising our ABI, but\n>> until then, disable m68k builds as libcamera is not expected to be\n>> supported on this target.\n>>\n>> Signed-off-by: Kieran Bingham \n> \n> We normally ask to have an autobuilder failure reference here. No need\n> to resend just for that, we can add it when applying.\n\nSorry, I didn't realise. But don't worry -there are plenty ;-)\n\nHere's the latest:\n\n\n> Results for the '2020.08.x' branch\n> ----------------------------------\n> \n> Build failures related to your packages:\n> \n> arch | reason | url \n> -------------+--------------------------------+---------------------------------------------------------------------------------\n> m68k | libcamera-96fab38e02792a109... | http://autobuild.buildroot.net/results/9dce26e94299a2c61bba60cbc7803926e2f85e29","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EB84BF019\n\tfor ;\n\tFri, 4 Sep 2020 12:52:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 136CC62B5B;\n\tFri, 4 Sep 2020 14:52:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5B3362B2F\n\tfor ;\n\tFri, 4 Sep 2020 14:52:42 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F8BB540;\n\tFri, 4 Sep 2020 14:52:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mbyWgDmg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599223962;\n\tbh=D5msSvXtSrWsivQk6oL0G0KwKZe2YP28Y2FoOaj3gcE=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=mbyWgDmgTDI0dU/UPMG+8hf67x7J5piCmn8yA9nnQHwtZKxeTwW0gKwnaQIfUHUsX\n\tgR8rxnkIgGzDXIVValjffxGmb78YIm21iZSa1esQJUvE9xEY/bdRmSHbSby/Sp9usY\n\thhNRsLFWzLp9meDSz2v/nGDwgvfA7oclaVXutSgQ=","To":"Thomas Petazzoni ","References":"<20200904095148.844292-1-kieran.bingham@ideasonboard.com>\n\t<20200904095148.844292-2-kieran.bingham@ideasonboard.com>\n\t<20200904145046.46cbb14c@windsurf.home>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7162b8ae-d23e-803d-a884-92783a960978@ideasonboard.com>","Date":"Fri, 4 Sep 2020 13:52:35 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200904145046.46cbb14c@windsurf.home>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ,\n\tbuildroot@buildroot.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12298,"web_url":"https://patchwork.libcamera.org/comment/12298/","msgid":"<20200904145046.46cbb14c@windsurf.home>","date":"2020-09-04T12:50:46","subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","submitter":{"id":13,"url":"https://patchwork.libcamera.org/api/people/13/","name":"Thomas Petazzoni","email":"thomas.petazzoni@bootlin.com"},"content":"On Fri, 4 Sep 2020 10:51:45 +0100\nKieran Bingham wrote:\n\n> The ControlValue structure is currently defined with a 16-bit hole\n> (causing unaligned access to the numElements_ field, though that's a\n> separate topic).\n> \n> This structure has a static assertion to ensure that its size does not\n> change without due care, as it forms part of our ABI and is used in\n> Serialisation between the pipeline handlers and IPA componenents.\n> \n> The m68k architecture is the only target which fails this assertion,\n> which is likely because it can pack the structure more efficiently,\n> producing a different binary size.\n> \n> This is likely an area we will tackle before stabilising our ABI, but\n> until then, disable m68k builds as libcamera is not expected to be\n> supported on this target.\n> \n> Signed-off-by: Kieran Bingham \n\nWe normally ask to have an autobuilder failure reference here. No need\nto resend just for that, we can add it when applying.\n\nThanks!\n\nThomas","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8D45BF019\n\tfor ;\n\tFri, 4 Sep 2020 12:53:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7FDB9629CF;\n\tFri, 4 Sep 2020 14:53:34 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2767C6037B\n\tfor ;\n\tFri, 4 Sep 2020 14:50:48 +0200 (CEST)","from windsurf.home (lfbn-tou-1-420-199.w86-206.abo.wanadoo.fr\n\t[86.206.245.199])\n\t(Authenticated sender: thomas.petazzoni@bootlin.com)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AD1ECFF809;\n\tFri, 4 Sep 2020 12:50:47 +0000 (UTC)"],"X-Originating-IP":"86.206.245.199","Date":"Fri, 4 Sep 2020 14:50:46 +0200","From":"Thomas Petazzoni ","To":"Kieran Bingham ","Message-ID":"<20200904145046.46cbb14c@windsurf.home>","In-Reply-To":"<20200904095148.844292-2-kieran.bingham@ideasonboard.com>","References":"<20200904095148.844292-1-kieran.bingham@ideasonboard.com>\n\t<20200904095148.844292-2-kieran.bingham@ideasonboard.com>","Organization":"Bootlin","X-Mailer":"Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","X-Mailman-Approved-At":"Fri, 04 Sep 2020 14:53:32 +0200","Subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tbuildroot@buildroot.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12300,"web_url":"https://patchwork.libcamera.org/comment/12300/","msgid":"<20200904145237.0b1acf0d@windsurf.home>","date":"2020-09-04T12:52:37","subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","submitter":{"id":13,"url":"https://patchwork.libcamera.org/api/people/13/","name":"Thomas Petazzoni","email":"thomas.petazzoni@bootlin.com"},"content":"On Fri, 4 Sep 2020 10:51:45 +0100\nKieran Bingham wrote:\n\n> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in\n> index 960d78b82e95..1ea747d1c57e 100644\n> --- a/package/libcamera/Config.in\n> +++ b/package/libcamera/Config.in\n> @@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA\n> \tdepends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14\n> \tdepends on !BR2_STATIC_LIBS # gnutls\n> \tdepends on BR2_USE_WCHAR # gnutls\n> +\t# Invalid packing size of ControlValue struct on m68k\n> +\tdepends on !BR2_m68k\n\nAnother comment: this dependency should be replicated in the Config.in\ncomment for libcamera, so that the comment that says \"libcamera needs a\ntoolchain w/ ...\" doesn't appear on m68k... which would be meaningless\nas libcamera is not available at all for this architecture.\n\nIn general, we like to have:\n\nconfig BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS\n\tconfig\n\tdefault y\n\tdepends on !BR2_m68k\n\nand then use that in BR2_PACKAGE_LIBCAMERA and the Config.in comment.\nThis way, if other packages select libcamera, they can also re-use this\n\"depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS\".\n\nThomas","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5E3CBF019\n\tfor ;\n\tFri, 4 Sep 2020 12:53:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE79E62B69;\n\tFri, 4 Sep 2020 14:53:34 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1091C629CF\n\tfor ;\n\tFri, 4 Sep 2020 14:52:39 +0200 (CEST)","from windsurf.home (lfbn-tou-1-420-199.w86-206.abo.wanadoo.fr\n\t[86.206.245.199])\n\t(Authenticated sender: thomas.petazzoni@bootlin.com)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BA9B51C0002;\n\tFri, 4 Sep 2020 12:52:38 +0000 (UTC)"],"X-Originating-IP":"86.206.245.199","Date":"Fri, 4 Sep 2020 14:52:37 +0200","From":"Thomas Petazzoni ","To":"Kieran Bingham ","Message-ID":"<20200904145237.0b1acf0d@windsurf.home>","In-Reply-To":"<20200904095148.844292-2-kieran.bingham@ideasonboard.com>","References":"<20200904095148.844292-1-kieran.bingham@ideasonboard.com>\n\t<20200904095148.844292-2-kieran.bingham@ideasonboard.com>","Organization":"Bootlin","X-Mailer":"Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","X-Mailman-Approved-At":"Fri, 04 Sep 2020 14:53:32 +0200","Subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tbuildroot@buildroot.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12308,"web_url":"https://patchwork.libcamera.org/comment/12308/","msgid":"<20200904203358.GL14354@scaer>","date":"2020-09-04T20:33:58","subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","submitter":{"id":11,"url":"https://patchwork.libcamera.org/api/people/11/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Kieran, All,\n\nOn 2020-09-04 10:51 +0100, Kieran Bingham spake thusly:\n> The ControlValue structure is currently defined with a 16-bit hole\n> (causing unaligned access to the numElements_ field, though that's a\n> separate topic).\n> \n> This structure has a static assertion to ensure that its size does not\n> change without due care, as it forms part of our ABI and is used in\n> Serialisation between the pipeline handlers and IPA componenents.\n> \n> The m68k architecture is the only target which fails this assertion,\n> which is likely because it can pack the structure more efficiently,\n> producing a different binary size.\n> \n> This is likely an area we will tackle before stabilising our ABI, but\n> until then, disable m68k builds as libcamera is not expected to be\n> supported on this target.\n> \n> Signed-off-by: Kieran Bingham \n\nApplied to master, after doing the slight adjustments suggested by\nThomas:\n\n - introduce BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS\n - propagate that to the comment\n - add autobuilder reference\n\nThanks!\n\nRegards,\nYann E. MORIN.\n\n> ---\n> package/libcamera/Config.in | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in\n> index 960d78b82e95..1ea747d1c57e 100644\n> --- a/package/libcamera/Config.in\n> +++ b/package/libcamera/Config.in\n> @@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA\n> \tdepends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14\n> \tdepends on !BR2_STATIC_LIBS # gnutls\n> \tdepends on BR2_USE_WCHAR # gnutls\n> +\t# Invalid packing size of ControlValue struct on m68k\n> +\tdepends on !BR2_m68k\n> \tselect BR2_PACKAGE_GNUTLS\n> \tselect BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE\n> \thelp\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> buildroot mailing list\n> buildroot@busybox.net\n> http://lists.busybox.net/mailman/listinfo/buildroot","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E34EBE174\n\tfor ;\n\tFri, 4 Sep 2020 20:34:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A256F62B5B;\n\tFri, 4 Sep 2020 22:34:06 +0200 (CEST)","from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23ADC60599\n\tfor ;\n\tFri, 4 Sep 2020 22:34:05 +0200 (CEST)","from ymorin.is-a-geek.org (unknown\n\t[IPv6:2a01:cb19:8b51:cb00:5967:c4ae:80bb:c858])\n\t(Authenticated sender: yann.morin.1998)\n\tby smtp3-g21.free.fr (Postfix) with ESMTPSA id CDAEA13F7F0;\n\tFri, 4 Sep 2020 22:33:58 +0200 (CEST)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tFri, 04 Sep 2020 22:33:58 +0200"],"Date":"Fri, 4 Sep 2020 22:33:58 +0200","From":"\"Yann E. MORIN\" ","To":"Kieran Bingham ","Message-ID":"<20200904203358.GL14354@scaer>","References":"<20200904095148.844292-1-kieran.bingham@ideasonboard.com>\n\t<20200904095148.844292-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200904095148.844292-2-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.5.22 (2013-10-16)","Subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tbuildroot@buildroot.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12309,"web_url":"https://patchwork.libcamera.org/comment/12309/","msgid":"<20200904203613.GM14354@scaer>","date":"2020-09-04T20:36:13","subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","submitter":{"id":11,"url":"https://patchwork.libcamera.org/api/people/11/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Kieran, All,\n\nOn 2020-09-04 22:33 +0200, Yann E. MORIN spake thusly:\n> On 2020-09-04 10:51 +0100, Kieran Bingham spake thusly:\n> > The ControlValue structure is currently defined with a 16-bit hole\n> > (causing unaligned access to the numElements_ field, though that's a\n> > separate topic).\n> > \n> > This structure has a static assertion to ensure that its size does not\n> > change without due care, as it forms part of our ABI and is used in\n> > Serialisation between the pipeline handlers and IPA componenents.\n> > \n> > The m68k architecture is the only target which fails this assertion,\n> > which is likely because it can pack the structure more efficiently,\n> > producing a different binary size.\n> > \n> > This is likely an area we will tackle before stabilising our ABI, but\n> > until then, disable m68k builds as libcamera is not expected to be\n> > supported on this target.\n> > \n> > Signed-off-by: Kieran Bingham \n> \n> Applied to master, after doing the slight adjustments suggested by\n> Thomas:\n> \n> - introduce BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS\n> - propagate that to the comment\n> - add autobuilder reference\n\nAh, I forgot to note:\n - move the arch dependency to the top (indeed we like to have those\n dependencies first:\n https://buildroot.org/downloads/manual/manual.html#_config_files\n\nCheers!\n\nRegards,\nYann E. MORIN.\n\n> Thanks!\n> \n> Regards,\n> Yann E. MORIN.\n> \n> > ---\n> > package/libcamera/Config.in | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in\n> > index 960d78b82e95..1ea747d1c57e 100644\n> > --- a/package/libcamera/Config.in\n> > +++ b/package/libcamera/Config.in\n> > @@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA\n> > \tdepends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14\n> > \tdepends on !BR2_STATIC_LIBS # gnutls\n> > \tdepends on BR2_USE_WCHAR # gnutls\n> > +\t# Invalid packing size of ControlValue struct on m68k\n> > +\tdepends on !BR2_m68k\n> > \tselect BR2_PACKAGE_GNUTLS\n> > \tselect BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE\n> > \thelp\n> > -- \n> > 2.25.1\n> > \n> > _______________________________________________\n> > buildroot mailing list\n> > buildroot@busybox.net\n> > http://lists.busybox.net/mailman/listinfo/buildroot\n> \n> -- \n> .-----------------.--------------------.------------------.--------------------.\n> | Yann E. MORIN | Real-Time Embedded | /\"\\ ASCII RIBBON | Erics' conspiracy: |\n> | +33 662 376 056 | Software Designer | \\ / CAMPAIGN | ___ |\n> | +33 561 099 427 `------------.-------: X AGAINST | \\e/ There is no |\n> | http://ymorin.is-a-geek.org/ | _/*\\_ | / \\ HTML MAIL | v conspiracy. |\n> '------------------------------^-------^------------------^--------------------'\n> _______________________________________________\n> buildroot mailing list\n> buildroot@busybox.net\n> http://lists.busybox.net/mailman/listinfo/buildroot","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D72FBF019\n\tfor ;\n\tFri, 4 Sep 2020 20:36:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2670062B5B;\n\tFri, 4 Sep 2020 22:36:22 +0200 (CEST)","from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DF6260599\n\tfor ;\n\tFri, 4 Sep 2020 22:36:20 +0200 (CEST)","from ymorin.is-a-geek.org (unknown\n\t[IPv6:2a01:cb19:8b51:cb00:5967:c4ae:80bb:c858])\n\t(Authenticated sender: yann.morin.1998)\n\tby smtp3-g21.free.fr (Postfix) with ESMTPSA id 29E0713F879;\n\tFri, 4 Sep 2020 22:36:14 +0200 (CEST)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tFri, 04 Sep 2020 22:36:13 +0200"],"Date":"Fri, 4 Sep 2020 22:36:13 +0200","From":"\"Yann E. MORIN\" ","To":"Kieran Bingham ","Message-ID":"<20200904203613.GM14354@scaer>","References":"<20200904095148.844292-1-kieran.bingham@ideasonboard.com>\n\t<20200904095148.844292-2-kieran.bingham@ideasonboard.com>\n\t<20200904203358.GL14354@scaer>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200904203358.GL14354@scaer>","User-Agent":"Mutt/1.5.22 (2013-10-16)","Subject":"Re: [libcamera-devel] [Buildroot] [PATCH 1/3] package/libcamera:\n\tPrevent builds on m68k","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tbuildroot@buildroot.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12312,"web_url":"https://patchwork.libcamera.org/comment/12312/","msgid":"<87ft7wjtg2.fsf@dell.be.48ers.dk>","date":"2020-09-05T12:31:41","subject":"Re: [libcamera-devel] [PATCH 1/3] package/libcamera: Prevent builds\n\ton m68k","submitter":{"id":68,"url":"https://patchwork.libcamera.org/api/people/68/","name":"Peter Korsgaard","email":"peter@korsgaard.com"},"content":">>>>> \"Kieran\" == Kieran Bingham writes:\n\n > The ControlValue structure is currently defined with a 16-bit hole\n > (causing unaligned access to the numElements_ field, though that's a\n > separate topic).\n\n > This structure has a static assertion to ensure that its size does not\n > change without due care, as it forms part of our ABI and is used in\n > Serialisation between the pipeline handlers and IPA componenents.\n\n > The m68k architecture is the only target which fails this assertion,\n > which is likely because it can pack the structure more efficiently,\n > producing a different binary size.\n\n > This is likely an area we will tackle before stabilising our ABI, but\n > until then, disable m68k builds as libcamera is not expected to be\n > supported on this target.\n\n > Signed-off-by: Kieran Bingham \n\nCommitted to 2020.08.x, thanks.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBCE1BDB1D\n\tfor ;\n\tSat, 5 Sep 2020 15:31:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 410E5629B6;\n\tSat, 5 Sep 2020 17:31:55 +0200 (CEST)","from mail-ed1-x543.google.com (mail-ed1-x543.google.com\n\t[IPv6:2a00:1450:4864:20::543])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6855F62901\n\tfor ;\n\tSat, 5 Sep 2020 14:31:43 +0200 (CEST)","by mail-ed1-x543.google.com with SMTP id c8so8501778edv.5\n\tfor ;\n\tSat, 05 Sep 2020 05:31:43 -0700 (PDT)","from dell.be.48ers.dk (d51a5bc31.access.telenet.be.\n\t[81.165.188.49]) by smtp.gmail.com with ESMTPSA id\n\tch29sm8893537edb.74.2020.09.05.05.31.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 05 Sep 2020 05:31:42 -0700 (PDT)","from peko by dell.be.48ers.dk with local (Exim 4.92)\n\t(envelope-from )\n\tid 1kEXM5-0000tk-ML; Sat, 05 Sep 2020 14:31:41 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FT17KZBX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:references:date:in-reply-to:message-id\n\t:user-agent:mime-version;\n\tbh=J4/P9FgkbVbBLbSW67Bt0Y32nlWmoy+jypMO2NSWCh0=;\n\tb=FT17KZBX8ozATKSYjf9IRGwIZOmifVIdw5BpM/PWyfceHiQQzS1PY1Gb6/XwdbzQMo\n\tmhgijjdbuc6q0wNnc14nIIKJiY7cZLulB04nSPbxi5gceJoqDx9GZ/GE+QgCouR/yasL\n\t0BLYIxiosSKoCFI+Txoqw3WiV62pxEpLpiZZrAYmQ18Ntnp9Br9eGYcUDVdMeKnvf/yj\n\tuPYdsDo/cqPJd1qq87ui/vQqtXUTB+5v/58iiU4xwK6kgSOFuey719HYuDuc7rk9wwjt\n\tRMEN48h2iYehxZgkJPgkspJYbO5c3WJvNSJTYMLRrVBZdPcovRfDay7UBvX1XwzdnJTe\n\ti0dQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:references:date\n\t:in-reply-to:message-id:user-agent:mime-version;\n\tbh=J4/P9FgkbVbBLbSW67Bt0Y32nlWmoy+jypMO2NSWCh0=;\n\tb=LOhh87F2JCC4pITnWrCkCm1A3pYlNSkVQueLaG7Wul08R+f1N45A7OSYvhatSx4Zff\n\twOUvvSWmtofMO4EYSEFxwL5WsDOKwwjLVeX8u6Q5lnWlaNfVlMWVE/9IJ18dhQFtykGP\n\t8sg6GznQDSTDKm0w4eQ+uMq3Lf0kyw79KiOMXd7dIxxyY2kqVsJEkDPL8Pud96muCIAg\n\tvNsn6PYoUvIsGvoVRzMM/cSL1EgQKyUixNK29bqYocJf5bDZ+4c9e0dp3eSBbVNH3aym\n\tBq3CMjPuNieMj8H5/6Rw42Z4CUG7+jY89Rw9WqKREn8+nH8ZNhMV8A+IoK7sO5lwz56W\n\tETew==","X-Gm-Message-State":"AOAM532MEpdTEnezqUFj8KxOEnZ4KzL0LFaOOgpirNKUtfElnZJ2JFvn\n\tBXC1e/2dgY8AFwleBe3JVNE=","X-Google-Smtp-Source":"ABdhPJzJvodZ/KVTQnED+OpD68BgSFBfvZM5TDoLjb8dbcr76oEQtVCJkT2OJM1BmBj5X26CiO9Vsw==","X-Received":"by 2002:aa7:db47:: with SMTP id n7mr9142786edt.315.1599309103035;\n\tSat, 05 Sep 2020 05:31:43 -0700 (PDT)","From":"Peter Korsgaard ","To":"Kieran Bingham ","References":"<20200904095148.844292-1-kieran.bingham@ideasonboard.com>\n\t<20200904095148.844292-2-kieran.bingham@ideasonboard.com>","Date":"Sat, 05 Sep 2020 14:31:41 +0200","In-Reply-To":"<20200904095148.844292-2-kieran.bingham@ideasonboard.com>\n\t(Kieran Bingham's message of \"Fri, 4 Sep 2020 10:51:45 +0100\")","Message-ID":"<87ft7wjtg2.fsf@dell.be.48ers.dk>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)","MIME-Version":"1.0","X-Mailman-Approved-At":"Sat, 05 Sep 2020 17:31:54 +0200","Subject":"Re: [libcamera-devel] [PATCH 1/3] package/libcamera: Prevent builds\n\ton m68k","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tbuildroot@buildroot.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]