[{"id":12261,"web_url":"https://patchwork.libcamera.org/comment/12261/","msgid":"<0665fab1-9315-eacf-e9c1-c4acf5784e9f@ideasonboard.com>","date":"2020-09-02T13:27:31","subject":"Re: [libcamera-devel] [RFC 4/7] android: camera_device: Use Android\n\tformat","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 02/09/2020 14:08, Jacopo Mondi wrote:\n> We assumed HAL_PIXEL_FORMAT_BLOB is always mapped to libcamera::MJPEG\n> and at the moment this is true. To protect against future changes in the\n> mapping, inspect the Android format instead of the libcamera one.\n> \n\nI think I recall choosing to compare against the libcamera pixel format\n\"libcamera::MJPEG\" as I believed it was more readable/expressive than\n'HAL_PIXEL_FORMAT_BLOB' which means JPEG without saying 'j p e g'.\n\n\nAgain, no actual fault in this patch, just it's directly different to\nwhat I think was an active decision I had made previously.\n\n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 01f4b3a45566..a917404016e7 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1216,7 +1216,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\tstream->priv = static_cast(&streams_[i]);\n> \n> \t\t/* Defer handling of MJPEG streams until all others are known. */\n> -\t\tif (format == formats::MJPEG)\n> +\t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB)\n> \t\t\tcontinue;\n> \n> \t\tStreamConfiguration streamConfiguration;\n> @@ -1230,10 +1230,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t/* Now handle MJPEG streams, adding a new stream if required. */\n> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> -\t\tPixelFormat format = toPixelFormat(stream->format);\n> \t\tbool match = false;\n> \n> -\t\tif (format != formats::MJPEG)\n> +\t\tif (stream->format != HAL_PIXEL_FORMAT_BLOB)\n> \t\t\tcontinue;\n> \n> \t\t/* Search for a compatible stream */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80562BF019\n\tfor ;\n\tWed, 2 Sep 2020 13:27:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C03962931;\n\tWed, 2 Sep 2020 15:27:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A52B60374\n\tfor ;\n\tWed, 2 Sep 2020 15:27:35 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F1E49CC;\n\tWed, 2 Sep 2020 15:27:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PanTdFsy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599053254;\n\tbh=Pny+s2WPT4pi07sYwG1B8w7zWM5cY/CA6xfZNoksRlU=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=PanTdFsyW1/a1E5HqpWE9WPYK3Jubcf5UoETfrxzy3EuvYVd1Shvn8HgS71SOqoU0\n\t7CGAxWpaun5ogKQpUA6Oh6hZ8Aphy+NMyg/TWkl+VQzlLEje3sG4QsQRKZryk9WWiN\n\tRXUtDUNuS/t/lEecm8t1gHdnxNa3eEd2f4qvwI3k=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20200902130846.55910-1-jacopo@jmondi.org>\n\t<20200902130846.55910-5-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0665fab1-9315-eacf-e9c1-c4acf5784e9f@ideasonboard.com>","Date":"Wed, 2 Sep 2020 14:27:31 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200902130846.55910-5-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC 4/7] android: camera_device: Use Android\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"tfiga@google.com, hiroh@google.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12265,"web_url":"https://patchwork.libcamera.org/comment/12265/","msgid":"<20200902134541.j4wonvvptrybpo7e@uno.localdomain>","date":"2020-09-02T13:45:41","subject":"Re: [libcamera-devel] [RFC 4/7] android: camera_device: Use Android\n\tformat","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Wed, Sep 02, 2020 at 02:27:31PM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 02/09/2020 14:08, Jacopo Mondi wrote:\n> > We assumed HAL_PIXEL_FORMAT_BLOB is always mapped to libcamera::MJPEG\n> > and at the moment this is true. To protect against future changes in the\n> > mapping, inspect the Android format instead of the libcamera one.\n> >\n>\n> I think I recall choosing to compare against the libcamera pixel format\n> \"libcamera::MJPEG\" as I believed it was more readable/expressive than\n> 'HAL_PIXEL_FORMAT_BLOB' which means JPEG without saying 'j p e g'.\n>\n>\n> Again, no actual fault in this patch, just it's directly different to\n> what I think was an active decision I had made previously.\n\nI as well don't see a reson to make BLOB_ to anything different than\nMJPEG. But that's an assumption and could be a wrong one.\n\nAlso, future considerations apart, I think we're here iterating the\ncamera3_streams, and thus it makes sense to check for their\ncharacteristics instead using what we have built on top. Maybe it's a\nmatter of tastes...\n\n>\n>\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/camera_device.cpp | 5 ++---\n> > 1 file changed, 2 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 01f4b3a45566..a917404016e7 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1216,7 +1216,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > \t\tstream->priv = static_cast(&streams_[i]);\n> >\n> > \t\t/* Defer handling of MJPEG streams until all others are known. */\n> > -\t\tif (format == formats::MJPEG)\n> > +\t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB)\n> > \t\t\tcontinue;\n> >\n> > \t\tStreamConfiguration streamConfiguration;\n> > @@ -1230,10 +1230,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > \t/* Now handle MJPEG streams, adding a new stream if required. */\n> > \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> > \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> > -\t\tPixelFormat format = toPixelFormat(stream->format);\n> > \t\tbool match = false;\n> >\n> > -\t\tif (format != formats::MJPEG)\n> > +\t\tif (stream->format != HAL_PIXEL_FORMAT_BLOB)\n> > \t\t\tcontinue;\n> >\n> > \t\t/* Search for a compatible stream */\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB1E1BE174\n\tfor ;\n\tWed, 2 Sep 2020 13:41:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8836C629B2;\n\tWed, 2 Sep 2020 15:41:56 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCA5560374\n\tfor ;\n\tWed, 2 Sep 2020 15:41:55 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id DD46B24000B;\n\tWed, 2 Sep 2020 13:41:54 +0000 (UTC)"],"Date":"Wed, 2 Sep 2020 15:45:41 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200902134541.j4wonvvptrybpo7e@uno.localdomain>","References":"<20200902130846.55910-1-jacopo@jmondi.org>\n\t<20200902130846.55910-5-jacopo@jmondi.org>\n\t<0665fab1-9315-eacf-e9c1-c4acf5784e9f@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<0665fab1-9315-eacf-e9c1-c4acf5784e9f@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC 4/7] android: camera_device: Use Android\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"tfiga@google.com, libcamera-devel@lists.libcamera.org, hiroh@google.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12269,"web_url":"https://patchwork.libcamera.org/comment/12269/","msgid":"<57e00dd7-568b-701b-5119-492865525704@ideasonboard.com>","date":"2020-09-02T14:14:20","subject":"Re: [libcamera-devel] [RFC 4/7] android: camera_device: Use Android\n\tformat","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 02/09/2020 14:45, Jacopo Mondi wrote:\n> Hi Kieran\n> \n> On Wed, Sep 02, 2020 at 02:27:31PM +0100, Kieran Bingham wrote:\n>> Hi Jacopo,\n>>\n>> On 02/09/2020 14:08, Jacopo Mondi wrote:\n>>> We assumed HAL_PIXEL_FORMAT_BLOB is always mapped to libcamera::MJPEG\n>>> and at the moment this is true. To protect against future changes in the\n>>> mapping, inspect the Android format instead of the libcamera one.\n>>>\n>>\n>> I think I recall choosing to compare against the libcamera pixel format\n>> \"libcamera::MJPEG\" as I believed it was more readable/expressive than\n>> 'HAL_PIXEL_FORMAT_BLOB' which means JPEG without saying 'j p e g'.\n>>\n>>\n>> Again, no actual fault in this patch, just it's directly different to\n>> what I think was an active decision I had made previously.\n> \n> I as well don't see a reson to make BLOB_ to anything different than\n> MJPEG. But that's an assumption and could be a wrong one.\n> \n> Also, future considerations apart, I think we're here iterating the\n> camera3_streams, and thus it makes sense to check for their\n> characteristics instead using what we have built on top. Maybe it's a\n> matter of tastes...\n\nPossibly, anyway, I wouldn't block this patch. Like I said - this is\nstill correct - just different from how I did it. So if you want to keep it:\n\nReviewed-by: Kieran Bingham \n\n> \n>>\n>>\n>>> Signed-off-by: Jacopo Mondi \n>>> ---\n>>> src/android/camera_device.cpp | 5 ++---\n>>> 1 file changed, 2 insertions(+), 3 deletions(-)\n>>>\n>>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>>> index 01f4b3a45566..a917404016e7 100644\n>>> --- a/src/android/camera_device.cpp\n>>> +++ b/src/android/camera_device.cpp\n>>> @@ -1216,7 +1216,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>>> \t\tstream->priv = static_cast(&streams_[i]);\n>>>\n>>> \t\t/* Defer handling of MJPEG streams until all others are known. */\n>>> -\t\tif (format == formats::MJPEG)\n>>> +\t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB)\n>>> \t\t\tcontinue;\n>>>\n>>> \t\tStreamConfiguration streamConfiguration;\n>>> @@ -1230,10 +1230,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>>> \t/* Now handle MJPEG streams, adding a new stream if required. */\n>>> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n>>> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n>>> -\t\tPixelFormat format = toPixelFormat(stream->format);\n>>> \t\tbool match = false;\n>>>\n>>> -\t\tif (format != formats::MJPEG)\n>>> +\t\tif (stream->format != HAL_PIXEL_FORMAT_BLOB)\n>>> \t\t\tcontinue;\n>>>\n>>> \t\t/* Search for a compatible stream */\n>>>\n>>\n>> --\n>> Regards\n>> --\n>> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7A28BF019\n\tfor ;\n\tWed, 2 Sep 2020 14:14:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 692B562984;\n\tWed, 2 Sep 2020 16:14:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 200F260374\n\tfor ;\n\tWed, 2 Sep 2020 16:14:25 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8C149CC;\n\tWed, 2 Sep 2020 16:14:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qM4CzVxL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599056063;\n\tbh=3IjFSU1Amo7rBAA6AB6eR1fbOD6dRMDh7w98aqCGzMs=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=qM4CzVxLZ99RJ+Oa0TywLFAaJkM0xMAPDJYWlTeZc0Wl6MyB6kn/0VtCV7eYjBBPi\n\tDgKrjhPcNEP0gOGiYL+oybVyOjuT3xaaeUaRmmJGolZciPp6cHaDtbtWB95f1xW7R8\n\tFjlcCigjBoZwV23+SHsaUET600bHSsWvyb4kd1ow=","To":"Jacopo Mondi ","References":"<20200902130846.55910-1-jacopo@jmondi.org>\n\t<20200902130846.55910-5-jacopo@jmondi.org>\n\t<0665fab1-9315-eacf-e9c1-c4acf5784e9f@ideasonboard.com>\n\t<20200902134541.j4wonvvptrybpo7e@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<57e00dd7-568b-701b-5119-492865525704@ideasonboard.com>","Date":"Wed, 2 Sep 2020 15:14:20 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200902134541.j4wonvvptrybpo7e@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC 4/7] android: camera_device: Use Android\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"tfiga@google.com, libcamera-devel@lists.libcamera.org, hiroh@google.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12291,"web_url":"https://patchwork.libcamera.org/comment/12291/","msgid":"<20200904061602.GF1498632@oden.dyn.berto.se>","date":"2020-09-04T06:16:02","subject":"Re: [libcamera-devel] [RFC 4/7] android: camera_device: Use Android\n\tformat","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2020-09-02 15:08:43 +0200, Jacopo Mondi wrote:\n> We assumed HAL_PIXEL_FORMAT_BLOB is always mapped to libcamera::MJPEG\n> and at the moment this is true. To protect against future changes in the\n> mapping, inspect the Android format instead of the libcamera one.\n> \n> Signed-off-by: Jacopo Mondi \n\nI have no strong opinion on this solution or the existing one as pointed \nout by Kieran, but for what it's worth.\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 01f4b3a45566..a917404016e7 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1216,7 +1216,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\tstream->priv = static_cast(&streams_[i]);\n> \n> \t\t/* Defer handling of MJPEG streams until all others are known. */\n> -\t\tif (format == formats::MJPEG)\n> +\t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB)\n> \t\t\tcontinue;\n> \n> \t\tStreamConfiguration streamConfiguration;\n> @@ -1230,10 +1230,9 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t/* Now handle MJPEG streams, adding a new stream if required. */\n> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> -\t\tPixelFormat format = toPixelFormat(stream->format);\n> \t\tbool match = false;\n> \n> -\t\tif (format != formats::MJPEG)\n> +\t\tif (stream->format != HAL_PIXEL_FORMAT_BLOB)\n> \t\t\tcontinue;\n> \n> \t\t/* Search for a compatible stream */\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DA13BE174\n\tfor ;\n\tFri, 4 Sep 2020 06:16:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B243629B6;\n\tFri, 4 Sep 2020 08:16:05 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D02196036F\n\tfor ;\n\tFri, 4 Sep 2020 08:16:03 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id d2so3267755lfj.1\n\tfor ;\n\tThu, 03 Sep 2020 23:16:03 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tz27sm1092361lfg.14.2020.09.03.23.16.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Sep 2020 23:16:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"QwBq6e8E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=NSMtzmJx5tllfeZEMOrq2Kn6s993PLMguNjMure/SaY=;\n\tb=QwBq6e8E+BYDypMu5ChkYL0OdAEiVeu9Dxy+pY3v19NHZpxo2stCf/bwgSeoKyWWYb\n\tmFY4DKjcEiiv2z1ScyBaAip2QqDg3ikbjuwd+m2jZWq8JWFTE6IogrZINAy48SRcSF3a\n\tCpu3KlScChYbQqIIzXvqbRATrGDSdCq2+KGxynb4ydLPpg9rDaa/UyzmTYg4eQwdJF8v\n\tOt/HoFZwXgsqcMvT39eN0tpIH5SVl4BCL+NWk+v4h0rLgbgIyksEQWTHJJM/GomFi+Me\n\tdpeXWyiXgqE8SPEJTl6CPa1FRja+CFHy2m4q2qj7xJIeX6Afdelv043fmTvoH/cQgcMS\n\tQ/wQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=NSMtzmJx5tllfeZEMOrq2Kn6s993PLMguNjMure/SaY=;\n\tb=jSW8UeenMkJbZ9Eb/nPScDwb/ngKvZ6Qoy4Mc1B5jbV8lU5tySZPdB7vLOEDVKlWhs\n\tUc24LWtcW87b6oGZBEHHutYFt2vlWpGcHaeiOcaRXOwMfnw64a/SRkNPspZ+kotJDAoK\n\tEHS/XfuxMasTbJ+DJojRYHrhg7K15SPALRvVuL7AbFz9AExHWHRJeyB82CKFQfgEQALx\n\tQua+qJbC3KQgeFfR726PzNLoOqdWzTG6/43bBfUhBv5/F7hZzbWHxVkC9pknNAFuonZV\n\t5NG6DOgaXc2kuFJfTKWXwpwRDcduyeXr0OMOxGE+OeEAHwXvrJWyGEIos1eAJZYdH6OH\n\tijyA==","X-Gm-Message-State":"AOAM533UqW/cKLw12MRwaWXWH4p/FvvULqKXjf6fZYF/wKlWCmVhDdaw\n\t0Hk/k33L+wZGp4HQUC1nqbbJZQ==","X-Google-Smtp-Source":"ABdhPJwEdR9o2TcbMJDL81YdDj//Sdc2dCx+olwd8Yk3AkCm9BrMPXNx30+ujdRmjlXu/OyA4umxRw==","X-Received":"by 2002:a05:6512:3692:: with SMTP id\n\td18mr2972570lfs.62.1599200163174; \n\tThu, 03 Sep 2020 23:16:03 -0700 (PDT)","Date":"Fri, 4 Sep 2020 08:16:02 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200904061602.GF1498632@oden.dyn.berto.se>","References":"<20200902130846.55910-1-jacopo@jmondi.org>\n\t<20200902130846.55910-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200902130846.55910-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [RFC 4/7] android: camera_device: Use Android\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"tfiga@google.com, libcamera-devel@lists.libcamera.org, hiroh@google.com","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]