[{"id":12260,"web_url":"https://patchwork.libcamera.org/comment/12260/","msgid":"","date":"2020-09-02T13:25:27","subject":"Re: [libcamera-devel] [RFC 3/7] android: camera_device: Check\n\tcorrect stream format","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 02/09/2020 14:08, Jacopo Mondi wrote:\n> When iterating the camera3_stream_t received from the Android camera\n> framework to identify the MJPEG streams, the format check was performed\n> on the CameraStream created when iterating the non-MJPEG streams and not\n> on the format actually requested by Android.\n> \n> Fix this by checking the camera3_stream format.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 5a70db832aa5..01f4b3a45566 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1230,9 +1230,10 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t/* Now handle MJPEG streams, adding a new stream if required. */\n> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> +\t\tPixelFormat format = toPixelFormat(stream->format);\n> \t\tbool match = false;\n> \n> -\t\tif (streams_[i].format != formats::MJPEG)\n\nI'm not sure how it's the 'wrong' format to check. The\nCameraStream->format is already stored as a\ntoPixelFormat(stream->format) isn't it ?\n\n\nIn the event of a JPEG stream - the CameraStream is created with\nformats::MJPEG ...\n\n\nEven with that said, I don't think this patch is 'wrong', I just don't\nsee the need.... but I see the story continues in the next patches...\n\n\n> +\t\tif (format != formats::MJPEG)\n> \t\t\tcontinue;\n> \n> \t\t/* Search for a compatible stream */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6417BF019\n\tfor ;\n\tWed, 2 Sep 2020 13:25:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65E1462984;\n\tWed, 2 Sep 2020 15:25:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A825D60374\n\tfor ;\n\tWed, 2 Sep 2020 15:25:31 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17B999CC;\n\tWed, 2 Sep 2020 15:25:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Eaek6Q/P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599053131;\n\tbh=7VruiGZMd8zzkXKq6pdhdHiv76IMfSMYPWFuzxuOapY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Eaek6Q/PEg6VOaRbLiM6nbnEkBXKpbPwsr2eakK6p2uJ4gdxEiOUuQDGuaUo52Klp\n\t/bHnuBtYKuvSF5nuzJPbWnGVd8gl6oFvGqxDcJNhw9emSNF05Gxnoy8b1BBFn3DRXn\n\toqi7JRQwidEhVsh8KEMAeqSnbTRiMv8JvnOb5W7Q=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20200902130846.55910-1-jacopo@jmondi.org>\n\t<20200902130846.55910-4-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 2 Sep 2020 14:25:27 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200902130846.55910-4-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC 3/7] android: camera_device: Check\n\tcorrect stream format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"tfiga@google.com, hiroh@google.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12263,"web_url":"https://patchwork.libcamera.org/comment/12263/","msgid":"<20200902134303.3bl3zi7gt3c5654n@uno.localdomain>","date":"2020-09-02T13:43:03","subject":"Re: [libcamera-devel] [RFC 3/7] android: camera_device: Check\n\tcorrect stream format","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Wed, Sep 02, 2020 at 02:25:27PM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 02/09/2020 14:08, Jacopo Mondi wrote:\n> > When iterating the camera3_stream_t received from the Android camera\n> > framework to identify the MJPEG streams, the format check was performed\n> > on the CameraStream created when iterating the non-MJPEG streams and not\n> > on the format actually requested by Android.\n> >\n> > Fix this by checking the camera3_stream format.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/camera_device.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 5a70db832aa5..01f4b3a45566 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1230,9 +1230,10 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> > \t/* Now handle MJPEG streams, adding a new stream if required. */\n> > \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> > \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> > +\t\tPixelFormat format = toPixelFormat(stream->format);\n> > \t\tbool match = false;\n> >\n> > -\t\tif (streams_[i].format != formats::MJPEG)\n>\n> I'm not sure how it's the 'wrong' format to check. The\n> CameraStream->format is already stored as a\n> toPixelFormat(stream->format) isn't it ?\n\nYou are right, the Subject says \"correct\" which implies the existing\nis wrong, which is not (assuming _BLOB -> MJPEG unconditionally).\n\nYou'll see in the next patches the real reason for this change is that\nwhen this loop is entered after [5/7] is that there's not streams_[i]\nanymore associated with BLOB streams, this prepares for it to be\nremoved safely. The commit message is a bit confused maybe.\n\n>\n>\n> In the event of a JPEG stream - the CameraStream is created with\n> formats::MJPEG ...\n\nYes, for now :) I see no reason why it should change, but..\n\n>\n>\n> Even with that said, I don't think this patch is 'wrong', I just don't\n> see the need.... but I see the story continues in the next patches...\n>\n\nYes, hope it makes sense looking the next patches\n\n>\n> > +\t\tif (format != formats::MJPEG)\n> > \t\t\tcontinue;\n> >\n> > \t\t/* Search for a compatible stream */\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EC52BF019\n\tfor ;\n\tWed, 2 Sep 2020 13:39:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0BB3628EE;\n\tWed, 2 Sep 2020 15:39:19 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A56360374\n\tfor ;\n\tWed, 2 Sep 2020 15:39:18 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 083D9240011;\n\tWed, 2 Sep 2020 13:39:16 +0000 (UTC)"],"Date":"Wed, 2 Sep 2020 15:43:03 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200902134303.3bl3zi7gt3c5654n@uno.localdomain>","References":"<20200902130846.55910-1-jacopo@jmondi.org>\n\t<20200902130846.55910-4-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC 3/7] android: camera_device: Check\n\tcorrect stream format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"tfiga@google.com, libcamera-devel@lists.libcamera.org, hiroh@google.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12270,"web_url":"https://patchwork.libcamera.org/comment/12270/","msgid":"<87ebdb17-a268-b68e-35a1-2dea9e9bdaab@ideasonboard.com>","date":"2020-09-02T14:15:10","subject":"Re: [libcamera-devel] [RFC 3/7] android: camera_device: Check\n\tcorrect stream format","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 02/09/2020 14:43, Jacopo Mondi wrote:\n> Hi Kieran,\n> \n> On Wed, Sep 02, 2020 at 02:25:27PM +0100, Kieran Bingham wrote:\n>> Hi Jacopo,\n>>\n>> On 02/09/2020 14:08, Jacopo Mondi wrote:\n>>> When iterating the camera3_stream_t received from the Android camera\n>>> framework to identify the MJPEG streams, the format check was performed\n>>> on the CameraStream created when iterating the non-MJPEG streams and not\n>>> on the format actually requested by Android.\n>>>\n>>> Fix this by checking the camera3_stream format.\n>>>\n>>> Signed-off-by: Jacopo Mondi \n>>> ---\n>>> src/android/camera_device.cpp | 3 ++-\n>>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>>> index 5a70db832aa5..01f4b3a45566 100644\n>>> --- a/src/android/camera_device.cpp\n>>> +++ b/src/android/camera_device.cpp\n>>> @@ -1230,9 +1230,10 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>>> \t/* Now handle MJPEG streams, adding a new stream if required. */\n>>> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n>>> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n>>> +\t\tPixelFormat format = toPixelFormat(stream->format);\n>>> \t\tbool match = false;\n>>>\n>>> -\t\tif (streams_[i].format != formats::MJPEG)\n>>\n>> I'm not sure how it's the 'wrong' format to check. The\n>> CameraStream->format is already stored as a\n>> toPixelFormat(stream->format) isn't it ?\n> \n> You are right, the Subject says \"correct\" which implies the existing\n> is wrong, which is not (assuming _BLOB -> MJPEG unconditionally).\n> \n> You'll see in the next patches the real reason for this change is that\n> when this loop is entered after [5/7] is that there's not streams_[i]\n> anymore associated with BLOB streams, this prepares for it to be\n> removed safely. The commit message is a bit confused maybe.\n\nSure, well I don't mind if it changes any way...\n\nReviewed-by: Kieran Bingham \n\n\n> \n>>\n>>\n>> In the event of a JPEG stream - the CameraStream is created with\n>> formats::MJPEG ...\n> \n> Yes, for now :) I see no reason why it should change, but..\n> \n>>\n>>\n>> Even with that said, I don't think this patch is 'wrong', I just don't\n>> see the need.... but I see the story continues in the next patches...\n>>\n> \n> Yes, hope it makes sense looking the next patches\n> \n>>\n>>> +\t\tif (format != formats::MJPEG)\n>>> \t\t\tcontinue;\n>>>\n>>> \t\t/* Search for a compatible stream */\n>>>\n>>\n>> --\n>> Regards\n>> --\n>> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DA6ABE174\n\tfor ;\n\tWed, 2 Sep 2020 14:15:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 010D4628EE;\n\tWed, 2 Sep 2020 16:15:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 409CE60374\n\tfor ;\n\tWed, 2 Sep 2020 16:15:23 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F30F39CC;\n\tWed, 2 Sep 2020 16:15:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AZclWjP0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599056116;\n\tbh=KE0JkMLsWsJuYa7h4qNkheTDlheFP3OMgtU9OmI8Gwo=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=AZclWjP0dIN1Bj/pP/YPa+yZPDh1tePf6AutUSMvZ7ubgp8sInUxjt/Tx5rpz4jI3\n\tTuToKIG+ezJ97E9/skchvHneo/zc24UHjaG9TlZpkrSDv7UlNtI8Vi+LRljseLWrpv\n\tgGSE0ns95MUxKwpz01rnOgVx+vmmIS/OhO9EthZ8=","To":"Jacopo Mondi ","References":"<20200902130846.55910-1-jacopo@jmondi.org>\n\t<20200902130846.55910-4-jacopo@jmondi.org>\n\t\n\t<20200902134303.3bl3zi7gt3c5654n@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<87ebdb17-a268-b68e-35a1-2dea9e9bdaab@ideasonboard.com>","Date":"Wed, 2 Sep 2020 15:15:10 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200902134303.3bl3zi7gt3c5654n@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC 3/7] android: camera_device: Check\n\tcorrect stream format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"tfiga@google.com, libcamera-devel@lists.libcamera.org, hiroh@google.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12290,"web_url":"https://patchwork.libcamera.org/comment/12290/","msgid":"<20200904061353.GE1498632@oden.dyn.berto.se>","date":"2020-09-04T06:13:53","subject":"Re: [libcamera-devel] [RFC 3/7] android: camera_device: Check\n\tcorrect stream format","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-09-02 15:08:42 +0200, Jacopo Mondi wrote:\n> When iterating the camera3_stream_t received from the Android camera\n> framework to identify the MJPEG streams, the format check was performed\n> on the CameraStream created when iterating the non-MJPEG streams and not\n> on the format actually requested by Android.\n> \n> Fix this by checking the camera3_stream format.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 5a70db832aa5..01f4b3a45566 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1230,9 +1230,10 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t/* Now handle MJPEG streams, adding a new stream if required. */\n> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> +\t\tPixelFormat format = toPixelFormat(stream->format);\n> \t\tbool match = false;\n> \n> -\t\tif (streams_[i].format != formats::MJPEG)\n> +\t\tif (format != formats::MJPEG)\n> \t\t\tcontinue;\n> \n> \t\t/* Search for a compatible stream */\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7473BF019\n\tfor ;\n\tFri, 4 Sep 2020 06:13:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DD51629B6;\n\tFri, 4 Sep 2020 08:13:57 +0200 (CEST)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63C296036F\n\tfor ;\n\tFri, 4 Sep 2020 08:13:55 +0200 (CEST)","by mail-lj1-x22b.google.com with SMTP id s205so6560999lja.7\n\tfor ;\n\tThu, 03 Sep 2020 23:13:55 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t15sm104975lfl.38.2020.09.03.23.13.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Sep 2020 23:13:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"zD0ohnXO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=SeIWIzH6Qn+wsfHInpBF/MwsTD8pWTyf6MREx10IE6A=;\n\tb=zD0ohnXOML6dlndSAynLbMShcCBiEztLCtjEakImNBRyNFpdInDnuJMyrQ6uBMf7U+\n\tONgSCOOze8z8YjYkO660XWKXb/0OEpZZ1cGLfM+coEuXOZzMmQLouMiOT6oKyEK754ZD\n\td9xwzmmhYvJ8XJHNetzxTNLpuv7HixYNqQfQTZF0jP6eODoxf/m0DAtRfmNSkGMY83T/\n\th9unQzqDdtCQKXXpgXiZ+I+PaCVXZ5HPV+kFVPBF03jKY+K7PvzJA+P5af8tFitaAsxU\n\twCWltY7ZhK5p5o2C6/53ALY11KEPrg/J06U2i97OFhqSJY+3Erap/y1Ss7m5OcXT2Wxu\n\t+GiA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=SeIWIzH6Qn+wsfHInpBF/MwsTD8pWTyf6MREx10IE6A=;\n\tb=O+IJaUQjPEuwo2Zxal9ULa8n3k1Wmkorq4YTUKjazuhojsBKI9vWaUewM2ka0B+RTu\n\tO18CJ3EcldKZeL4D4sU5Dk8Ctv6U20/ONNZm0iF0rgooTDjW123abqG73S+kNgHQciHr\n\tQIw7lRFEyhC3bOwigaFTowfa0s9VvRkWvfqM1Y2MV2WNbJqnj7858ZWeRKOvWkr4uSVl\n\te4+nXRuzJoPd9YCpedUwcfj7SnaPLM5ykbsA+Rs19H/pb4BlMNwiTxZ+74RGQ2KAJOrT\n\tliJ7D3l9LWYnYdzHF+oZfdgzFsPPL3zH4+ZByHUSYXeuv8T20nFJR6WELXuJ914rdbLA\n\tMK3g==","X-Gm-Message-State":"AOAM531/Mr23bWnavE4FlI2kjyo2YczadbeA2Hwl/WB3SWWfSixjP+lW\n\tC7Hkz2iNQZla6NUXAeV5s4IZcg==","X-Google-Smtp-Source":"ABdhPJy4ChJCriv7y3ckDIM8cWBbrC+wZ5vpPEBIR+E/7cJbntzDyVOCU6el1cUHqIQBWHWih2vJ8g==","X-Received":"by 2002:a2e:8098:: with SMTP id i24mr3167401ljg.50.1599200034856;\n\tThu, 03 Sep 2020 23:13:54 -0700 (PDT)","Date":"Fri, 4 Sep 2020 08:13:53 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200904061353.GE1498632@oden.dyn.berto.se>","References":"<20200902130846.55910-1-jacopo@jmondi.org>\n\t<20200902130846.55910-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200902130846.55910-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [RFC 3/7] android: camera_device: Check\n\tcorrect stream format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"tfiga@google.com, libcamera-devel@lists.libcamera.org, hiroh@google.com","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]