[{"id":12253,"web_url":"https://patchwork.libcamera.org/comment/12253/","msgid":"<28ee1c08-729d-a8eb-248a-18fcbb159438@ideasonboard.com>","date":"2020-09-02T13:00:43","subject":"Re: [libcamera-devel] [PATCH] libcamera: buffer: Fix\n\tMappedBuffer::maps_ documentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 02/09/2020 13:57, Umang Jain wrote:\n> Complete the brief for MappedBuffer::maps_ documentation.\n> \n> Fixes: b3383da79f1d (\"libcamera: buffer: Create a MappedBuffer\")\n\nOoops... /o\\\n\n> Signed-off-by: Umang Jain \n> ---\n> src/libcamera/buffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> index a094737..03f628e 100644\n> --- a/src/libcamera/buffer.cpp\n> +++ b/src/libcamera/buffer.cpp\n> @@ -392,7 +392,7 @@ MappedBuffer::~MappedBuffer()\n> \n> /**\n> * \\var MappedBuffer::maps_\n> - * \\brief Stores the internal\n> + * \\brief Stores the internal mapped planes\n\nThough maybe we don't need the word 'internal' there .. but either way.\n\nReviewed-by: Kieran Bingham \n\n> *\n> * MappedBuffer derived classes shall store the mappings they create in this\n> * vector which is parsed during destruct to unmap any memory mappings which\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8A45BE174\n\tfor ;\n\tWed, 2 Sep 2020 13:00:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50458628EE;\n\tWed, 2 Sep 2020 15:00:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8003B60374\n\tfor ;\n\tWed, 2 Sep 2020 15:00:50 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AEA2F9CC;\n\tWed, 2 Sep 2020 15:00:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RXUK1Yzh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599051646;\n\tbh=enBmzdULxAhoJyT+ToY5ZDUZqYa7wu4zFmx2qQJJ6EI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=RXUK1YzhXmV2TvFzPfhKjsGblRuVWubEfIR97vR8Zy4qvC5igx9yGYN9bLx85Vfk8\n\tGOK5Y2ZK61l26u5jRuTWFuy/bRhO+o8BJ/uwblfWJAnyXSccGQMMqFayMtwbIjv6+h\n\t6tHvqSQXpwPoYf7yPpx/dbluwCi7bJvgqxoO/aEo=","To":"Umang Jain , libcamera-devel@lists.libcamera.org","References":"<20200902125743.61649-1-email@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<28ee1c08-729d-a8eb-248a-18fcbb159438@ideasonboard.com>","Date":"Wed, 2 Sep 2020 14:00:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200902125743.61649-1-email@uajain.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: buffer: Fix\n\tMappedBuffer::maps_ documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12286,"web_url":"https://patchwork.libcamera.org/comment/12286/","msgid":"<20200904060529.GB1498632@oden.dyn.berto.se>","date":"2020-09-04T06:05:29","subject":"Re: [libcamera-devel] [PATCH] libcamera: buffer: Fix\n\tMappedBuffer::maps_ documentation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Umang,\n\nThanks for your patch.\n\nOn 2020-09-02 18:27:43 +0530, Umang Jain wrote:\n> Complete the brief for MappedBuffer::maps_ documentation.\n> \n> Fixes: b3383da79f1d (\"libcamera: buffer: Create a MappedBuffer\")\n> Signed-off-by: Umang Jain \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/buffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> index a094737..03f628e 100644\n> --- a/src/libcamera/buffer.cpp\n> +++ b/src/libcamera/buffer.cpp\n> @@ -392,7 +392,7 @@ MappedBuffer::~MappedBuffer()\n> \n> /**\n> * \\var MappedBuffer::maps_\n> - * \\brief Stores the internal\n> + * \\brief Stores the internal mapped planes\n> *\n> * MappedBuffer derived classes shall store the mappings they create in this\n> * vector which is parsed during destruct to unmap any memory mappings which\n> -- \n> 2.26.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6BC61BE174\n\tfor ;\n\tFri, 4 Sep 2020 06:05:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 35BB962946;\n\tFri, 4 Sep 2020 08:05:33 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BEEE16036F\n\tfor ;\n\tFri, 4 Sep 2020 08:05:31 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id a22so146881ljp.13\n\tfor ;\n\tThu, 03 Sep 2020 23:05:31 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id n2sm15776lji.97.2020.09.03.23.05.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Sep 2020 23:05:30 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"XHPYQlR/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=YLTA9pMWZBvOeoWXibo5AhfTDT/D6ye3V6q4t3XkRsE=;\n\tb=XHPYQlR/5t22Vb9oRD173f+NmQAsThrKCHHkutfGxiFrgcHduQu7oV1kgCN10Kyn9k\n\tl7XGwYlHlTQwOJrNOXhhwm7ujF7jh766DX+QTLIRF2ijZzsGa1J11n4jnjEe/LixQXxd\n\trE4uKm0rEzX0iW3rE6XzNlyrzV1qnBE6e8g6o+/WoLEPldMK8hLdU8e3ZX09pVGRjylV\n\tGTb5m53rpheYPPEbSbI4wDzMeMmZ3LrZQwH0rm9xHA5BLzKyV4d8GpX7UGENXkzcyB8N\n\tDbSQIsb+1/vcb1Y3EhW8YNtcHO19pcuAhpILs4B09Z29eiq9+OVN4SkupO7t7vLPJ898\n\teqqg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=YLTA9pMWZBvOeoWXibo5AhfTDT/D6ye3V6q4t3XkRsE=;\n\tb=ovAwoiSKzJL2jj5umTlJHklH7+cNDXCJ5wkypQrMNzOWnBYcXtlKd4a5MDNiQxL6+2\n\tyrPZ91m2jYXI55rUt7Axq4vr4AuujTy9Sehu7+j/1OSSkNvCgq1YHsXcg6e/iTfR6ko2\n\t+2ZwIsJLPEOEv5im2JX91NKsEPDbtA1ot1MbXWeheQ7Xve3V/E4/J3ZeG0Q1P9QEUDpc\n\tQTCJeGTXrekyFUMK03HavlLGz+XbhWPWKrN08F8o5Z5ak0EO9czNBYd9RWRbFD9+rguH\n\t5xOZaZ6U8aBZHGevI4fVIA7vJCxqEwSXpIAqeN5VMdOcDtac2mU+b+0ZQ1zASy+YKvfk\n\thDiA==","X-Gm-Message-State":"AOAM531PMvHvIlKEb4k8IoxkoujDTmhHS0AZlNnIdntMF/MG6aHePmFF\n\t0iO05L3Bbrkvg0+qosuSoZw0jA==","X-Google-Smtp-Source":"ABdhPJzC79zjiYb9DxOXjvSo9yFtsR8nB4jC4KT9DXvwkxr81T+IDgaDWiCVqHrzKUpZ/eOCZssl/Q==","X-Received":"by 2002:a2e:b008:: with SMTP id y8mr2681950ljk.421.1599199530884;\n\tThu, 03 Sep 2020 23:05:30 -0700 (PDT)","Date":"Fri, 4 Sep 2020 08:05:29 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Umang Jain ","Message-ID":"<20200904060529.GB1498632@oden.dyn.berto.se>","References":"<20200902125743.61649-1-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200902125743.61649-1-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: buffer: Fix\n\tMappedBuffer::maps_ documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]