[{"id":12245,"web_url":"https://patchwork.libcamera.org/comment/12245/","msgid":"","date":"2020-09-02T11:49:01","subject":"Re: [libcamera-devel] [PATCH v6 4/8] libcamera: Add BayerFormat type","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 02/09/2020 11:44, David Plowman wrote:\n> This type encodes BayerFormats in an explicit way, that makes them\n> easier to use than some of the other more opaque type formats. This\n> makes the BayerFormat useful for editing or manipulating Bayer types\n> more easily.\n\nI sort of got excited reading about this in the cover letter.\nSounds like a good way to deal with all of this!\n\n> \n> Signed-off-by: David Plowman \n\nLooks like only minor comments below, therefore:\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/bayer_format.h | 63 ++++++\n> src/libcamera/bayer_format.cpp | 223 ++++++++++++++++++++++\n> src/libcamera/meson.build | 1 +\n> 3 files changed, 287 insertions(+)\n> create mode 100644 include/libcamera/internal/bayer_format.h\n> create mode 100644 src/libcamera/bayer_format.cpp\n> \n> diff --git a/include/libcamera/internal/bayer_format.h b/include/libcamera/internal/bayer_format.h\n> new file mode 100644\n> index 0000000..3a0f5cb\n> --- /dev/null\n> +++ b/include/libcamera/internal/bayer_format.h\n> @@ -0,0 +1,63 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Raspberry Pi (Trading) Ltd.\n> + *\n> + * bayer_format.h - Bayer Pixel Format\n> + */\n> +#ifndef __LIBCAMERA_INTERNAL_BAYER_FORMAT_H__\n> +#define __LIBCAMERA_INTERNAL_BAYER_FORMAT_H__\n> +\n> +#include \n> +#include \n> +\n> +#include \"libcamera/internal/v4l2_pixelformat.h\"\n> +\n> +namespace libcamera {\n> +\n> +enum class Transform;\n> +\n> +class BayerFormat\n> +{\n> +public:\n> +\tenum Order : uint8_t {\n> +\t\tBGGR = 0,\n> +\t\tGBRG = 1,\n> +\t\tGRBG = 2,\n> +\t\tRGGB = 3\n> +\t};\n> +\n> +\tenum Modifier : uint16_t {\n> +\t\tNone = 0,\n> +\t\tPacked = 1,\n> +\t};\n> +\n> +\tconstexpr BayerFormat()\n> +\t\t: order(Order::BGGR), bitDepth(0), modifiers(Modifier::None)\n> +\t{\n> +\t}\n> +\n> +\tconstexpr BayerFormat(Order o, uint8_t b, Modifier m)\n> +\t\t: order(o), bitDepth(b), modifiers(m)\n> +\t{\n> +\t}\n> +\n> +\texplicit BayerFormat(V4L2PixelFormat v4l2Format);\n> +\n> +\tbool isValid() const { return bitDepth != 0; }\n> +\n> +\tstd::string toString() const;\n> +\n> +\tV4L2PixelFormat toV4L2PixelFormat() const;\n> +\n> +\tBayerFormat transform(Transform t) const;\n> +\n> +\tOrder order;\n> +\n> +\tuint8_t bitDepth;\n> +\n> +\tModifier modifiers;\n\nHrm ... a newline between 'every' entry looks a bit odd - I think I've\nasked to keep things distinct before - but I think newlines should only\nbe where it makes sense.\n\nI'd probably group these more like this:\n\n> +\texplicit BayerFormat(V4L2PixelFormat v4l2Format);\n> +\tbool isValid() const { return bitDepth != 0; }\n> +\n> +\tstd::string toString() const;\n> +\n> +\tV4L2PixelFormat toV4L2PixelFormat() const;\n> +\tBayerFormat transform(Transform t) const;\n> +\n> +\tOrder order;\n> +\tuint8_t bitDepth;\n> +\tModifier modifiers;\n\n\n> +};\n> +\n> +} /* namespace libcamera */\n> +\n> +#endif /* __LIBCAMERA_INTERNAL_BAYER_FORMAT_H__ */\n> diff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\n> new file mode 100644\n> index 0000000..cc8ed66\n> --- /dev/null\n> +++ b/src/libcamera/bayer_format.cpp\n> @@ -0,0 +1,223 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Raspberry Pi (Trading) Limited\n> + *\n> + * bayer_format.cpp - class to represent Bayer formats\n> + */\n> +\n> +#include \"libcamera/internal/bayer_format.h\"\n> +\n> +#include \n> +\n> +#include \n> +\n> +/**\n> + * \\file bayer_format.h\n> + * \\brief Class to represent Bayer formats and manipulate them\n> + */\n> +\n> +namespace libcamera {\n> +\n> +/**\n> + * \\class BayerFormat\n> + * \\brief Class to represent a raw image Bayer format\n> + *\n> + * This class encodes the different Bayer formats in such a way that they can\n> + * be easily manipulated. For example, the bit depth or Bayer order can be\n> + * easily altered - the Bayer order can even be \"transformed\" in the same\n> + * manner as happens in many sensors when their horizontal or vertical \"flip\"\n> + * controls are set.\n> + */\n> +\n> +/**\n> + * \\enum BayerFormat::Order\n> + * \\brief The order of the colour channels in the Bayer pattern\n> + *\n> + * \\var BayerFormat::BGGR\n> + * \\brief B then G on the first row, G then R on the second row.\n> + * \\var BayerFormat::GBRG\n> + * \\brief G then B on the first row, R then G on the second row.\n> + * \\var BayerFormat::GRBG\n> + * \\brief G then R on the first row, B then G on the second row.\n> + * \\var BayerFormat::RGGB\n> + * \\brief T then G on the first row, G then B on the second row.\n> + */\n> +\n> +/**\n> + * \\enum BayerFormat::Modifier\n> + * \\brief Modifiers that can apply to a BayerFormat\n> + *\n> + * \\var BayerFormat::None\n> + * \\brief No modifiers\n> + * \\var BayerFormat::Packed\n> + * \\brief Format uses MIPI CSI-2 style packing\n> + */\n> +\n> +namespace {\n> +\n> +const std::map v4l2ToBayer{\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR8), { BayerFormat::BGGR, 8, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG8), { BayerFormat::GBRG, 8, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG8), { BayerFormat::GRBG, 8, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB8), { BayerFormat::RGGB, 8, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10), { BayerFormat::BGGR, 10, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10), { BayerFormat::GBRG, 10, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10), { BayerFormat::GRBG, 10, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10), { BayerFormat::RGGB, 10, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10P), { BayerFormat::BGGR, 10, BayerFormat::Packed } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10P), { BayerFormat::GBRG, 10, BayerFormat::Packed } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10P), { BayerFormat::GRBG, 10, BayerFormat::Packed } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10P), { BayerFormat::RGGB, 10, BayerFormat::Packed } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR12), { BayerFormat::BGGR, 12, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG12), { BayerFormat::GBRG, 12, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG12), { BayerFormat::GRBG, 12, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB12), { BayerFormat::RGGB, 12, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR12P), { BayerFormat::BGGR, 12, BayerFormat::Packed } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG12P), { BayerFormat::GBRG, 12, BayerFormat::Packed } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG12P), { BayerFormat::GRBG, 12, BayerFormat::Packed } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB12P), { BayerFormat::RGGB, 12, BayerFormat::Packed } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR16), { BayerFormat::BGGR, 16, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG16), { BayerFormat::GBRG, 16, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG16), { BayerFormat::GRBG, 16, BayerFormat::None } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16), { BayerFormat::RGGB, 16, BayerFormat::None } },\n> +};\n> +\n> +/* Define a slightly arbitrary ordering so that we can use a std::map. */\n> +struct BayerFormatComparator {\n> +\tbool operator()(const BayerFormat &left, const BayerFormat &right) const\n> +\t{\n> +\t\treturn left.bitDepth > right.bitDepth ||\n> +\t\t (left.bitDepth == right.bitDepth && left.order > right.order) ||\n> +\t\t (left.bitDepth == right.bitDepth && left.order == right.order &&\n> +\t\t\tleft.modifiers > right.modifiers);\n> +\t}\n> +};\n> +\n> +const std::map bayerToV4l2{\n> +\t{ { BayerFormat::BGGR, 8, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SBGGR8) },\n> +\t{ { BayerFormat::GBRG, 8, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SGBRG8) },\n> +\t{ { BayerFormat::GRBG, 8, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SGRBG8) },\n> +\t{ { BayerFormat::RGGB, 8, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SRGGB8) },\n> +\t{ { BayerFormat::BGGR, 10, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10) },\n> +\t{ { BayerFormat::GBRG, 10, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10) },\n> +\t{ { BayerFormat::GRBG, 10, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10) },\n> +\t{ { BayerFormat::RGGB, 10, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10) },\n> +\t{ { BayerFormat::BGGR, 10, BayerFormat::Packed }, V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10P) },\n> +\t{ { BayerFormat::GBRG, 10, BayerFormat::Packed }, V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10P) },\n> +\t{ { BayerFormat::GRBG, 10, BayerFormat::Packed }, V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10P) },\n> +\t{ { BayerFormat::RGGB, 10, BayerFormat::Packed }, V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10P) },\n> +\t{ { BayerFormat::BGGR, 12, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SBGGR12) },\n> +\t{ { BayerFormat::GBRG, 12, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SGBRG12) },\n> +\t{ { BayerFormat::GRBG, 12, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SGRBG12) },\n> +\t{ { BayerFormat::RGGB, 12, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SRGGB12) },\n> +\t{ { BayerFormat::BGGR, 12, BayerFormat::Packed }, V4L2PixelFormat(V4L2_PIX_FMT_SBGGR12P) },\n> +\t{ { BayerFormat::GBRG, 12, BayerFormat::Packed }, V4L2PixelFormat(V4L2_PIX_FMT_SGBRG12P) },\n> +\t{ { BayerFormat::GRBG, 12, BayerFormat::Packed }, V4L2PixelFormat(V4L2_PIX_FMT_SGRBG12P) },\n> +\t{ { BayerFormat::RGGB, 12, BayerFormat::Packed }, V4L2PixelFormat(V4L2_PIX_FMT_SRGGB12P) },\n> +\t{ { BayerFormat::BGGR, 16, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SBGGR16) },\n> +\t{ { BayerFormat::GBRG, 16, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SGBRG16) },\n> +\t{ { BayerFormat::GRBG, 16, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SGRBG16) },\n> +\t{ { BayerFormat::RGGB, 16, BayerFormat::None }, V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16) },\n\n\nI always wished we could generate V4L2 (or DRM?) pixelformats in an\nexplicit manner such as this 'BayerFormat::RGGB, 16, BayerFormat::None'\nrather than the tables of enums/defines ;-)\n\n\n> +};\n> +\n> +} // namespace\n> +\n> +/**\n> + * \\fn BayerFormat::BayerFormat()\n> + * \\brief Construct an empty (and invalid) BayerFormat\n> + */\n> +\n> +/**\n> + * \\fn BayerFormat::BayerFormat(Order o, uint8_t b, Modifier m)\n> + * \\brief Construct a BayerFormat from explicit values\n> + */\n> +\n> +/**\n> + * \\brief Construct a BayerFormat from a V4L2PixelFormat\n> + * \\param[in] v4l2Format The raw format to convert into a BayerFormat\n> + */\n> +BayerFormat::BayerFormat(V4L2PixelFormat v4l2Format)\n> +{\n> +\tconst auto it = v4l2ToBayer.find(v4l2Format);\n> +\tif (it == v4l2ToBayer.end())\n> +\t\tbitDepth = 0;\n> +\telse\n> +\t\t*this = it->second;\n> +}\n> +\n> +/**\n> + * \\fn BayerFormat::isValid()\n> + * \\brief Return whether a BayerFormat is valid\n> + */\n> +\n> +/**\n> + * \\brief Returns a readable string representation of the BayerFormat\n> + */\n> +std::string BayerFormat::toString() const\n> +{\n> +\tstd::string result;\n> +\n> +\tstatic const char *orderStrings[] = {\n> +\t\t\"BGGR\",\n> +\t\t\"GBRG\",\n> +\t\t\"GRBG\",\n> +\t\t\"RGGB\"\n> +\t};\n> +\tif (order <= RGGB)\n> +\t\tresult = orderStrings[order];\n> +\telse\n> +\t\tresult = \"unknown\";\n> +\n> +\tresult += \"-\" + std::to_string(bitDepth);\n> +\n> +\tif (modifiers & Packed)\n> +\t\tresult += \"-P\";\n> +\n> +\treturn result;\n> +}\n\nNice ;-)\n\n> +\n> +/**\n> + * \\brief Convert a BayerFormat into the corresponding V4L2PixelFormat\n> + */\n> +V4L2PixelFormat BayerFormat::toV4L2PixelFormat() const\n> +{\n> +\tconst auto it = bayerToV4l2.find(*this);\n> +\tif (it != bayerToV4l2.end())\n> +\t\treturn it->second;\n> +\n> +\treturn V4L2PixelFormat();\n> +}\n> +\n> +/**\n> + * \\brief Apply a transform to this BayerFormat.\n> + * \\param[in] t The transform to apply\n> + */\n> +BayerFormat BayerFormat::transform(Transform t) const\n> +{\n> +\tBayerFormat result = *this;\n> +\n> +\t/* The order encoding is chosen to behave like this: */\n\nI'm not sure I fully understand that comment, could you expand a little\nperhaps please?\n\n> +\tif (!!(t & Transform::HFlip))\n> +\t\tresult.order = static_cast(result.order ^ 1);\n> +\tif (!!(t & Transform::VFlip))\n> +\t\tresult.order = static_cast(result.order ^ 2);\n\nPresumably you mean the ordering is specific to the '1' and '2' values\nused there...\n\n> +\n> +\treturn result;\n> +}\n> +\n> +/**\n> + * \\var BayerFormat::order\n> + * \\brief The order of the colour channels in the Bayer pattern\n> + */\n> +\n> +/**\n> + * \\var BayerFormat::bitDepth\n> + * \\brief The bit depth of the samples in the Bayer pattern\n> + */\n> +\n> +/**\n> + * \\var BayerFormat::modifiers\n> + * \\brief Any modifier flags applied to this BayerFormat\n> + */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index edec55e..86c225f 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> libcamera_sources = files([\n> + 'bayer_format.cpp',\n> 'bound_method.cpp',\n> 'buffer.cpp',\n> 'byte_stream_buffer.cpp',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C91ABF019\n\tfor ;\n\tWed, 2 Sep 2020 11:49:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2F7362931;\n\tWed, 2 Sep 2020 13:49:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DA706037A\n\tfor ;\n\tWed, 2 Sep 2020 13:49:05 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E04539CC;\n\tWed, 2 Sep 2020 13:49:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"htaPWDOe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599047345;\n\tbh=nB2CIqaCblPsl34Mlsj1/ioZrG0tpFkZD8yVFUBMhvw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=htaPWDOeVx7jOL837BjDY+BQzgX6Yz9wpR6QcCvWFJZWPa2KaoAX3e5/YhUHZr50Y\n\t+VpUPMsyv0bZ3T/dFPIG7VJgUfDwtyZlUdpiw9g+wO00KC14lZcrS3wd0GzEvOnFD7\n\tezDIynFu8dKGAlBtfMxdb9e2xMFIt0xWvCnzFj2I=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200902104410.7569-1-david.plowman@raspberrypi.com>\n\t<20200902104410.7569-5-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 2 Sep 2020 12:49:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200902104410.7569-5-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v6 4/8] libcamera: Add BayerFormat type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]