[{"id":12242,"web_url":"https://patchwork.libcamera.org/comment/12242/","msgid":"<20200901181528.GC6148@pendragon.ideasonboard.com>","date":"2020-09-01T18:15:28","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipelines: Print enabled\n\tpipelines","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Sep 01, 2020 at 03:07:52PM +0100, Kieran Bingham wrote:\n> Report the enabled pipelines when configuring the meson build hierarchy.\n> \n> This helps clarify what pipelines are used when building, and is useful\n> when looking back through build-traces to see what was actually\n> configured.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> \n> This helps report enabled pipelines with the following examples visible\n> during configuration phase:\n> \n> ...\n> Configuring version.h using configuration\n> Dependency libjpeg found: YES 2.0.3 (cached)\n> Program openssl found: YES (/usr/bin/openssl)\n> Message: Enabling pipeline: ipu3\n> Message: Enabling pipeline: raspberrypi\n> Message: Enabling pipeline: rkisp1\n> Message: Enabling pipeline: simple\n> Message: Enabling pipeline: uvcvideo\n> Message: Enabling pipeline: vimc\n\nShould we print this on a single line ? It would prepare for using\nsummary() (https://mesonbuild.com/Reference-manual.html#summary), which\nis available in meson 0.53 and newer.\n\nSpeaking of meson version, the latest Ubuntu LTS ships meson 0.53.2, and\nDebian stable backports are currently at 0.52.1. We could upgrade to\n0.52 (or 0.51 if we want to support Ubuntu 19.10), which gives us the\nability to check for Python modules. Worth it ?\n\n> Library atomic found: YES\n> Library dl found: YES\n> ...\n> \n> src/libcamera/pipeline/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\n> index 46424493aa37..9eb66af59d79 100644\n> --- a/src/libcamera/pipeline/meson.build\n> +++ b/src/libcamera/pipeline/meson.build\n> @@ -1,5 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> foreach pipeline : get_option('pipelines')\n> + message('Enabling pipeline: ' + pipeline)\n> subdir(pipeline)\n> endforeach","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27B48BE174\n\tfor ;\n\tTue, 1 Sep 2020 18:15:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D3186294E;\n\tTue, 1 Sep 2020 20:15:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B85D62901\n\tfor ;\n\tTue, 1 Sep 2020 20:15:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A26DFAF2;\n\tTue, 1 Sep 2020 20:15:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V/0QGblg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598984149;\n\tbh=GVPM3geJt73ua5axcRppC9epLJ3beTtSmKbyrphN8W4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=V/0QGblgmpz2+UuV0tUSGqGoyenOtbgrq7AJpJpSbIFGCMwB+P2DgUz79r3AuTwUk\n\trVE/ls9NjIYMuPNumVgROPpGKa1YHXwhr4j/q7dniOKT9YMhD+wbXEUwTSAi7cKnrd\n\tEPjLggAGtvaEeEv6223E8LZmhr6XqJBM+lnLwR/8=","Date":"Tue, 1 Sep 2020 21:15:28 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200901181528.GC6148@pendragon.ideasonboard.com>","References":"<20200901140752.49347-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200901140752.49347-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipelines: Print enabled\n\tpipelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12276,"web_url":"https://patchwork.libcamera.org/comment/12276/","msgid":"<65837d12-719a-0c97-e26b-0c752c1528b0@ideasonboard.com>","date":"2020-09-03T18:30:47","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipelines: Print enabled\n\tpipelines","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 01/09/2020 19:15, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Sep 01, 2020 at 03:07:52PM +0100, Kieran Bingham wrote:\n>> Report the enabled pipelines when configuring the meson build hierarchy.\n>>\n>> This helps clarify what pipelines are used when building, and is useful\n>> when looking back through build-traces to see what was actually\n>> configured.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>>\n>> This helps report enabled pipelines with the following examples visible\n>> during configuration phase:\n>>\n>> ...\n>> Configuring version.h using configuration\n>> Dependency libjpeg found: YES 2.0.3 (cached)\n>> Program openssl found: YES (/usr/bin/openssl)\n>> Message: Enabling pipeline: ipu3\n>> Message: Enabling pipeline: raspberrypi\n>> Message: Enabling pipeline: rkisp1\n>> Message: Enabling pipeline: simple\n>> Message: Enabling pipeline: uvcvideo\n>> Message: Enabling pipeline: vimc\n> \n> Should we print this on a single line ? It would prepare for using\n> summary() (https://mesonbuild.com/Reference-manual.html#summary), which\n> is available in meson 0.53 and newer.\n\nI tried that, but couldn't easily print a list - therefore this was the\neasiest option I had.\n\n> Speaking of meson version, the latest Ubuntu LTS ships meson 0.53.2, and\n> Debian stable backports are currently at 0.52.1. We could upgrade to\n> 0.52 (or 0.51 if we want to support Ubuntu 19.10), which gives us the\n> ability to check for Python modules. Worth it ?\n\nI'm already running on the latest meson, and we detail in the README.rst\nhow to upgrade meson using pip\n\n(pip3 install --user --upgrade meson) easily on distributions which are\nusing an out of date meson.\n\n\nBut that summary() looks very helpful indeed, and is essentially what\nthis patch was trying to convey.\n\nIf you find a way to easily print on a single line, I can update this\npatch, or should I skip it until we think we can move forwards with\nsummary()?\n\n\n> \n>> Library atomic found: YES\n>> Library dl found: YES\n>> ...\n>>\n>> src/libcamera/pipeline/meson.build | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\n>> index 46424493aa37..9eb66af59d79 100644\n>> --- a/src/libcamera/pipeline/meson.build\n>> +++ b/src/libcamera/pipeline/meson.build\n>> @@ -1,5 +1,6 @@\n>> # SPDX-License-Identifier: CC0-1.0\n>> \n>> foreach pipeline : get_option('pipelines')\n>> + message('Enabling pipeline: ' + pipeline)\n>> subdir(pipeline)\n>> endforeach\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F7E3BE174\n\tfor ;\n\tThu, 3 Sep 2020 18:30:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D01CE629C7;\n\tThu, 3 Sep 2020 20:30:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A895E62931\n\tfor ;\n\tThu, 3 Sep 2020 20:30:52 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47A7056E;\n\tThu, 3 Sep 2020 20:30:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XAKt6bfI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599157850;\n\tbh=1txyqf4+FfWHPGicDvwjAcGMdJo6jJNTnlozq41pDtk=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=XAKt6bfIZl60JCCiR34uO2tgRXwyBkh5wo+e4O/weRVnUoleUzKEG1k0tH12L7LzR\n\tCTRzE9LEKDTSjmKyb+BWp+lZi8SSUV+fdQDSD37SEprBTTKaHdSbbv/9P6hfsiFomm\n\tg3Fte6ik+JIcDJSLYTQVkdSP96FnpfutCzfcUSrk=","To":"Laurent Pinchart ","References":"<20200901140752.49347-1-kieran.bingham@ideasonboard.com>\n\t<20200901181528.GC6148@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<65837d12-719a-0c97-e26b-0c752c1528b0@ideasonboard.com>","Date":"Thu, 3 Sep 2020 19:30:47 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200901181528.GC6148@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipelines: Print enabled\n\tpipelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12278,"web_url":"https://patchwork.libcamera.org/comment/12278/","msgid":"<20200903222334.GJ6492@pendragon.ideasonboard.com>","date":"2020-09-03T22:23:34","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipelines: Print enabled\n\tpipelines","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Sep 03, 2020 at 07:30:47PM +0100, Kieran Bingham wrote:\n> On 01/09/2020 19:15, Laurent Pinchart wrote:\n> > On Tue, Sep 01, 2020 at 03:07:52PM +0100, Kieran Bingham wrote:\n> >> Report the enabled pipelines when configuring the meson build hierarchy.\n> >>\n> >> This helps clarify what pipelines are used when building, and is useful\n> >> when looking back through build-traces to see what was actually\n> >> configured.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >>\n> >> This helps report enabled pipelines with the following examples visible\n> >> during configuration phase:\n> >>\n> >> ...\n> >> Configuring version.h using configuration\n> >> Dependency libjpeg found: YES 2.0.3 (cached)\n> >> Program openssl found: YES (/usr/bin/openssl)\n> >> Message: Enabling pipeline: ipu3\n> >> Message: Enabling pipeline: raspberrypi\n> >> Message: Enabling pipeline: rkisp1\n> >> Message: Enabling pipeline: simple\n> >> Message: Enabling pipeline: uvcvideo\n> >> Message: Enabling pipeline: vimc\n> > \n> > Should we print this on a single line ? It would prepare for using\n> > summary() (https://mesonbuild.com/Reference-manual.html#summary), which\n> > is available in meson 0.53 and newer.\n> \n> I tried that, but couldn't easily print a list - therefore this was the\n> easiest option I had.\n\n', '.join(get_option('pipelines')) ?\n\n> > Speaking of meson version, the latest Ubuntu LTS ships meson 0.53.2, and\n> > Debian stable backports are currently at 0.52.1. We could upgrade to\n> > 0.52 (or 0.51 if we want to support Ubuntu 19.10), which gives us the\n> > ability to check for Python modules. Worth it ?\n> \n> I'm already running on the latest meson, and we detail in the README.rst\n> how to upgrade meson using pip\n> \n> (pip3 install --user --upgrade meson) easily on distributions which are\n> using an out of date meson.\n> \n> \n> But that summary() looks very helpful indeed, and is essentially what\n> this patch was trying to convey.\n> \n> If you find a way to easily print on a single line, I can update this\n> patch, or should I skip it until we think we can move forwards with\n> summary()?\n\nUp to you :-) I think the feature is useful. Let's however group such\nmessages at the bottom of the top-level meson.build, to ease transition\nto summary().\n\n> >> Library atomic found: YES\n> >> Library dl found: YES\n> >> ...\n> >>\n> >> src/libcamera/pipeline/meson.build | 1 +\n> >> 1 file changed, 1 insertion(+)\n> >>\n> >> diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\n> >> index 46424493aa37..9eb66af59d79 100644\n> >> --- a/src/libcamera/pipeline/meson.build\n> >> +++ b/src/libcamera/pipeline/meson.build\n> >> @@ -1,5 +1,6 @@\n> >> # SPDX-License-Identifier: CC0-1.0\n> >> \n> >> foreach pipeline : get_option('pipelines')\n> >> + message('Enabling pipeline: ' + pipeline)\n> >> subdir(pipeline)\n> >> endforeach","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80BFEBE174\n\tfor ;\n\tThu, 3 Sep 2020 22:24:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2C94629CF;\n\tFri, 4 Sep 2020 00:23:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F8E560374\n\tfor ;\n\tFri, 4 Sep 2020 00:23:58 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C85B356E;\n\tFri, 4 Sep 2020 00:23:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wd/YwcP9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599171838;\n\tbh=sb2GCsPTrdhbiqlTvIeTa8++4KAZ/aP7wrXxGdlLqYI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wd/YwcP9s8cE4HJxbz34iLuM8c322rPZ7EwMOJF4ym25O4CGA2SgdbrOqPSx4wf8h\n\tMSRE2hjALFkDCd+GUv7BSWB29fFKGxP39pyTQ8+tj1h7QIXIzTWD3TPI0CaDWuLeWv\n\tZFONLtL9POBGwdas7g28qFsPGnxc9lLDWOBkR/X0=","Date":"Fri, 4 Sep 2020 01:23:34 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200903222334.GJ6492@pendragon.ideasonboard.com>","References":"<20200901140752.49347-1-kieran.bingham@ideasonboard.com>\n\t<20200901181528.GC6148@pendragon.ideasonboard.com>\n\t<65837d12-719a-0c97-e26b-0c752c1528b0@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<65837d12-719a-0c97-e26b-0c752c1528b0@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipelines: Print enabled\n\tpipelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12280,"web_url":"https://patchwork.libcamera.org/comment/12280/","msgid":"","date":"2020-09-03T23:13:09","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipelines: Print enabled\n\tpipelines","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 03/09/2020 23:23, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Thu, Sep 03, 2020 at 07:30:47PM +0100, Kieran Bingham wrote:\n>> On 01/09/2020 19:15, Laurent Pinchart wrote:\n>>> On Tue, Sep 01, 2020 at 03:07:52PM +0100, Kieran Bingham wrote:\n>>>> Report the enabled pipelines when configuring the meson build hierarchy.\n>>>>\n>>>> This helps clarify what pipelines are used when building, and is useful\n>>>> when looking back through build-traces to see what was actually\n>>>> configured.\n>>>>\n>>>> Signed-off-by: Kieran Bingham \n>>>> ---\n>>>>\n>>>> This helps report enabled pipelines with the following examples visible\n>>>> during configuration phase:\n>>>>\n>>>> ...\n>>>> Configuring version.h using configuration\n>>>> Dependency libjpeg found: YES 2.0.3 (cached)\n>>>> Program openssl found: YES (/usr/bin/openssl)\n>>>> Message: Enabling pipeline: ipu3\n>>>> Message: Enabling pipeline: raspberrypi\n>>>> Message: Enabling pipeline: rkisp1\n>>>> Message: Enabling pipeline: simple\n>>>> Message: Enabling pipeline: uvcvideo\n>>>> Message: Enabling pipeline: vimc\n>>>\n>>> Should we print this on a single line ? It would prepare for using\n>>> summary() (https://mesonbuild.com/Reference-manual.html#summary), which\n>>> is available in meson 0.53 and newer.\n>>\n>> I tried that, but couldn't easily print a list - therefore this was the\n>> easiest option I had.\n> \n> ', '.join(get_option('pipelines')) ?\n\nWell, sure but that's clearly .. overly uhm complex, and too many\nadditional lines and ... errmmm ... uh ...\n\nOk so it works ;-)\n\nV2 tomorrow with this instead:\n\nmessage('Enabled pipelines: ' + ', '.join(get_option('pipelines')) )\n\n> Configuring config.h using configuration\n> Message: Enabled pipelines: ipu3, raspberrypi, rkisp1, simple, uvcvideo, vimc\n> Build targets in project: 86\n\n\n\n\n> \n>>> Speaking of meson version, the latest Ubuntu LTS ships meson 0.53.2, and\n>>> Debian stable backports are currently at 0.52.1. We could upgrade to\n>>> 0.52 (or 0.51 if we want to support Ubuntu 19.10), which gives us the\n>>> ability to check for Python modules. Worth it ?\n>>\n>> I'm already running on the latest meson, and we detail in the README.rst\n>> how to upgrade meson using pip\n>>\n>> (pip3 install --user --upgrade meson) easily on distributions which are\n>> using an out of date meson.\n>>\n>>\n>> But that summary() looks very helpful indeed, and is essentially what\n>> this patch was trying to convey.\n>>\n>> If you find a way to easily print on a single line, I can update this\n>> patch, or should I skip it until we think we can move forwards with\n>> summary()?\n> \n> Up to you :-) I think the feature is useful. Let's however group such\n> messages at the bottom of the top-level meson.build, to ease transition\n> to summary().\n\nAgreed.\n\n>>>> Library atomic found: YES\n>>>> Library dl found: YES\n>>>> ...\n>>>>\n>>>> src/libcamera/pipeline/meson.build | 1 +\n>>>> 1 file changed, 1 insertion(+)\n>>>>\n>>>> diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build\n>>>> index 46424493aa37..9eb66af59d79 100644\n>>>> --- a/src/libcamera/pipeline/meson.build\n>>>> +++ b/src/libcamera/pipeline/meson.build\n>>>> @@ -1,5 +1,6 @@\n>>>> # SPDX-License-Identifier: CC0-1.0\n>>>> \n>>>> foreach pipeline : get_option('pipelines')\n>>>> + message('Enabling pipeline: ' + pipeline)\n>>>> subdir(pipeline)\n>>>> endforeach\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13AB4BE174\n\tfor ;\n\tThu, 3 Sep 2020 23:13:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9ACE762901;\n\tFri, 4 Sep 2020 01:13:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03B6960374\n\tfor ;\n\tFri, 4 Sep 2020 01:13:12 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75DAF56E;\n\tFri, 4 Sep 2020 01:13:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JNuW+xMH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599174792;\n\tbh=IAk1V+0xWRJZjOLlNlmlsxLEElz/pjLucrCJThblwVI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=JNuW+xMHhzI97te25fkfmIbQt3Na2LqlQMQN4QwBFJwF1CB/PBNlSsKQE2B/Szn71\n\tG1h4xSQjjXcIIz0Hk9o24SB/UUOdYFjVdPwpnyl8DQhfLAH6IyRwfoyyKahaMWpcrb\n\t/HcTpYVgOn2wXVnJSMY9QMxFK3LA9cxv5jBqEa1k=","To":"Laurent Pinchart ","References":"<20200901140752.49347-1-kieran.bingham@ideasonboard.com>\n\t<20200901181528.GC6148@pendragon.ideasonboard.com>\n\t<65837d12-719a-0c97-e26b-0c752c1528b0@ideasonboard.com>\n\t<20200903222334.GJ6492@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 4 Sep 2020 00:13:09 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200903222334.GJ6492@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipelines: Print enabled\n\tpipelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]