[{"id":12209,"web_url":"https://patchwork.libcamera.org/comment/12209/","msgid":"<20200828160036.t2zo732mn6vjqxab@uno.localdomain>","date":"2020-08-28T16:00:36","subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: raspberrypi:\n\tdmaheaps: Add isValid()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Fri, Aug 28, 2020 at 05:51:35PM +0200, Jacopo Mondi wrote:\n> Add isValid() method to verify the allocator device has been open\n> correctly.\n>\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/raspberrypi/dma_heaps.h | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/dma_heaps.h b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> index ae6be1135f17..119abd26ed31 100644\n> --- a/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> +++ b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> @@ -18,6 +18,7 @@ class DmaHeap\n> public:\n> \tDmaHeap();\n> \t~DmaHeap();\n> +\tint isValid() const { return dmaHeapHandle_ > -1; }\n\nMaybe bool ?\n\n> \tFileDescriptor alloc(const char *name, std::size_t size);\n>\n> private:\n> --\n> 2.28.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DD7BBDC71\n\tfor ;\n\tFri, 28 Aug 2020 15:56:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD514628F3;\n\tFri, 28 Aug 2020 17:56:52 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75DB26037B\n\tfor ;\n\tFri, 28 Aug 2020 17:56:51 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 3A4C51BF203\n\tfor ;\n\tFri, 28 Aug 2020 15:56:50 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 28 Aug 2020 18:00:36 +0200","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200828160036.t2zo732mn6vjqxab@uno.localdomain>","References":"<20200828155136.541696-1-jacopo@jmondi.org>\n\t<20200828155136.541696-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200828155136.541696-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: raspberrypi:\n\tdmaheaps: Add isValid()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12212,"web_url":"https://patchwork.libcamera.org/comment/12212/","msgid":"","date":"2020-08-28T16:03:07","subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: raspberrypi:\n\tdmaheaps: Add isValid()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 28/08/2020 17:00, Jacopo Mondi wrote:\n> On Fri, Aug 28, 2020 at 05:51:35PM +0200, Jacopo Mondi wrote:\n>> Add isValid() method to verify the allocator device has been open\n>> correctly.\n>>\n>> Signed-off-by: Jacopo Mondi \n>> ---\n>> src/libcamera/pipeline/raspberrypi/dma_heaps.h | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/src/libcamera/pipeline/raspberrypi/dma_heaps.h b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n>> index ae6be1135f17..119abd26ed31 100644\n>> --- a/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n>> +++ b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n>> @@ -18,6 +18,7 @@ class DmaHeap\n>> public:\n>> \tDmaHeap();\n>> \t~DmaHeap();\n>> +\tint isValid() const { return dmaHeapHandle_ > -1; }\n> \n> Maybe bool ?\n> \n\nWith that changed,\n\nReviewed-by: Kieran Bingham \n\n>> \tFileDescriptor alloc(const char *name, std::size_t size);\n>>\n>> private:\n>> --\n>> 2.28.0\n>>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD802BF019\n\tfor ;\n\tFri, 28 Aug 2020 16:03:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4660762917;\n\tFri, 28 Aug 2020 18:03:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 950EA6037B\n\tfor ;\n\tFri, 28 Aug 2020 18:03:10 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1151F303;\n\tFri, 28 Aug 2020 18:03:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QC9WBiB9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598630590;\n\tbh=4igmAfIvcwPRvVfa9tLWDWQdQURlDPaNtT+plYJoh6U=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=QC9WBiB9yZmivKk9nUnVKIkbZI+RfrANe7Sm8iuTS65MfaKMza+W3QR5xyQCYChN8\n\tyFDpIgzyxLvGjARb/M8enrclQWL16oljnPgR4LXcZo31IvqBqdVKauW4mfcY6WSs8I\n\tze7hyApoyyan7H5Rnoa9VoUHN/5yF6qfcFLNKqBs=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20200828155136.541696-1-jacopo@jmondi.org>\n\t<20200828155136.541696-2-jacopo@jmondi.org>\n\t<20200828160036.t2zo732mn6vjqxab@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 28 Aug 2020 17:03:07 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200828160036.t2zo732mn6vjqxab@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: raspberrypi:\n\tdmaheaps: Add isValid()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12215,"web_url":"https://patchwork.libcamera.org/comment/12215/","msgid":"<20200828160715.GJ10034@pendragon.ideasonboard.com>","date":"2020-08-28T16:07:15","subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: raspberrypi:\n\tdmaheaps: Add isValid()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 28, 2020 at 05:03:07PM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n> \n> On 28/08/2020 17:00, Jacopo Mondi wrote:\n> > On Fri, Aug 28, 2020 at 05:51:35PM +0200, Jacopo Mondi wrote:\n> >> Add isValid() method to verify the allocator device has been open\n> >> correctly.\n> >>\n> >> Signed-off-by: Jacopo Mondi \n> >> ---\n> >> src/libcamera/pipeline/raspberrypi/dma_heaps.h | 1 +\n> >> 1 file changed, 1 insertion(+)\n> >>\n> >> diff --git a/src/libcamera/pipeline/raspberrypi/dma_heaps.h b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> >> index ae6be1135f17..119abd26ed31 100644\n> >> --- a/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> >> +++ b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> >> @@ -18,6 +18,7 @@ class DmaHeap\n> >> public:\n> >> \tDmaHeap();\n> >> \t~DmaHeap();\n> >> +\tint isValid() const { return dmaHeapHandle_ > -1; }\n> > \n> > Maybe bool ?\n> > \n> \n> With that changed,\n> \n> Reviewed-by: Kieran Bingham \n\nLikewise,\n\nReviewed-by: Laurent Pinchart \n\n> >> \tFileDescriptor alloc(const char *name, std::size_t size);\n> >>\n> >> private:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41FBEBDC71\n\tfor ;\n\tFri, 28 Aug 2020 16:07:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14784628F3;\n\tFri, 28 Aug 2020 18:07:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A99436037B\n\tfor ;\n\tFri, 28 Aug 2020 18:07:36 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F340303;\n\tFri, 28 Aug 2020 18:07:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nzipZnmZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598630856;\n\tbh=J7KNL8//QqngeUsFQuNoAaz6tgWdF1ialasT3gBRarc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nzipZnmZW1DZ/6Zj5YBJIY8AEqwGsZHt6B95UJ40lCLXf/culSlnBmNshyvF+0Qsa\n\tGW/ut4FML3/0ZOCNTgtQHuvck9YfqkQIycOYeISgveRCOLl1Brp/bJ5GRj1wTdRrVz\n\tIB2Qxy//halaeE+OKzsCJBicM9N5bWt5PFj0wU/g=","Date":"Fri, 28 Aug 2020 19:07:15 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200828160715.GJ10034@pendragon.ideasonboard.com>","References":"<20200828155136.541696-1-jacopo@jmondi.org>\n\t<20200828155136.541696-2-jacopo@jmondi.org>\n\t<20200828160036.t2zo732mn6vjqxab@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: raspberrypi:\n\tdmaheaps: Add isValid()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]