{"id":9422,"url":"https://patchwork.libcamera.org/api/patches/9422/?format=json","web_url":"https://patchwork.libcamera.org/patch/9422/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200828144110.17303-8-david.plowman@raspberrypi.com>","date":"2020-08-28T14:41:10","name":"[libcamera-devel,v4,7/7] libcamera: ipa: raspberrypi: ALSC: Handle user transform","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"925b363fef36d092def50ce22ca02dce4058de08","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9422/mbox/","series":[{"id":1250,"url":"https://patchwork.libcamera.org/api/series/1250/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1250","date":"2020-08-28T14:41:03","name":"2D transforms","version":4,"mbox":"https://patchwork.libcamera.org/series/1250/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9422/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9422/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D40D9BF019\n\tfor ;\n\tFri, 28 Aug 2020 14:41:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1F176291C;\n\tFri, 28 Aug 2020 16:41:25 +0200 (CEST)","from mail-wm1-x341.google.com (mail-wm1-x341.google.com\n\t[IPv6:2a00:1450:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11254628F3\n\tfor ;\n\tFri, 28 Aug 2020 16:41:23 +0200 (CEST)","by mail-wm1-x341.google.com with SMTP id t14so1132007wmi.3\n\tfor ;\n\tFri, 28 Aug 2020 07:41:23 -0700 (PDT)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\ts12sm2493724wmj.26.2020.08.28.07.41.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 28 Aug 2020 07:41:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"VwwNvkMQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=yqzzfDnOwH0Awzrjn/UOHYIemK1WmVNHkZJX33QDD+s=;\n\tb=VwwNvkMQdERJJyklkxtJ7tfuiRdOWY3LTtCGpXMr27vSDGXgVFV1+VijMM4HdnpDGS\n\tE5/Wuukod1gHpJ3k/lyw3T430EHhwoAAik9upH9rzG8lSPPSQ0mceaxhm65WyaKpGHaj\n\t4DWkuGqgP89BsnQszxD1GB19+yV//dsklca1VcUGOCIDAgYP+V+iuuvAjIl9S4zSWM6g\n\tVAgd32cfqD2RtKsLbCWqiEXaspZZ/w+Yum4jeGS6h7fc9JNw46tVyOYVa++ODeP8UFu/\n\t7j+3OOS2inQUUYn3MIYgPJcQckZi1MwbHJPIs/4hjFXK4adLXyMXccmaiQfvoa+llIg5\n\td5iw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=yqzzfDnOwH0Awzrjn/UOHYIemK1WmVNHkZJX33QDD+s=;\n\tb=YR5Rdbyb/DLIW6z6TCZSKSJklznHOC2WJwoHAJtNkE6saXWkN1C4QgoVdJsbm/D3AG\n\tmTRefH2xI2zI3gyKtgGxLGkjXUPkaQPtgS4hAsJ1mhG4KXrG/vez3K8i5H1+lsG7vrGP\n\tl7n+i8PekIIqVE30E7DDiHD8Y4oEO+K24GwL0g10GoIuVilk6ZHj27UyIzZwkTHSF7ZA\n\tpABrP94Gp0VzD/u0DejwXifFHdStaj9pg6ePjP880wrLxj6uPeAHLpDGDsm1VmVY5EpN\n\tZVgm0Qq87oSkc0CeQkMKxQ3W4fWJmNUDm8Ty8bUjOiZaSmDb3aY8acSdD6hEiVOXKZFP\n\t0a/g==","X-Gm-Message-State":"AOAM531+J8jynYVD9bI/kPx3L8pO1Gakrc4TOX3vE0aVKyNzTi95bmVt\n\t3PIiYWo1SGZ59h7b542FCRf1Deo3CJil9A==","X-Google-Smtp-Source":"ABdhPJybbLoH3jpI5AH+zFSEaAQfwcLRkTxnnWNumnDYx4FwqQ0TCg4kOb6/uWqL54Ivs46wuWDGzg==","X-Received":"by 2002:a7b:c2aa:: with SMTP id c10mr1924450wmk.86.1598625682532;\n\tFri, 28 Aug 2020 07:41:22 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 28 Aug 2020 15:41:10 +0100","Message-Id":"<20200828144110.17303-8-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20200828144110.17303-1-david.plowman@raspberrypi.com>","References":"<20200828144110.17303-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 7/7] libcamera: ipa: raspberrypi: ALSC:\n\tHandle user transform","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update ALSC (Auto Lens Shading Correction) to handle correctly the\nuser transform now passed in the camera mode.\n\nThe user transform is applied directly in the sensor so the image\nstatistics already incorporate it, and the adaptive algorithm is\nentirely agnostic towards it, so all we have to do is flip the\ncalibrated tables to match. (These tables will have been calibrated\nwithout the user transform.)\n\nSigned-off-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\nindex 0d0e0b0..f610de2 100644\n--- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n@@ -184,7 +184,10 @@ void Alsc::waitForAysncThread()\n \n static bool compare_modes(CameraMode const &cm0, CameraMode const &cm1)\n {\n-\t// Return true if the modes crop from the sensor significantly differently.\n+\t// Return true if the modes crop from the sensor significantly differently,\n+\t// or if the user transform has changed.\n+\tif (cm0.transform != cm1.transform)\n+\t\treturn true;\n \tint left_diff = abs(cm0.crop_x - cm1.crop_x);\n \tint top_diff = abs(cm0.crop_y - cm1.crop_y);\n \tint right_diff = fabs(cm0.crop_x + cm0.scale_x * cm0.width -\n@@ -428,6 +431,10 @@ void resample_cal_table(double const cal_table_in[XY],\n \t\txf[i] = x - x_lo[i];\n \t\tx_hi[i] = std::min(x_lo[i] + 1, X - 1);\n \t\tx_lo[i] = std::max(x_lo[i], 0);\n+\t\tif (!!(camera_mode.transform & libcamera::Transform::HFlip)) {\n+\t\t\tx_lo[i] = X - 1 - x_lo[i];\n+\t\t\tx_hi[i] = X - 1 - x_hi[i];\n+\t\t}\n \t}\n \t// Now march over the output table generating the new values.\n \tdouble scale_y = camera_mode.sensor_height /\n@@ -440,6 +447,10 @@ void resample_cal_table(double const cal_table_in[XY],\n \t\tdouble yf = y - y_lo;\n \t\tint y_hi = std::min(y_lo + 1, Y - 1);\n \t\ty_lo = std::max(y_lo, 0);\n+\t\tif (!!(camera_mode.transform & libcamera::Transform::VFlip)) {\n+\t\t\ty_lo = Y - 1 - y_lo;\n+\t\t\ty_hi = Y - 1 - y_hi;\n+\t\t}\n \t\tdouble const *row_above = cal_table_in + X * y_lo;\n \t\tdouble const *row_below = cal_table_in + X * y_hi;\n \t\tfor (int i = 0; i < X; i++) {\n","prefixes":["libcamera-devel","v4","7/7"]}