{"id":9397,"url":"https://patchwork.libcamera.org/api/patches/9397/?format=json","web_url":"https://patchwork.libcamera.org/patch/9397/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200826110926.67192-14-paul.elder@ideasonboard.com>","date":"2020-08-26T11:09:22","name":"[libcamera-devel,RFC,13/17] libcamera: PipelineHandler: Remove IPA from base class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4f08cbdaedbd4ccbdc4cf52700f277880b912cf0","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9397/mbox/","series":[{"id":1243,"url":"https://patchwork.libcamera.org/api/series/1243/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1243","date":"2020-08-26T11:09:09","name":"[libcamera-devel,RFC,01/17] IPA: IPC: raspberrypi: Add data definition and generated header","version":1,"mbox":"https://patchwork.libcamera.org/series/1243/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9397/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9397/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07D9ABD87E\n\tfor ;\n\tWed, 26 Aug 2020 11:10:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8B4C62912;\n\tWed, 26 Aug 2020 13:10:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC8AA628F9\n\tfor ;\n\tWed, 26 Aug 2020 13:10:19 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0AFE3B1A;\n\tWed, 26 Aug 2020 13:10:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MRE/3/fV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598440219;\n\tbh=sHQZxUf464cUUxWvh5t0rO7Wh4wGbbpd0kdCkgnFrhk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MRE/3/fVe31poWTnNbkGJWaWUBlm8k7RgTFRS5hHef8xZKemFvyQW6sMr8ErVmZ7S\n\tn7S2WQIYwUWgC4+YL4R5a3Dk3t5O/M3NViB3Ul3gbnO1OVXCBUqt786B1KDtM5u/d3\n\t2XRthtGYOGAf9iyrAPCP2lOarO5HOmXn1jtV2kxg=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 26 Aug 2020 20:09:22 +0900","Message-Id":"<20200826110926.67192-14-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200826110926.67192-1-paul.elder@ideasonboard.com>","References":"<20200826110926.67192-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 13/17] libcamera: PipelineHandler:\n\tRemove IPA from base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since pipline handlers now have their own IPA interface types, it can no\nlonger be defined in the base class, and each pipline handler\nimplementation must declare it and its type themselves. Remove it from\nthe base class.\n\nSigned-off-by: Paul Elder \n---\n include/libcamera/internal/pipeline_handler.h | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex a4e1b529..2018bef0 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -47,7 +47,6 @@ public:\n \tstd::list queuedRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n-\tstd::unique_ptr ipa_;\n \n private:\n \tCameraData(const CameraData &) = delete;\n","prefixes":["libcamera-devel","RFC","13/17"]}