{"id":9395,"url":"https://patchwork.libcamera.org/api/patches/9395/?format=json","web_url":"https://patchwork.libcamera.org/patch/9395/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200826110926.67192-12-paul.elder@ideasonboard.com>","date":"2020-08-26T11:09:20","name":"[libcamera-devel,RFC,11/17] libcamera: IPAProxy: Remove stop() override","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fa86ad9c1eb2f56683e2be12fcd1fb4fa478c87e","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9395/mbox/","series":[{"id":1243,"url":"https://patchwork.libcamera.org/api/series/1243/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1243","date":"2020-08-26T11:09:09","name":"[libcamera-devel,RFC,01/17] IPA: IPC: raspberrypi: Add data definition and generated header","version":1,"mbox":"https://patchwork.libcamera.org/series/1243/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9395/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9395/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BB17BD87E\n\tfor ;\n\tWed, 26 Aug 2020 11:10:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0997A628FB;\n\tWed, 26 Aug 2020 13:10:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F1D6628DD\n\tfor ;\n\tWed, 26 Aug 2020 13:10:15 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6AA189CE;\n\tWed, 26 Aug 2020 13:10:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tjxNlJeJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598440214;\n\tbh=3Tmzp3GTPNTq8PBgF2z8zvV2ry6agt6dvbi+OPuAp20=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tjxNlJeJ1prUZyypOJqhXNsfcrD97HTf0OogP97uDjW5mRPaB7884Dw9mjuem9f3V\n\tyZvwIiApfWCNPmmyx8h7n5N6jd3X0rZxeRJMlKNr8lboLhuHy5rhpkr4j/6KxQN/EA\n\txaNxaCCF2VcZUxRXexjhB5PTCLiYOVnrtNttAV2w=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 26 Aug 2020 20:09:20 +0900","Message-Id":"<20200826110926.67192-12-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200826110926.67192-1-paul.elder@ideasonboard.com>","References":"<20200826110926.67192-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 11/17] libcamera: IPAProxy: Remove\n\tstop() override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since stop() is part of the IPA interface, and the IPA interface is now\ngenerated based on the data definition file per pipeline, this no longer\nneeds to be overrided by the base IPAProxy. Remove it.\n\nSigned-off-by: Paul Elder \n---\n include/libcamera/internal/ipa_proxy.h | 2 --\n 1 file changed, 2 deletions(-)","diff":"diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex b429ce5a..aec8f04f 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -27,8 +27,6 @@ public:\n \n \tstd::string configurationFile(const std::string &file) const;\n \n-\tvoid stop() override = 0;\n-\n protected:\n \tstd::string resolvePath(const std::string &file) const;\n \n","prefixes":["libcamera-devel","RFC","11/17"]}