[{"id":12127,"web_url":"https://patchwork.libcamera.org/comment/12127/","msgid":"","date":"2020-08-24T21:14:40","subject":"Re: [libcamera-devel] [PATCH 3/3] android: Support initial set of\n\tEXIF metadata tags","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 24/08/2020 21:46, Umang Jain wrote:\n> Support a initial set of EXIF metadata tags namely:\n> Make, Model, Height, Width, Orientation and Timestamp.\n> Each tag is set by a convenient high level helper API\n> defined in exif.h.\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/android/camera_device.cpp | 8 +++++++\n> src/android/jpeg/encoder_libjpeg.cpp | 12 ++++++++++\n> src/android/jpeg/exif.cpp | 34 ++++++++++++++++++++++++++++\n> src/android/jpeg/exif.h | 8 +++++++\n\nI'd merge the helpers directly into the Exif object creation patch (and\ntake authorship on that if you like), or as an additional patch on it's\nown after.\n\n\n> 4 files changed, 62 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index bc5690e..fcf378a 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1435,6 +1435,14 @@ void CameraDevice::requestComplete(Request *request)\n> \t\t}\n> \n> \t\tExif exif;\n> +\t\t/*\n> +\t\t * \\todo Discuss setMake String, maybe vendor ID?\n> +\t\t * KB suggested to leave it to \"libcamera\" for now.\n> +\t\t * setModel should use the 'model' property of the camera.\n> +\t\t */\n\nI think ultimately this will indeed need to come from some sort of\nvendor tag. But I don't think we have those yet, so libcamera should be\nfine for now ;-)\n\n> +\t\texif.setMake(\"Libcamera\");\n\nlibcamera always has a lowercase 'l'.\n\n> +\t\texif.setModel(\"cameraModel\");\n\nAha, are the patches for setting the model not integrated yet ?\n\nThat would indeed mean it's a todo for now, but hopefully that will be\nusable really soon, so I hope that can be done before these patches get in.\n\n\n> +\t\texif.setOrientation(orientation_);\n> \n> \t\tint jpeg_size = encoder->encode(buffer, mapped.maps()[0], &exif);\n> \t\tif (jpeg_size < 0) {\n> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\n> index 0cd93b6..f84def9 100644\n> --- a/src/android/jpeg/encoder_libjpeg.cpp\n> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n> @@ -213,7 +213,19 @@ int EncoderLibJpeg::encode(const FrameBuffer *source,\n> \telse\n> \t\tcompressRGB(&frame);\n> \n> +\texif->setWidth(compress_.image_width);\n> +\texif->setHeight(compress_.image_height);\n> +\texif->setTimestamp(source->metadata().timestamp);\n\nI hope all three of those could be obtained/determined in the layer\nabove, so we don't need to pass in the whole exif object, just the\ngenerated span,\n\n> +\n> +\tSpan exif_data = exif->generate();\n> +\n\nSo if you can do that in the camera_device.cpp, then we\n\n> \tjpeg_finish_compress(&compress_);\n> \n> +\tif (exif->size())\n> +\t\t/* Store Exif data in the JPEG_APP1 data block. */\n> +\t\tjpeg_write_marker(&compress_, JPEG_APP0 + 1,\n> +\t\t\t\t static_cast(exif_data.data()),\n> +\t\t\t\t exif_data.size());\n> +\n> \treturn size;\n> }\n> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n> index f6a9f5c..b7591d5 100644\n> --- a/src/android/jpeg/exif.cpp\n> +++ b/src/android/jpeg/exif.cpp\n> @@ -160,6 +160,40 @@ int Exif::setString(ExifIfd ifd, ExifTag tag, ExifFormat format, const std::stri\n> \treturn 0;\n> }\n> \n> +int Exif::setHeight(uint16_t height)\n> +{\n> +\tsetShort(EXIF_IFD_0, EXIF_TAG_IMAGE_LENGTH, height);\n> +\tsetLong(EXIF_IFD_EXIF, EXIF_TAG_PIXEL_Y_DIMENSION, height);\n> +\n> +\treturn 0;\n> +}\n> +\n> +int Exif::setWidth(uint16_t width)\n> +{\n> +\tsetShort(EXIF_IFD_0, EXIF_TAG_IMAGE_WIDTH, width);\n> +\tsetLong(EXIF_IFD_EXIF, EXIF_TAG_PIXEL_X_DIMENSION, width);\n> +\n> +\treturn 0;\n> +}\n> +\n> +int Exif::setTimestamp(const time_t timestamp)\n> +{\n> +\tstd::string ts(std::ctime(×tamp));\n> +\tint ret = setString(EXIF_IFD_0, EXIF_TAG_DATE_TIME, EXIF_FORMAT_ASCII, ts);\n> +\tif(ret < 0)\n> +\t\treturn ret;\n> +\n> +\tret = setString(EXIF_IFD_EXIF, EXIF_TAG_DATE_TIME_ORIGINAL, EXIF_FORMAT_ASCII, ts);\n> +\tif(ret < 0)\n> +\t\treturn ret;\n> +\n> +\tret = setString(EXIF_IFD_EXIF, EXIF_TAG_DATE_TIME_DIGITIZED, EXIF_FORMAT_ASCII, ts);\n> +\tif(ret < 0)\n> +\t\treturn ret;\n> +\n> +\treturn ret;\n> +}\n> +\n> Span Exif::generate()\n> {\n> \tif (exif_data_) {\n> diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h\n> index 7df83c7..6a8f5f5 100644\n> --- a/src/android/jpeg/exif.h\n> +++ b/src/android/jpeg/exif.h\n> @@ -11,6 +11,7 @@\n> \n> #include \n> \n> +#include \n> #include \n> \n> class Exif\n> @@ -24,6 +25,13 @@ public:\n> \tint setString(ExifIfd ifd, ExifTag tag, ExifFormat format, const std::string &item);\n> \tint setRational(ExifIfd ifd, ExifTag tag, uint32_t numerator, uint32_t denominator);\n> \n> +\tint setHeight(uint16_t height);\n> +\tint setMake(const std::string &make) { return setString(EXIF_IFD_0, EXIF_TAG_MAKE, EXIF_FORMAT_ASCII, make); }\n> +\tint setModel(const std::string &model) { return setString(EXIF_IFD_0, EXIF_TAG_MODEL, EXIF_FORMAT_ASCII, model); }\n> +\tint setOrientation(int orientation) { return setShort(EXIF_IFD_0, EXIF_TAG_ORIENTATION, orientation); }\n\nEven if they're short, I think these implementations would probably be\nbetter in the .cpp so that all helpers are in the same place.\n\nOrientation will potentially be more complex too, as I think there will\nneed to be a translation between the libcamera orientation value, and\nthe Exif orientation values.\n\nI remember seeing some helpful comments in the USB HAL in CrOS/Camera2\nfor that.\n\n\n> +\tint setTimestamp(const time_t timestamp);\n> +\tint setWidth(uint16_t width);\n\nI'd group by feature over sorting alphabetically, and keep setWidth,\nsetHeight together.\n\n--\nKieran\n\n\n> +\n> \tlibcamera::Span generate();\n> \tunsigned char *data() const { return exif_data_; }\n> \tunsigned int size() const { return size_; }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FA65BE173\n\tfor ;\n\tMon, 24 Aug 2020 21:14:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DE2F62818;\n\tMon, 24 Aug 2020 23:14:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8374616B1\n\tfor ;\n\tMon, 24 Aug 2020 23:14:43 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51D4C9CE;\n\tMon, 24 Aug 2020 23:14:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HIgXPhmK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598303683;\n\tbh=gd43UC6V+yEEA8HbwFmFEtGSscziG+u8EJpV7h5ccto=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=HIgXPhmKrrsapwsS/arPf+v7syiffBu3gnP9LpProCR7kl98AdpBU9ijOGkVbd5J2\n\twJfHNypNLixs52hRX/CD76l8M3tX95fS5+cbJtXAyM9JKhUpin6Ef1JZkF6PcPt+hx\n\tVFstLhH1m27Q2GI+3b2YCRgZn/Ebkvr3YhnZs5pc=","To":"Umang Jain , libcamera-devel@lists.libcamera.org","References":"<20200824204646.16866-1-email@uajain.com>\n\t<20200824204646.16866-4-email@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 24 Aug 2020 22:14:40 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200824204646.16866-4-email@uajain.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/3] android: Support initial set of\n\tEXIF metadata tags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12149,"web_url":"https://patchwork.libcamera.org/comment/12149/","msgid":"<20200825203455.GK6767@pendragon.ideasonboard.com>","date":"2020-08-25T20:34:55","subject":"Re: [libcamera-devel] [PATCH 3/3] android: Support initial set of\n\tEXIF metadata tags","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Aug 24, 2020 at 10:14:40PM +0100, Kieran Bingham wrote:\n> On 24/08/2020 21:46, Umang Jain wrote:\n> > Support a initial set of EXIF metadata tags namely:\n> > Make, Model, Height, Width, Orientation and Timestamp.\n> > Each tag is set by a convenient high level helper API\n> > defined in exif.h.\n> > \n> > Signed-off-by: Umang Jain \n> > ---\n> > src/android/camera_device.cpp | 8 +++++++\n> > src/android/jpeg/encoder_libjpeg.cpp | 12 ++++++++++\n> > src/android/jpeg/exif.cpp | 34 ++++++++++++++++++++++++++++\n> > src/android/jpeg/exif.h | 8 +++++++\n> \n> I'd merge the helpers directly into the Exif object creation patch (and\n> take authorship on that if you like), or as an additional patch on it's\n> own after.\n> \n> > 4 files changed, 62 insertions(+)\n> > \n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index bc5690e..fcf378a 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1435,6 +1435,14 @@ void CameraDevice::requestComplete(Request *request)\n> > \t\t}\n> > \n> > \t\tExif exif;\n> > +\t\t/*\n> > +\t\t * \\todo Discuss setMake String, maybe vendor ID?\n> > +\t\t * KB suggested to leave it to \"libcamera\" for now.\n> > +\t\t * setModel should use the 'model' property of the camera.\n> > +\t\t */\n> \n> I think ultimately this will indeed need to come from some sort of\n> vendor tag. But I don't think we have those yet, so libcamera should be\n> fine for now ;-)\n> \n> > +\t\texif.setMake(\"Libcamera\");\n> \n> libcamera always has a lowercase 'l'.\n> \n> > +\t\texif.setModel(\"cameraModel\");\n> \n> Aha, are the patches for setting the model not integrated yet ?\n> \n> That would indeed mean it's a todo for now, but hopefully that will be\n> usable really soon, so I hope that can be done before these patches get in.\n\nWouldn't the maker and vendor we expect here would be along the lines of\n\"Jolla\" / \"TheFirstOne\" or \"Google\" / \"Pixel 4\" ? I think we can thus\nhardcode them here, until we add support for a platform config/data\nfile. There's probably no point in filling these with the model reported\nby the pipeline handler, as that would just be extra code that will have\nto be replaced anyway.\n\n> > +\t\texif.setOrientation(orientation_);\n> > \n> > \t\tint jpeg_size = encoder->encode(buffer, mapped.maps()[0], &exif);\n> > \t\tif (jpeg_size < 0) {\n> > diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\n> > index 0cd93b6..f84def9 100644\n> > --- a/src/android/jpeg/encoder_libjpeg.cpp\n> > +++ b/src/android/jpeg/encoder_libjpeg.cpp\n> > @@ -213,7 +213,19 @@ int EncoderLibJpeg::encode(const FrameBuffer *source,\n> > \telse\n> > \t\tcompressRGB(&frame);\n> > \n> > +\texif->setWidth(compress_.image_width);\n> > +\texif->setHeight(compress_.image_height);\n> > +\texif->setTimestamp(source->metadata().timestamp);\n> \n> I hope all three of those could be obtained/determined in the layer\n> above, so we don't need to pass in the whole exif object, just the\n> generated span,\n> \n> > +\n> > +\tSpan exif_data = exif->generate();\n> > +\n> \n> So if you can do that in the camera_device.cpp, then we\n> \n> > \tjpeg_finish_compress(&compress_);\n> > \n> > +\tif (exif->size())\n> > +\t\t/* Store Exif data in the JPEG_APP1 data block. */\n> > +\t\tjpeg_write_marker(&compress_, JPEG_APP0 + 1,\n> > +\t\t\t\t static_cast(exif_data.data()),\n> > +\t\t\t\t exif_data.size());\n> > +\n> > \treturn size;\n> > }\n> > diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n> > index f6a9f5c..b7591d5 100644\n> > --- a/src/android/jpeg/exif.cpp\n> > +++ b/src/android/jpeg/exif.cpp\n> > @@ -160,6 +160,40 @@ int Exif::setString(ExifIfd ifd, ExifTag tag, ExifFormat format, const std::stri\n> > \treturn 0;\n> > }\n> > \n> > +int Exif::setHeight(uint16_t height)\n> > +{\n> > +\tsetShort(EXIF_IFD_0, EXIF_TAG_IMAGE_LENGTH, height);\n> > +\tsetLong(EXIF_IFD_EXIF, EXIF_TAG_PIXEL_Y_DIMENSION, height);\n> > +\n> > +\treturn 0;\n> > +}\n> > +\n> > +int Exif::setWidth(uint16_t width)\n> > +{\n> > +\tsetShort(EXIF_IFD_0, EXIF_TAG_IMAGE_WIDTH, width);\n> > +\tsetLong(EXIF_IFD_EXIF, EXIF_TAG_PIXEL_X_DIMENSION, width);\n> > +\n> > +\treturn 0;\n> > +}\n> > +\n> > +int Exif::setTimestamp(const time_t timestamp)\n> > +{\n> > +\tstd::string ts(std::ctime(×tamp));\n> > +\tint ret = setString(EXIF_IFD_0, EXIF_TAG_DATE_TIME, EXIF_FORMAT_ASCII, ts);\n> > +\tif(ret < 0)\n> > +\t\treturn ret;\n> > +\n> > +\tret = setString(EXIF_IFD_EXIF, EXIF_TAG_DATE_TIME_ORIGINAL, EXIF_FORMAT_ASCII, ts);\n> > +\tif(ret < 0)\n> > +\t\treturn ret;\n> > +\n> > +\tret = setString(EXIF_IFD_EXIF, EXIF_TAG_DATE_TIME_DIGITIZED, EXIF_FORMAT_ASCII, ts);\n> > +\tif(ret < 0)\n> > +\t\treturn ret;\n> > +\n> > +\treturn ret;\n> > +}\n> > +\n> > Span Exif::generate()\n> > {\n> > \tif (exif_data_) {\n> > diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h\n> > index 7df83c7..6a8f5f5 100644\n> > --- a/src/android/jpeg/exif.h\n> > +++ b/src/android/jpeg/exif.h\n> > @@ -11,6 +11,7 @@\n> > \n> > #include \n> > \n> > +#include \n> > #include \n> > \n> > class Exif\n> > @@ -24,6 +25,13 @@ public:\n> > \tint setString(ExifIfd ifd, ExifTag tag, ExifFormat format, const std::string &item);\n> > \tint setRational(ExifIfd ifd, ExifTag tag, uint32_t numerator, uint32_t denominator);\n> > \n> > +\tint setHeight(uint16_t height);\n> > +\tint setMake(const std::string &make) { return setString(EXIF_IFD_0, EXIF_TAG_MAKE, EXIF_FORMAT_ASCII, make); }\n> > +\tint setModel(const std::string &model) { return setString(EXIF_IFD_0, EXIF_TAG_MODEL, EXIF_FORMAT_ASCII, model); }\n> > +\tint setOrientation(int orientation) { return setShort(EXIF_IFD_0, EXIF_TAG_ORIENTATION, orientation); }\n> \n> Even if they're short, I think these implementations would probably be\n> better in the .cpp so that all helpers are in the same place.\n> \n> Orientation will potentially be more complex too, as I think there will\n> need to be a translation between the libcamera orientation value, and\n> the Exif orientation values.\n> \n> I remember seeing some helpful comments in the USB HAL in CrOS/Camera2\n> for that.\n> \n> > +\tint setTimestamp(const time_t timestamp);\n> > +\tint setWidth(uint16_t width);\n> \n> I'd group by feature over sorting alphabetically, and keep setWidth,\n> setHeight together.\n> \n> > +\n> > \tlibcamera::Span generate();\n> > \tunsigned char *data() const { return exif_data_; }\n> > \tunsigned int size() const { return size_; }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4AC3ABD87E\n\tfor ;\n\tTue, 25 Aug 2020 20:35:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4B2D62882;\n\tTue, 25 Aug 2020 22:35:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B93F6037C\n\tfor ;\n\tTue, 25 Aug 2020 22:35:16 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB530B96;\n\tTue, 25 Aug 2020 22:35:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i5CB+IvS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598387715;\n\tbh=58sFizW6n9MeGLMFKxFlD5Cz8MrH/Jvi2S16HDcjzVI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i5CB+IvSvLR/yIUpxSwhQdj2X2vpVg+EkRpXeSQTwCSSbbyMJ8DGxdxx/KBYJTLcy\n\t1f6G73pDvRxFOxyFM3tuS93YvaDolHj0OrgoUGBx5ii0A+UHQIwkBlTr4UoRNYJafo\n\tygKASvxHaxNJXvsbYIADD/boYUTqw6hYdtwv8cvE=","Date":"Tue, 25 Aug 2020 23:34:55 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200825203455.GK6767@pendragon.ideasonboard.com>","References":"<20200824204646.16866-1-email@uajain.com>\n\t<20200824204646.16866-4-email@uajain.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 3/3] android: Support initial set of\n\tEXIF metadata tags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]