[{"id":12118,"web_url":"https://patchwork.libcamera.org/comment/12118/","msgid":"<1890b62a-8c52-492c-1237-4c467a2fd8b5@ideasonboard.com>","date":"2020-08-24T10:01:38","subject":"Re: [libcamera-devel] [PATCH 5/5] ipa: raspberrypi: Replace void\n\tcast with [[maybe_unused]]","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/08/2020 21:00, Laurent Pinchart wrote:\n> The standard way in C++17 to specify that a function or function\n> argument may be unused it to specify the [[maybe_unused]] attribute.\n> Replace manual void casts to silence compiler warnings.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/raspberrypi/controller/algorithm.cpp | 16 ++++++----------\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 8 +++-----\n> src/ipa/raspberrypi/controller/rpi/contrast.cpp | 4 ++--\n> src/ipa/raspberrypi/controller/rpi/noise.cpp | 5 ++---\n> src/ipa/raspberrypi/controller/rpi/sharpen.cpp | 5 ++---\n> 5 files changed, 15 insertions(+), 23 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/algorithm.cpp b/src/ipa/raspberrypi/controller/algorithm.cpp\n> index 55cb2012e63b..1b80e29602f4 100644\n> --- a/src/ipa/raspberrypi/controller/algorithm.cpp\n> +++ b/src/ipa/raspberrypi/controller/algorithm.cpp\n> @@ -9,28 +9,24 @@\n> \n> using namespace RPi;\n> \n> -void Algorithm::Read(boost::property_tree::ptree const ¶ms)\n> +void Algorithm::Read([[maybe_unused]] boost::property_tree::ptree const ¶ms)\n> {\n> -\t(void)params;\n> }\n> \n> void Algorithm::Initialise() {}\n> \n> -void Algorithm::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Algorithm::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,\n> +\t\t\t [[maybe_unused]] Metadata *metadata)\n> {\n> -\t(void)camera_mode;\n> -\t(void)metadata;\n> }\n> \n> -void Algorithm::Prepare(Metadata *image_metadata)\n> +void Algorithm::Prepare([[maybe_unused]] Metadata *image_metadata)\n> {\n> -\t(void)image_metadata;\n> }\n> \n> -void Algorithm::Process(StatisticsPtr &stats, Metadata *image_metadata)\n> +void Algorithm::Process([[maybe_unused]] StatisticsPtr &stats,\n> +\t\t\t[[maybe_unused]] Metadata *image_metadata)\n> {\n> -\t(void)stats;\n> -\t(void)image_metadata;\n> }\n> \n> // For registering algorithms with the system:\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> index 9df713a37a69..0d0e0b0c8fc4 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> @@ -200,10 +200,9 @@ static bool compare_modes(CameraMode const &cm0, CameraMode const &cm1)\n> \t top_diff > threshold_y || bottom_diff > threshold_y;\n> }\n> \n> -void Alsc::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Alsc::SwitchMode(CameraMode const &camera_mode,\n> +\t\t [[maybe_unused]] Metadata *metadata)\n> {\n> -\t(void)metadata;\n> -\n> \t// We're going to start over with the tables if there's any \"significant\"\n> \t// change.\n> \tbool reset_tables = first_time_ || compare_modes(camera_mode_, camera_mode);\n> @@ -490,7 +489,7 @@ void compensate_lambdas_for_cal(double const cal_table[XY],\n> \t\tnew_lambdas[i] /= min_new_lambda;\n> }\n> \n> -static void print_cal_table(double const C[XY])\n> +[[maybe_unused]] static void print_cal_table(double const C[XY])\n> {\n> \tprintf(\"table: [\\n\");\n> \tfor (int j = 0; j < Y; j++) {\n> @@ -710,7 +709,6 @@ void Alsc::doAlsc()\n> \tresample_cal_table(cal_table_tmp, camera_mode_, cal_table_b);\n> \t// You could print out the cal tables for this image here, if you're\n> \t// tuning the algorithm...\n> -\t(void)print_cal_table;\n> \t// Apply any calibration to the statistics, so the adaptive algorithm\n> \t// makes only the extra adjustments.\n> \tapply_cal_table(cal_table_r, Cr);\n> diff --git a/src/ipa/raspberrypi/controller/rpi/contrast.cpp b/src/ipa/raspberrypi/controller/rpi/contrast.cpp\n> index e4967990c577..c8d9ab6184f5 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/contrast.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/contrast.cpp\n> @@ -137,9 +137,9 @@ Pwl apply_manual_contrast(Pwl const &gamma_curve, double brightness,\n> \treturn new_gamma_curve;\n> }\n> \n> -void Contrast::Process(StatisticsPtr &stats, Metadata *image_metadata)\n> +void Contrast::Process(StatisticsPtr &stats,\n> +\t\t [[maybe_unused]] Metadata *image_metadata)\n> {\n> -\t(void)image_metadata;\n> \tdouble brightness = brightness_, contrast = contrast_;\n> \tHistogram histogram(stats->hist[0].g_hist, NUM_HISTOGRAM_BINS);\n> \t// We look at the histogram and adjust the gamma curve in the following\n> diff --git a/src/ipa/raspberrypi/controller/rpi/noise.cpp b/src/ipa/raspberrypi/controller/rpi/noise.cpp\n> index 2cafde3ab951..1b84ecb0b22c 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/noise.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/noise.cpp\n> @@ -27,10 +27,9 @@ char const *Noise::Name() const\n> \treturn NAME;\n> }\n> \n> -void Noise::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Noise::SwitchMode(CameraMode const &camera_mode,\n> +\t\t [[maybe_unused]] Metadata *metadata)\n> {\n> -\t(void)metadata;\n> -\n> \t// For example, we would expect a 2x2 binned mode to have a \"noise\n> \t// factor\" of sqrt(2x2) = 2. (can't be less than one, right?)\n> \tmode_factor_ = std::max(1.0, camera_mode.noise_factor);\n> diff --git a/src/ipa/raspberrypi/controller/rpi/sharpen.cpp b/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n> index 2b701db5367c..356c10588d01 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n> @@ -26,10 +26,9 @@ char const *Sharpen::Name() const\n> \treturn NAME;\n> }\n> \n> -void Sharpen::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Sharpen::SwitchMode(CameraMode const &camera_mode,\n> +\t\t\t [[maybe_unused]] Metadata *metadata)\n> {\n> -\t(void)metadata;\n> -\n> \t// can't be less than one, right?\n> \tmode_factor_ = std::max(1.0, camera_mode.noise_factor);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A31BBD87C\n\tfor ;\n\tMon, 24 Aug 2020 10:01:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA71962818;\n\tMon, 24 Aug 2020 12:01:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCC8A61ED9\n\tfor ;\n\tMon, 24 Aug 2020 12:01:42 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89B5E279;\n\tMon, 24 Aug 2020 12:01:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SMQTcXhz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598263300;\n\tbh=V/Fp3fFYk8xzFDuU5ux252+XOJdd48iqUoLHwHDxcaA=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=SMQTcXhzldIah/S2iVcP5Ljpq07IR3JYdx0hLLPccv0so3ZNSN21YdHLI6zbhbHCT\n\tJzks4/K+YAAz617cc6GVDpbhrU+FR8tfyMOUsHSQWmb1F5qLDnuYAEso6gy9p0uM26\n\twiU0XE/1Iw+PgFzTJG27Cn8z3e2uE/jSbqv/BTyw=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200822200037.20892-1-laurent.pinchart@ideasonboard.com>\n\t<20200822200037.20892-6-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<1890b62a-8c52-492c-1237-4c467a2fd8b5@ideasonboard.com>","Date":"Mon, 24 Aug 2020 11:01:38 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200822200037.20892-6-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 5/5] ipa: raspberrypi: Replace void\n\tcast with [[maybe_unused]]","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12130,"web_url":"https://patchwork.libcamera.org/comment/12130/","msgid":"<20200824213958.GE594558@oden.dyn.berto.se>","date":"2020-08-24T21:39:58","subject":"Re: [libcamera-devel] [PATCH 5/5] ipa: raspberrypi: Replace void\n\tcast with [[maybe_unused]]","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-08-22 23:00:37 +0300, Laurent Pinchart wrote:\n> The standard way in C++17 to specify that a function or function\n> argument may be unused it to specify the [[maybe_unused]] attribute.\n> Replace manual void casts to silence compiler warnings.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/ipa/raspberrypi/controller/algorithm.cpp | 16 ++++++----------\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 8 +++-----\n> src/ipa/raspberrypi/controller/rpi/contrast.cpp | 4 ++--\n> src/ipa/raspberrypi/controller/rpi/noise.cpp | 5 ++---\n> src/ipa/raspberrypi/controller/rpi/sharpen.cpp | 5 ++---\n> 5 files changed, 15 insertions(+), 23 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/algorithm.cpp b/src/ipa/raspberrypi/controller/algorithm.cpp\n> index 55cb2012e63b..1b80e29602f4 100644\n> --- a/src/ipa/raspberrypi/controller/algorithm.cpp\n> +++ b/src/ipa/raspberrypi/controller/algorithm.cpp\n> @@ -9,28 +9,24 @@\n> \n> using namespace RPi;\n> \n> -void Algorithm::Read(boost::property_tree::ptree const ¶ms)\n> +void Algorithm::Read([[maybe_unused]] boost::property_tree::ptree const ¶ms)\n> {\n> -\t(void)params;\n> }\n> \n> void Algorithm::Initialise() {}\n> \n> -void Algorithm::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Algorithm::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,\n> +\t\t\t [[maybe_unused]] Metadata *metadata)\n> {\n> -\t(void)camera_mode;\n> -\t(void)metadata;\n> }\n> \n> -void Algorithm::Prepare(Metadata *image_metadata)\n> +void Algorithm::Prepare([[maybe_unused]] Metadata *image_metadata)\n> {\n> -\t(void)image_metadata;\n> }\n> \n> -void Algorithm::Process(StatisticsPtr &stats, Metadata *image_metadata)\n> +void Algorithm::Process([[maybe_unused]] StatisticsPtr &stats,\n> +\t\t\t[[maybe_unused]] Metadata *image_metadata)\n> {\n> -\t(void)stats;\n> -\t(void)image_metadata;\n> }\n> \n> // For registering algorithms with the system:\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> index 9df713a37a69..0d0e0b0c8fc4 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> @@ -200,10 +200,9 @@ static bool compare_modes(CameraMode const &cm0, CameraMode const &cm1)\n> \t top_diff > threshold_y || bottom_diff > threshold_y;\n> }\n> \n> -void Alsc::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Alsc::SwitchMode(CameraMode const &camera_mode,\n> +\t\t [[maybe_unused]] Metadata *metadata)\n> {\n> -\t(void)metadata;\n> -\n> \t// We're going to start over with the tables if there's any \"significant\"\n> \t// change.\n> \tbool reset_tables = first_time_ || compare_modes(camera_mode_, camera_mode);\n> @@ -490,7 +489,7 @@ void compensate_lambdas_for_cal(double const cal_table[XY],\n> \t\tnew_lambdas[i] /= min_new_lambda;\n> }\n> \n> -static void print_cal_table(double const C[XY])\n> +[[maybe_unused]] static void print_cal_table(double const C[XY])\n> {\n> \tprintf(\"table: [\\n\");\n> \tfor (int j = 0; j < Y; j++) {\n> @@ -710,7 +709,6 @@ void Alsc::doAlsc()\n> \tresample_cal_table(cal_table_tmp, camera_mode_, cal_table_b);\n> \t// You could print out the cal tables for this image here, if you're\n> \t// tuning the algorithm...\n> -\t(void)print_cal_table;\n> \t// Apply any calibration to the statistics, so the adaptive algorithm\n> \t// makes only the extra adjustments.\n> \tapply_cal_table(cal_table_r, Cr);\n> diff --git a/src/ipa/raspberrypi/controller/rpi/contrast.cpp b/src/ipa/raspberrypi/controller/rpi/contrast.cpp\n> index e4967990c577..c8d9ab6184f5 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/contrast.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/contrast.cpp\n> @@ -137,9 +137,9 @@ Pwl apply_manual_contrast(Pwl const &gamma_curve, double brightness,\n> \treturn new_gamma_curve;\n> }\n> \n> -void Contrast::Process(StatisticsPtr &stats, Metadata *image_metadata)\n> +void Contrast::Process(StatisticsPtr &stats,\n> +\t\t [[maybe_unused]] Metadata *image_metadata)\n> {\n> -\t(void)image_metadata;\n> \tdouble brightness = brightness_, contrast = contrast_;\n> \tHistogram histogram(stats->hist[0].g_hist, NUM_HISTOGRAM_BINS);\n> \t// We look at the histogram and adjust the gamma curve in the following\n> diff --git a/src/ipa/raspberrypi/controller/rpi/noise.cpp b/src/ipa/raspberrypi/controller/rpi/noise.cpp\n> index 2cafde3ab951..1b84ecb0b22c 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/noise.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/noise.cpp\n> @@ -27,10 +27,9 @@ char const *Noise::Name() const\n> \treturn NAME;\n> }\n> \n> -void Noise::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Noise::SwitchMode(CameraMode const &camera_mode,\n> +\t\t [[maybe_unused]] Metadata *metadata)\n> {\n> -\t(void)metadata;\n> -\n> \t// For example, we would expect a 2x2 binned mode to have a \"noise\n> \t// factor\" of sqrt(2x2) = 2. (can't be less than one, right?)\n> \tmode_factor_ = std::max(1.0, camera_mode.noise_factor);\n> diff --git a/src/ipa/raspberrypi/controller/rpi/sharpen.cpp b/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n> index 2b701db5367c..356c10588d01 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/sharpen.cpp\n> @@ -26,10 +26,9 @@ char const *Sharpen::Name() const\n> \treturn NAME;\n> }\n> \n> -void Sharpen::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Sharpen::SwitchMode(CameraMode const &camera_mode,\n> +\t\t\t [[maybe_unused]] Metadata *metadata)\n> {\n> -\t(void)metadata;\n> -\n> \t// can't be less than one, right?\n> \tmode_factor_ = std::max(1.0, camera_mode.noise_factor);\n> }\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C90A7BD87C\n\tfor ;\n\tMon, 24 Aug 2020 21:40:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4792262818;\n\tMon, 24 Aug 2020 23:40:01 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C969616B1\n\tfor ;\n\tMon, 24 Aug 2020 23:40:00 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id v12so11388465ljc.10\n\tfor ;\n\tMon, 24 Aug 2020 14:39:59 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tb15sm2412314lji.140.2020.08.24.14.39.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 24 Aug 2020 14:39:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"KzOg93a3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=5sHq0Jl/UZ9RVaaNwpDjuTdgP54+gLe9gzMxb8sEQxQ=;\n\tb=KzOg93a3CB43y7B+OSTI098aX11LFegkohptjiYhI++409YSYSEi8hIhomC5eg68rT\n\tePHJzy97nROqVtJmdnEV6gITyo6VqtiwcHs9/zgLO1xSiuvxgEjhlKMfPobpSN3IG0sC\n\tHeYlhpCqe28sdeojQjugEjR9bTFA9bKaS1oHkhzGB6JJ/rDFqjZnufWe9dwuyGRqJuVS\n\tAzhJ6eLoc/R+HzD/nYOxObrFygmUHeH79Ck36j7x23Qm5H6K/O66rhfazvESMij/8AXT\n\t3x77Wk+Cfty0ozSDVKUKYaqzR4avzAetDV624Rs0T48I/Stz5/TVqB6syra2IcTxMYSP\n\tFCOA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=5sHq0Jl/UZ9RVaaNwpDjuTdgP54+gLe9gzMxb8sEQxQ=;\n\tb=CoDXUL3/SEz5yaT35wXpnATRi0/fzIhUu+i3NSMEBq3i2LFLqBJT1psoKGv/DA5vz6\n\tZ902LlN/OITjkpOipSd5ep5SiqXyUzCHbnY63aRRhPeh+XxQiX46rHmaBsj6UV7Vh4+h\n\tmivO9ChGeGmacdq5iDT+wRkWZkjd4zjhpzhK9QEUhBXwo1PjOElZ0qh+falE8iGEalhd\n\tYiwhBTgosraBj6+BaPRckLjhWuT9teA9ZymT3WrmIx/5sO8OJkCuocsyvrP2P8T/wYyg\n\tVgtNUcVgyNRRwRQf+VjlsiXnQdI4tj5fUmX2PRD98ILHmOQgSrxZRw7Uu+8LRdyrfnky\n\t8fFQ==","X-Gm-Message-State":"AOAM532wGy7ZQQSXFLxbdgO9amzfhxPLDud9wGfEa+V5XxDL11t9/Fxn\n\tp90DRxaFV+g40DhOqk4NxTvgKA==","X-Google-Smtp-Source":"ABdhPJz5KoC9gXsd8tx/UUVLm8kInz/bJf9pPm8uJvOqeDM0sJKVZAVuXptXrCb5hYbI9t+bBNY4uQ==","X-Received":"by 2002:a2e:b00f:: with SMTP id\n\ty15mr3668729ljk.223.1598305199272; \n\tMon, 24 Aug 2020 14:39:59 -0700 (PDT)","Date":"Mon, 24 Aug 2020 23:39:58 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200824213958.GE594558@oden.dyn.berto.se>","References":"<20200822200037.20892-1-laurent.pinchart@ideasonboard.com>\n\t<20200822200037.20892-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200822200037.20892-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 5/5] ipa: raspberrypi: Replace void\n\tcast with [[maybe_unused]]","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]