[{"id":12116,"web_url":"https://patchwork.libcamera.org/comment/12116/","msgid":"<107b3882-799d-187d-75bc-b175cd95e098@ideasonboard.com>","date":"2020-08-24T10:00:17","subject":"Re: [libcamera-devel] [PATCH 4/5] meson: Remove\n\t-Wno-unused-parameter","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/08/2020 21:00, Laurent Pinchart wrote:\n> We build libcamera with -Wno-unused-parameter and this doesn't cause\n> much issue internally. However, it prevents catching unused parameters\n> in inline functions defined in public headers. This can lead to\n> compilation warnings for applications compiled without\n> -Wno-unused-parameter.\n> \n> To catch those issues, remove -Wno-unused-parameter and fix all the\n> related warnings.\n\nOhhh removing warning disables makes me happy ;-)\n\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/bound_method.h | 2 +-\n> include/libcamera/signal.h | 2 +-\n> include/libcamera/span.h | 4 ++--\n> meson.build | 1 -\n> src/android/camera3_hal.cpp | 11 +++++----\n> src/android/camera_device.cpp | 5 ++--\n> src/android/camera_ops.cpp | 5 ++--\n> src/cam/main.cpp | 2 +-\n> src/gstreamer/gstlibcamerapool.cpp | 2 +-\n> src/gstreamer/gstlibcameraprovider.cpp | 2 +-\n> src/gstreamer/gstlibcamerasrc.cpp | 7 ++++--\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 3 ++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> src/ipa/rkisp1/rkisp1.cpp | 13 +++++++----\n> src/ipa/vimc/vimc.cpp | 16 ++++++-------\n> src/libcamera/device_enumerator_udev.cpp | 2 +-\n> src/libcamera/ipc_unixsocket.cpp | 2 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 5 ++--\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/pipeline/rkisp1/timeline.cpp | 2 +-\n> src/libcamera/process.cpp | 2 +-\n> src/libcamera/proxy/ipa_proxy_linux.cpp | 23 +++++++++++--------\n> src/libcamera/v4l2_pixelformat.cpp | 2 +-\n> src/libcamera/v4l2_videodevice.cpp | 4 ++--\n> src/qcam/dng_writer.cpp | 5 ++--\n> src/qcam/main.cpp | 2 +-\n> src/v4l2/v4l2_camera.cpp | 2 +-\n> test/camera/buffer_import.cpp | 3 ++-\n> test/camera/capture.cpp | 3 ++-\n> test/hotplug-cameras.cpp | 4 ++--\n> test/ipa/ipa_wrappers_test.cpp | 4 ++--\n> test/libtest/test.h | 2 +-\n> test/log/log_process.cpp | 3 ++-\n> test/object-invoke.cpp | 2 +-\n> test/process/process_test.cpp | 3 ++-\n> test/timer-thread.cpp | 2 +-\n> test/timer.cpp | 2 +-\n> 37 files changed, 89 insertions(+), 69 deletions(-)\n> \n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index 983bb5cbbad0..d1e4448304a9 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -214,7 +214,7 @@ public:\n> \n> \tbool match(R (*func)(Args...)) const { return func == func_; }\n> \n> -\tR activate(Args... args, bool deleteMethod = false) override\n> +\tR activate(Args... args, [[maybe_unused]] bool deleteMethod = false) override\n> \t{\n> \t\treturn (*func_)(args...);\n> \t}\n> diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\n> index ed30eb559127..accb797e911c 100644\n> --- a/include/libcamera/signal.h\n> +++ b/include/libcamera/signal.h\n> @@ -70,7 +70,7 @@ public:\n> \n> \tvoid disconnect()\n> \t{\n> -\t\tSignalBase::disconnect([](SlotList::iterator &iter) {\n> +\t\tSignalBase::disconnect([]([[maybe_unused]] SlotList::iterator &iter) {\n> \t\t\treturn true;\n> \t\t});\n> \t}\n> diff --git a/include/libcamera/span.h b/include/libcamera/span.h\n> index 513ddb432405..738af6aca871 100644\n> --- a/include/libcamera/span.h\n> +++ b/include/libcamera/span.h\n> @@ -113,12 +113,12 @@ public:\n> \t{\n> \t}\n> \n> -\tconstexpr Span(pointer ptr, size_type count)\n> +\tconstexpr Span(pointer ptr, [[maybe_unused]] size_type count)\n> \t\t: data_(ptr)\n> \t{\n> \t}\n> \n> -\tconstexpr Span(pointer first, pointer last)\n> +\tconstexpr Span(pointer first, [[maybe_unused]] pointer last)\n> \t\t: data_(first)\n> \t{\n> \t}\n> diff --git a/meson.build b/meson.build\n> index ce1d1c63ddc6..d7e8122ccaa3 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -37,7 +37,6 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n> endif\n> \n> common_arguments = [\n> - '-Wno-unused-parameter',\n> '-include', 'config.h',\n> ]\n> \n> diff --git a/src/android/camera3_hal.cpp b/src/android/camera3_hal.cpp\n> index decaf59e6915..ddcfea591ce6 100644\n> --- a/src/android/camera3_hal.cpp\n> +++ b/src/android/camera3_hal.cpp\n> @@ -32,18 +32,21 @@ static int hal_get_camera_info(int id, struct camera_info *info)\n> \treturn cameraManager.getCameraInfo(id, info);\n> }\n> \n> -static int hal_set_callbacks(const camera_module_callbacks_t *callbacks)\n> +static int hal_set_callbacks([[maybe_unused]] const camera_module_callbacks_t *callbacks)\n> {\n> \treturn 0;\n> }\n> \n> -static int hal_open_legacy(const struct hw_module_t *module, const char *id,\n> -\t\t\t uint32_t halVersion, struct hw_device_t **device)\n> +static int hal_open_legacy([[maybe_unused]] const struct hw_module_t *module,\n> +\t\t\t [[maybe_unused]] const char *id,\n> +\t\t\t [[maybe_unused]] uint32_t halVersion,\n> +\t\t\t [[maybe_unused]] struct hw_device_t **device)\n> {\n> \treturn -ENOSYS;\n> }\n> \n> -static int hal_set_torch_mode(const char *camera_id, bool enabled)\n> +static int hal_set_torch_mode([[maybe_unused]] const char *camera_id,\n> +\t\t\t [[maybe_unused]] bool enabled)\n> {\n> \treturn -ENOSYS;\n> }\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 3419236a061c..8a39bee690a0 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1541,8 +1541,9 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n> /*\n> * Produce a set of fixed result metadata.\n> */\n> -std::unique_ptr CameraDevice::getResultMetadata(int frame_number,\n> -\t\t\t\t\t\t\t\tint64_t timestamp)\n> +std::unique_ptr\n> +CameraDevice::getResultMetadata([[maybe_unused]] int frame_number,\n> +\t\t\t\tint64_t timestamp)\n> {\n> \t/*\n> \t * \\todo Keep this in sync with the actual number of entries.\n> diff --git a/src/android/camera_ops.cpp b/src/android/camera_ops.cpp\n> index 216ac285f964..696e80436821 100644\n> --- a/src/android/camera_ops.cpp\n> +++ b/src/android/camera_ops.cpp\n> @@ -61,11 +61,12 @@ static int hal_dev_process_capture_request(const struct camera3_device *dev,\n> \treturn camera->processCaptureRequest(request);\n> }\n> \n> -static void hal_dev_dump(const struct camera3_device *dev, int fd)\n> +static void hal_dev_dump([[maybe_unused]] const struct camera3_device *dev,\n> +\t\t\t [[maybe_unused]] int fd)\n> {\n> }\n> \n> -static int hal_dev_flush(const struct camera3_device *dev)\n> +static int hal_dev_flush([[maybe_unused]] const struct camera3_device *dev)\n> {\n> \treturn 0;\n> }\n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index cc3facd5a5b2..244720b491f5 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -378,7 +378,7 @@ int CamApp::run()\n> \treturn 0;\n> }\n> \n> -void signalHandler(int signal)\n> +void signalHandler([[maybe_unused]] int signal)\n> {\n> \tstd::cout << \"Exiting\" << std::endl;\n> \tCamApp::instance()->quit();\n> diff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\n> index 8f536169455f..b756ee356d61 100644\n> --- a/src/gstreamer/gstlibcamerapool.cpp\n> +++ b/src/gstreamer/gstlibcamerapool.cpp\n> @@ -33,7 +33,7 @@ G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL);\n> \n> static GstFlowReturn\n> gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer,\n> -\t\t\t\t GstBufferPoolAcquireParams *params)\n> +\t\t\t\t [[maybe_unused]] GstBufferPoolAcquireParams *params)\n> {\n> \tGstLibcameraPool *self = GST_LIBCAMERA_POOL(pool);\n> \tGstBuffer *buf = GST_BUFFER(gst_atomic_queue_pop(self->queue));\n> diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\n> index 840e87a3d8da..cd850d813a6e 100644\n> --- a/src/gstreamer/gstlibcameraprovider.cpp\n> +++ b/src/gstreamer/gstlibcameraprovider.cpp\n> @@ -89,7 +89,7 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id,\n> }\n> \n> static void\n> -gst_libcamera_device_init(GstLibcameraDevice *self)\n> +gst_libcamera_device_init([[maybe_unused]] GstLibcameraDevice *self)\n> {\n> }\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 0c28ae3f2852..1bfc2e2f8cf3 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -338,7 +338,8 @@ gst_libcamera_src_task_run(gpointer user_data)\n> }\n> \n> static void\n> -gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n> +gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n> +\t\t\t gpointer user_data)\n> {\n> \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> \tGLibRecLocker lock(&self->stream_lock);\n> @@ -467,7 +468,9 @@ done:\n> }\n> \n> static void\n> -gst_libcamera_src_task_leave(GstTask *task, GThread *thread, gpointer user_data)\n> +gst_libcamera_src_task_leave([[maybe_unused]] GstTask *task,\n> +\t\t\t [[maybe_unused]] GThread *thread,\n> +\t\t\t gpointer user_data)\n> {\n> \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> \tGstLibcameraSrcState *state = self->state;\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index c02b5ece242f..3573f36be46a 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -221,7 +221,8 @@ void Agc::SetConstraintMode(std::string const &constraint_mode_name)\n> \tconstraint_mode_name_ = constraint_mode_name;\n> }\n> \n> -void Agc::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Agc::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,\n> +\t\t Metadata *metadata)\n> {\n> \t// On a mode switch, it's possible the exposure profile could change,\n> \t// so we run through the dividing up of exposure/gain again and\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 37472087f5a9..4557016c2dd4 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -191,7 +191,7 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n> }\n> \n> void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n> -\t\t const std::map &streamConfig,\n> +\t\t [[maybe_unused]] const std::map &streamConfig,\n> \t\t const std::map &entityControls,\n> \t\t const IPAOperationData &ipaConfig,\n> \t\t IPAOperationData *result)\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 3a1c50c4add0..d95d902adff3 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -32,7 +32,10 @@ LOG_DEFINE_CATEGORY(IPARkISP1)\n> class IPARkISP1 : public IPAInterface\n> {\n> public:\n> -\tint init(const IPASettings &settings) override { return 0; }\n> +\tint init([[maybe_unused]] const IPASettings &settings) override\n> +\t{\n> +\t\treturn 0;\n> +\t}\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n> \n> @@ -75,11 +78,11 @@ private:\n> * assemble one. Make sure the reported sensor information are relevant\n> * before accessing them.\n> */\n> -void IPARkISP1::configure(const CameraSensorInfo &info,\n> -\t\t\t const std::map &streamConfig,\n> +void IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,\n> +\t\t\t [[maybe_unused]] const std::map &streamConfig,\n> \t\t\t const std::map &entityControls,\n> -\t\t\t const IPAOperationData &ipaConfig,\n> -\t\t\t IPAOperationData *result)\n> +\t\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t\t [[maybe_unused]] IPAOperationData *result)\n> {\n> \tif (entityControls.empty())\n> \t\treturn;\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 1593c92d80f3..ef257762a1d4 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -37,14 +37,14 @@ public:\n> \tint start() override;\n> \tvoid stop() override;\n> \n> -\tvoid configure(const CameraSensorInfo &sensorInfo,\n> -\t\t const std::map &streamConfig,\n> -\t\t const std::map &entityControls,\n> -\t\t const IPAOperationData &ipaConfig,\n> -\t\t IPAOperationData *result) override {}\n> -\tvoid mapBuffers(const std::vector &buffers) override {}\n> -\tvoid unmapBuffers(const std::vector &ids) override {}\n> -\tvoid processEvent(const IPAOperationData &event) override {}\n> +\tvoid configure([[maybe_unused]] const CameraSensorInfo &sensorInfo,\n> +\t\t [[maybe_unused]] const std::map &streamConfig,\n> +\t\t [[maybe_unused]] const std::map &entityControls,\n> +\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t [[maybe_unused]] IPAOperationData *result) override {}\n> +\tvoid mapBuffers([[maybe_unused]] const std::vector &buffers) override {}\n> +\tvoid unmapBuffers([[maybe_unused]] const std::vector &ids) override {}\n> +\tvoid processEvent([[maybe_unused]] const IPAOperationData &event) override {}\n> \n> private:\n> \tvoid initTrace();\n> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> index 96689daa5dd1..c6e23a1a7a18 100644\n> --- a/src/libcamera/device_enumerator_udev.cpp\n> +++ b/src/libcamera/device_enumerator_udev.cpp\n> @@ -327,7 +327,7 @@ int DeviceEnumeratorUdev::addV4L2Device(dev_t devnum)\n> \treturn 0;\n> }\n> \n> -void DeviceEnumeratorUdev::udevNotify(EventNotifier *notifier)\n> +void DeviceEnumeratorUdev::udevNotify([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tstruct udev_device *dev = udev_monitor_receive_device(monitor_);\n> \tstd::string action(udev_device_get_action(dev));\n> diff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp\n> index 7df86e885f23..701b2c518217 100644\n> --- a/src/libcamera/ipc_unixsocket.cpp\n> +++ b/src/libcamera/ipc_unixsocket.cpp\n> @@ -308,7 +308,7 @@ int IPCUnixSocket::recvData(void *buffer, size_t length,\n> \treturn 0;\n> }\n> \n> -void IPCUnixSocket::dataNotifier(EventNotifier *notifier)\n> +void IPCUnixSocket::dataNotifier([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tint ret;\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index b8f0549f0c60..42c9caa03e2e 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -758,7 +758,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \treturn ret;\n> }\n> \n> -int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream,\n> +int PipelineHandlerRPi::exportFrameBuffers([[maybe_unused]] Camera *camera, Stream *stream,\n> \t\t\t\t\t std::vector> *buffers)\n> {\n> \tRPiStream *s = static_cast(stream);\n> @@ -1182,7 +1182,8 @@ int RPiCameraData::configureIPA()\n> \treturn 0;\n> }\n> \n> -void RPiCameraData::queueFrameAction(unsigned int frame, const IPAOperationData &action)\n> +void RPiCameraData::queueFrameAction([[maybe_unused]] unsigned int frame,\n> +\t\t\t\t const IPAOperationData &action)\n> {\n> \t/*\n> \t * The following actions can be handled when the pipeline handler is in\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 32fdaed7c661..4d89aab3845d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -700,7 +700,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \treturn 0;\n> }\n> \n> -int PipelineHandlerRkISP1::exportFrameBuffers(Camera *camera, Stream *stream,\n> +int PipelineHandlerRkISP1::exportFrameBuffers([[maybe_unused]] Camera *camera, Stream *stream,\n> \t\t\t\t\t std::vector> *buffers)\n> {\n> \tunsigned int count = stream->configuration().bufferCount;\n> diff --git a/src/libcamera/pipeline/rkisp1/timeline.cpp b/src/libcamera/pipeline/rkisp1/timeline.cpp\n> index f5194608ced7..6b83bbe5b589 100644\n> --- a/src/libcamera/pipeline/rkisp1/timeline.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/timeline.cpp\n> @@ -204,7 +204,7 @@ void Timeline::updateDeadline()\n> \ttimer_.start(deadline);\n> }\n> \n> -void Timeline::timeout(Timer *timer)\n> +void Timeline::timeout([[maybe_unused]] Timer *timer)\n> {\n> \tutils::time_point now = std::chrono::steady_clock::now();\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 8311d274a288..994190dc6f3d 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -89,7 +89,7 @@ void sigact(int signal, siginfo_t *info, void *ucontext)\n> \n> } /* namespace */\n> \n> -void ProcessManager::sighandler(EventNotifier *notifier)\n> +void ProcessManager::sighandler([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tchar data;\n> \tssize_t ret = read(pipe_[0], &data, sizeof(data));\n> diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> index 68eafb307b2a..b78a0e4535f5 100644\n> --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> @@ -26,17 +26,20 @@ public:\n> \tIPAProxyLinux(IPAModule *ipam);\n> \t~IPAProxyLinux();\n> \n> -\tint init(const IPASettings &settings) override { return 0; }\n> +\tint init([[maybe_unused]] const IPASettings &settings) override\n> +\t{\n> +\t\treturn 0;\n> +\t}\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n> -\tvoid configure(const CameraSensorInfo &sensorInfo,\n> -\t\t const std::map &streamConfig,\n> -\t\t const std::map &entityControls,\n> -\t\t const IPAOperationData &ipaConfig,\n> -\t\t IPAOperationData *result) override {}\n> -\tvoid mapBuffers(const std::vector &buffers) override {}\n> -\tvoid unmapBuffers(const std::vector &ids) override {}\n> -\tvoid processEvent(const IPAOperationData &event) override {}\n> +\tvoid configure([[maybe_unused]] const CameraSensorInfo &sensorInfo,\n> +\t\t [[maybe_unused]] const std::map &streamConfig,\n> +\t\t [[maybe_unused]] const std::map &entityControls,\n> +\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t [[maybe_unused]] IPAOperationData *result) override {}\n> +\tvoid mapBuffers([[maybe_unused]] const std::vector &buffers) override {}\n> +\tvoid unmapBuffers([[maybe_unused]] const std::vector &ids) override {}\n> +\tvoid processEvent([[maybe_unused]] const IPAOperationData &event) override {}\n> \n> private:\n> \tvoid readyRead(IPCUnixSocket *ipc);\n> @@ -91,7 +94,7 @@ IPAProxyLinux::~IPAProxyLinux()\n> \tdelete socket_;\n> }\n> \n> -void IPAProxyLinux::readyRead(IPCUnixSocket *ipc)\n> +void IPAProxyLinux::readyRead([[maybe_unused]] IPCUnixSocket *ipc)\n> {\n> }\n> \n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 8391ec48ac10..30c94bb98f44 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -196,7 +196,7 @@ PixelFormat V4L2PixelFormat::toPixelFormat() const\n> * \\return The V4L2PixelFormat corresponding to \\a pixelFormat\n> */\n> V4L2PixelFormat V4L2PixelFormat::fromPixelFormat(const PixelFormat &pixelFormat,\n> -\t\t\t\t\t\t bool multiplanar)\n> +\t\t\t\t\t\t [[maybe_unused]] bool multiplanar)\n> {\n> \tconst PixelFormatInfo &info = PixelFormatInfo::info(pixelFormat);\n> \tif (!info.isValid())\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 652677ff1d4d..508522ef42bb 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1462,7 +1462,7 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> * For Capture video devices the FrameBuffer will contain valid data.\n> * For Output video devices the FrameBuffer can be considered empty.\n> */\n> -void V4L2VideoDevice::bufferAvailable(EventNotifier *notifier)\n> +void V4L2VideoDevice::bufferAvailable([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tFrameBuffer *buffer = dequeueBuffer();\n> \tif (!buffer)\n> @@ -1539,7 +1539,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n> * When this slot is called, a V4L2 event is available to be dequeued from the\n> * device.\n> */\n> -void V4L2VideoDevice::eventAvailable(EventNotifier *notifier)\n> +void V4L2VideoDevice::eventAvailable([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tstruct v4l2_event event{};\n> \tint ret = ioctl(VIDIOC_DQEVENT, &event);\n> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> index b5b81f0637b5..030d1387118d 100644\n> --- a/src/qcam/dng_writer.cpp\n> +++ b/src/qcam/dng_writer.cpp\n> @@ -215,7 +215,7 @@ void packScanlineIPU3(void *output, const void *input, unsigned int width)\n> \t}\n> }\n> \n> -void thumbScanlineIPU3(const FormatInfo &info, void *output,\n> +void thumbScanlineIPU3([[maybe_unused]] const FormatInfo &info, void *output,\n> \t\t const void *input, unsigned int width,\n> \t\t unsigned int stride)\n> {\n> @@ -350,7 +350,8 @@ static const std::map formatInfo = {\n> int DNGWriter::write(const char *filename, const Camera *camera,\n> \t\t const StreamConfiguration &config,\n> \t\t const ControlList &metadata,\n> -\t\t const FrameBuffer *buffer, const void *data)\n> +\t\t [[maybe_unused]] const FrameBuffer *buffer,\n> +\t\t const void *data)\n> {\n> \tconst auto it = formatInfo.find(config.pixelFormat);\n> \tif (it == formatInfo.cend()) {\n> diff --git a/src/qcam/main.cpp b/src/qcam/main.cpp\n> index b3468cbf47e2..bae358df0877 100644\n> --- a/src/qcam/main.cpp\n> +++ b/src/qcam/main.cpp\n> @@ -17,7 +17,7 @@\n> #include \"../cam/stream_options.h\"\n> #include \"main_window.h\"\n> \n> -void signalHandler(int signal)\n> +void signalHandler([[maybe_unused]] int signal)\n> {\n> \tqInfo() << \"Exiting\";\n> \tqApp->quit();\n> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\n> index 61bca0732447..7a22f983ec0e 100644\n> --- a/src/v4l2/v4l2_camera.cpp\n> +++ b/src/v4l2/v4l2_camera.cpp\n> @@ -158,7 +158,7 @@ int V4L2Camera::validateConfiguration(const PixelFormat &pixelFormat,\n> \treturn 0;\n> }\n> \n> -int V4L2Camera::allocBuffers(unsigned int count)\n> +int V4L2Camera::allocBuffers([[maybe_unused]] unsigned int count)\n> {\n> \tStream *stream = config_->at(0).stream();\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 97a8582761a7..d57ffa75edeb 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -33,7 +33,8 @@ public:\n> \t}\n> \n> protected:\n> -\tvoid bufferComplete(Request *request, FrameBuffer *buffer)\n> +\tvoid bufferComplete([[maybe_unused]] Request *request,\n> +\t\t\t FrameBuffer *buffer)\n> \t{\n> \t\tif (buffer->metadata().status != FrameMetadata::FrameSuccess)\n> \t\t\treturn;\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index 0fe3bf9be7f1..eb67bf2da71f 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -26,7 +26,8 @@ protected:\n> \tunsigned int completeBuffersCount_;\n> \tunsigned int completeRequestsCount_;\n> \n> -\tvoid bufferComplete(Request *request, FrameBuffer *buffer)\n> +\tvoid bufferComplete([[maybe_unused]] Request *request,\n> +\t\t\t FrameBuffer *buffer)\n> \t{\n> \t\tif (buffer->metadata().status != FrameMetadata::FrameSuccess)\n> \t\t\treturn;\n> diff --git a/test/hotplug-cameras.cpp b/test/hotplug-cameras.cpp\n> index 6a94535fa315..7d551eeb900d 100644\n> --- a/test/hotplug-cameras.cpp\n> +++ b/test/hotplug-cameras.cpp\n> @@ -26,12 +26,12 @@ using namespace libcamera;\n> class HotplugTest : public Test\n> {\n> protected:\n> -\tvoid cameraAddedHandler(std::shared_ptr cam)\n> +\tvoid cameraAddedHandler([[maybe_unused]] std::shared_ptr cam)\n> \t{\n> \t\tcameraAdded_ = true;\n> \t}\n> \n> -\tvoid cameraRemovedHandler(std::shared_ptr cam)\n> +\tvoid cameraRemovedHandler([[maybe_unused]] std::shared_ptr cam)\n> \t{\n> \t\tcameraRemoved_ = true;\n> \t}\n> diff --git a/test/ipa/ipa_wrappers_test.cpp b/test/ipa/ipa_wrappers_test.cpp\n> index 23c799da0663..59d991cbbf6a 100644\n> --- a/test/ipa/ipa_wrappers_test.cpp\n> +++ b/test/ipa/ipa_wrappers_test.cpp\n> @@ -70,8 +70,8 @@ public:\n> \tvoid configure(const CameraSensorInfo &sensorInfo,\n> \t\t const std::map &streamConfig,\n> \t\t const std::map &entityControls,\n> -\t\t const IPAOperationData &ipaConfig,\n> -\t\t IPAOperationData *result) override\n> +\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t [[maybe_unused]] IPAOperationData *result) override\n> \t{\n> \t\t/* Verify sensorInfo. */\n> \t\tif (sensorInfo.outputSize.width != 2560 ||\n> diff --git a/test/libtest/test.h b/test/libtest/test.h\n> index 26d4b94bc12d..8ecf2bda950f 100644\n> --- a/test/libtest/test.h\n> +++ b/test/libtest/test.h\n> @@ -30,7 +30,7 @@ protected:\n> };\n> \n> #define TEST_REGISTER(klass)\t\t\t\t\t\t\\\n> -int main(int argc, char *argv[])\t\t\t\t\t\\\n> +int main([[maybe_unused]] int argc, [[maybe_unused]] char *argv[])\t\\\n> {\t\t\t\t\t\t\t\t\t\\\n> \treturn klass().execute();\t\t\t\t\t\\\n> }\n> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\n> index d46d5e354727..b024f002843c 100644\n> --- a/test/log/log_process.cpp\n> +++ b/test/log/log_process.cpp\n> @@ -125,7 +125,8 @@ protected:\n> \t}\n> \n> private:\n> -\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n> +\tvoid procFinished([[maybe_unused]] Process *proc,\n> +\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n> \t{\n> \t\texitStatus_ = exitStatus;\n> \t\texitCode_ = exitCode;\n> diff --git a/test/object-invoke.cpp b/test/object-invoke.cpp\n> index 1ae11bb11e16..f3fd23283239 100644\n> --- a/test/object-invoke.cpp\n> +++ b/test/object-invoke.cpp\n> @@ -50,7 +50,7 @@ public:\n> \t\tvalue_ = value;\n> \t}\n> \n> -\tvoid methodWithReference(const int &value)\n> +\tvoid methodWithReference([[maybe_unused]] const int &value)\n> \t{\n> \t}\n> \n> diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp\n> index 721a7c9d46ff..42a26749f5d9 100644\n> --- a/test/process/process_test.cpp\n> +++ b/test/process/process_test.cpp\n> @@ -80,7 +80,8 @@ protected:\n> \t}\n> \n> private:\n> -\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n> +\tvoid procFinished([[maybe_unused]] Process *proc,\n> +\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n> \t{\n> \t\texitStatus_ = exitStatus;\n> \t\texitCode_ = exitCode;\n> diff --git a/test/timer-thread.cpp b/test/timer-thread.cpp\n> index 2f901787f5fb..f794d8e7dd4e 100644\n> --- a/test/timer-thread.cpp\n> +++ b/test/timer-thread.cpp\n> @@ -40,7 +40,7 @@ public:\n> \t}\n> \n> private:\n> -\tvoid timeoutHandler(Timer *timer)\n> +\tvoid timeoutHandler([[maybe_unused]] Timer *timer)\n> \t{\n> \t\ttimeout_ = true;\n> \t}\n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index 7d5b93c37799..537489d736ad 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -57,7 +57,7 @@ public:\n> \t}\n> \n> private:\n> -\tvoid timeoutHandler(Timer *timer)\n> +\tvoid timeoutHandler([[maybe_unused]] Timer *timer)\n> \t{\n> \t\texpiration_ = std::chrono::steady_clock::now();\n> \t\tcount_++;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C686BD87C\n\tfor ;\n\tMon, 24 Aug 2020 10:00:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D90B62849;\n\tMon, 24 Aug 2020 12:00:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E1B961ED9\n\tfor ;\n\tMon, 24 Aug 2020 12:00:22 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86859279;\n\tMon, 24 Aug 2020 12:00:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TT2dyYjO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598263219;\n\tbh=fiD4aXEoO6MnpGAoj+Whnt3k1NDID3pQ4ThQ2jDkpww=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=TT2dyYjO3OnAmy5hkvS2S51LM9jIyO5K+W3AYqnO0iz1pOnmgYcyPY5P4ozXGk3xz\n\tbKuAEbFG68YOjYbbdJKMLhoTZto7CIVzKXUSWtIpZpuD3DR83gJ4H72n388vB8FLvu\n\tHqVKX1XNpN4RDC5gtimtZeva42LPgO7oSDSaLc9A=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200822200037.20892-1-laurent.pinchart@ideasonboard.com>\n\t<20200822200037.20892-5-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<107b3882-799d-187d-75bc-b175cd95e098@ideasonboard.com>","Date":"Mon, 24 Aug 2020 11:00:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200822200037.20892-5-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 4/5] meson: Remove\n\t-Wno-unused-parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12120,"web_url":"https://patchwork.libcamera.org/comment/12120/","msgid":"<20200824124146.ggmomxnfserqypni@uno.localdomain>","date":"2020-08-24T12:41:46","subject":"Re: [libcamera-devel] [PATCH 4/5] meson: Remove\n\t-Wno-unused-parameter","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sat, Aug 22, 2020 at 11:00:36PM +0300, Laurent Pinchart wrote:\n> We build libcamera with -Wno-unused-parameter and this doesn't cause\n> much issue internally. However, it prevents catching unused parameters\n> in inline functions defined in public headers. This can lead to\n> compilation warnings for applications compiled without\n> -Wno-unused-parameter.\n>\n> To catch those issues, remove -Wno-unused-parameter and fix all the\n> related warnings.\n\nI would mention the usage of [[maybe_unused]] as that's what allows\nyou to drop the -Wno-unused-parameter flag :)\n\nLooks good otherwise.\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/bound_method.h | 2 +-\n> include/libcamera/signal.h | 2 +-\n> include/libcamera/span.h | 4 ++--\n> meson.build | 1 -\n> src/android/camera3_hal.cpp | 11 +++++----\n> src/android/camera_device.cpp | 5 ++--\n> src/android/camera_ops.cpp | 5 ++--\n> src/cam/main.cpp | 2 +-\n> src/gstreamer/gstlibcamerapool.cpp | 2 +-\n> src/gstreamer/gstlibcameraprovider.cpp | 2 +-\n> src/gstreamer/gstlibcamerasrc.cpp | 7 ++++--\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 3 ++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> src/ipa/rkisp1/rkisp1.cpp | 13 +++++++----\n> src/ipa/vimc/vimc.cpp | 16 ++++++-------\n> src/libcamera/device_enumerator_udev.cpp | 2 +-\n> src/libcamera/ipc_unixsocket.cpp | 2 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 5 ++--\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/pipeline/rkisp1/timeline.cpp | 2 +-\n> src/libcamera/process.cpp | 2 +-\n> src/libcamera/proxy/ipa_proxy_linux.cpp | 23 +++++++++++--------\n> src/libcamera/v4l2_pixelformat.cpp | 2 +-\n> src/libcamera/v4l2_videodevice.cpp | 4 ++--\n> src/qcam/dng_writer.cpp | 5 ++--\n> src/qcam/main.cpp | 2 +-\n> src/v4l2/v4l2_camera.cpp | 2 +-\n> test/camera/buffer_import.cpp | 3 ++-\n> test/camera/capture.cpp | 3 ++-\n> test/hotplug-cameras.cpp | 4 ++--\n> test/ipa/ipa_wrappers_test.cpp | 4 ++--\n> test/libtest/test.h | 2 +-\n> test/log/log_process.cpp | 3 ++-\n> test/object-invoke.cpp | 2 +-\n> test/process/process_test.cpp | 3 ++-\n> test/timer-thread.cpp | 2 +-\n> test/timer.cpp | 2 +-\n> 37 files changed, 89 insertions(+), 69 deletions(-)\n>\n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index 983bb5cbbad0..d1e4448304a9 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -214,7 +214,7 @@ public:\n>\n> \tbool match(R (*func)(Args...)) const { return func == func_; }\n>\n> -\tR activate(Args... args, bool deleteMethod = false) override\n> +\tR activate(Args... args, [[maybe_unused]] bool deleteMethod = false) override\n> \t{\n> \t\treturn (*func_)(args...);\n> \t}\n> diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\n> index ed30eb559127..accb797e911c 100644\n> --- a/include/libcamera/signal.h\n> +++ b/include/libcamera/signal.h\n> @@ -70,7 +70,7 @@ public:\n>\n> \tvoid disconnect()\n> \t{\n> -\t\tSignalBase::disconnect([](SlotList::iterator &iter) {\n> +\t\tSignalBase::disconnect([]([[maybe_unused]] SlotList::iterator &iter) {\n> \t\t\treturn true;\n> \t\t});\n> \t}\n> diff --git a/include/libcamera/span.h b/include/libcamera/span.h\n> index 513ddb432405..738af6aca871 100644\n> --- a/include/libcamera/span.h\n> +++ b/include/libcamera/span.h\n> @@ -113,12 +113,12 @@ public:\n> \t{\n> \t}\n>\n> -\tconstexpr Span(pointer ptr, size_type count)\n> +\tconstexpr Span(pointer ptr, [[maybe_unused]] size_type count)\n> \t\t: data_(ptr)\n> \t{\n> \t}\n>\n> -\tconstexpr Span(pointer first, pointer last)\n> +\tconstexpr Span(pointer first, [[maybe_unused]] pointer last)\n> \t\t: data_(first)\n> \t{\n> \t}\n> diff --git a/meson.build b/meson.build\n> index ce1d1c63ddc6..d7e8122ccaa3 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -37,7 +37,6 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n> endif\n>\n> common_arguments = [\n> - '-Wno-unused-parameter',\n> '-include', 'config.h',\n> ]\n>\n> diff --git a/src/android/camera3_hal.cpp b/src/android/camera3_hal.cpp\n> index decaf59e6915..ddcfea591ce6 100644\n> --- a/src/android/camera3_hal.cpp\n> +++ b/src/android/camera3_hal.cpp\n> @@ -32,18 +32,21 @@ static int hal_get_camera_info(int id, struct camera_info *info)\n> \treturn cameraManager.getCameraInfo(id, info);\n> }\n>\n> -static int hal_set_callbacks(const camera_module_callbacks_t *callbacks)\n> +static int hal_set_callbacks([[maybe_unused]] const camera_module_callbacks_t *callbacks)\n> {\n> \treturn 0;\n> }\n>\n> -static int hal_open_legacy(const struct hw_module_t *module, const char *id,\n> -\t\t\t uint32_t halVersion, struct hw_device_t **device)\n> +static int hal_open_legacy([[maybe_unused]] const struct hw_module_t *module,\n> +\t\t\t [[maybe_unused]] const char *id,\n> +\t\t\t [[maybe_unused]] uint32_t halVersion,\n> +\t\t\t [[maybe_unused]] struct hw_device_t **device)\n> {\n> \treturn -ENOSYS;\n> }\n>\n> -static int hal_set_torch_mode(const char *camera_id, bool enabled)\n> +static int hal_set_torch_mode([[maybe_unused]] const char *camera_id,\n> +\t\t\t [[maybe_unused]] bool enabled)\n> {\n> \treturn -ENOSYS;\n> }\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 3419236a061c..8a39bee690a0 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1541,8 +1541,9 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n> /*\n> * Produce a set of fixed result metadata.\n> */\n> -std::unique_ptr CameraDevice::getResultMetadata(int frame_number,\n> -\t\t\t\t\t\t\t\tint64_t timestamp)\n> +std::unique_ptr\n> +CameraDevice::getResultMetadata([[maybe_unused]] int frame_number,\n> +\t\t\t\tint64_t timestamp)\n> {\n> \t/*\n> \t * \\todo Keep this in sync with the actual number of entries.\n> diff --git a/src/android/camera_ops.cpp b/src/android/camera_ops.cpp\n> index 216ac285f964..696e80436821 100644\n> --- a/src/android/camera_ops.cpp\n> +++ b/src/android/camera_ops.cpp\n> @@ -61,11 +61,12 @@ static int hal_dev_process_capture_request(const struct camera3_device *dev,\n> \treturn camera->processCaptureRequest(request);\n> }\n>\n> -static void hal_dev_dump(const struct camera3_device *dev, int fd)\n> +static void hal_dev_dump([[maybe_unused]] const struct camera3_device *dev,\n> +\t\t\t [[maybe_unused]] int fd)\n> {\n> }\n>\n> -static int hal_dev_flush(const struct camera3_device *dev)\n> +static int hal_dev_flush([[maybe_unused]] const struct camera3_device *dev)\n> {\n> \treturn 0;\n> }\n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index cc3facd5a5b2..244720b491f5 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -378,7 +378,7 @@ int CamApp::run()\n> \treturn 0;\n> }\n>\n> -void signalHandler(int signal)\n> +void signalHandler([[maybe_unused]] int signal)\n> {\n> \tstd::cout << \"Exiting\" << std::endl;\n> \tCamApp::instance()->quit();\n> diff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\n> index 8f536169455f..b756ee356d61 100644\n> --- a/src/gstreamer/gstlibcamerapool.cpp\n> +++ b/src/gstreamer/gstlibcamerapool.cpp\n> @@ -33,7 +33,7 @@ G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL);\n>\n> static GstFlowReturn\n> gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer,\n> -\t\t\t\t GstBufferPoolAcquireParams *params)\n> +\t\t\t\t [[maybe_unused]] GstBufferPoolAcquireParams *params)\n> {\n> \tGstLibcameraPool *self = GST_LIBCAMERA_POOL(pool);\n> \tGstBuffer *buf = GST_BUFFER(gst_atomic_queue_pop(self->queue));\n> diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\n> index 840e87a3d8da..cd850d813a6e 100644\n> --- a/src/gstreamer/gstlibcameraprovider.cpp\n> +++ b/src/gstreamer/gstlibcameraprovider.cpp\n> @@ -89,7 +89,7 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id,\n> }\n>\n> static void\n> -gst_libcamera_device_init(GstLibcameraDevice *self)\n> +gst_libcamera_device_init([[maybe_unused]] GstLibcameraDevice *self)\n> {\n> }\n>\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 0c28ae3f2852..1bfc2e2f8cf3 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -338,7 +338,8 @@ gst_libcamera_src_task_run(gpointer user_data)\n> }\n>\n> static void\n> -gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n> +gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n> +\t\t\t gpointer user_data)\n> {\n> \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> \tGLibRecLocker lock(&self->stream_lock);\n> @@ -467,7 +468,9 @@ done:\n> }\n>\n> static void\n> -gst_libcamera_src_task_leave(GstTask *task, GThread *thread, gpointer user_data)\n> +gst_libcamera_src_task_leave([[maybe_unused]] GstTask *task,\n> +\t\t\t [[maybe_unused]] GThread *thread,\n> +\t\t\t gpointer user_data)\n> {\n> \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> \tGstLibcameraSrcState *state = self->state;\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index c02b5ece242f..3573f36be46a 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -221,7 +221,8 @@ void Agc::SetConstraintMode(std::string const &constraint_mode_name)\n> \tconstraint_mode_name_ = constraint_mode_name;\n> }\n>\n> -void Agc::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Agc::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,\n> +\t\t Metadata *metadata)\n> {\n> \t// On a mode switch, it's possible the exposure profile could change,\n> \t// so we run through the dividing up of exposure/gain again and\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 37472087f5a9..4557016c2dd4 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -191,7 +191,7 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n> }\n>\n> void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n> -\t\t const std::map &streamConfig,\n> +\t\t [[maybe_unused]] const std::map &streamConfig,\n> \t\t const std::map &entityControls,\n> \t\t const IPAOperationData &ipaConfig,\n> \t\t IPAOperationData *result)\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 3a1c50c4add0..d95d902adff3 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -32,7 +32,10 @@ LOG_DEFINE_CATEGORY(IPARkISP1)\n> class IPARkISP1 : public IPAInterface\n> {\n> public:\n> -\tint init(const IPASettings &settings) override { return 0; }\n> +\tint init([[maybe_unused]] const IPASettings &settings) override\n> +\t{\n> +\t\treturn 0;\n> +\t}\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n>\n> @@ -75,11 +78,11 @@ private:\n> * assemble one. Make sure the reported sensor information are relevant\n> * before accessing them.\n> */\n> -void IPARkISP1::configure(const CameraSensorInfo &info,\n> -\t\t\t const std::map &streamConfig,\n> +void IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,\n> +\t\t\t [[maybe_unused]] const std::map &streamConfig,\n> \t\t\t const std::map &entityControls,\n> -\t\t\t const IPAOperationData &ipaConfig,\n> -\t\t\t IPAOperationData *result)\n> +\t\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t\t [[maybe_unused]] IPAOperationData *result)\n> {\n> \tif (entityControls.empty())\n> \t\treturn;\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 1593c92d80f3..ef257762a1d4 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -37,14 +37,14 @@ public:\n> \tint start() override;\n> \tvoid stop() override;\n>\n> -\tvoid configure(const CameraSensorInfo &sensorInfo,\n> -\t\t const std::map &streamConfig,\n> -\t\t const std::map &entityControls,\n> -\t\t const IPAOperationData &ipaConfig,\n> -\t\t IPAOperationData *result) override {}\n> -\tvoid mapBuffers(const std::vector &buffers) override {}\n> -\tvoid unmapBuffers(const std::vector &ids) override {}\n> -\tvoid processEvent(const IPAOperationData &event) override {}\n> +\tvoid configure([[maybe_unused]] const CameraSensorInfo &sensorInfo,\n> +\t\t [[maybe_unused]] const std::map &streamConfig,\n> +\t\t [[maybe_unused]] const std::map &entityControls,\n> +\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t [[maybe_unused]] IPAOperationData *result) override {}\n> +\tvoid mapBuffers([[maybe_unused]] const std::vector &buffers) override {}\n> +\tvoid unmapBuffers([[maybe_unused]] const std::vector &ids) override {}\n> +\tvoid processEvent([[maybe_unused]] const IPAOperationData &event) override {}\n>\n> private:\n> \tvoid initTrace();\n> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> index 96689daa5dd1..c6e23a1a7a18 100644\n> --- a/src/libcamera/device_enumerator_udev.cpp\n> +++ b/src/libcamera/device_enumerator_udev.cpp\n> @@ -327,7 +327,7 @@ int DeviceEnumeratorUdev::addV4L2Device(dev_t devnum)\n> \treturn 0;\n> }\n>\n> -void DeviceEnumeratorUdev::udevNotify(EventNotifier *notifier)\n> +void DeviceEnumeratorUdev::udevNotify([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tstruct udev_device *dev = udev_monitor_receive_device(monitor_);\n> \tstd::string action(udev_device_get_action(dev));\n> diff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp\n> index 7df86e885f23..701b2c518217 100644\n> --- a/src/libcamera/ipc_unixsocket.cpp\n> +++ b/src/libcamera/ipc_unixsocket.cpp\n> @@ -308,7 +308,7 @@ int IPCUnixSocket::recvData(void *buffer, size_t length,\n> \treturn 0;\n> }\n>\n> -void IPCUnixSocket::dataNotifier(EventNotifier *notifier)\n> +void IPCUnixSocket::dataNotifier([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tint ret;\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index b8f0549f0c60..42c9caa03e2e 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -758,7 +758,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \treturn ret;\n> }\n>\n> -int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream,\n> +int PipelineHandlerRPi::exportFrameBuffers([[maybe_unused]] Camera *camera, Stream *stream,\n> \t\t\t\t\t std::vector> *buffers)\n> {\n> \tRPiStream *s = static_cast(stream);\n> @@ -1182,7 +1182,8 @@ int RPiCameraData::configureIPA()\n> \treturn 0;\n> }\n>\n> -void RPiCameraData::queueFrameAction(unsigned int frame, const IPAOperationData &action)\n> +void RPiCameraData::queueFrameAction([[maybe_unused]] unsigned int frame,\n> +\t\t\t\t const IPAOperationData &action)\n> {\n> \t/*\n> \t * The following actions can be handled when the pipeline handler is in\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 32fdaed7c661..4d89aab3845d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -700,7 +700,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \treturn 0;\n> }\n>\n> -int PipelineHandlerRkISP1::exportFrameBuffers(Camera *camera, Stream *stream,\n> +int PipelineHandlerRkISP1::exportFrameBuffers([[maybe_unused]] Camera *camera, Stream *stream,\n> \t\t\t\t\t std::vector> *buffers)\n> {\n> \tunsigned int count = stream->configuration().bufferCount;\n> diff --git a/src/libcamera/pipeline/rkisp1/timeline.cpp b/src/libcamera/pipeline/rkisp1/timeline.cpp\n> index f5194608ced7..6b83bbe5b589 100644\n> --- a/src/libcamera/pipeline/rkisp1/timeline.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/timeline.cpp\n> @@ -204,7 +204,7 @@ void Timeline::updateDeadline()\n> \ttimer_.start(deadline);\n> }\n>\n> -void Timeline::timeout(Timer *timer)\n> +void Timeline::timeout([[maybe_unused]] Timer *timer)\n> {\n> \tutils::time_point now = std::chrono::steady_clock::now();\n>\n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 8311d274a288..994190dc6f3d 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -89,7 +89,7 @@ void sigact(int signal, siginfo_t *info, void *ucontext)\n>\n> } /* namespace */\n>\n> -void ProcessManager::sighandler(EventNotifier *notifier)\n> +void ProcessManager::sighandler([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tchar data;\n> \tssize_t ret = read(pipe_[0], &data, sizeof(data));\n> diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> index 68eafb307b2a..b78a0e4535f5 100644\n> --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> @@ -26,17 +26,20 @@ public:\n> \tIPAProxyLinux(IPAModule *ipam);\n> \t~IPAProxyLinux();\n>\n> -\tint init(const IPASettings &settings) override { return 0; }\n> +\tint init([[maybe_unused]] const IPASettings &settings) override\n> +\t{\n> +\t\treturn 0;\n> +\t}\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n> -\tvoid configure(const CameraSensorInfo &sensorInfo,\n> -\t\t const std::map &streamConfig,\n> -\t\t const std::map &entityControls,\n> -\t\t const IPAOperationData &ipaConfig,\n> -\t\t IPAOperationData *result) override {}\n> -\tvoid mapBuffers(const std::vector &buffers) override {}\n> -\tvoid unmapBuffers(const std::vector &ids) override {}\n> -\tvoid processEvent(const IPAOperationData &event) override {}\n> +\tvoid configure([[maybe_unused]] const CameraSensorInfo &sensorInfo,\n> +\t\t [[maybe_unused]] const std::map &streamConfig,\n> +\t\t [[maybe_unused]] const std::map &entityControls,\n> +\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t [[maybe_unused]] IPAOperationData *result) override {}\n> +\tvoid mapBuffers([[maybe_unused]] const std::vector &buffers) override {}\n> +\tvoid unmapBuffers([[maybe_unused]] const std::vector &ids) override {}\n> +\tvoid processEvent([[maybe_unused]] const IPAOperationData &event) override {}\n>\n> private:\n> \tvoid readyRead(IPCUnixSocket *ipc);\n> @@ -91,7 +94,7 @@ IPAProxyLinux::~IPAProxyLinux()\n> \tdelete socket_;\n> }\n>\n> -void IPAProxyLinux::readyRead(IPCUnixSocket *ipc)\n> +void IPAProxyLinux::readyRead([[maybe_unused]] IPCUnixSocket *ipc)\n> {\n> }\n>\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 8391ec48ac10..30c94bb98f44 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -196,7 +196,7 @@ PixelFormat V4L2PixelFormat::toPixelFormat() const\n> * \\return The V4L2PixelFormat corresponding to \\a pixelFormat\n> */\n> V4L2PixelFormat V4L2PixelFormat::fromPixelFormat(const PixelFormat &pixelFormat,\n> -\t\t\t\t\t\t bool multiplanar)\n> +\t\t\t\t\t\t [[maybe_unused]] bool multiplanar)\n> {\n> \tconst PixelFormatInfo &info = PixelFormatInfo::info(pixelFormat);\n> \tif (!info.isValid())\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 652677ff1d4d..508522ef42bb 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1462,7 +1462,7 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> * For Capture video devices the FrameBuffer will contain valid data.\n> * For Output video devices the FrameBuffer can be considered empty.\n> */\n> -void V4L2VideoDevice::bufferAvailable(EventNotifier *notifier)\n> +void V4L2VideoDevice::bufferAvailable([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tFrameBuffer *buffer = dequeueBuffer();\n> \tif (!buffer)\n> @@ -1539,7 +1539,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n> * When this slot is called, a V4L2 event is available to be dequeued from the\n> * device.\n> */\n> -void V4L2VideoDevice::eventAvailable(EventNotifier *notifier)\n> +void V4L2VideoDevice::eventAvailable([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tstruct v4l2_event event{};\n> \tint ret = ioctl(VIDIOC_DQEVENT, &event);\n> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> index b5b81f0637b5..030d1387118d 100644\n> --- a/src/qcam/dng_writer.cpp\n> +++ b/src/qcam/dng_writer.cpp\n> @@ -215,7 +215,7 @@ void packScanlineIPU3(void *output, const void *input, unsigned int width)\n> \t}\n> }\n>\n> -void thumbScanlineIPU3(const FormatInfo &info, void *output,\n> +void thumbScanlineIPU3([[maybe_unused]] const FormatInfo &info, void *output,\n> \t\t const void *input, unsigned int width,\n> \t\t unsigned int stride)\n> {\n> @@ -350,7 +350,8 @@ static const std::map formatInfo = {\n> int DNGWriter::write(const char *filename, const Camera *camera,\n> \t\t const StreamConfiguration &config,\n> \t\t const ControlList &metadata,\n> -\t\t const FrameBuffer *buffer, const void *data)\n> +\t\t [[maybe_unused]] const FrameBuffer *buffer,\n> +\t\t const void *data)\n> {\n> \tconst auto it = formatInfo.find(config.pixelFormat);\n> \tif (it == formatInfo.cend()) {\n> diff --git a/src/qcam/main.cpp b/src/qcam/main.cpp\n> index b3468cbf47e2..bae358df0877 100644\n> --- a/src/qcam/main.cpp\n> +++ b/src/qcam/main.cpp\n> @@ -17,7 +17,7 @@\n> #include \"../cam/stream_options.h\"\n> #include \"main_window.h\"\n>\n> -void signalHandler(int signal)\n> +void signalHandler([[maybe_unused]] int signal)\n> {\n> \tqInfo() << \"Exiting\";\n> \tqApp->quit();\n> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\n> index 61bca0732447..7a22f983ec0e 100644\n> --- a/src/v4l2/v4l2_camera.cpp\n> +++ b/src/v4l2/v4l2_camera.cpp\n> @@ -158,7 +158,7 @@ int V4L2Camera::validateConfiguration(const PixelFormat &pixelFormat,\n> \treturn 0;\n> }\n>\n> -int V4L2Camera::allocBuffers(unsigned int count)\n> +int V4L2Camera::allocBuffers([[maybe_unused]] unsigned int count)\n> {\n> \tStream *stream = config_->at(0).stream();\n>\n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 97a8582761a7..d57ffa75edeb 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -33,7 +33,8 @@ public:\n> \t}\n>\n> protected:\n> -\tvoid bufferComplete(Request *request, FrameBuffer *buffer)\n> +\tvoid bufferComplete([[maybe_unused]] Request *request,\n> +\t\t\t FrameBuffer *buffer)\n> \t{\n> \t\tif (buffer->metadata().status != FrameMetadata::FrameSuccess)\n> \t\t\treturn;\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index 0fe3bf9be7f1..eb67bf2da71f 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -26,7 +26,8 @@ protected:\n> \tunsigned int completeBuffersCount_;\n> \tunsigned int completeRequestsCount_;\n>\n> -\tvoid bufferComplete(Request *request, FrameBuffer *buffer)\n> +\tvoid bufferComplete([[maybe_unused]] Request *request,\n> +\t\t\t FrameBuffer *buffer)\n> \t{\n> \t\tif (buffer->metadata().status != FrameMetadata::FrameSuccess)\n> \t\t\treturn;\n> diff --git a/test/hotplug-cameras.cpp b/test/hotplug-cameras.cpp\n> index 6a94535fa315..7d551eeb900d 100644\n> --- a/test/hotplug-cameras.cpp\n> +++ b/test/hotplug-cameras.cpp\n> @@ -26,12 +26,12 @@ using namespace libcamera;\n> class HotplugTest : public Test\n> {\n> protected:\n> -\tvoid cameraAddedHandler(std::shared_ptr cam)\n> +\tvoid cameraAddedHandler([[maybe_unused]] std::shared_ptr cam)\n> \t{\n> \t\tcameraAdded_ = true;\n> \t}\n>\n> -\tvoid cameraRemovedHandler(std::shared_ptr cam)\n> +\tvoid cameraRemovedHandler([[maybe_unused]] std::shared_ptr cam)\n> \t{\n> \t\tcameraRemoved_ = true;\n> \t}\n> diff --git a/test/ipa/ipa_wrappers_test.cpp b/test/ipa/ipa_wrappers_test.cpp\n> index 23c799da0663..59d991cbbf6a 100644\n> --- a/test/ipa/ipa_wrappers_test.cpp\n> +++ b/test/ipa/ipa_wrappers_test.cpp\n> @@ -70,8 +70,8 @@ public:\n> \tvoid configure(const CameraSensorInfo &sensorInfo,\n> \t\t const std::map &streamConfig,\n> \t\t const std::map &entityControls,\n> -\t\t const IPAOperationData &ipaConfig,\n> -\t\t IPAOperationData *result) override\n> +\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t [[maybe_unused]] IPAOperationData *result) override\n> \t{\n> \t\t/* Verify sensorInfo. */\n> \t\tif (sensorInfo.outputSize.width != 2560 ||\n> diff --git a/test/libtest/test.h b/test/libtest/test.h\n> index 26d4b94bc12d..8ecf2bda950f 100644\n> --- a/test/libtest/test.h\n> +++ b/test/libtest/test.h\n> @@ -30,7 +30,7 @@ protected:\n> };\n>\n> #define TEST_REGISTER(klass)\t\t\t\t\t\t\\\n> -int main(int argc, char *argv[])\t\t\t\t\t\\\n> +int main([[maybe_unused]] int argc, [[maybe_unused]] char *argv[])\t\\\n> {\t\t\t\t\t\t\t\t\t\\\n> \treturn klass().execute();\t\t\t\t\t\\\n> }\n> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\n> index d46d5e354727..b024f002843c 100644\n> --- a/test/log/log_process.cpp\n> +++ b/test/log/log_process.cpp\n> @@ -125,7 +125,8 @@ protected:\n> \t}\n>\n> private:\n> -\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n> +\tvoid procFinished([[maybe_unused]] Process *proc,\n> +\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n> \t{\n> \t\texitStatus_ = exitStatus;\n> \t\texitCode_ = exitCode;\n> diff --git a/test/object-invoke.cpp b/test/object-invoke.cpp\n> index 1ae11bb11e16..f3fd23283239 100644\n> --- a/test/object-invoke.cpp\n> +++ b/test/object-invoke.cpp\n> @@ -50,7 +50,7 @@ public:\n> \t\tvalue_ = value;\n> \t}\n>\n> -\tvoid methodWithReference(const int &value)\n> +\tvoid methodWithReference([[maybe_unused]] const int &value)\n> \t{\n> \t}\n>\n> diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp\n> index 721a7c9d46ff..42a26749f5d9 100644\n> --- a/test/process/process_test.cpp\n> +++ b/test/process/process_test.cpp\n> @@ -80,7 +80,8 @@ protected:\n> \t}\n>\n> private:\n> -\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n> +\tvoid procFinished([[maybe_unused]] Process *proc,\n> +\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n> \t{\n> \t\texitStatus_ = exitStatus;\n> \t\texitCode_ = exitCode;\n> diff --git a/test/timer-thread.cpp b/test/timer-thread.cpp\n> index 2f901787f5fb..f794d8e7dd4e 100644\n> --- a/test/timer-thread.cpp\n> +++ b/test/timer-thread.cpp\n> @@ -40,7 +40,7 @@ public:\n> \t}\n>\n> private:\n> -\tvoid timeoutHandler(Timer *timer)\n> +\tvoid timeoutHandler([[maybe_unused]] Timer *timer)\n> \t{\n> \t\ttimeout_ = true;\n> \t}\n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index 7d5b93c37799..537489d736ad 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -57,7 +57,7 @@ public:\n> \t}\n>\n> private:\n> -\tvoid timeoutHandler(Timer *timer)\n> +\tvoid timeoutHandler([[maybe_unused]] Timer *timer)\n> \t{\n> \t\texpiration_ = std::chrono::steady_clock::now();\n> \t\tcount_++;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13F26BD87C\n\tfor ;\n\tMon, 24 Aug 2020 12:38:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 756A962818;\n\tMon, 24 Aug 2020 14:38:05 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3626616B1\n\tfor ;\n\tMon, 24 Aug 2020 14:38:03 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 0560F1C000E;\n\tMon, 24 Aug 2020 12:38:00 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 24 Aug 2020 14:41:46 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200824124146.ggmomxnfserqypni@uno.localdomain>","References":"<20200822200037.20892-1-laurent.pinchart@ideasonboard.com>\n\t<20200822200037.20892-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200822200037.20892-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/5] meson: Remove\n\t-Wno-unused-parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12129,"web_url":"https://patchwork.libcamera.org/comment/12129/","msgid":"<20200824213245.GD594558@oden.dyn.berto.se>","date":"2020-08-24T21:32:45","subject":"Re: [libcamera-devel] [PATCH 4/5] meson: Remove\n\t-Wno-unused-parameter","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-08-22 23:00:36 +0300, Laurent Pinchart wrote:\n> We build libcamera with -Wno-unused-parameter and this doesn't cause\n> much issue internally. However, it prevents catching unused parameters\n> in inline functions defined in public headers. This can lead to\n> compilation warnings for applications compiled without\n> -Wno-unused-parameter.\n> \n> To catch those issues, remove -Wno-unused-parameter and fix all the\n> related warnings.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/bound_method.h | 2 +-\n> include/libcamera/signal.h | 2 +-\n> include/libcamera/span.h | 4 ++--\n> meson.build | 1 -\n> src/android/camera3_hal.cpp | 11 +++++----\n> src/android/camera_device.cpp | 5 ++--\n> src/android/camera_ops.cpp | 5 ++--\n> src/cam/main.cpp | 2 +-\n> src/gstreamer/gstlibcamerapool.cpp | 2 +-\n> src/gstreamer/gstlibcameraprovider.cpp | 2 +-\n> src/gstreamer/gstlibcamerasrc.cpp | 7 ++++--\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 3 ++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> src/ipa/rkisp1/rkisp1.cpp | 13 +++++++----\n> src/ipa/vimc/vimc.cpp | 16 ++++++-------\n> src/libcamera/device_enumerator_udev.cpp | 2 +-\n> src/libcamera/ipc_unixsocket.cpp | 2 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 5 ++--\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/pipeline/rkisp1/timeline.cpp | 2 +-\n> src/libcamera/process.cpp | 2 +-\n> src/libcamera/proxy/ipa_proxy_linux.cpp | 23 +++++++++++--------\n> src/libcamera/v4l2_pixelformat.cpp | 2 +-\n> src/libcamera/v4l2_videodevice.cpp | 4 ++--\n> src/qcam/dng_writer.cpp | 5 ++--\n> src/qcam/main.cpp | 2 +-\n> src/v4l2/v4l2_camera.cpp | 2 +-\n> test/camera/buffer_import.cpp | 3 ++-\n> test/camera/capture.cpp | 3 ++-\n> test/hotplug-cameras.cpp | 4 ++--\n> test/ipa/ipa_wrappers_test.cpp | 4 ++--\n> test/libtest/test.h | 2 +-\n> test/log/log_process.cpp | 3 ++-\n> test/object-invoke.cpp | 2 +-\n> test/process/process_test.cpp | 3 ++-\n> test/timer-thread.cpp | 2 +-\n> test/timer.cpp | 2 +-\n> 37 files changed, 89 insertions(+), 69 deletions(-)\n> \n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index 983bb5cbbad0..d1e4448304a9 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -214,7 +214,7 @@ public:\n> \n> \tbool match(R (*func)(Args...)) const { return func == func_; }\n> \n> -\tR activate(Args... args, bool deleteMethod = false) override\n> +\tR activate(Args... args, [[maybe_unused]] bool deleteMethod = false) override\n> \t{\n> \t\treturn (*func_)(args...);\n> \t}\n> diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\n> index ed30eb559127..accb797e911c 100644\n> --- a/include/libcamera/signal.h\n> +++ b/include/libcamera/signal.h\n> @@ -70,7 +70,7 @@ public:\n> \n> \tvoid disconnect()\n> \t{\n> -\t\tSignalBase::disconnect([](SlotList::iterator &iter) {\n> +\t\tSignalBase::disconnect([]([[maybe_unused]] SlotList::iterator &iter) {\n> \t\t\treturn true;\n> \t\t});\n> \t}\n> diff --git a/include/libcamera/span.h b/include/libcamera/span.h\n> index 513ddb432405..738af6aca871 100644\n> --- a/include/libcamera/span.h\n> +++ b/include/libcamera/span.h\n> @@ -113,12 +113,12 @@ public:\n> \t{\n> \t}\n> \n> -\tconstexpr Span(pointer ptr, size_type count)\n> +\tconstexpr Span(pointer ptr, [[maybe_unused]] size_type count)\n> \t\t: data_(ptr)\n> \t{\n> \t}\n> \n> -\tconstexpr Span(pointer first, pointer last)\n> +\tconstexpr Span(pointer first, [[maybe_unused]] pointer last)\n> \t\t: data_(first)\n> \t{\n> \t}\n> diff --git a/meson.build b/meson.build\n> index ce1d1c63ddc6..d7e8122ccaa3 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -37,7 +37,6 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n> endif\n> \n> common_arguments = [\n> - '-Wno-unused-parameter',\n> '-include', 'config.h',\n> ]\n> \n> diff --git a/src/android/camera3_hal.cpp b/src/android/camera3_hal.cpp\n> index decaf59e6915..ddcfea591ce6 100644\n> --- a/src/android/camera3_hal.cpp\n> +++ b/src/android/camera3_hal.cpp\n> @@ -32,18 +32,21 @@ static int hal_get_camera_info(int id, struct camera_info *info)\n> \treturn cameraManager.getCameraInfo(id, info);\n> }\n> \n> -static int hal_set_callbacks(const camera_module_callbacks_t *callbacks)\n> +static int hal_set_callbacks([[maybe_unused]] const camera_module_callbacks_t *callbacks)\n> {\n> \treturn 0;\n> }\n> \n> -static int hal_open_legacy(const struct hw_module_t *module, const char *id,\n> -\t\t\t uint32_t halVersion, struct hw_device_t **device)\n> +static int hal_open_legacy([[maybe_unused]] const struct hw_module_t *module,\n> +\t\t\t [[maybe_unused]] const char *id,\n> +\t\t\t [[maybe_unused]] uint32_t halVersion,\n> +\t\t\t [[maybe_unused]] struct hw_device_t **device)\n> {\n> \treturn -ENOSYS;\n> }\n> \n> -static int hal_set_torch_mode(const char *camera_id, bool enabled)\n> +static int hal_set_torch_mode([[maybe_unused]] const char *camera_id,\n> +\t\t\t [[maybe_unused]] bool enabled)\n> {\n> \treturn -ENOSYS;\n> }\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 3419236a061c..8a39bee690a0 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1541,8 +1541,9 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n> /*\n> * Produce a set of fixed result metadata.\n> */\n> -std::unique_ptr CameraDevice::getResultMetadata(int frame_number,\n> -\t\t\t\t\t\t\t\tint64_t timestamp)\n> +std::unique_ptr\n> +CameraDevice::getResultMetadata([[maybe_unused]] int frame_number,\n> +\t\t\t\tint64_t timestamp)\n> {\n> \t/*\n> \t * \\todo Keep this in sync with the actual number of entries.\n> diff --git a/src/android/camera_ops.cpp b/src/android/camera_ops.cpp\n> index 216ac285f964..696e80436821 100644\n> --- a/src/android/camera_ops.cpp\n> +++ b/src/android/camera_ops.cpp\n> @@ -61,11 +61,12 @@ static int hal_dev_process_capture_request(const struct camera3_device *dev,\n> \treturn camera->processCaptureRequest(request);\n> }\n> \n> -static void hal_dev_dump(const struct camera3_device *dev, int fd)\n> +static void hal_dev_dump([[maybe_unused]] const struct camera3_device *dev,\n> +\t\t\t [[maybe_unused]] int fd)\n> {\n> }\n> \n> -static int hal_dev_flush(const struct camera3_device *dev)\n> +static int hal_dev_flush([[maybe_unused]] const struct camera3_device *dev)\n> {\n> \treturn 0;\n> }\n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index cc3facd5a5b2..244720b491f5 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -378,7 +378,7 @@ int CamApp::run()\n> \treturn 0;\n> }\n> \n> -void signalHandler(int signal)\n> +void signalHandler([[maybe_unused]] int signal)\n> {\n> \tstd::cout << \"Exiting\" << std::endl;\n> \tCamApp::instance()->quit();\n> diff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\n> index 8f536169455f..b756ee356d61 100644\n> --- a/src/gstreamer/gstlibcamerapool.cpp\n> +++ b/src/gstreamer/gstlibcamerapool.cpp\n> @@ -33,7 +33,7 @@ G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL);\n> \n> static GstFlowReturn\n> gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer,\n> -\t\t\t\t GstBufferPoolAcquireParams *params)\n> +\t\t\t\t [[maybe_unused]] GstBufferPoolAcquireParams *params)\n> {\n> \tGstLibcameraPool *self = GST_LIBCAMERA_POOL(pool);\n> \tGstBuffer *buf = GST_BUFFER(gst_atomic_queue_pop(self->queue));\n> diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\n> index 840e87a3d8da..cd850d813a6e 100644\n> --- a/src/gstreamer/gstlibcameraprovider.cpp\n> +++ b/src/gstreamer/gstlibcameraprovider.cpp\n> @@ -89,7 +89,7 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id,\n> }\n> \n> static void\n> -gst_libcamera_device_init(GstLibcameraDevice *self)\n> +gst_libcamera_device_init([[maybe_unused]] GstLibcameraDevice *self)\n> {\n> }\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 0c28ae3f2852..1bfc2e2f8cf3 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -338,7 +338,8 @@ gst_libcamera_src_task_run(gpointer user_data)\n> }\n> \n> static void\n> -gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n> +gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n> +\t\t\t gpointer user_data)\n> {\n> \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> \tGLibRecLocker lock(&self->stream_lock);\n> @@ -467,7 +468,9 @@ done:\n> }\n> \n> static void\n> -gst_libcamera_src_task_leave(GstTask *task, GThread *thread, gpointer user_data)\n> +gst_libcamera_src_task_leave([[maybe_unused]] GstTask *task,\n> +\t\t\t [[maybe_unused]] GThread *thread,\n> +\t\t\t gpointer user_data)\n> {\n> \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n> \tGstLibcameraSrcState *state = self->state;\n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index c02b5ece242f..3573f36be46a 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -221,7 +221,8 @@ void Agc::SetConstraintMode(std::string const &constraint_mode_name)\n> \tconstraint_mode_name_ = constraint_mode_name;\n> }\n> \n> -void Agc::SwitchMode(CameraMode const &camera_mode, Metadata *metadata)\n> +void Agc::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,\n> +\t\t Metadata *metadata)\n> {\n> \t// On a mode switch, it's possible the exposure profile could change,\n> \t// so we run through the dividing up of exposure/gain again and\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 37472087f5a9..4557016c2dd4 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -191,7 +191,7 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n> }\n> \n> void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n> -\t\t const std::map &streamConfig,\n> +\t\t [[maybe_unused]] const std::map &streamConfig,\n> \t\t const std::map &entityControls,\n> \t\t const IPAOperationData &ipaConfig,\n> \t\t IPAOperationData *result)\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 3a1c50c4add0..d95d902adff3 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -32,7 +32,10 @@ LOG_DEFINE_CATEGORY(IPARkISP1)\n> class IPARkISP1 : public IPAInterface\n> {\n> public:\n> -\tint init(const IPASettings &settings) override { return 0; }\n> +\tint init([[maybe_unused]] const IPASettings &settings) override\n> +\t{\n> +\t\treturn 0;\n> +\t}\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n> \n> @@ -75,11 +78,11 @@ private:\n> * assemble one. Make sure the reported sensor information are relevant\n> * before accessing them.\n> */\n> -void IPARkISP1::configure(const CameraSensorInfo &info,\n> -\t\t\t const std::map &streamConfig,\n> +void IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,\n> +\t\t\t [[maybe_unused]] const std::map &streamConfig,\n> \t\t\t const std::map &entityControls,\n> -\t\t\t const IPAOperationData &ipaConfig,\n> -\t\t\t IPAOperationData *result)\n> +\t\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t\t [[maybe_unused]] IPAOperationData *result)\n> {\n> \tif (entityControls.empty())\n> \t\treturn;\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 1593c92d80f3..ef257762a1d4 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -37,14 +37,14 @@ public:\n> \tint start() override;\n> \tvoid stop() override;\n> \n> -\tvoid configure(const CameraSensorInfo &sensorInfo,\n> -\t\t const std::map &streamConfig,\n> -\t\t const std::map &entityControls,\n> -\t\t const IPAOperationData &ipaConfig,\n> -\t\t IPAOperationData *result) override {}\n> -\tvoid mapBuffers(const std::vector &buffers) override {}\n> -\tvoid unmapBuffers(const std::vector &ids) override {}\n> -\tvoid processEvent(const IPAOperationData &event) override {}\n> +\tvoid configure([[maybe_unused]] const CameraSensorInfo &sensorInfo,\n> +\t\t [[maybe_unused]] const std::map &streamConfig,\n> +\t\t [[maybe_unused]] const std::map &entityControls,\n> +\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t [[maybe_unused]] IPAOperationData *result) override {}\n> +\tvoid mapBuffers([[maybe_unused]] const std::vector &buffers) override {}\n> +\tvoid unmapBuffers([[maybe_unused]] const std::vector &ids) override {}\n> +\tvoid processEvent([[maybe_unused]] const IPAOperationData &event) override {}\n> \n> private:\n> \tvoid initTrace();\n> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> index 96689daa5dd1..c6e23a1a7a18 100644\n> --- a/src/libcamera/device_enumerator_udev.cpp\n> +++ b/src/libcamera/device_enumerator_udev.cpp\n> @@ -327,7 +327,7 @@ int DeviceEnumeratorUdev::addV4L2Device(dev_t devnum)\n> \treturn 0;\n> }\n> \n> -void DeviceEnumeratorUdev::udevNotify(EventNotifier *notifier)\n> +void DeviceEnumeratorUdev::udevNotify([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tstruct udev_device *dev = udev_monitor_receive_device(monitor_);\n> \tstd::string action(udev_device_get_action(dev));\n> diff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp\n> index 7df86e885f23..701b2c518217 100644\n> --- a/src/libcamera/ipc_unixsocket.cpp\n> +++ b/src/libcamera/ipc_unixsocket.cpp\n> @@ -308,7 +308,7 @@ int IPCUnixSocket::recvData(void *buffer, size_t length,\n> \treturn 0;\n> }\n> \n> -void IPCUnixSocket::dataNotifier(EventNotifier *notifier)\n> +void IPCUnixSocket::dataNotifier([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tint ret;\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index b8f0549f0c60..42c9caa03e2e 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -758,7 +758,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \treturn ret;\n> }\n> \n> -int PipelineHandlerRPi::exportFrameBuffers(Camera *camera, Stream *stream,\n> +int PipelineHandlerRPi::exportFrameBuffers([[maybe_unused]] Camera *camera, Stream *stream,\n> \t\t\t\t\t std::vector> *buffers)\n> {\n> \tRPiStream *s = static_cast(stream);\n> @@ -1182,7 +1182,8 @@ int RPiCameraData::configureIPA()\n> \treturn 0;\n> }\n> \n> -void RPiCameraData::queueFrameAction(unsigned int frame, const IPAOperationData &action)\n> +void RPiCameraData::queueFrameAction([[maybe_unused]] unsigned int frame,\n> +\t\t\t\t const IPAOperationData &action)\n> {\n> \t/*\n> \t * The following actions can be handled when the pipeline handler is in\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 32fdaed7c661..4d89aab3845d 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -700,7 +700,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \treturn 0;\n> }\n> \n> -int PipelineHandlerRkISP1::exportFrameBuffers(Camera *camera, Stream *stream,\n> +int PipelineHandlerRkISP1::exportFrameBuffers([[maybe_unused]] Camera *camera, Stream *stream,\n> \t\t\t\t\t std::vector> *buffers)\n> {\n> \tunsigned int count = stream->configuration().bufferCount;\n> diff --git a/src/libcamera/pipeline/rkisp1/timeline.cpp b/src/libcamera/pipeline/rkisp1/timeline.cpp\n> index f5194608ced7..6b83bbe5b589 100644\n> --- a/src/libcamera/pipeline/rkisp1/timeline.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/timeline.cpp\n> @@ -204,7 +204,7 @@ void Timeline::updateDeadline()\n> \ttimer_.start(deadline);\n> }\n> \n> -void Timeline::timeout(Timer *timer)\n> +void Timeline::timeout([[maybe_unused]] Timer *timer)\n> {\n> \tutils::time_point now = std::chrono::steady_clock::now();\n> \n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 8311d274a288..994190dc6f3d 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -89,7 +89,7 @@ void sigact(int signal, siginfo_t *info, void *ucontext)\n> \n> } /* namespace */\n> \n> -void ProcessManager::sighandler(EventNotifier *notifier)\n> +void ProcessManager::sighandler([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tchar data;\n> \tssize_t ret = read(pipe_[0], &data, sizeof(data));\n> diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> index 68eafb307b2a..b78a0e4535f5 100644\n> --- a/src/libcamera/proxy/ipa_proxy_linux.cpp\n> +++ b/src/libcamera/proxy/ipa_proxy_linux.cpp\n> @@ -26,17 +26,20 @@ public:\n> \tIPAProxyLinux(IPAModule *ipam);\n> \t~IPAProxyLinux();\n> \n> -\tint init(const IPASettings &settings) override { return 0; }\n> +\tint init([[maybe_unused]] const IPASettings &settings) override\n> +\t{\n> +\t\treturn 0;\n> +\t}\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n> -\tvoid configure(const CameraSensorInfo &sensorInfo,\n> -\t\t const std::map &streamConfig,\n> -\t\t const std::map &entityControls,\n> -\t\t const IPAOperationData &ipaConfig,\n> -\t\t IPAOperationData *result) override {}\n> -\tvoid mapBuffers(const std::vector &buffers) override {}\n> -\tvoid unmapBuffers(const std::vector &ids) override {}\n> -\tvoid processEvent(const IPAOperationData &event) override {}\n> +\tvoid configure([[maybe_unused]] const CameraSensorInfo &sensorInfo,\n> +\t\t [[maybe_unused]] const std::map &streamConfig,\n> +\t\t [[maybe_unused]] const std::map &entityControls,\n> +\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t [[maybe_unused]] IPAOperationData *result) override {}\n> +\tvoid mapBuffers([[maybe_unused]] const std::vector &buffers) override {}\n> +\tvoid unmapBuffers([[maybe_unused]] const std::vector &ids) override {}\n> +\tvoid processEvent([[maybe_unused]] const IPAOperationData &event) override {}\n> \n> private:\n> \tvoid readyRead(IPCUnixSocket *ipc);\n> @@ -91,7 +94,7 @@ IPAProxyLinux::~IPAProxyLinux()\n> \tdelete socket_;\n> }\n> \n> -void IPAProxyLinux::readyRead(IPCUnixSocket *ipc)\n> +void IPAProxyLinux::readyRead([[maybe_unused]] IPCUnixSocket *ipc)\n> {\n> }\n> \n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 8391ec48ac10..30c94bb98f44 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -196,7 +196,7 @@ PixelFormat V4L2PixelFormat::toPixelFormat() const\n> * \\return The V4L2PixelFormat corresponding to \\a pixelFormat\n> */\n> V4L2PixelFormat V4L2PixelFormat::fromPixelFormat(const PixelFormat &pixelFormat,\n> -\t\t\t\t\t\t bool multiplanar)\n> +\t\t\t\t\t\t [[maybe_unused]] bool multiplanar)\n> {\n> \tconst PixelFormatInfo &info = PixelFormatInfo::info(pixelFormat);\n> \tif (!info.isValid())\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 652677ff1d4d..508522ef42bb 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1462,7 +1462,7 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> * For Capture video devices the FrameBuffer will contain valid data.\n> * For Output video devices the FrameBuffer can be considered empty.\n> */\n> -void V4L2VideoDevice::bufferAvailable(EventNotifier *notifier)\n> +void V4L2VideoDevice::bufferAvailable([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tFrameBuffer *buffer = dequeueBuffer();\n> \tif (!buffer)\n> @@ -1539,7 +1539,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n> * When this slot is called, a V4L2 event is available to be dequeued from the\n> * device.\n> */\n> -void V4L2VideoDevice::eventAvailable(EventNotifier *notifier)\n> +void V4L2VideoDevice::eventAvailable([[maybe_unused]] EventNotifier *notifier)\n> {\n> \tstruct v4l2_event event{};\n> \tint ret = ioctl(VIDIOC_DQEVENT, &event);\n> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> index b5b81f0637b5..030d1387118d 100644\n> --- a/src/qcam/dng_writer.cpp\n> +++ b/src/qcam/dng_writer.cpp\n> @@ -215,7 +215,7 @@ void packScanlineIPU3(void *output, const void *input, unsigned int width)\n> \t}\n> }\n> \n> -void thumbScanlineIPU3(const FormatInfo &info, void *output,\n> +void thumbScanlineIPU3([[maybe_unused]] const FormatInfo &info, void *output,\n> \t\t const void *input, unsigned int width,\n> \t\t unsigned int stride)\n> {\n> @@ -350,7 +350,8 @@ static const std::map formatInfo = {\n> int DNGWriter::write(const char *filename, const Camera *camera,\n> \t\t const StreamConfiguration &config,\n> \t\t const ControlList &metadata,\n> -\t\t const FrameBuffer *buffer, const void *data)\n> +\t\t [[maybe_unused]] const FrameBuffer *buffer,\n> +\t\t const void *data)\n> {\n> \tconst auto it = formatInfo.find(config.pixelFormat);\n> \tif (it == formatInfo.cend()) {\n> diff --git a/src/qcam/main.cpp b/src/qcam/main.cpp\n> index b3468cbf47e2..bae358df0877 100644\n> --- a/src/qcam/main.cpp\n> +++ b/src/qcam/main.cpp\n> @@ -17,7 +17,7 @@\n> #include \"../cam/stream_options.h\"\n> #include \"main_window.h\"\n> \n> -void signalHandler(int signal)\n> +void signalHandler([[maybe_unused]] int signal)\n> {\n> \tqInfo() << \"Exiting\";\n> \tqApp->quit();\n> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\n> index 61bca0732447..7a22f983ec0e 100644\n> --- a/src/v4l2/v4l2_camera.cpp\n> +++ b/src/v4l2/v4l2_camera.cpp\n> @@ -158,7 +158,7 @@ int V4L2Camera::validateConfiguration(const PixelFormat &pixelFormat,\n> \treturn 0;\n> }\n> \n> -int V4L2Camera::allocBuffers(unsigned int count)\n> +int V4L2Camera::allocBuffers([[maybe_unused]] unsigned int count)\n> {\n> \tStream *stream = config_->at(0).stream();\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 97a8582761a7..d57ffa75edeb 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -33,7 +33,8 @@ public:\n> \t}\n> \n> protected:\n> -\tvoid bufferComplete(Request *request, FrameBuffer *buffer)\n> +\tvoid bufferComplete([[maybe_unused]] Request *request,\n> +\t\t\t FrameBuffer *buffer)\n> \t{\n> \t\tif (buffer->metadata().status != FrameMetadata::FrameSuccess)\n> \t\t\treturn;\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index 0fe3bf9be7f1..eb67bf2da71f 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -26,7 +26,8 @@ protected:\n> \tunsigned int completeBuffersCount_;\n> \tunsigned int completeRequestsCount_;\n> \n> -\tvoid bufferComplete(Request *request, FrameBuffer *buffer)\n> +\tvoid bufferComplete([[maybe_unused]] Request *request,\n> +\t\t\t FrameBuffer *buffer)\n> \t{\n> \t\tif (buffer->metadata().status != FrameMetadata::FrameSuccess)\n> \t\t\treturn;\n> diff --git a/test/hotplug-cameras.cpp b/test/hotplug-cameras.cpp\n> index 6a94535fa315..7d551eeb900d 100644\n> --- a/test/hotplug-cameras.cpp\n> +++ b/test/hotplug-cameras.cpp\n> @@ -26,12 +26,12 @@ using namespace libcamera;\n> class HotplugTest : public Test\n> {\n> protected:\n> -\tvoid cameraAddedHandler(std::shared_ptr cam)\n> +\tvoid cameraAddedHandler([[maybe_unused]] std::shared_ptr cam)\n> \t{\n> \t\tcameraAdded_ = true;\n> \t}\n> \n> -\tvoid cameraRemovedHandler(std::shared_ptr cam)\n> +\tvoid cameraRemovedHandler([[maybe_unused]] std::shared_ptr cam)\n> \t{\n> \t\tcameraRemoved_ = true;\n> \t}\n> diff --git a/test/ipa/ipa_wrappers_test.cpp b/test/ipa/ipa_wrappers_test.cpp\n> index 23c799da0663..59d991cbbf6a 100644\n> --- a/test/ipa/ipa_wrappers_test.cpp\n> +++ b/test/ipa/ipa_wrappers_test.cpp\n> @@ -70,8 +70,8 @@ public:\n> \tvoid configure(const CameraSensorInfo &sensorInfo,\n> \t\t const std::map &streamConfig,\n> \t\t const std::map &entityControls,\n> -\t\t const IPAOperationData &ipaConfig,\n> -\t\t IPAOperationData *result) override\n> +\t\t [[maybe_unused]] const IPAOperationData &ipaConfig,\n> +\t\t [[maybe_unused]] IPAOperationData *result) override\n> \t{\n> \t\t/* Verify sensorInfo. */\n> \t\tif (sensorInfo.outputSize.width != 2560 ||\n> diff --git a/test/libtest/test.h b/test/libtest/test.h\n> index 26d4b94bc12d..8ecf2bda950f 100644\n> --- a/test/libtest/test.h\n> +++ b/test/libtest/test.h\n> @@ -30,7 +30,7 @@ protected:\n> };\n> \n> #define TEST_REGISTER(klass)\t\t\t\t\t\t\\\n> -int main(int argc, char *argv[])\t\t\t\t\t\\\n> +int main([[maybe_unused]] int argc, [[maybe_unused]] char *argv[])\t\\\n> {\t\t\t\t\t\t\t\t\t\\\n> \treturn klass().execute();\t\t\t\t\t\\\n> }\n> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp\n> index d46d5e354727..b024f002843c 100644\n> --- a/test/log/log_process.cpp\n> +++ b/test/log/log_process.cpp\n> @@ -125,7 +125,8 @@ protected:\n> \t}\n> \n> private:\n> -\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n> +\tvoid procFinished([[maybe_unused]] Process *proc,\n> +\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n> \t{\n> \t\texitStatus_ = exitStatus;\n> \t\texitCode_ = exitCode;\n> diff --git a/test/object-invoke.cpp b/test/object-invoke.cpp\n> index 1ae11bb11e16..f3fd23283239 100644\n> --- a/test/object-invoke.cpp\n> +++ b/test/object-invoke.cpp\n> @@ -50,7 +50,7 @@ public:\n> \t\tvalue_ = value;\n> \t}\n> \n> -\tvoid methodWithReference(const int &value)\n> +\tvoid methodWithReference([[maybe_unused]] const int &value)\n> \t{\n> \t}\n> \n> diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp\n> index 721a7c9d46ff..42a26749f5d9 100644\n> --- a/test/process/process_test.cpp\n> +++ b/test/process/process_test.cpp\n> @@ -80,7 +80,8 @@ protected:\n> \t}\n> \n> private:\n> -\tvoid procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)\n> +\tvoid procFinished([[maybe_unused]] Process *proc,\n> +\t\t\t enum Process::ExitStatus exitStatus, int exitCode)\n> \t{\n> \t\texitStatus_ = exitStatus;\n> \t\texitCode_ = exitCode;\n> diff --git a/test/timer-thread.cpp b/test/timer-thread.cpp\n> index 2f901787f5fb..f794d8e7dd4e 100644\n> --- a/test/timer-thread.cpp\n> +++ b/test/timer-thread.cpp\n> @@ -40,7 +40,7 @@ public:\n> \t}\n> \n> private:\n> -\tvoid timeoutHandler(Timer *timer)\n> +\tvoid timeoutHandler([[maybe_unused]] Timer *timer)\n> \t{\n> \t\ttimeout_ = true;\n> \t}\n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index 7d5b93c37799..537489d736ad 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -57,7 +57,7 @@ public:\n> \t}\n> \n> private:\n> -\tvoid timeoutHandler(Timer *timer)\n> +\tvoid timeoutHandler([[maybe_unused]] Timer *timer)\n> \t{\n> \t\texpiration_ = std::chrono::steady_clock::now();\n> \t\tcount_++;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B632BBE173\n\tfor ;\n\tMon, 24 Aug 2020 21:32:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 423FC62113;\n\tMon, 24 Aug 2020 23:32:49 +0200 (CEST)","from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com\n\t[IPv6:2a00:1450:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5B24616B1\n\tfor ;\n\tMon, 24 Aug 2020 23:32:47 +0200 (CEST)","by mail-lj1-x22d.google.com with SMTP id g6so11347786ljn.11\n\tfor ;\n\tMon, 24 Aug 2020 14:32:47 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tg22sm2402658lja.29.2020.08.24.14.32.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 24 Aug 2020 14:32:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"FnbKRPSf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=PV8jFZke8mVTf0DCzvfPR96hZAXrqk6qTpTgr9vWljI=;\n\tb=FnbKRPSfbG75VqXBR7FkcsekCFPC5N6GUpcdIGFfb0EBKaeSZfRpyb2/Ho5Jx08yR3\n\trXPFdB74YVxobLJ5KW2sNGzf5J4CqecHXkwHKsy/UKd21iPw46G7p1JnDa1HJulup80Y\n\ti/oDR5oKpaf0eMZ+DjvSDDsBhUXpJSBHMQX/RTlLo/AcED60vsvBk4UCv/QzoFXHZwXt\n\thVx/yhgsZCzg2f2/Q78JbwO6Vwic4ux11DBr5L1Qg6MGk4NRmk5eGwzBDTlU3vzndyI8\n\th5Jp0S/09MtZq61aZnx1wkQADaCbbgATcYo+Tv+AOZeIpCYAo9s6SQuYkw3QLTC7D/WO\n\tVp1Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=PV8jFZke8mVTf0DCzvfPR96hZAXrqk6qTpTgr9vWljI=;\n\tb=s+T8J6iang/3OGFDprQmoXRzCPCaWY2pDQAN/brKimqnj+BgemMMmCZbaY1NQxrdeX\n\tPM08HXJFP2Leqke1j2Mz6pHhTdXGKiGpmTKVV7VxF5WHGFBv552geEDTMaoLITJ44NgG\n\t9p4ynuWKHRj4SPhvaSkvWva6+NtG6zNFFE2aarwrMoOS5B5zLTaTCRXDMCVfi4G/R54D\n\tIDYAviz8TtrRARlE18vdAOqX4ZGdZ1eKt6BxvQzhIF84Y8UbWaeEuj/Q+ZuI9x0306/v\n\t+1oVJrsQWIr79Pa3UBTdgARU94ihJDDNJ3to3rzQqHAUGwrOJWTnkQo9Gwp7CuQtn+sY\n\tV+AA==","X-Gm-Message-State":"AOAM5321KzpUt9B8M6tsSeVU44bVKNQy9XKUfEF29Bwj3vI1//uP01Tv\n\tkZehelmQry3ov0aGXjB7AO+QNt6eACiaXg==","X-Google-Smtp-Source":"ABdhPJxLusw800aM/DKLa9pA0J/Dri1lCmst1bTMAEKdzqXSxFWdiRPUaO23RjQWAxDZ6x/aLlGR8w==","X-Received":"by 2002:a2e:99d5:: with SMTP id\n\tl21mr3213487ljj.320.1598304767000; \n\tMon, 24 Aug 2020 14:32:47 -0700 (PDT)","Date":"Mon, 24 Aug 2020 23:32:45 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200824213245.GD594558@oden.dyn.berto.se>","References":"<20200822200037.20892-1-laurent.pinchart@ideasonboard.com>\n\t<20200822200037.20892-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200822200037.20892-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/5] meson: Remove\n\t-Wno-unused-parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]